97668 2012-09-26 05:51:06 -0700 Gesture tap highlighting entire first line 2012-09-26 07:35:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 728456 0 allan.jensen 2012-09-26 05:51:06 -0700 On platforms using the GestureTapHighlighter in WebCore/page/GestureTapHighlighter, and tapping a link that is spread over two lines but where there the lower and upper line of the link touches, the gesture highligther will return path that includes the entire width of the first line. The problem is the code ends up treating the first part of the highlight as if was a middle part when adding the last part. 728458 1 165776 allan.jensen 2012-09-26 05:52:59 -0700 Created attachment 165776 Patch 728542 2 165776 webkit.review.bot 2012-09-26 07:35:28 -0700 Comment on attachment 165776 Patch Clearing flags on attachment: 165776 Committed r129643: <http://trac.webkit.org/changeset/129643> 728543 3 webkit.review.bot 2012-09-26 07:35:31 -0700 All reviewed patches have been landed. Closing bug. 165776 2012-09-26 05:52:59 -0700 2012-09-26 07:35:28 -0700 Patch bug-97668-20120926145205.patch text/plain 4523 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFlOWI2NWM1MGQ5OTJh NGY2NzFlMTllYWQ2Zjg5MTU0MTNmNjQxZi4uNmNkMDk4YTc4MDM5ODhjZDA1MDAxMzNhMzc4MmI3 MzczYmU5ZWYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5LTI2ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIEdl c3R1cmUgdGFwIGhpZ2hsaWdodGluZyBlbnRpcmUgZmlyc3QgbGluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc2NjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLZWVwIGJldHRlciB0cmFjayBpZiB3aGlj aCBwYXJ0IGlzIHRoZSBmaXJzdCwgbWlkZGxlIG9yIGxhc3QsIGFuZCBhZGp1c3QgdGhlIFgtZWRn ZXMgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgKiBwYWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5j cHA6CisKIDIwMTItMDktMjYgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgU3VnZ2VzdGlvblBpY2tlciBtaW4gd2lkdGggaXMgdHdvIHBpeGVscyB3aWRlciB0 aGFuIGl0IHNob3VsZCBiZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9HZXN0dXJl VGFwSGlnaGxpZ2h0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9HZXN0dXJlVGFwSGlnaGxp Z2h0ZXIuY3BwCmluZGV4IGJiOGY0MjNiY2EyN2I1NDhjZWU3ZjIwNGFhNjJmMGUzY2YzODFkN2Yu LmVlZjFkMzc3NGI4YjhlMzZiOWE0MDk4Mjg2YTgwYWI2NmE5MGI1ZjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvR2VzdHVyZVRhcEhpZ2hsaWdodGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5jcHAKQEAgLTkzLDIwICs5MywyNCBA QCBpbmxpbmUgYm9vbCBzdHJpa2VzKGNvbnN0IExheW91dFJlY3QmIGEsIGNvbnN0IExheW91dFJl Y3QmIGIpCiAgICAgICAgICYmIGEueSgpIDw9IGIubWF4WSgpICYmIGIueSgpIDw9IGEubWF4WSgp OwogfQogCi1pbmxpbmUgdm9pZCBzaGlmdFhFZGdlc1RvQ29udGFpbklmU3RyaWtlcyhMYXlvdXRS ZWN0JiByZWN0LCBjb25zdCBMYXlvdXRSZWN0JiBvdGhlcikKK2lubGluZSB2b2lkIHNoaWZ0WEVk Z2VzVG9Db250YWluSWZTdHJpa2VzKExheW91dFJlY3QmIHJlY3QsIExheW91dFJlY3QmIG90aGVy LCBib29sIGlzRmlyc3QpCiB7CiAgICAgaWYgKHJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1 cm47Ci0gICAgTGF5b3V0VW5pdCBsZWZ0U2lkZSA9IHJlY3QueCgpOwotICAgIExheW91dFVuaXQg cmlnaHRTaWRlID0gcmVjdC5tYXhYKCk7CiAKLSAgICBpZiAoIW90aGVyLmlzRW1wdHkoKSAmJiBz dHJpa2VzKHJlY3QsIG90aGVyKSkgewotICAgICAgICBsZWZ0U2lkZSA9IHN0ZDo6bWluKGxlZnRT aWRlLCBvdGhlci54KCkpOwotICAgICAgICByaWdodFNpZGUgPSBzdGQ6Om1heChyaWdodFNpZGUs IG90aGVyLm1heFgoKSk7Ci0gICAgfQorICAgIGlmIChvdGhlci5pc0VtcHR5KCkgfHwgIXN0cmlr ZXMocmVjdCwgb3RoZXIpKQorICAgICAgICByZXR1cm47CisKKyAgICBMYXlvdXRVbml0IGxlZnRT aWRlID0gc3RkOjptaW4ocmVjdC54KCksIG90aGVyLngoKSk7CisgICAgTGF5b3V0VW5pdCByaWdo dFNpZGUgPSBzdGQ6Om1heChyZWN0Lm1heFgoKSwgb3RoZXIubWF4WCgpKTsKKworICAgIHJlY3Qu c2hpZnRYRWRnZVRvKGxlZnRTaWRlKTsKKyAgICByZWN0LnNoaWZ0TWF4WEVkZ2VUbyhyaWdodFNp ZGUpOwogCi0gICAgcmVjdC5zZXRYKGxlZnRTaWRlKTsKLSAgICByZWN0LnNldFdpZHRoKHJpZ2h0 U2lkZSAtIGxlZnRTaWRlKTsKKyAgICBpZiAoaXNGaXJzdCkKKyAgICAgICAgb3RoZXIuc2hpZnRN YXhYRWRnZVRvKHJpZ2h0U2lkZSk7CisgICAgZWxzZQorICAgICAgICBvdGhlci5zaGlmdFhFZGdl VG8obGVmdFNpZGUpOwogfQogCiBpbmxpbmUgdm9pZCBhZGRIaWdobGlnaHRSZWN0KFBhdGgmIHBh dGgsIGNvbnN0IExheW91dFJlY3QmIHJlY3QsIGNvbnN0IExheW91dFJlY3QmIHByZXYsIGNvbnN0 IExheW91dFJlY3QmIG5leHQpCkBAIC0xNTgsMzMgKzE2MiwzOCBAQCBQYXRoIGFic29sdXRlUGF0 aEZvclJlbmRlcmVyKFJlbmRlck9iamVjdCogY29uc3QgbykKICAgICBmb3IgKGludCBpID0gMTsg aSA8IGVuZDsgKytpKQogICAgICAgICBtaWQudW5pdGVJZk5vblplcm8ocmVjdHMuYXQoaSkpOwog Ci0gICAgVmVjdG9yPExheW91dFJlY3Q+IGRyYXdhYmxlUmVjdHM7Ci0KLSAgICBpZiAoIW1pZC5p c0VtcHR5KCkpCi0gICAgICAgIGRyYXdhYmxlUmVjdHMuYXBwZW5kKG1pZCk7CisgICAgTGF5b3V0 UmVjdCBmaXJzdDsKKyAgICBMYXlvdXRSZWN0IGxhc3Q7CiAKICAgICAvLyBBZGQgdGhlIGZpcnN0 IGJveCwgYnV0IG1lcmdlIGl0IHdpdGggdGhlIGNlbnRlciBib3hlcyBpZiBpdCBpbnRlcnNlY3Rz LgogICAgIGlmIChyZWN0cy5zaXplKCkgJiYgIXJlY3RzLmZpcnN0KCkuaXNFbXB0eSgpKSB7Ci0g ICAgICAgIC8vIEFkanVzdCBjZW50ZXIgYm94ZXMgdG8gYm91bmRhcnkgb2YgZmlyc3QKLSAgICAg ICAgaWYgKGRyYXdhYmxlUmVjdHMuc2l6ZSgpKQotICAgICAgICAgICAgc2hpZnRYRWRnZXNUb0Nv bnRhaW5JZlN0cmlrZXMoZHJhd2FibGVSZWN0cy5sYXN0KCksIHJlY3RzLmZpcnN0KCkpOwotICAg ICAgICBpZiAoZHJhd2FibGVSZWN0cy5zaXplKCkgJiYgZHJhd2FibGVSZWN0cy5sYXN0KCkuaW50 ZXJzZWN0cyhyZWN0cy5maXJzdCgpKSkKLSAgICAgICAgICAgIGRyYXdhYmxlUmVjdHMubGFzdCgp LnVuaXRlKHJlY3RzLmZpcnN0KCkpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBkcmF3YWJs ZVJlY3RzLnByZXBlbmQocmVjdHMuZmlyc3QoKSk7CisgICAgICAgIGlmICghbWlkLmlzRW1wdHko KSAmJiBtaWQuaW50ZXJzZWN0cyhyZWN0cy5maXJzdCgpKSkKKyAgICAgICAgICAgIG1pZC51bml0 ZShyZWN0cy5maXJzdCgpKTsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBmaXJzdCA9IHJl Y3RzLmZpcnN0KCk7CisgICAgICAgICAgICBzaGlmdFhFZGdlc1RvQ29udGFpbklmU3RyaWtlcyht aWQsIGZpcnN0LCAvKiBpc0ZpcnN0ICovIHRydWUpOworICAgICAgICB9CiAgICAgfQogCiAgICAg Ly8gQWRkIHRoZSBsYXN0IGJveCwgYnV0IG1lcmdlIGl0IHdpdGggdGhlIGNlbnRlciBib3hlcyBp ZiBpdCBpbnRlcnNlY3RzLgogICAgIGlmIChyZWN0cy5zaXplKCkgPiAxICYmICFyZWN0cy5sYXN0 KCkuaXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIEFkanVzdCBjZW50ZXIgYm94ZXMgdG8gYm91bmRh cnkgb2YgbGFzdAotICAgICAgICBpZiAoZHJhd2FibGVSZWN0cy5zaXplKCkpCi0gICAgICAgICAg ICBzaGlmdFhFZGdlc1RvQ29udGFpbklmU3RyaWtlcyhkcmF3YWJsZVJlY3RzLmxhc3QoKSwgcmVj dHMubGFzdCgpKTsKLSAgICAgICAgaWYgKGRyYXdhYmxlUmVjdHMuc2l6ZSgpICYmIGRyYXdhYmxl UmVjdHMubGFzdCgpLmludGVyc2VjdHMocmVjdHMubGFzdCgpKSkKLSAgICAgICAgICAgIGRyYXdh YmxlUmVjdHMubGFzdCgpLnVuaXRlKHJlY3RzLmxhc3QoKSk7Ci0gICAgICAgIGVsc2UKLSAgICAg ICAgICAgIGRyYXdhYmxlUmVjdHMuYXBwZW5kKHJlY3RzLmxhc3QoKSk7CisgICAgICAgIGlmICgh bWlkLmlzRW1wdHkoKSAmJiBtaWQuaW50ZXJzZWN0cyhyZWN0cy5sYXN0KCkpKQorICAgICAgICAg ICAgbWlkLnVuaXRlKHJlY3RzLmxhc3QoKSk7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAg bGFzdCA9IHJlY3RzLmxhc3QoKTsKKyAgICAgICAgICAgIHNoaWZ0WEVkZ2VzVG9Db250YWluSWZT dHJpa2VzKG1pZCwgbGFzdCwgLyogaXNGaXJzdCAqLyBmYWxzZSk7CisgICAgICAgIH0KICAgICB9 CiAKKyAgICBWZWN0b3I8TGF5b3V0UmVjdD4gZHJhd2FibGVSZWN0czsKKyAgICBpZiAoIWZpcnN0 LmlzRW1wdHkoKSkKKyAgICAgICAgZHJhd2FibGVSZWN0cy5hcHBlbmQoZmlyc3QpOworICAgIGlm ICghbWlkLmlzRW1wdHkoKSkKKyAgICAgICAgZHJhd2FibGVSZWN0cy5hcHBlbmQobWlkKTsKKyAg ICBpZiAoIWxhc3QuaXNFbXB0eSgpKQorICAgICAgICBkcmF3YWJsZVJlY3RzLmFwcGVuZChsYXN0 KTsKKwogICAgIC8vIENsaXAgdGhlIG92ZXJmbG93IHJlY3RzIGlmIG5lZWRlZCwgYmVmb3JlIHRo ZSByaW5nIHBhdGggaXMgZm9ybWVkIHRvCiAgICAgLy8gZW5zdXJlIHJvdW5kZWQgaGlnaGxpZ2h0 IHJlY3RzLiBUaGlzIGNsaXBwaW5nIGhhcyB0aGUgcHJvYmxlbSB3aXRoIG5lc3RlZAogICAgIC8v IGRpdnMgd2l0aCB0cmFuc2Zvcm1zLCB3aGljaCBjb3VsZCBiZSByZXNvbHZlZCBieSBwcm9wZXIg UGF0aDo6aW50ZXJzZWN0aW5nLgo=