<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97660</bug_id>
          
          <creation_ts>2012-09-26 04:49:39 -0700</creation_ts>
          <short_desc>[GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY</short_desc>
          <delta_ts>2012-09-26 05:55:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>728409</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-09-26 04:49:39 -0700</bug_when>
    <thetext>And also cr characters to try to fix the double line ending of the script output in the bots</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728416</commentid>
    <comment_count>1</comment_count>
      <attachid>165768</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-09-26 04:55:37 -0700</bug_when>
    <thetext>Created attachment 165768
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728451</commentid>
    <comment_count>2</comment_count>
      <attachid>165768</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2012-09-26 05:43:19 -0700</bug_when>
    <thetext>Comment on attachment 165768
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728460</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-09-26 05:55:20 -0700</bug_when>
    <thetext>Committed r129627: &lt;http://trac.webkit.org/changeset/129627&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165768</attachid>
            <date>2012-09-26 04:55:37 -0700</date>
            <delta_ts>2012-09-26 05:43:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk-run-gtk-tests-colors.diff</filename>
            <type>text/plain</type>
            <size>2757</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NTNk
ZmUyLi41YWJkZWRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDktMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z
ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlbW92ZSBjb2xvciBjb2Rl
cyBjaGFyYWN0ZXJzIGZyb20gcnVuLWd0ay10ZXN0cyBvdXRwdXQgd2hlbiBub3Qgd3JpdGluZyB0
byBhIFRUWQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
OTc2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS
ZW1vdmUgYWxzbyB0aGUgJ1xyJyBjaGFyYWN0ZXJzIHJldHVybmVkIGJ5IFRUWSBvdXRwdXQgdG8g
dHJ5IHRvIGZpeAorICAgICAgICB0aGUgZG91YmxlIGxpbmUgZW5kaW5ncyBvZiB0aGUgc2NyaXB0
IG91dHB1dCBpbiB0aGUgYm90cy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czoK
KyAgICAgICAgKFRlc3RSdW5uZXIuX19pbml0X18pOiBDb21waWxlIGEgcmVnZXhwIGZvciBjb2xv
ciBjb2RlcyBpZiBzdGRvdXQKKyAgICAgICAgaXQgbm90IGEgVFRZLgorICAgICAgICAoVGVzdFJ1
bm5lci5fcnVuX3Rlc3RfY29tbWFuZC5wYXJzZV9saW5lKTogUmVtb3ZlIGNvbG9yIGNvZGVzIGFu
ZAorICAgICAgICAnXHInIGNoYXJhY3RlcnMgZnJvbSB0aGUgbGluZSByZXR1cm5lZCBieSB0aGUg
cHNldWRvLXRlcm1pbmFsIGlmCisgICAgICAgIHN0ZG91dCBpcyBub3QgYSBUVFkuCisgICAgICAg
ICogZ3RrL2NvbW1vbi5weToKKyAgICAgICAgKHBhcnNlX291dHB1dF9saW5lcyk6IEZpeCB0aGUg
bGFzdCBjaHVuayBjaGVjayB0byBtYWtlIHN1cmUgd2UKKyAgICAgICAgYWx3YXlzIHNlbmQgZW50
aXJlIGxpbmVzIHRvIHRoZSBjYWxsYmFjaywgb3RoZXJ3aXNlIGNvbG9yIGNvZGVzCisgICAgICAg
IHJlZ2V4cCBtaWdodCBmYWlsIGlmIHRoZSBsaW5lIGlzIG5vdCBjb21wbGV0ZS4KKwogMjAxMi0w
OS0yNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRhdGUg
bWFzdGVyLmNmZyB0byBpbnZva2UgcnVuLXBlcmYtdGVzdHMgd2l0aCAtLW5vLXNob3ctcmVzdWx0
cyBhbmQgLS1yZXNldC1yZXN1bHRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGst
dGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggOWQ1YjcxMS4uMTI3NjU5
NiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rvb2xzL1Nj
cmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtODMsNiArODMsOCBAQCBjbGFzcyBUZXN0UnVubmVyOgog
ICAgICAgICBzZWxmLl9wcm9ncmFtc19wYXRoID0gY29tbW9uLmJ1aWxkX3BhdGgoIlByb2dyYW1z
IikKICAgICAgICAgc2VsZi5fdGVzdHMgPSBzZWxmLl9nZXRfdGVzdHModGVzdHMpCiAgICAgICAg
IHNlbGYuX3NraXBwZWRfdGVzdHMgPSBUZXN0UnVubmVyLlNLSVBQRUQKKyAgICAgICAgaWYgbm90
IHN5cy5zdGRvdXQuaXNhdHR5KCk6CisgICAgICAgICAgICBzZWxmLl90dHlfY29sb3JzX3BhdHRl
cm4gPSByZS5jb21waWxlKCJcMDMzXFtbMC05O10qbSIpCiAKICAgICAgICAgIyBUaGVzZSBTUEkg
ZGFlbW9ucyBuZWVkIHRvIGJlIGFjdGl2ZSBmb3IgdGhlIGFjY2Vzc2liaWxpdHkgdGVzdHMgdG8g
d29yay4KICAgICAgICAgc2VsZi5fc3BpX3JlZ2lzdHJ5ZCA9IE5vbmUKQEAgLTIxNyw3ICsyMTks
MTEgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgZGVmIHBhcnNlX2xpbmUobGluZSwgY2hp
bGRfcGlkID0gY2hpbGRfcGlkKToKICAgICAgICAgICAgIGlmIGNoaWxkX3BpZFswXSA9PSAtMToK
ICAgICAgICAgICAgICAgICBjaGlsZF9waWRbMF0gPSBzZWxmLl9nZXRfY2hpbGRfcGlkX2Zyb21f
dGVzdF9vdXRwdXQobGluZSkKLSAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUobGluZSkKKwor
ICAgICAgICAgICAgaWYgc3lzLnN0ZG91dC5pc2F0dHkoKToKKyAgICAgICAgICAgICAgICBzeXMu
c3Rkb3V0LndyaXRlKGxpbmUpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHN5
cy5zdGRvdXQud3JpdGUoc2VsZi5fdHR5X2NvbG9yc19wYXR0ZXJuLnN1YignJywgbGluZS5yZXBs
YWNlKCdccicsICcnKSkpCiAKICAgICAgICAgZGVmIHdhaXRwaWQocGlkKToKICAgICAgICAgICAg
IHdoaWxlIFRydWU6CmRpZmYgLS1naXQgYS9Ub29scy9ndGsvY29tbW9uLnB5IGIvVG9vbHMvZ3Rr
L2NvbW1vbi5weQppbmRleCBlMDkwZWZjLi5kZDMyZTA4IDEwMDY0NAotLS0gYS9Ub29scy9ndGsv
Y29tbW9uLnB5CisrKyBiL1Rvb2xzL2d0ay9jb21tb24ucHkKQEAgLTEzMCw2ICsxMzAsNiBAQCBk
ZWYgcGFyc2Vfb3V0cHV0X2xpbmVzKGZkLCBwYXJzZV9saW5lX2NhbGxiYWNrKToKICAgICAgICAg
ICAgICAgICBwYXJzZV9saW5lX2NhbGxiYWNrKG91dHB1dFs6cG9zICsgMV0pCiAgICAgICAgICAg
ICAgICAgb3V0cHV0ID0gb3V0cHV0W3BvcyArIDE6XQogCi0gICAgICAgICAgICBpZiBsZW4oY2h1
bmspIDwgMTAyNCBhbmQgb3V0cHV0OgorICAgICAgICAgICAgaWYgbm90IGNodW5rIGFuZCBvdXRw
dXQ6CiAgICAgICAgICAgICAgICAgcGFyc2VfbGluZV9jYWxsYmFjayhvdXRwdXQpCiAgICAgICAg
ICAgICAgICAgb3V0cHV0ID0gJycK
</data>
<flag name="review"
          id="177910"
          type_id="1"
          status="+"
          setter="pnormand"
    />
          </attachment>
      

    </bug>

</bugzilla>