97658 2012-09-26 04:44:01 -0700 [Cairo] Bump Cairo to fix more canvas/philip tests 2012-10-09 19:18:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 54458 1 d-r webkit-unassigned alex gyuyoung.kim mrobinson naginenis rakuco webkit.review.bot zan oldest_to_newest 728404 0 d-r 2012-09-26 04:44:01 -0700 We've continued the analysis from https://bugs.webkit.org/show_bug.cgi?id=54458#c7 and worked with Chris Wilson to address some of these issue. We've experimentally bumped cairo to 1.12 which has introduced new regressions: fast/canvas/canvas-fillRect-gradient-shadow.html = TEXT svg/batik/text/smallFonts.svg = TEXT svg/batik/text/textGlyphOrientationHorizontal.svg = TEXT svg/batik/text/textOnPath2.svg = TEXT svg/batik/text/textOnPath3.svg = TEXT svg/batik/text/textOnPathSpaces.svg = TEXT svg/batik/text/verticalTextOnPath.svg = TEXT svg/hixie/perf/001.xml = TEXT svg/hixie/perf/002.xml = TEXT svg/stroke/zero-length-path-linecap-rendering.svg = TEXT svg/stroke/zero-length-subpaths-linecap-rendering.svg = TEXT svg/transforms/transformed-text-fill-pattern.html = IMAGE For which we filed https://bugs.freedesktop.org/show_bug.cgi?id=54446 "WebKit regression observed in Cairo commit 83bfd85" (now resolved) https://bugs.freedesktop.org/show_bug.cgi?id=54507 "WebKit regression found in Cairo commit 51594d9" (under investigation) Once the second bug can be resolved (on either cairo side or WebKit side), we should be able to bump Cairo to at least f34b87f6d76cbea93acd4a8c73c8c6a6b412a302 or a release version after this commit. This would resolve failures for (no webkit bugs): 2d.path.rect.selfintersect.html canvas/philip/tests/2d.path.rect.zero.6.html canvas/philip/tests/2d.path.arc.zeroradius.html WebKit Bug 54471: canvas/philip/tests/2d.path.arc.selfintersect.1.html canvas/philip/tests/2d.path.arc.shape.3.html 728407 1 d-r 2012-09-26 04:44:53 -0700 *** Bug 54471 has been marked as a duplicate of this bug. *** 729319 2 naginenis 2012-09-27 01:47:07 -0700 The stroke and hixie/perf tests are addressed in Cairo bug https://bugs.freedesktop.org/show_bug.cgi?id=54549 (commit b0c466e) 737868 3 167773 naginenis 2012-10-09 09:33:50 -0700 Created attachment 167773 Patch Bumped the cairo to version 1.12.4 in the jhbuild files for EFL and GTK. Also, unskipped canvas/philip tests which are passing now and updated platform-specific baselines for svg tests. 737870 4 mrobinson 2012-10-09 09:37:10 -0700 I'm not sure if I understand the new shadow failure. Shadows are not rendered with Cairo, rather the shadow code works with the pixels of the image directly. 738368 5 167882 naginenis 2012-10-09 17:43:37 -0700 Created attachment 167882 Patch Updated the test case of new shadow failure in the bug #98760, after discussing with Martin a bit more. 738440 6 167882 webkit.review.bot 2012-10-09 19:18:21 -0700 Comment on attachment 167882 Patch Clearing flags on attachment: 167882 Committed r130840: <http://trac.webkit.org/changeset/130840> 738441 7 webkit.review.bot 2012-10-09 19:18:26 -0700 All reviewed patches have been landed. Closing bug. 167773 2012-10-09 09:33:50 -0700 2012-10-09 17:43:37 -0700 Patch 97658.patch text/plain 0 naginenis 167882 2012-10-09 17:43:37 -0700 2012-10-09 19:18:21 -0700 Patch 97658.patch text/plain 0 naginenis