97645 2012-09-26 01:50:27 -0700 SuggestionPicker min width is two pixels wider than it should be 2012-09-26 04:50:12 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97551 1 keishi keishi tkent webkit.review.bot oldest_to_newest 728317 0 keishi 2012-09-26 01:50:27 -0700 SuggestionPicker min width is two pixels wider than it should be 728320 1 165751 keishi 2012-09-26 01:57:28 -0700 Created attachment 165751 Patch 728324 2 165751 tkent 2012-09-26 02:01:30 -0700 Comment on attachment 165751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165751&action=review > Source/WebCore/ChangeLog:14 > + (SuggestionPicker.prototype._measureMaxContentWidth): > + (SuggestionPicker.prototype._fixWindowSize): Please add reasons of changes per function as possible. 728330 3 165754 keishi 2012-09-26 02:06:21 -0700 Created attachment 165754 Patch 728410 4 165754 webkit.review.bot 2012-09-26 04:50:09 -0700 Comment on attachment 165754 Patch Clearing flags on attachment: 165754 Committed r129622: <http://trac.webkit.org/changeset/129622> 728411 5 webkit.review.bot 2012-09-26 04:50:12 -0700 All reviewed patches have been landed. Closing bug. 165751 2012-09-26 01:57:28 -0700 2012-09-26 02:06:16 -0700 Patch bug-97645-20120926175647.patch text/plain 2310 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUxZTQxYzY0ZDA3Yjc4 NmE4ZWRlYTc4MGZkYjhjYjU5ODQzZGYxZS4uZTg5ZWQxNDM4NGY3YTgzZjhiZDc5YzRhMTNjOGEy NTMyYzhkNzdlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI2ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFN1Z2dlc3Rpb25QaWNr ZXIgbWluIHdpZHRoIGlzIHR3byBwaXhlbHMgd2lkZXIgdGhhbiBpdCBzaG91bGQgYmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjQ1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VnZ2VzdGlvbiBwaWNr ZXIncyBtaW5pbXVtIHdpZHRoIHNob3VsZCBtYXRjaCBpbnB1dFdpZHRoLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gQWRkZWQgbGF0ZXIgaW4gQnVnIDk3NjQ1LgorCisgICAgICAgICogUmVzb3Vy Y2VzL3BhZ2Vwb3B1cHMvc3VnZ2VzdGlvblBpY2tlci5qczoKKyAgICAgICAgKFN1Z2dlc3Rpb25Q aWNrZXIucHJvdG90eXBlLl9tZWFzdXJlTWF4Q29udGVudFdpZHRoKToKKyAgICAgICAgKFN1Z2dl c3Rpb25QaWNrZXIucHJvdG90eXBlLl9maXhXaW5kb3dTaXplKToKKwogMjAxMi0wOS0yNSAgQmVh ciBUcmF2aXMgIDxiZXRyYXZpc0BhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25z XSBzaGFwZS1pbnNpZGUgbGluZSBzZWdtZW50IGxheW91dCBzaG91bGQgYmUgYmFzZWQgb24gbGlu ZSBwb3NpdGlvbiBhbmQgaGVpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJj ZXMvcGFnZXBvcHVwcy9zdWdnZXN0aW9uUGlja2VyLmpzIGIvU291cmNlL1dlYkNvcmUvUmVzb3Vy Y2VzL3BhZ2Vwb3B1cHMvc3VnZ2VzdGlvblBpY2tlci5qcwppbmRleCBjNzhiMWUwNTk2NjJiODNl YWU0MmQwZDVkMzFjY2YzMzM1NjU5ZmEzLi4wOTBmN2ZiZjZhYjQwZTdkOGFmYzFiODU3MDRiMzQx YzBiNzM1YjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVw cy9zdWdnZXN0aW9uUGlja2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdl cG9wdXBzL3N1Z2dlc3Rpb25QaWNrZXIuanMKQEAgLTEyNiw4ICsxMjYsNiBAQCBTdWdnZXN0aW9u UGlja2VyLnByb3RvdHlwZS5fbWVhc3VyZU1heENvbnRlbnRXaWR0aCA9IGZ1bmN0aW9uKCkgewog ICAgIC8vIGxlZnQgYWxpZ25zIGFsbCB0aGUgY29udGVudCBpbmNsdWRpbmcgbGFiZWwuCiAgICAg dGhpcy5fY29udGFpbmVyRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJtZWFzdXJpbmctd2lkdGgiKTsK ICAgICB2YXIgbWF4Q29udGVudFdpZHRoID0gMDsKLSAgICBpZiAodHlwZW9mIHRoaXMuX2NvbmZp Zy5pbnB1dFdpZHRoID09PSAibnVtYmVyIikKLSAgICAgICAgbWF4Q29udGVudFdpZHRoID0gdGhp cy5fY29uZmlnLmlucHV0V2lkdGg7CiAgICAgdmFyIGNvbnRlbnRFbGVtZW50cyA9IHRoaXMuX2Nv bnRhaW5lckVsZW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgiY29udGVudCIpOwogICAgIGZv ciAodmFyIGk9MDsgaSA8IGNvbnRlbnRFbGVtZW50cy5sZW5ndGg7ICsraSkgewogICAgICAgICBt YXhDb250ZW50V2lkdGggPSBNYXRoLm1heChtYXhDb250ZW50V2lkdGgsIGNvbnRlbnRFbGVtZW50 c1tpXS5vZmZzZXRXaWR0aCk7CkBAIC0xMzksNiArMTM3LDggQEAgU3VnZ2VzdGlvblBpY2tlci5w cm90b3R5cGUuX21lYXN1cmVNYXhDb250ZW50V2lkdGggPSBmdW5jdGlvbigpIHsKIFN1Z2dlc3Rp b25QaWNrZXIucHJvdG90eXBlLl9maXhXaW5kb3dTaXplID0gZnVuY3Rpb24oKSB7CiAgICAgdmFy IExpc3RCb3JkZXIgPSAyOwogICAgIHZhciBkZXNpcmVkV2luZG93V2lkdGggPSB0aGlzLl9tZWFz dXJlTWF4Q29udGVudFdpZHRoKCkgKyBMaXN0Qm9yZGVyOworICAgIGlmICh0eXBlb2YgdGhpcy5f Y29uZmlnLmlucHV0V2lkdGggPT09ICJudW1iZXIiKQorICAgICAgICBkZXNpcmVkV2luZG93V2lk dGggPSBNYXRoLm1heCh0aGlzLl9jb25maWcuaW5wdXRXaWR0aCwgZGVzaXJlZFdpbmRvd1dpZHRo KTsKICAgICB2YXIgdG90YWxIZWlnaHQgPSBMaXN0Qm9yZGVyOwogICAgIHZhciBtYXhIZWlnaHQg PSAwOwogICAgIHZhciBlbnRyeUNvdW50ID0gMDsK 165754 2012-09-26 02:06:21 -0700 2012-09-26 04:50:09 -0700 Patch bug-97645-20120926180539.patch text/plain 2356 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUxZTQxYzY0ZDA3Yjc4 NmE4ZWRlYTc4MGZkYjhjYjU5ODQzZGYxZS4uMzg0NjRmZGNhYzAyOGU3MzgzMjY5YzI4ZjRlM2Fj MGU5MmExYTJmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI2ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFN1Z2dlc3Rpb25QaWNr ZXIgbWluIHdpZHRoIGlzIHR3byBwaXhlbHMgd2lkZXIgdGhhbiBpdCBzaG91bGQgYmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjQ1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCisKKyAgICAgICAgU3VnZ2VzdGlvbiBwaWNrZXIn cyBtaW5pbXVtIHdpZHRoIHNob3VsZCBtYXRjaCBpbnB1dFdpZHRoLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gQWRkZWQgbGF0ZXIgaW4gQnVnIDk3NjQ1LgorCisgICAgICAgICogUmVzb3VyY2Vz L3BhZ2Vwb3B1cHMvc3VnZ2VzdGlvblBpY2tlci5qczoKKyAgICAgICAgKFN1Z2dlc3Rpb25QaWNr ZXIucHJvdG90eXBlLl9tZWFzdXJlTWF4Q29udGVudFdpZHRoKToKKyAgICAgICAgKFN1Z2dlc3Rp b25QaWNrZXIucHJvdG90eXBlLl9maXhXaW5kb3dTaXplKTogV2Ugc2hvdWxkbid0IGJlIGFkZGlu ZyBMaXN0Qm9yZGVyIHRvIGlucHV0V2lkdGguCisKIDIwMTItMDktMjUgIEJlYXIgVHJhdmlzICA8 YmV0cmF2aXNAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gc2hhcGUtaW5z aWRlIGxpbmUgc2VnbWVudCBsYXlvdXQgc2hvdWxkIGJlIGJhc2VkIG9uIGxpbmUgcG9zaXRpb24g YW5kIGhlaWdodApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1 cHMvc3VnZ2VzdGlvblBpY2tlci5qcyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9w dXBzL3N1Z2dlc3Rpb25QaWNrZXIuanMKaW5kZXggYzc4YjFlMDU5NjYyYjgzZWFlNDJkMGQ1ZDMx Y2NmMzMzNTY1OWZhMy4uMDkwZjdmYmY2YWI0MGU3ZDhhZmMxYjg1NzA0YjM0MWMwYjczNWIwOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvc3VnZ2VzdGlv blBpY2tlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9zdWdn ZXN0aW9uUGlja2VyLmpzCkBAIC0xMjYsOCArMTI2LDYgQEAgU3VnZ2VzdGlvblBpY2tlci5wcm90 b3R5cGUuX21lYXN1cmVNYXhDb250ZW50V2lkdGggPSBmdW5jdGlvbigpIHsKICAgICAvLyBsZWZ0 IGFsaWducyBhbGwgdGhlIGNvbnRlbnQgaW5jbHVkaW5nIGxhYmVsLgogICAgIHRoaXMuX2NvbnRh aW5lckVsZW1lbnQuY2xhc3NMaXN0LmFkZCgibWVhc3VyaW5nLXdpZHRoIik7CiAgICAgdmFyIG1h eENvbnRlbnRXaWR0aCA9IDA7Ci0gICAgaWYgKHR5cGVvZiB0aGlzLl9jb25maWcuaW5wdXRXaWR0 aCA9PT0gIm51bWJlciIpCi0gICAgICAgIG1heENvbnRlbnRXaWR0aCA9IHRoaXMuX2NvbmZpZy5p bnB1dFdpZHRoOwogICAgIHZhciBjb250ZW50RWxlbWVudHMgPSB0aGlzLl9jb250YWluZXJFbGVt ZW50LmdldEVsZW1lbnRzQnlDbGFzc05hbWUoImNvbnRlbnQiKTsKICAgICBmb3IgKHZhciBpPTA7 IGkgPCBjb250ZW50RWxlbWVudHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgbWF4Q29udGVudFdp ZHRoID0gTWF0aC5tYXgobWF4Q29udGVudFdpZHRoLCBjb250ZW50RWxlbWVudHNbaV0ub2Zmc2V0 V2lkdGgpOwpAQCAtMTM5LDYgKzEzNyw4IEBAIFN1Z2dlc3Rpb25QaWNrZXIucHJvdG90eXBlLl9t ZWFzdXJlTWF4Q29udGVudFdpZHRoID0gZnVuY3Rpb24oKSB7CiBTdWdnZXN0aW9uUGlja2VyLnBy b3RvdHlwZS5fZml4V2luZG93U2l6ZSA9IGZ1bmN0aW9uKCkgewogICAgIHZhciBMaXN0Qm9yZGVy ID0gMjsKICAgICB2YXIgZGVzaXJlZFdpbmRvd1dpZHRoID0gdGhpcy5fbWVhc3VyZU1heENvbnRl bnRXaWR0aCgpICsgTGlzdEJvcmRlcjsKKyAgICBpZiAodHlwZW9mIHRoaXMuX2NvbmZpZy5pbnB1 dFdpZHRoID09PSAibnVtYmVyIikKKyAgICAgICAgZGVzaXJlZFdpbmRvd1dpZHRoID0gTWF0aC5t YXgodGhpcy5fY29uZmlnLmlucHV0V2lkdGgsIGRlc2lyZWRXaW5kb3dXaWR0aCk7CiAgICAgdmFy IHRvdGFsSGVpZ2h0ID0gTGlzdEJvcmRlcjsKICAgICB2YXIgbWF4SGVpZ2h0ID0gMDsKICAgICB2 YXIgZW50cnlDb3VudCA9IDA7Cg==