97632 2012-09-25 22:34:48 -0700 Fix potential build error on LocalFileSystem::deleteFileSystem 2012-09-26 00:30:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 dw.im webkit-unassigned tzik webkit.review.bot yutak oldest_to_newest 728199 0 dw.im 2012-09-25 22:34:48 -0700 Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at LocalFileSystem::deleteFileSystem. Type of the third parameter is PassOwnPtr<AsyncFileSystemCallbacks> in header file, but PassRefPtr<AsyncFileSystemCallbacks> in cpp file. I will upload patch soon. 728214 1 165732 dw.im 2012-09-25 22:58:48 -0700 Created attachment 165732 patch Modify the type of the parameter. 728254 2 tzik 2012-09-26 00:03:23 -0700 Thank you for fixing it, Dongwoo. It looks good to me. 728270 3 165732 yutak 2012-09-26 00:24:47 -0700 Comment on attachment 165732 patch Looks OK. 728273 4 165732 webkit.review.bot 2012-09-26 00:30:24 -0700 Comment on attachment 165732 patch Clearing flags on attachment: 165732 Committed r129602: <http://trac.webkit.org/changeset/129602> 728274 5 webkit.review.bot 2012-09-26 00:30:27 -0700 All reviewed patches have been landed. Closing bug. 165732 2012-09-25 22:58:48 -0700 2012-09-26 00:30:24 -0700 patch patch_97632_0926.patch text/plain 2086 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MTBmYTE2Li5mZDg0ODMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDktMjUgIERvbmd3b28gSm9zaHVhIEltICA8ZHcuaW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgRml4IHBvdGVudGlhbCBidWlsZCBlcnJvciBvbiBMb2NhbEZpbGVTeXN0ZW06OmRl bGV0ZUZpbGVTeXN0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk3NjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm9uLUNocm9tZSBidWlsZCBvZiBXZWJLaXQgd2l0aCBGSUxFX1NZU1RFTSBmbGFnIHdp bGwgYmUgYnJva2VuIGF0IExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbS4KKyAgICAg ICAgVHlwZSBvZiB0aGUgdGhpcmQgcGFyYW1ldGVyIGlzIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lz dGVtQ2FsbGJhY2tzPiBpbiBoZWFkZXIgZmlsZSwKKyAgICAgICAgYnV0IFBhc3NSZWZQdHI8QXN5 bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBpbiBjcHAgZmlsZS4KKworICAgICAgICBOb24tQ2hyb21l IFdlYktpdCBidWlsZCB3aXRoIEZJTEVfU1lTVEVNIHNob3VsZCBiZSBmaW5pc2hlZCBzdWNjZXNz ZnVsbHkuCisKKyAgICAgICAgKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbSk6 CisKIDIwMTItMDktMjUgIEx1a2UgTWFjcGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBFbnN1cmUgdmFyaWFibGVzIGFyZSByZXNvbHZlZCBmb3Igc3BlY2lhbGl6 ZWQgQ1NTIHByaW1pdGl2ZSB2YWx1ZSB0eXBlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvZmlsZXN5c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5jcHAKaW5kZXggOWY3YzlkNS4uZTEw NjRhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2Fs RmlsZVN5c3RlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xv Y2FsRmlsZVN5c3RlbS5jcHAKQEAgLTEwMiw3ICsxMDIsNyBAQCB2b2lkIExvY2FsRmlsZVN5c3Rl bTo6cmVxdWVzdEZpbGVTeXN0ZW0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgRmls ZVN5cwogICAgIGNvbnRleHQtPnBvc3RUYXNrKGNyZWF0ZUNhbGxiYWNrVGFzaygmb3BlbkZpbGVT eXN0ZW0sIGZpbGVTeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5k YXRhYmFzZUlkZW50aWZpZXIoKSwgdHJ1ZSwgY2FsbGJhY2tzKSk7CiB9CiAKLXZvaWQgTG9jYWxG aWxlU3lzdGVtOjpkZWxldGVGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRl eHQsIEZpbGVTeXN0ZW1UeXBlIHR5cGUsIFBhc3NSZWZQdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJh Y2tzPiBjYWxsYmFja3MpCit2b2lkIExvY2FsRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbShT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBGaWxlU3lzdGVtVHlwZSB0eXBlLCBQYXNz T3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJhY2tzKQogewogICAgIC8vIEFz eW5jRmlsZVN5c3RlbTo6ZGVsZXRlRmlsZVN5c3RlbSBjYWxscyBjYWxsYmFja3Mgc3luY2hyb25v dXNseSwgc28gdGhlIG1ldGhvZCBuZWVkcyB0byBiZSBjYWxsZWQgYXN5bmNocm9ub3VzbHkuCiAg ICAgY29udGV4dC0+cG9zdFRhc2soY3JlYXRlQ2FsbGJhY2tUYXNrKCZkZWxldGVGaWxlU3lzdGVt LCBmaWxlc3lzdGVtQmFzZVBhdGgoKSwgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ZGF0YWJh c2VJZGVudGlmaWVyKCksIHR5cGUsIGNhbGxiYWNrcyk7Cg==