97629 2012-09-25 21:23:39 -0700 http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after being unskipped 2012-09-26 13:26:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin thorton oldest_to_newest 728185 0 bdakin 2012-09-25 21:23:39 -0700 http/tests/security/cross-frame-access-put.html was a skipped test until http://trac.webkit.org/changeset/129486 Now that is is unskipped, it is failing on the WK2 bots. It's possible that the failure is just a platform difference though since the test indicates that it is still passing. The diff is: --- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt @@ -520,9 +520,9 @@ ALERT: PASS: window.personalbar should be '[object BarInfo]' and is. ALERT: PASS: window.plugins should be 'undefined' and is. ALERT: PASS: window.screen should be '[object Screen]' and is. -ALERT: PASS: window.screenLeft should be '0' and is. +ALERT: PASS: window.screenLeft should be '-10000' and is. ALERT: PASS: window.screenTop matched the expected value. -ALERT: PASS: window.screenX should be '0' and is. +ALERT: PASS: window.screenX should be '-10000' and is. ALERT: PASS: window.screenY matched the expected value. ALERT: PASS: window.scrollbars should be '[object BarInfo]' and is. ALERT: PASS: window.scrollX should be '0' and is. 728771 1 bdakin 2012-09-26 11:18:09 -0700 It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs. That doesn't seem right. 728781 2 thorton 2012-09-26 11:23:00 -0700 (In reply to comment #1) > It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs. That doesn't seem right. We should probably ditch _shouldUseFakeOrigin and just always use it (and initialize it to wherever we put the window initially). 728848 3 165849 bdakin 2012-09-26 12:15:29 -0700 Created attachment 165849 Patch 728918 4 bdakin 2012-09-26 13:26:00 -0700 Thanks Tim! Committed change: http://trac.webkit.org/changeset/129694 165849 2012-09-26 12:15:29 -0700 2012-09-26 13:22:00 -0700 Patch for-review.txt text/plain 2916 bdakin SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyOTY4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTA5LTI2ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc2MjkKKyAg ICAgICAgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtcHV0Lmh0bWwgZmFp bGluZyBvbiBNYWMgV0syIGJvdHMgYWZ0ZXIgCisgICAgICAgIGJlaW5nIHVuc2tpcHBlZAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IHdh cyBmYWlsaW5nIGJlY2F1c2Ugd2Ugd2VyZSBmYWlsaW5nIHRvIHVzZSB0aGUgZmFrZSB3aW5kb3cg b3JpZ2luLiBXZSAKKyAgICAgICAgc2hvdWxkIHJlYWxseSBhbHdheXMgdXNlIHRoZSBmYWtlIG9y aWdpbi4gVGhpcyBwYXRjaCBlbGltaW5hdGVzIAorICAgICAgICBfc2hvdWxkVXNlRmFrZU9yaWdp biBpbiBmYXZvciBvZiBhbHdheXMgdXNpbmcgaXQuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tOgorICAgICAgICAoLVtXZWJLaXRUZXN0UnVubmVy V2luZG93IHNldEZyYW1lT3JpZ2luOl0pOgorICAgICAgICAoLVtXZWJLaXRUZXN0UnVubmVyV2lu ZG93IHNldEZyYW1lOmRpc3BsYXk6YW5pbWF0ZTpdKToKKyAgICAgICAgKC1bV2ViS2l0VGVzdFJ1 bm5lcldpbmRvdyBzZXRGcmFtZTpkaXNwbGF5Ol0pOgorICAgICAgICAoLVtXZWJLaXRUZXN0UnVu bmVyV2luZG93IGZyYW1lUmVzcGVjdGluZ0Zha2VPcmlnaW5dKToKKwogMjAxMi0wOS0yNiAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjEyOTY1NC4KSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv bWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0 UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0JKHJldmlzaW9uIDEyOTU3MykKKysrIFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQkod29ya2luZyBj b3B5KQpAQCAtMzMsNyArMzMsNiBAQAogQGludGVyZmFjZSBXZWJLaXRUZXN0UnVubmVyV2luZG93 IDogTlNXaW5kb3cgewogICAgIFdUUjo6UGxhdGZvcm1XZWJWaWV3KiBfcGxhdGZvcm1XZWJWaWV3 OwogICAgIE5TUG9pbnQgX2Zha2VPcmlnaW47Ci0gICAgYm9vbCBfc2hvdWxkVXNlRmFrZU9yaWdp bjsKIH0KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBhc3NpZ24pIFdUUjo6UGxhdGZvcm1XZWJWaWV3 KiBwbGF0Zm9ybVdlYlZpZXc7CiBAZW5kCkBAIC00OSw3ICs0OCw2IEBAIC0gKEJPT0wpaXNLZXlX aW5kb3cKIC0gKHZvaWQpc2V0RnJhbWVPcmlnaW46KE5TUG9pbnQpcG9pbnQKIHsKICAgICBfZmFr ZU9yaWdpbiA9IHBvaW50OwotICAgIF9zaG91bGRVc2VGYWtlT3JpZ2luID0gWUVTOwogfQogCiAt ICh2b2lkKXNldEZyYW1lOihOU1JlY3Qpd2luZG93RnJhbWUgZGlzcGxheTooQk9PTClkaXNwbGF5 Vmlld3MgYW5pbWF0ZTooQk9PTClwZXJmb3JtQW5pbWF0aW9uCkBAIC01Nyw3ICs1NSw2IEBAIC0g KHZvaWQpc2V0RnJhbWU6KE5TUmVjdCl3aW5kb3dGcmFtZSBkaXMKICAgICBOU1JlY3QgY3VycmVu dEZyYW1lID0gW3N1cGVyIGZyYW1lXTsKIAogICAgIF9mYWtlT3JpZ2luID0gd2luZG93RnJhbWUu b3JpZ2luOwotICAgIF9zaG91bGRVc2VGYWtlT3JpZ2luID0gWUVTOwogCiAgICAgW3N1cGVyIHNl dEZyYW1lOk5TTWFrZVJlY3QoY3VycmVudEZyYW1lLm9yaWdpbi54LCBjdXJyZW50RnJhbWUub3Jp Z2luLnksIHdpbmRvd0ZyYW1lLnNpemUud2lkdGgsIHdpbmRvd0ZyYW1lLnNpemUuaGVpZ2h0KSBk aXNwbGF5OmRpc3BsYXlWaWV3cyBhbmltYXRlOnBlcmZvcm1BbmltYXRpb25dOwogfQpAQCAtNjcs NyArNjQsNiBAQCAtICh2b2lkKXNldEZyYW1lOihOU1JlY3Qpd2luZG93RnJhbWUgZGlzCiAgICAg TlNSZWN0IGN1cnJlbnRGcmFtZSA9IFtzdXBlciBmcmFtZV07CiAKICAgICBfZmFrZU9yaWdpbiA9 IHdpbmRvd0ZyYW1lLm9yaWdpbjsKLSAgICBfc2hvdWxkVXNlRmFrZU9yaWdpbiA9IFlFUzsKIAog ICAgIFtzdXBlciBzZXRGcmFtZTpOU01ha2VSZWN0KGN1cnJlbnRGcmFtZS5vcmlnaW4ueCwgY3Vy cmVudEZyYW1lLm9yaWdpbi55LCB3aW5kb3dGcmFtZS5zaXplLndpZHRoLCB3aW5kb3dGcmFtZS5z aXplLmhlaWdodCkgZGlzcGxheTpkaXNwbGF5Vmlld3NdOwogfQpAQCAtNzUsMTEgKzcxLDcgQEAg LSAodm9pZClzZXRGcmFtZTooTlNSZWN0KXdpbmRvd0ZyYW1lIGRpcwogLSAoTlNSZWN0KWZyYW1l UmVzcGVjdGluZ0Zha2VPcmlnaW4KIHsKICAgICBOU1JlY3QgY3VycmVudEZyYW1lID0gW3NlbGYg ZnJhbWVdOwotCi0gICAgaWYgKF9zaG91bGRVc2VGYWtlT3JpZ2luKQotICAgICAgICByZXR1cm4g TlNNYWtlUmVjdChfZmFrZU9yaWdpbi54LCBfZmFrZU9yaWdpbi55LCBjdXJyZW50RnJhbWUuc2l6 ZS53aWR0aCwgY3VycmVudEZyYW1lLnNpemUuaGVpZ2h0KTsKLQotICAgIHJldHVybiBjdXJyZW50 RnJhbWU7CisgICAgcmV0dXJuIE5TTWFrZVJlY3QoX2Zha2VPcmlnaW4ueCwgX2Zha2VPcmlnaW4u eSwgY3VycmVudEZyYW1lLnNpemUud2lkdGgsIGN1cnJlbnRGcmFtZS5zaXplLmhlaWdodCk7CiB9 CiAKIEBlbmQK