97622 2012-09-25 18:39:53 -0700 [EFL] Fix build error : Link webkit2 library to ewk2UnitTestInjectedBundleSample. 2012-09-29 05:51:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bw80.lee bw80.lee gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 728126 0 bw80.lee 2012-09-25 18:39:53 -0700 When building efl for the first time, there is a build error as below. In file included from WebKitBuild/Debug/DerivedSources/WebKit2/include/WebKit2/WKBase.h:1:0, from Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:29, from WebKitBuild/Debug/DerivedSources/WebKit2/include/WebKit2/WKBundleInitialize.h:1, from Source/WebKit2/UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp:26: Source/WebKit2/Shared/API/c/WKBase.h:41:32: fatal error: WebKit2/WKBaseSoup.h: No such file or directory 728140 1 165716 bw80.lee 2012-09-25 19:00:10 -0700 Created attachment 165716 Patch 728246 2 165716 rakuco 2012-09-25 23:51:30 -0700 Comment on attachment 165716 Patch Doesn't it make sense to link this library against ${EWK2UnitTests_LIBRARIES} instead? Right now the file only includes a few headers and does nothing, but in the future not only will it need these created headers, but also actual function calls, I guess. 728379 3 bw80.lee 2012-09-26 03:18:50 -0700 (In reply to comment #2) > (From update of attachment 165716 [details]) > Doesn't it make sense to link this library against ${EWK2UnitTests_LIBRARIES} instead? Right now the file only includes a few headers and does nothing, but in the future not only will it need these created headers, but also actual function calls, I guess. I understand your point. Actually, I have one doubt for linking EWK2UnitTests_LIBRARIES to injected bundle libraries. (about static library conflict issue) As you already know, EWK2UnitTests_LIBRARIES has wtf, javascriptcore and webcore library. And if SHARED_CORE is not ON, wtf, javascript, webcore will be a static library, and linked both WebProcess and injected bundle library. Isn't there any problem when WebProcess load the injected bundle library? I'm not sure but I simply understood that the EFL's build guide about SHARED_CORE=ON for the layout test is related with this issue. 728425 4 gyuyoung.kim 2012-09-26 05:01:20 -0700 (In reply to comment #3) > I'm not sure but I simply understood that the EFL's build guide about SHARED_CORE=ON for the layout test is related with this issue. We should support to enable | disable SHARED_CORE both. 728429 5 rakuco 2012-09-26 05:08:12 -0700 (In reply to comment #3) > As you already know, > EWK2UnitTests_LIBRARIES has wtf, javascriptcore and webcore library. > And if SHARED_CORE is not ON, wtf, javascript, webcore will be a static library, and linked both WebProcess and injected bundle library. > > Isn't there any problem when WebProcess load the injected bundle library? I don't think there should be an issue, but you can try it locally first and see if you experience any sort of weird issues. 728584 6 165807 bw80.lee 2012-09-26 08:24:31 -0700 Created attachment 165807 Simple test code for dlopen and static library problem. 728585 7 bw80.lee 2012-09-26 08:25:27 -0700 (In reply to comment #5) > (In reply to comment #3) > > As you already know, > > EWK2UnitTests_LIBRARIES has wtf, javascriptcore and webcore library. > > And if SHARED_CORE is not ON, wtf, javascript, webcore will be a static library, and linked both WebProcess and injected bundle library. > > > > Isn't there any problem when WebProcess load the injected bundle library? > > I don't think there should be an issue, but you can try it locally first and see if you experience any sort of weird issues. I'm telling the general case about singleton instance or static/global variable in static library. I attached the simple example about this. A singleton is created in TestClass static library. WebProcess and libInjectedBundle.so link the static library and both uses the singleton. The address of the singleton instance is different as below. WebProcess instance: 0x0896a008 InjectedBundle instance: 0x0896a410 InjectedBundle instance: 0x0896a410 InjectedBundle instance: 0x0896a410 WebProcess instance: 0x0896a008 WebProcess instance: 0x0896a008 WebProcess and InjectedBundle has different singleton instance because the static library is linked WebProcess and InjectedBundle statically. 729511 8 rakuco 2012-09-27 07:31:14 -0700 Right. I was talking to Kenneth about this; I guess you can simply link against the webkit2 library itself to avoid this sort of problem -- injected bundles are not really supposed to call WebCore/WTF/whatever. 730134 9 bw80.lee 2012-09-27 19:23:20 -0700 (In reply to comment #8) > Right. I was talking to Kenneth about this; I guess you can simply link against the webkit2 library itself to avoid this sort of problem -- injected bundles are not really supposed to call WebCore/WTF/whatever. Ok. That makes sense. Thanks :) 731113 10 166342 bw80.lee 2012-09-28 18:23:23 -0700 Created attachment 166342 Patch 731182 11 166342 rakuco 2012-09-29 05:02:03 -0700 Comment on attachment 166342 Patch Looks good, thanks! 731186 12 166342 webkit.review.bot 2012-09-29 05:51:16 -0700 Comment on attachment 166342 Patch Clearing flags on attachment: 166342 Committed r129976: <http://trac.webkit.org/changeset/129976> 731187 13 webkit.review.bot 2012-09-29 05:51:20 -0700 All reviewed patches have been landed. Closing bug. 165716 2012-09-25 19:00:10 -0700 2012-09-28 18:23:19 -0700 Patch bug-97622-20120926105923.patch text/plain 1582 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjYyNDBiODQwN2U4NDk3 ODY1YTI0Yzk2MWYxNThhMDE1OGVlYzhiNC4uNTJmNWZlZmZjYjMwNTliODhjNjliNGE4NmQ0OWMy MGQ1NTFjMTBiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI1ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVp bGQgZXJyb3IgOiBhZGQgZm9yd2FyZGluZy1oZWFkZXJTb3VwIGRlcGVuZGVuY3kgb24gZXdrMlVu aXRUZXN0SW5qZWN0ZWRCdW5kbGVTYW1wbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NzYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE9uIHRoZSBmaXJzdCBidWlsZCwgY29tcGlsZXIgdHJpZXMgdG8g YnVpbGQgaW5qZWN0ZWRfYnVuZGxlX3NhbXBsZS5jcHAKKyAgICAgICAgYmVmb3JlIHRoZSBmb3J3 YXJkaW5nIGhlYWRlcnMgYXJlIGNyZWF0ZWQuCisgICAgICAgIFRoaXMgbWFrZXMgYnVpbGQgZXJy b3IgdGhhdCB0aGUgaGVhZGVyIGZpbGUgJ1dlYktpdDIvV0tCYXNlU291cC5oJworICAgICAgICBj YW5ub3QgYmUgZm91bmQuCisKKyAgICAgICAgRm9yIHByZXZlbnRpbmcgdGhpcywgYWRkZWQgZm9y d2FyZGluZy1oZWFkZXJTb3VwIGRlcGVuZGVuY3kgb24KKyAgICAgICAgZXdrMlVuaXRUZXN0SW5q ZWN0ZWRCdW5kbGVTYW1wbGUuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZToKKwogMjAx Mi0wOS0yNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNv bT4KIAogICAgICAgICBbV0syXVtXVFJdIFdUUiBidW5kbGUgY2xpZW50IGxvYWRzIGJpbmFyeSBk YXRhIGFzIHRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtl IGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggZDM5MzJiNmRjOTY3MWFh MWJkNzhmYzc1NzMzNjg1N2YyNmNhMjRkOS4uNzA3NjE2ZDcyMWY1ZjUyZTI0MGQ0MDYwNWM1NjBi ZDY3MWJmOGZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UK KysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTMwNiw2ICszMDYsNyBA QCBJRiAoRU5BQkxFX0FQSV9URVNUUykKICAgICBFTkRGT1JFQUNIICgpCiAKICAgICBBRERfTElC UkFSWShld2syVW5pdFRlc3RJbmplY3RlZEJ1bmRsZVNhbXBsZSBTSEFSRUQgJHtURVNUX0lOSkVD VEVEX0JVTkRMRV9ESVJ9L2luamVjdGVkX2J1bmRsZV9zYW1wbGUuY3BwKQorICAgIEFERF9ERVBF TkRFTkNJRVMoZXdrMlVuaXRUZXN0SW5qZWN0ZWRCdW5kbGVTYW1wbGUgZm9yd2FyZGluZy1oZWFk ZXJTb3VwKQogRU5ESUYgKCkKIAogSUYgKEVOQUJMRV9JTlNQRUNUT1IpCg== 165807 2012-09-26 08:24:31 -0700 2012-09-26 08:24:31 -0700 Simple test code for dlopen and static library problem. dlopen_and_static.tar.gz application/x-gzip 832 bw80.lee H4sIALMdY1AAA+1YbWvbMBDO1+pXHA4dtlsntmPHI32BrYNR6KCMwtgYBEdWEq+uHGyn6yj775Oc xC9xXtrOpF2nB4Ll053u5NNzkuIF4YTQvku9fpy4iY/bjdqhMziOzZ+GY+vF5wINw9Q7etfodi2n oRsdy7IbYNcfShVTNu0IoEEG/sDfoLet/x+FV8n/FYmTs8CN4xaeTGrxwRPMErs2/5ZjZPnXuZw9 LKsBei3et+A/z3/TpziYegSO48Tzw9b4FGUiKV8KYwmh7E2FrNnrjUhyTtk3pJjICrpHwDBbSVAw 8OcqcAKU/Mx7ZOUotYhIMo1opnaEfiN0G/pe0dMk8mnm6zJkLySSccgEgMdupAJ2g4BEiyCGqf5Q ZvMKp8khSPtxNn4P9Lt9/e3ddyodzs0OWQzpkBMWSx+7cXI8pbE/osQ7lUuTVBQe3nMnriZs4v+4 Jh/b+G92nQX/LadrMv7btin4vxM0/SH1yDDnWX+MmkzgU1KSIcwbuQju0WQ6CHzcW8P4EmWOUKqV MnobjTm7mH6TUM8fQrsNq0J87s/2alDl/yf3mqU/IPX52Lr/W9n+bztml/Pf0A3B/10Asc2vh/ZG BwegYdBGUDr+oT32bbQIAn+Qy92CTlg01YaX52dwTn8QnBDv/ZR6AZmNkupoMaM38UAL+XhLanG4 bBiCdtFqgxZk3oq+vpDBZRRisogz7QkL4qJGdSjW9gJe1IhL2fSjG1B5CGqL/9yC7WuvNFX+V/P3 tz628d+28/sfu/kx/ju6aQr+7wKPOP+TO7ZTU5DOJLjPt3M8Jvj6Y3mzXxzeq32PPZtL5dUobTyl r7uVKPNLxrp+7XTlmWTZ9/IostJ6qN3LvS5U+V+urHX42MJ/gxWAnP+dDr//m0ZX8H8X2MR/LmI7 dVnmBUNMN5UJRgK4cX0q84YbjfDh7Fyv8pfbx1eAfD0+nf1ZuVJh7HJSwgnMVr4stdqrTiPM1+er iw/9i3ffvs6Jn5Y0WV0uasriPwxVTj2oivymopP6i3/dyDP3bFrLKtIizFUF9Unlq/DhHly6qjbz f2b0l1zEBAQEBAQEBAQEBAQEBAQEBATW4g+czfr7ACgAAA== 166342 2012-09-28 18:23:23 -0700 2012-09-29 05:51:15 -0700 Patch bug-97622-20120929102239.patch text/plain 1741 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWU5ZWRkY2M3MDk4YjQ2 OGQxZmZjNDgyOGZiNDUxZDMyM2VhZDNiNC4uNjk3ZmJmZDE4MmU5ZDdmMWFlMmM2MzZjNDU2NTNk YmNhZWQwMjRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA5LTI4ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBbRUZMXSBGaXggYnVp bGQgZXJyb3IgOiBMaW5rIHdlYmtpdDIgbGlicmFyeSB0byBld2syVW5pdFRlc3RJbmplY3RlZEJ1 bmRsZVNhbXBsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk3NjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlcmUgaXMgbm8gZGVwZW5kZW5jeSBiZXR3ZWVuIGV3azJVbml0VGVzdEluamVjdGVkQnVu ZGxlU2FtcGxlIGFuZAorICAgICAgICB3ZWJraXQyIGxpYnJhcnkuCisKKyAgICAgICAgQmVjYXVz ZSBvZiB0aGlzLCBvbiB0aGUgZmlyc3QgYnVpbGQsIGNvbXBpbGVyIHRyaWVzIHRvIGJ1aWxkCisg ICAgICAgIGluamVjdGVkX2J1bmRsZV9zYW1wbGUuY3BwIGJlZm9yZSB0aGUgZm9yd2FyZGluZyBo ZWFkZXJzIGFyZSBjcmVhdGVkLgorICAgICAgICBUaGlzIG1ha2VzIGJ1aWxkIGVycm9yIHRoYXQg dGhlIGhlYWRlciBmaWxlICdXZWJLaXQyL1dLQmFzZVNvdXAuaCcKKyAgICAgICAgY2Fubm90IGJl IGZvdW5kLgorCisgICAgICAgIFRvIHByZXZlbnQgdGhpcywgd2Via2l0MiBsaWJyYXJ5IGlzIGxp bmtlZCB0byBld2syVW5pdFRlc3RJbmplY3RlZEJ1bmRsZVNhbXBsZS4KKworICAgICAgICAqIFBs YXRmb3JtRWZsLmNtYWtlOgorCisyMDEyLTA5LTI4ICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBz YW1zdW5nLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIENsZWFyIHByb3ZpZGVyIG9uIGRlc3Ry dWN0b3Igb2Yge1ZpYnJhdGlvbixCYXR0ZXJ5LE5ldHdvcmtJbmZvfVByb3ZpZGVyLgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc1MjgKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybUVmbC5jbWFrZQppbmRleCBkMDAzZmJlNzA5YzJlNTIwZThmYWYzZTQ4OTRhMWMwNWFl NzFjMTA0Li4yYjRmZDRkYmNhNGRhZDFkMDJmMjg3ZGE1NTc1NzMzNmQ3NDFhYWQ3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMzA1LDYgKzMwNSw3IEBAIElGIChFTkFCTEVfQVBJX1RF U1RTKQogICAgIEVOREZPUkVBQ0ggKCkKIAogICAgIEFERF9MSUJSQVJZKGV3azJVbml0VGVzdElu amVjdGVkQnVuZGxlU2FtcGxlIFNIQVJFRCAke1RFU1RfSU5KRUNURURfQlVORExFX0RJUn0vaW5q ZWN0ZWRfYnVuZGxlX3NhbXBsZS5jcHApCisgICAgVEFSR0VUX0xJTktfTElCUkFSSUVTKGV3azJV bml0VGVzdEluamVjdGVkQnVuZGxlU2FtcGxlICR7V2ViS2l0Ml9MSUJSQVJZX05BTUV9KQogRU5E SUYgKCkKIAogSUYgKEVOQUJMRV9JTlNQRUNUT1IpCg==