<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97619</bug_id>
          
          <creation_ts>2012-09-25 17:44:31 -0700</creation_ts>
          <short_desc>webkit-patch rebaseline-expectations is broken</short_desc>
          <delta_ts>2012-09-28 13:27:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>hclam</cc>
    
    <cc>ojan</cc>
    
    <cc>schenney</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>728097</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 17:44:31 -0700</bug_when>
    <thetext>webkit-patch rebaseline-expectations is broken</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728098</commentid>
    <comment_count>1</comment_count>
      <attachid>165705</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 17:49:19 -0700</bug_when>
    <thetext>Created attachment 165705
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728100</commentid>
    <comment_count>2</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 17:54:01 -0700</bug_when>
    <thetext>Note that this patch isn&apos;t quite ready to land yet.

1) it needs a test.
2) I&apos;m not sure about my use of reconstitute_only_these yet
3) we probably need to be smarter about how we reconstitute lines where the new line says the same thing as the original line, only differently (e.g., if the original is &apos;foo.html&apos; (no [Skip]), should we leave it like &apos;foo.html&apos;, or add the &apos;[Skip]&apos; to normalize the line?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728110</commentid>
    <comment_count>3</comment_count>
      <attachid>165708</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 18:09:15 -0700</bug_when>
    <thetext>Created attachment 165708
remove debugger call</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728125</commentid>
    <comment_count>4</comment_count>
      <attachid>165708</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-09-25 18:39:10 -0700</bug_when>
    <thetext>Comment on attachment 165708
remove debugger call

View in context: https://bugs.webkit.org/attachment.cgi?id=165708&amp;action=review

This is fine. It&apos;s kind of a bandaid solution though since the other rebaselining commands will have this problem, no? If we make [ Skip ] required and disallow [ Skip WontFix Pass ] (i.e. it should just be [ WontFix ]). Then these problems will just go away once we update the existing lines once, right?

&gt; Tools/ChangeLog:14
&gt; +        1) the transformation into and out of the old syntax (which is
&gt; +        still used internally) is somewhat lossy, e.g., we&apos;re not
&gt; +        preserving the case of Bug(x) identifiers. Also, we can&apos;t
&gt; +        tell if the input was [ WontFix ] or [ Skip WontFix Pass ]

Don&apos;t we only write out the new syntax? In that case, can&apos;t we always write out [ WontFix ]? I suppose it&apos;s annoying to have ones patch modify unrelated bits.

&gt; Tools/ChangeLog:17
&gt; +        2) the new syntax is more lenient, allowing for multiple ways to
&gt; +        specify the same result, e.g., &quot;[ Skip ]&quot; may or may not be
&gt; +        missing.

I think we should do away with this. It seemed nice at first, but now that I actually see it in the file, I think it&apos;s just confusing. We should require [ Skip ].</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728135</commentid>
    <comment_count>5</comment_count>
      <attachid>165714</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 18:55:37 -0700</bug_when>
    <thetext>Created attachment 165714
remove the --platform arg</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728137</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 18:56:33 -0700</bug_when>
    <thetext>moved the --platform arg patch into bug 97621.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728138</commentid>
    <comment_count>7</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-25 18:58:18 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 165708 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=165708&amp;action=review
&gt; 
&gt; This is fine. It&apos;s kind of a bandaid solution though since the other rebaselining commands will have this problem, no? If we make [ Skip ] required and disallow [ Skip WontFix Pass ] (i.e. it should just be [ WontFix ]). Then these problems will just go away once we update the existing lines once, right?
&gt; 

There&apos;s still a bug where we don&apos;t preserve the case of the Bug(X) modifiers, e.g., Bug(EFL) gets rewritten to Bug(efl), but that needs to be fixed independently, regardless.

Otherwise, in theory, yes.

&gt; &gt; Tools/ChangeLog:14
&gt; &gt; +        1) the transformation into and out of the old syntax (which is
&gt; &gt; +        still used internally) is somewhat lossy, e.g., we&apos;re not
&gt; &gt; +        preserving the case of Bug(x) identifiers. Also, we can&apos;t
&gt; &gt; +        tell if the input was [ WontFix ] or [ Skip WontFix Pass ]
&gt; 
&gt; Don&apos;t we only write out the new syntax? In that case, can&apos;t we always write out [ WontFix ]? I suppose it&apos;s annoying to have ones patch modify unrelated bits.
&gt; 

Yes, modifying unrelated lines is exactly the problem.

&gt; &gt; Tools/ChangeLog:17
&gt; &gt; +        2) the new syntax is more lenient, allowing for multiple ways to
&gt; &gt; +        specify the same result, e.g., &quot;[ Skip ]&quot; may or may not be
&gt; &gt; +        missing.
&gt; 
&gt; I think we should do away with this. It seemed nice at first, but now that I actually see it in the file, I think it&apos;s just confusing. We should require [ Skip ].

I&apos;m not necessarily opposed to this, but others might be.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>728693</commentid>
    <comment_count>8</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-09-26 09:59:18 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; &gt; &gt; Tools/ChangeLog:17
&gt; &gt; &gt; +        2) the new syntax is more lenient, allowing for multiple ways to
&gt; &gt; &gt; +        specify the same result, e.g., &quot;[ Skip ]&quot; may or may not be
&gt; &gt; &gt; +        missing.
&gt; &gt; 
&gt; &gt; I think we should do away with this. It seemed nice at first, but now that I actually see it in the file, I think it&apos;s just confusing. We should require [ Skip ].
&gt; 
&gt; I&apos;m not necessarily opposed to this, but others might be.

I think this is one of the things that was not resolved in the long discussions we had about this on webkit-dev. IIRC, noone was opposed to requiring it. I think we should try requiring it and see if anyone is upset.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>730915</commentid>
    <comment_count>9</comment_count>
      <attachid>166299</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-28 13:02:39 -0700</bug_when>
    <thetext>Created attachment 166299
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>730917</commentid>
    <comment_count>10</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-28 13:03:15 -0700</bug_when>
    <thetext>okay, I&apos;ve convinced myself about the correctness of this, and added a test. Please take a look?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>730940</commentid>
    <comment_count>11</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-28 13:27:39 -0700</bug_when>
    <thetext>Committed r129941: &lt;http://trac.webkit.org/changeset/129941&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165705</attachid>
            <date>2012-09-25 17:49:19 -0700</date>
            <delta_ts>2012-09-25 18:09:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97619-20120925174839.patch</filename>
            <type>text/plain</type>
            <size>5387</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGI1MWQwNGIyMDhmZWQxNzIwNmQ4NzJlZDgyYmNmMTEy
MThjNWJkYS4uNzBjYWZkZWFmZGRmODM4MDEyZDJlNTk3NTNmYTI5Zjg3NmViZWMxZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5
IEBACisyMDEyLTA5LTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBpcyBicm9rZW4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjE5CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyBleHBl
Y3RhdGlvbnMgZm9ybWF0IGlzIGNhdXNpbmcgdHdvIHByb2JsZW1zIGZvcgorICAgICAgICB3ZWJr
aXQtcGF0Y2ggcmViYXNlbGluZSBleHBlY3RhdGlvbnMKKworICAgICAgICAxKSB0aGUgdHJhbnNm
b3JtYXRpb24gaW50byBhbmQgb3V0IG9mIHRoZSBvbGQgc3ludGF4ICh3aGljaCBpcworICAgICAg
ICBzdGlsbCB1c2VkIGludGVybmFsbHkpIGlzIHNvbWV3aGF0IGxvc3N5LCBlLmcuLCB3ZSdyZSBu
b3QKKyAgICAgICAgcHJlc2VydmluZyB0aGUgY2FzZSBvZiBCdWcoeCkgaWRlbnRpZmllcnMuIEFs
c28sIHdlIGNhbid0CisgICAgICAgIHRlbGwgaWYgdGhlIGlucHV0IHdhcyBbIFdvbnRGaXggXSBv
ciBbIFNraXAgV29udEZpeCBQYXNzIF0KKyAgICAgICAgMikgdGhlIG5ldyBzeW50YXggaXMgbW9y
ZSBsZW5pZW50LCBhbGxvd2luZyBmb3IgbXVsdGlwbGUgd2F5cyB0bworICAgICAgICBzcGVjaWZ5
IHRoZSBzYW1lIHJlc3VsdCwgZS5nLiwgIlsgU2tpcCBdIiBtYXkgb3IgbWF5IG5vdCBiZQorICAg
ICAgICBtaXNzaW5nLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcmV3cml0aW5n
IGEgd2hvbGUgYnVuY2ggb2YgbGluZXMgZm9yCisgICAgICAgIHB1cmVseSBzeW50YWN0aWMgZGlm
ZmVyZW5jZXMuCisKKyAgICAgICAgQm90aCBvZiB0aGVzZSB0aGluZ3MgYXJlIGJ1Z3MgdGhhdCBu
ZWVkIHRvIGJlIGZpeGVkLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIGFsc28gbm90IGp1c3QgcmV3
cml0ZSBsaW5lcyB0aGF0IHNob3VsZG4ndCBiZQorICAgICAgICBtb2RpZmllZC4KKworICAgICAg
ICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBsYXN0IGlzc3VlIChubyByZXdyaXRpbmcpIGFuZCBhZGRz
IGEKKyAgICAgICAgLS1wbGF0Zm9ybSBhcmd1bWVudCB0byByZWJhc2VsaW5lLWV4cGVjdGF0aW9u
cyBzbyB0aGF0IHdlIGNhbgorICAgICAgICBub3QgY2hlY2sgVGVzdEV4cGVjdGF0aW9ucyBmb3Ig
b3RoZXIgcG9ydHMgaWYgd2UgZG9uJ3Qgd2FudCB0by4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAg
KFRlc3RFeHBlY3RhdGlvbkxpbmUuX2Zvcm1hdF9saW5lKToKKyAgICAgICAgKFRlc3RFeHBlY3Rh
dGlvbnMucmVtb3ZlX3JlYmFzZWxpbmVkX3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weToKKyAgICAgICAgKFJlYmFzZWxpbmVFeHBl
Y3RhdGlvbnMuX19pbml0X18pOgorICAgICAgICAoUmViYXNlbGluZUV4cGVjdGF0aW9ucy5leGVj
dXRlKToKKwogMjAxMi0wOS0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv
bT4KIAogICAgICAgICBGaXggdGhlIGJ1aWxkIGFmdGVyIHIxMjk1NjYuCmRpZmYgLS1naXQgYS9U
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlv
bnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l
eHBlY3RhdGlvbnMucHkKaW5kZXggNDJiNTE4ZjdmYjg5NTM3Mzc3NmM0YmE1ZDNjYmRhYmEzMzU4
MzBkYi4uZjU1MGFkNGUzYWRjYjZiMmRiYjJiODVlMGM4ZjVjNWNjYjgzMGNjOSAxMDA2NDQKLS0t
IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0
YXRpb25zLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVs
cy90ZXN0X2V4cGVjdGF0aW9ucy5weQpAQCAtOTcwLDcgKzk3MCw3IEBAIGNsYXNzIFRlc3RFeHBl
Y3RhdGlvbnMob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RhdGlvbi5u
YW1lIGluIGV4Y2VwdF90aGVzZV90ZXN0cyBhbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAn
cmViYXNlbGluZScgaW4gZXhwZWN0YXRpb24ucGFyc2VkX21vZGlmaWVycykpCiAKLSAgICAgICAg
cmV0dXJuIHNlbGYubGlzdF90b19zdHJpbmcoZmlsdGVyKHdpdGhvdXRfcmViYXNlbGluZV9tb2Rp
Zmllciwgc2VsZi5fZXhwZWN0YXRpb25zKSkKKyAgICAgICAgcmV0dXJuIHNlbGYubGlzdF90b19z
dHJpbmcoZmlsdGVyKHdpdGhvdXRfcmViYXNlbGluZV9tb2RpZmllciwgc2VsZi5fZXhwZWN0YXRp
b25zKSwgcmVjb25zdGl0dXRlX29ubHlfdGhlc2U9W10pCiAKICAgICBkZWYgX2FkZF9leHBlY3Rh
dGlvbnMoc2VsZiwgZXhwZWN0YXRpb25fbGlzdCk6CiAgICAgICAgIGZvciBleHBlY3RhdGlvbl9s
aW5lIGluIGV4cGVjdGF0aW9uX2xpc3Q6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9jb21tYW5kcy9yZWJhc2VsaW5lLnB5CmluZGV4IGNiOGZhMDAxZjQyYWVlZWUzYTc5MjJj
MGFmM2NjNzI4MTI2MWNiYmQuLjViN2RkZTFlODhiNDc3OGE0Zjk4ZWI1M2U0MDQyZjE3MjRiNjY1
YzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJh
c2VsaW5lLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJh
c2VsaW5lLnB5CkBAIC0yNiw2ICsyNiw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP
VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNP
RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF
LgogCitpbXBvcnQgZm5tYXRjaAogaW1wb3J0IGpzb24KIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQg
b3B0cGFyc2UKQEAgLTQ1LDcgKzQ2LDcgQEAgZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMuY29u
dHJvbGxlcnMudGVzdF9yZXN1bHRfd3JpdGVyIGltcG9ydCBUZXN0UmVzdWx0V3JpdGUKIGZyb20g
d2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscyBpbXBvcnQgdGVzdF9mYWlsdXJlcwogZnJvbSB3
ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29uZmlndXJhdGlvbiBpbXBvcnQgVGVz
dENvbmZpZ3VyYXRpb24KIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscy50ZXN0X2V4
cGVjdGF0aW9ucyBpbXBvcnQgVGVzdEV4cGVjdGF0aW9ucywgQkFTRUxJTkVfU1VGRklYX0xJU1QK
LWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGJ1aWxkZXJzCitmcm9tIHdl
YmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBidWlsZGVycywgcG9ydF9vcHRpb25zCiBm
cm9tIHdlYmtpdHB5LnRvb2wuZ3JhbW1hciBpbXBvcnQgcGx1cmFsaXplCiBmcm9tIHdlYmtpdHB5
LnRvb2wubXVsdGljb21tYW5kdG9vbCBpbXBvcnQgQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQK
IApAQCAtMzIxLDYgKzMyMiw5IEBAIGNsYXNzIFJlYmFzZWxpbmVFeHBlY3RhdGlvbnMoQWJzdHJh
Y3RQYXJhbGxlbFJlYmFzZWxpbmVDb21tYW5kKToKICAgICBuYW1lID0gInJlYmFzZWxpbmUtZXhw
ZWN0YXRpb25zIgogICAgIGhlbHBfdGV4dCA9ICJSZWJhc2VsaW5lcyB0aGUgdGVzdHMgaW5kaWNh
dGVkIGluIFRlc3RFeHBlY3RhdGlvbnMuIgogCisgICAgZGVmIF9faW5pdF9fKHNlbGYpOgorICAg
ICAgICBBYnN0cmFjdFBhcmFsbGVsUmViYXNlbGluZUNvbW1hbmQuX19pbml0X18oc2VsZiwgb3B0
aW9ucz1wb3J0X29wdGlvbnMocGxhdGZvcm09J3BvcnQvcGxhdGZvcm0gdG8gdXNlLiBVc2UgZ2xv
Yi1zdHlsZSB3aWxkY2FyZHMgZm9yIG11bHRpcGxlIHBvcnRzJykpCisKICAgICBkZWYgX3VwZGF0
ZV9leHBlY3RhdGlvbnNfZmlsZXMoc2VsZiwgcG9ydF9uYW1lKToKICAgICAgICAgcG9ydCA9IHNl
bGYuX3Rvb2wucG9ydF9mYWN0b3J5LmdldChwb3J0X25hbWUpCiAKQEAgLTM1MywxNSArMzU3LDI0
IEBAIGNsYXNzIFJlYmFzZWxpbmVFeHBlY3RhdGlvbnMoQWJzdHJhY3RQYXJhbGxlbFJlYmFzZWxp
bmVDb21tYW5kKToKIAogICAgIGRlZiBleGVjdXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wp
OgogICAgICAgICBzZWxmLl90ZXN0X2xpc3QgPSB7fQotICAgICAgICBmb3IgcG9ydF9uYW1lIGlu
IHRvb2wucG9ydF9mYWN0b3J5LmFsbF9wb3J0X25hbWVzKCk6CisgICAgICAgIGlmIG9wdGlvbnMu
cGxhdGZvcm06CisgICAgICAgICAgICBwb3J0X25hbWVzID0gZm5tYXRjaC5maWx0ZXIodG9vbC5w
b3J0X2ZhY3RvcnkuYWxsX3BvcnRfbmFtZXMoKSwgb3B0aW9ucy5wbGF0Zm9ybSkKKyAgICAgICAg
ICAgIGlmIG5vdCBwb3J0X25hbWVzOgorICAgICAgICAgICAgICAgIHByaW50ICJObyBwb3J0IG5h
bWVzIG1hdGNoICclcyciICUgb3B0aW9ucy5wbGF0Zm9ybQorICAgICAgICBlbHNlOgorICAgICAg
ICAgICAgcG9ydF9uYW1lcyA9IHRvb2wucG9ydF9mYWN0b3J5LmFsbF9wb3J0X25hbWVzKCkKKwor
ICAgICAgICBmb3IgcG9ydF9uYW1lIGluIHBvcnRfbmFtZXM6CiAgICAgICAgICAgICBzZWxmLl9h
ZGRfdGVzdHNfdG9fcmViYXNlbGluZV9mb3JfcG9ydChwb3J0X25hbWUpCiAgICAgICAgIGlmIG5v
dCBzZWxmLl90ZXN0X2xpc3Q6CiAgICAgICAgICAgICBfbG9nLndhcm5pbmcoIkRpZCBub3QgZmlu
ZCBhbnkgdGVzdHMgbWFya2VkIFJlYmFzZWxpbmUuIikKICAgICAgICAgICAgIHJldHVybgogCisg
ICAgICAgIGltcG9ydCBwZGIKKyAgICAgICAgcGRiLnNldF90cmFjZSgpCiAgICAgICAgIHNlbGYu
X3JlYmFzZWxpbmUob3B0aW9ucywgc2VsZi5fdGVzdF9saXN0KQogCi0gICAgICAgIGZvciBwb3J0
X25hbWUgaW4gdG9vbC5wb3J0X2ZhY3RvcnkuYWxsX3BvcnRfbmFtZXMoKToKKyAgICAgICAgZm9y
IHBvcnRfbmFtZSBpbiBwb3J0X25hbWVzOgogICAgICAgICAgICAgc2VsZi5fdXBkYXRlX2V4cGVj
dGF0aW9uc19maWxlcyhwb3J0X25hbWUpCiAKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165708</attachid>
            <date>2012-09-25 18:09:15 -0700</date>
            <delta_ts>2012-09-25 18:55:34 -0700</delta_ts>
            <desc>remove debugger call</desc>
            <filename>bug-97619-20120925180835.patch</filename>
            <type>text/plain</type>
            <size>5406</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGI1MWQwNGIyMDhmZWQxNzIwNmQ4NzJlZDgyYmNmMTEy
MThjNWJkYS4uNzBjYWZkZWFmZGRmODM4MDEyZDJlNTk3NTNmYTI5Zjg3NmViZWMxZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5
IEBACisyMDEyLTA5LTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBpcyBicm9rZW4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjE5CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyBleHBl
Y3RhdGlvbnMgZm9ybWF0IGlzIGNhdXNpbmcgdHdvIHByb2JsZW1zIGZvcgorICAgICAgICB3ZWJr
aXQtcGF0Y2ggcmViYXNlbGluZSBleHBlY3RhdGlvbnMKKworICAgICAgICAxKSB0aGUgdHJhbnNm
b3JtYXRpb24gaW50byBhbmQgb3V0IG9mIHRoZSBvbGQgc3ludGF4ICh3aGljaCBpcworICAgICAg
ICBzdGlsbCB1c2VkIGludGVybmFsbHkpIGlzIHNvbWV3aGF0IGxvc3N5LCBlLmcuLCB3ZSdyZSBu
b3QKKyAgICAgICAgcHJlc2VydmluZyB0aGUgY2FzZSBvZiBCdWcoeCkgaWRlbnRpZmllcnMuIEFs
c28sIHdlIGNhbid0CisgICAgICAgIHRlbGwgaWYgdGhlIGlucHV0IHdhcyBbIFdvbnRGaXggXSBv
ciBbIFNraXAgV29udEZpeCBQYXNzIF0KKyAgICAgICAgMikgdGhlIG5ldyBzeW50YXggaXMgbW9y
ZSBsZW5pZW50LCBhbGxvd2luZyBmb3IgbXVsdGlwbGUgd2F5cyB0bworICAgICAgICBzcGVjaWZ5
IHRoZSBzYW1lIHJlc3VsdCwgZS5nLiwgIlsgU2tpcCBdIiBtYXkgb3IgbWF5IG5vdCBiZQorICAg
ICAgICBtaXNzaW5nLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcmV3cml0aW5n
IGEgd2hvbGUgYnVuY2ggb2YgbGluZXMgZm9yCisgICAgICAgIHB1cmVseSBzeW50YWN0aWMgZGlm
ZmVyZW5jZXMuCisKKyAgICAgICAgQm90aCBvZiB0aGVzZSB0aGluZ3MgYXJlIGJ1Z3MgdGhhdCBu
ZWVkIHRvIGJlIGZpeGVkLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIGFsc28gbm90IGp1c3QgcmV3
cml0ZSBsaW5lcyB0aGF0IHNob3VsZG4ndCBiZQorICAgICAgICBtb2RpZmllZC4KKworICAgICAg
ICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBsYXN0IGlzc3VlIChubyByZXdyaXRpbmcpIGFuZCBhZGRz
IGEKKyAgICAgICAgLS1wbGF0Zm9ybSBhcmd1bWVudCB0byByZWJhc2VsaW5lLWV4cGVjdGF0aW9u
cyBzbyB0aGF0IHdlIGNhbgorICAgICAgICBub3QgY2hlY2sgVGVzdEV4cGVjdGF0aW9ucyBmb3Ig
b3RoZXIgcG9ydHMgaWYgd2UgZG9uJ3Qgd2FudCB0by4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAg
KFRlc3RFeHBlY3RhdGlvbkxpbmUuX2Zvcm1hdF9saW5lKToKKyAgICAgICAgKFRlc3RFeHBlY3Rh
dGlvbnMucmVtb3ZlX3JlYmFzZWxpbmVkX3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weToKKyAgICAgICAgKFJlYmFzZWxpbmVFeHBl
Y3RhdGlvbnMuX19pbml0X18pOgorICAgICAgICAoUmViYXNlbGluZUV4cGVjdGF0aW9ucy5leGVj
dXRlKToKKwogMjAxMi0wOS0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv
bT4KIAogICAgICAgICBGaXggdGhlIGJ1aWxkIGFmdGVyIHIxMjk1NjYuCmRpZmYgLS1naXQgYS9U
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlv
bnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l
eHBlY3RhdGlvbnMucHkKaW5kZXggNDJiNTE4ZjdmYjg5NTM3Mzc3NmM0YmE1ZDNjYmRhYmEzMzU4
MzBkYi4uZjU1MGFkNGUzYWRjYjZiMmRiYjJiODVlMGM4ZjVjNWNjYjgzMGNjOSAxMDA2NDQKLS0t
IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0
YXRpb25zLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVs
cy90ZXN0X2V4cGVjdGF0aW9ucy5weQpAQCAtOTcwLDcgKzk3MCw3IEBAIGNsYXNzIFRlc3RFeHBl
Y3RhdGlvbnMob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RhdGlvbi5u
YW1lIGluIGV4Y2VwdF90aGVzZV90ZXN0cyBhbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAn
cmViYXNlbGluZScgaW4gZXhwZWN0YXRpb24ucGFyc2VkX21vZGlmaWVycykpCiAKLSAgICAgICAg
cmV0dXJuIHNlbGYubGlzdF90b19zdHJpbmcoZmlsdGVyKHdpdGhvdXRfcmViYXNlbGluZV9tb2Rp
Zmllciwgc2VsZi5fZXhwZWN0YXRpb25zKSkKKyAgICAgICAgcmV0dXJuIHNlbGYubGlzdF90b19z
dHJpbmcoZmlsdGVyKHdpdGhvdXRfcmViYXNlbGluZV9tb2RpZmllciwgc2VsZi5fZXhwZWN0YXRp
b25zKSwgcmVjb25zdGl0dXRlX29ubHlfdGhlc2U9W10pCiAKICAgICBkZWYgX2FkZF9leHBlY3Rh
dGlvbnMoc2VsZiwgZXhwZWN0YXRpb25fbGlzdCk6CiAgICAgICAgIGZvciBleHBlY3RhdGlvbl9s
aW5lIGluIGV4cGVjdGF0aW9uX2xpc3Q6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9jb21tYW5kcy9yZWJhc2VsaW5lLnB5CmluZGV4IGNiOGZhMDAxZjQyYWVlZWUzYTc5MjJj
MGFmM2NjNzI4MTI2MWNiYmQuLjE3ZWQyNzRlNTA3MmRjMzFhMDhhMzhjYjk2MzkyY2NiZGVkMTFi
ZDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJh
c2VsaW5lLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJh
c2VsaW5lLnB5CkBAIC0yNiw2ICsyNiw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP
VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNP
RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF
LgogCitpbXBvcnQgZm5tYXRjaAogaW1wb3J0IGpzb24KIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQg
b3B0cGFyc2UKQEAgLTQ1LDcgKzQ2LDcgQEAgZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMuY29u
dHJvbGxlcnMudGVzdF9yZXN1bHRfd3JpdGVyIGltcG9ydCBUZXN0UmVzdWx0V3JpdGUKIGZyb20g
d2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscyBpbXBvcnQgdGVzdF9mYWlsdXJlcwogZnJvbSB3
ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29uZmlndXJhdGlvbiBpbXBvcnQgVGVz
dENvbmZpZ3VyYXRpb24KIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscy50ZXN0X2V4
cGVjdGF0aW9ucyBpbXBvcnQgVGVzdEV4cGVjdGF0aW9ucywgQkFTRUxJTkVfU1VGRklYX0xJU1QK
LWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGJ1aWxkZXJzCitmcm9tIHdl
YmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBidWlsZGVycywgcG9ydF9vcHRpb25zCiBm
cm9tIHdlYmtpdHB5LnRvb2wuZ3JhbW1hciBpbXBvcnQgcGx1cmFsaXplCiBmcm9tIHdlYmtpdHB5
LnRvb2wubXVsdGljb21tYW5kdG9vbCBpbXBvcnQgQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQK
IApAQCAtMzIxLDYgKzMyMiw5IEBAIGNsYXNzIFJlYmFzZWxpbmVFeHBlY3RhdGlvbnMoQWJzdHJh
Y3RQYXJhbGxlbFJlYmFzZWxpbmVDb21tYW5kKToKICAgICBuYW1lID0gInJlYmFzZWxpbmUtZXhw
ZWN0YXRpb25zIgogICAgIGhlbHBfdGV4dCA9ICJSZWJhc2VsaW5lcyB0aGUgdGVzdHMgaW5kaWNh
dGVkIGluIFRlc3RFeHBlY3RhdGlvbnMuIgogCisgICAgZGVmIF9faW5pdF9fKHNlbGYpOgorICAg
ICAgICBBYnN0cmFjdFBhcmFsbGVsUmViYXNlbGluZUNvbW1hbmQuX19pbml0X18oc2VsZiwgb3B0
aW9ucz1wb3J0X29wdGlvbnMocGxhdGZvcm09J3BvcnQvcGxhdGZvcm0gdG8gdXNlLiBVc2UgZ2xv
Yi1zdHlsZSB3aWxkY2FyZHMgZm9yIG11bHRpcGxlIHBvcnRzJykpCisKICAgICBkZWYgX3VwZGF0
ZV9leHBlY3RhdGlvbnNfZmlsZXMoc2VsZiwgcG9ydF9uYW1lKToKICAgICAgICAgcG9ydCA9IHNl
bGYuX3Rvb2wucG9ydF9mYWN0b3J5LmdldChwb3J0X25hbWUpCiAKQEAgLTM1Myw3ICszNTcsMTQg
QEAgY2xhc3MgUmViYXNlbGluZUV4cGVjdGF0aW9ucyhBYnN0cmFjdFBhcmFsbGVsUmViYXNlbGlu
ZUNvbW1hbmQpOgogCiAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6
CiAgICAgICAgIHNlbGYuX3Rlc3RfbGlzdCA9IHt9Ci0gICAgICAgIGZvciBwb3J0X25hbWUgaW4g
dG9vbC5wb3J0X2ZhY3RvcnkuYWxsX3BvcnRfbmFtZXMoKToKKyAgICAgICAgaWYgb3B0aW9ucy5w
bGF0Zm9ybToKKyAgICAgICAgICAgIHBvcnRfbmFtZXMgPSBmbm1hdGNoLmZpbHRlcih0b29sLnBv
cnRfZmFjdG9yeS5hbGxfcG9ydF9uYW1lcygpLCBvcHRpb25zLnBsYXRmb3JtKQorICAgICAgICAg
ICAgaWYgbm90IHBvcnRfbmFtZXM6CisgICAgICAgICAgICAgICAgcHJpbnQgIk5vIHBvcnQgbmFt
ZXMgbWF0Y2ggJyVzJyIgJSBvcHRpb25zLnBsYXRmb3JtCisgICAgICAgIGVsc2U6CisgICAgICAg
ICAgICBwb3J0X25hbWVzID0gdG9vbC5wb3J0X2ZhY3RvcnkuYWxsX3BvcnRfbmFtZXMoKQorCisg
ICAgICAgIGZvciBwb3J0X25hbWUgaW4gcG9ydF9uYW1lczoKICAgICAgICAgICAgIHNlbGYuX2Fk
ZF90ZXN0c190b19yZWJhc2VsaW5lX2Zvcl9wb3J0KHBvcnRfbmFtZSkKICAgICAgICAgaWYgbm90
IHNlbGYuX3Rlc3RfbGlzdDoKICAgICAgICAgICAgIF9sb2cud2FybmluZygiRGlkIG5vdCBmaW5k
IGFueSB0ZXN0cyBtYXJrZWQgUmViYXNlbGluZS4iKQpAQCAtMzYxLDcgKzM3Miw3IEBAIGNsYXNz
IFJlYmFzZWxpbmVFeHBlY3RhdGlvbnMoQWJzdHJhY3RQYXJhbGxlbFJlYmFzZWxpbmVDb21tYW5k
KToKIAogICAgICAgICBzZWxmLl9yZWJhc2VsaW5lKG9wdGlvbnMsIHNlbGYuX3Rlc3RfbGlzdCkK
IAotICAgICAgICBmb3IgcG9ydF9uYW1lIGluIHRvb2wucG9ydF9mYWN0b3J5LmFsbF9wb3J0X25h
bWVzKCk6CisgICAgICAgIGZvciBwb3J0X25hbWUgaW4gcG9ydF9uYW1lczoKICAgICAgICAgICAg
IHNlbGYuX3VwZGF0ZV9leHBlY3RhdGlvbnNfZmlsZXMocG9ydF9uYW1lKQogCiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165714</attachid>
            <date>2012-09-25 18:55:37 -0700</date>
            <delta_ts>2012-09-28 13:02:36 -0700</delta_ts>
            <desc>remove the --platform arg</desc>
            <filename>bug-97619-20120925185457.patch</filename>
            <type>text/plain</type>
            <size>2461</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGI1MWQwNGIyMDhmZWQxNzIwNmQ4NzJlZDgyYmNmMTEy
MThjNWJkYS4uNjdkYzNlYmM4MDUwYmQ0ZTRmZTNkY2Y4ZWQwMmM3NmJiYmVmNzBmMyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMz
IEBACisyMDEyLTA5LTI1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBpcyBicm9rZW4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjE5CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyBleHBl
Y3RhdGlvbnMgZm9ybWF0IGlzIGNhdXNpbmcgdHdvIHByb2JsZW1zIGZvcgorICAgICAgICB3ZWJr
aXQtcGF0Y2ggcmViYXNlbGluZSBleHBlY3RhdGlvbnMKKworICAgICAgICAxKSB0aGUgdHJhbnNm
b3JtYXRpb24gaW50byBhbmQgb3V0IG9mIHRoZSBvbGQgc3ludGF4ICh3aGljaCBpcworICAgICAg
ICBzdGlsbCB1c2VkIGludGVybmFsbHkpIGlzIHNvbWV3aGF0IGxvc3N5LCBlLmcuLCB3ZSdyZSBu
b3QKKyAgICAgICAgcHJlc2VydmluZyB0aGUgY2FzZSBvZiBCdWcoeCkgaWRlbnRpZmllcnMuIEFs
c28sIHdlIGNhbid0CisgICAgICAgIHRlbGwgaWYgdGhlIGlucHV0IHdhcyBbIFdvbnRGaXggXSBv
ciBbIFNraXAgV29udEZpeCBQYXNzIF0KKyAgICAgICAgMikgdGhlIG5ldyBzeW50YXggaXMgbW9y
ZSBsZW5pZW50LCBhbGxvd2luZyBmb3IgbXVsdGlwbGUgd2F5cyB0bworICAgICAgICBzcGVjaWZ5
IHRoZSBzYW1lIHJlc3VsdCwgZS5nLiwgIlsgU2tpcCBdIiBtYXkgb3IgbWF5IG5vdCBiZQorICAg
ICAgICBtaXNzaW5nLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcmV3cml0aW5n
IGEgd2hvbGUgYnVuY2ggb2YgbGluZXMgZm9yCisgICAgICAgIHB1cmVseSBzeW50YWN0aWMgZGlm
ZmVyZW5jZXMuCisKKyAgICAgICAgQm90aCBvZiB0aGVzZSB0aGluZ3MgYXJlIGJ1Z3MgdGhhdCBu
ZWVkIHRvIGJlIGZpeGVkLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIGFsc28gbm90IGp1c3QgcmV3
cml0ZSBsaW5lcyB0aGF0IHNob3VsZG4ndCBiZQorICAgICAgICBtb2RpZmllZC4KKworICAgICAg
ICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBsYXN0IGlzc3VlIChubyByZXdyaXRpbmcpLgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9u
cy5weToKKyAgICAgICAgKFRlc3RFeHBlY3RhdGlvbkxpbmUuX2Zvcm1hdF9saW5lKToKKyAgICAg
ICAgKFRlc3RFeHBlY3RhdGlvbnMucmVtb3ZlX3JlYmFzZWxpbmVkX3Rlc3RzKToKKwogMjAxMi0w
OS0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBG
aXggdGhlIGJ1aWxkIGFmdGVyIHIxMjk1NjYuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkgYi9Ub29scy9T
Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkK
aW5kZXggNDJiNTE4ZjdmYjg5NTM3Mzc3NmM0YmE1ZDNjYmRhYmEzMzU4MzBkYi4uZjU1MGFkNGUz
YWRjYjZiMmRiYjJiODVlMGM4ZjVjNWNjYjgzMGNjOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CisrKyBi
L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0
aW9ucy5weQpAQCAtOTcwLDcgKzk3MCw3IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlvbnMob2JqZWN0
KToKICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RhdGlvbi5uYW1lIGluIGV4Y2VwdF90
aGVzZV90ZXN0cyBhbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAncmViYXNlbGluZScgaW4g
ZXhwZWN0YXRpb24ucGFyc2VkX21vZGlmaWVycykpCiAKLSAgICAgICAgcmV0dXJuIHNlbGYubGlz
dF90b19zdHJpbmcoZmlsdGVyKHdpdGhvdXRfcmViYXNlbGluZV9tb2RpZmllciwgc2VsZi5fZXhw
ZWN0YXRpb25zKSkKKyAgICAgICAgcmV0dXJuIHNlbGYubGlzdF90b19zdHJpbmcoZmlsdGVyKHdp
dGhvdXRfcmViYXNlbGluZV9tb2RpZmllciwgc2VsZi5fZXhwZWN0YXRpb25zKSwgcmVjb25zdGl0
dXRlX29ubHlfdGhlc2U9W10pCiAKICAgICBkZWYgX2FkZF9leHBlY3RhdGlvbnMoc2VsZiwgZXhw
ZWN0YXRpb25fbGlzdCk6CiAgICAgICAgIGZvciBleHBlY3RhdGlvbl9saW5lIGluIGV4cGVjdGF0
aW9uX2xpc3Q6Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166299</attachid>
            <date>2012-09-28 13:02:39 -0700</date>
            <delta_ts>2012-09-28 13:13:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97619-20120928130156.patch</filename>
            <type>text/plain</type>
            <size>4099</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDI4NWI2NWU4MjNiN2Y4NzNlMjhlMzA3Njc5NTNiZTk1
ZWRhOTgyOC4uYTYzMDI4NTA1NzYxZjM0ZmQ0MDE2MWM4NjQ1YWU2ZTViY2I3NjJlMCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM4
IEBACiAyMDEyLTA5LTI4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg
ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBpcyBicm9rZW4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjE5CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyBleHBl
Y3RhdGlvbnMgZm9ybWF0IGlzIGNhdXNpbmcgdHdvIHByb2JsZW1zIGZvcgorICAgICAgICB3ZWJr
aXQtcGF0Y2ggcmViYXNlbGluZSBleHBlY3RhdGlvbnMKKworICAgICAgICAxKSB0aGUgdHJhbnNm
b3JtYXRpb24gaW50byBhbmQgb3V0IG9mIHRoZSBvbGQgc3ludGF4ICh3aGljaCBpcworICAgICAg
ICBzdGlsbCB1c2VkIGludGVybmFsbHkpIGlzIHNvbWV3aGF0IGxvc3N5LCBlLmcuLCB3ZSdyZSBu
b3QKKyAgICAgICAgcHJlc2VydmluZyB0aGUgY2FzZSBvZiBCdWcoeCkgaWRlbnRpZmllcnMuIEFs
c28sIHdlIGNhbid0CisgICAgICAgIHRlbGwgaWYgdGhlIGlucHV0IHdhcyBbIFdvbnRGaXggXSBv
ciBbIFNraXAgV29udEZpeCBQYXNzIF0KKyAgICAgICAgMikgdGhlIG5ldyBzeW50YXggaXMgbW9y
ZSBsZW5pZW50LCBhbGxvd2luZyBmb3IgbXVsdGlwbGUgd2F5cyB0bworICAgICAgICBzcGVjaWZ5
IHRoZSBzYW1lIHJlc3VsdCwgZS5nLiwgIlsgU2tpcCBdIiBtYXkgb3IgbWF5IG5vdCBiZQorICAg
ICAgICBtaXNzaW5nLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcmV3cml0aW5n
IGEgd2hvbGUgYnVuY2ggb2YgbGluZXMgZm9yCisgICAgICAgIHB1cmVseSBzeW50YWN0aWMgZGlm
ZmVyZW5jZXMuCisKKyAgICAgICAgQm90aCBvZiB0aGVzZSB0aGluZ3MgYXJlIGJ1Z3MgdGhhdCBu
ZWVkIHRvIGJlIGZpeGVkLCBidXQKKyAgICAgICAgd2Ugc2hvdWxkIGFsc28gbm90IGp1c3QgcmV3
cml0ZSBsaW5lcyB0aGF0IHNob3VsZG4ndCBiZQorICAgICAgICBtb2RpZmllZC4KKworICAgICAg
ICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBsYXN0IGlzc3VlIChubyByZXdyaXRpbmcpLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRp
b25zLnB5OgorICAgICAgICAoVGVzdEV4cGVjdGF0aW9uTGluZS5fZm9ybWF0X2xpbmUpOgorICAg
ICAgICAoVGVzdEV4cGVjdGF0aW9ucy5yZW1vdmVfcmViYXNlbGluZWRfdGVzdHMpOgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9u
c191bml0dGVzdC5weToKKyAgICAgICAgKFJlYmFzZWxpbmluZ1Rlc3QudGVzdF9yZW1vdmUpOgor
CisyMDEyLTA5LTI4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAg
ICAgIHZpcnR1YWwgZGlyZWN0b3JpZXMgc2hvdWxkIGp1c3QgcmVuYW1lIHRoZSBiZWdpbm5pbmcg
b2YgdGhlIHRlc3QgcGF0aAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9OTc5MjUKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv
dXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CmluZGV4IGE2MTEz
ZmNmMDhhNGIyNmVhNmE4OTZkNzQ1MGM0ZjBhNTc2YjAyNjcuLjMyYmU0NzY0ZmI3Y2NmYjlhODZi
MWQxODU0YjdiZmNhMWZlNWRiNjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQorKysgYi9Ub29scy9TY3Jp
cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKQEAg
LTk3MCw3ICs5NzAsNyBAQCBjbGFzcyBUZXN0RXhwZWN0YXRpb25zKG9iamVjdCk6CiAgICAgICAg
ICAgICAgICAgICAgICAgICAgZXhwZWN0YXRpb24ubmFtZSBpbiBleGNlcHRfdGhlc2VfdGVzdHMg
YW5kCiAgICAgICAgICAgICAgICAgICAgICAgICAgJ3JlYmFzZWxpbmUnIGluIGV4cGVjdGF0aW9u
LnBhcnNlZF9tb2RpZmllcnMpKQogCi0gICAgICAgIHJldHVybiBzZWxmLmxpc3RfdG9fc3RyaW5n
KGZpbHRlcih3aXRob3V0X3JlYmFzZWxpbmVfbW9kaWZpZXIsIHNlbGYuX2V4cGVjdGF0aW9ucykp
CisgICAgICAgIHJldHVybiBzZWxmLmxpc3RfdG9fc3RyaW5nKGZpbHRlcih3aXRob3V0X3JlYmFz
ZWxpbmVfbW9kaWZpZXIsIHNlbGYuX2V4cGVjdGF0aW9ucyksIHJlY29uc3RpdHV0ZV9vbmx5X3Ro
ZXNlPVtdKQogCiAgICAgZGVmIF9hZGRfZXhwZWN0YXRpb25zKHNlbGYsIGV4cGVjdGF0aW9uX2xp
c3QpOgogICAgICAgICBmb3IgZXhwZWN0YXRpb25fbGluZSBpbiBleHBlY3RhdGlvbl9saXN0Ogpk
aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rl
c3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv
dXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5CmluZGV4IDUxNGNh
ZDA2OTEyN2FkODUxNjRjOTExODAyYWVlZjNkZjFkN2I2YjguLmUxY2QwNDI1ZmFkYmVkODJkMzIz
YjkyYWJiNmY2ODRmMzAzNGViMjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weQorKysgYi9U
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlv
bnNfdW5pdHRlc3QucHkKQEAgLTUxMyw2ICs1MTMsMTggQEAgY2xhc3MgUmViYXNlbGluaW5nVGVz
dChCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0J1Zyh6KSBmYWlsdXJlcy9leHBl
Y3RlZC9jcmFzaC5odG1sIFsgQ3Jhc2ggXVxuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAg
J0J1Zyh4MCkgZmFpbHVyZXMvZXhwZWN0ZWQvaW1hZ2UuaHRtbCBbIENyYXNoIF1cbicpCiAKKyAg
ICAgICAgIyBFbnN1cmUgdGhhdCB3ZSBkb24ndCBtb2RpZnkgdW5yZWxhdGVkIGxpbmVzLCBldmVu
IGlmIHdlIGNvdWxkIHJld3JpdGUgdGhlbS4KKyAgICAgICAgIyBpLmUuLCB0aGUgc2Vjb25kIGxp
bmUgZG9lc24ndCBnZXQgcmV3cml0dGVuIHRvICJCdWcoeSkgZmFpbHVyZXMvZXhwZWN0ZWQvc2tp
cC5odG1sIgorICAgICAgICBzZWxmLmFzc2VydFJlbW92ZSgnQnVnKHgpIGZhaWx1cmVzL2V4cGVj
dGVkL3RleHQuaHRtbCBbIEZhaWx1cmUgUmViYXNlbGluZSBdXG4nCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICdCdWcoWSkgZmFpbHVyZXMvZXhwZWN0ZWQvaW1hZ2UuaHRtbCBbIFNraXAgICBd
XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICdCdWcoeikgZmFpbHVyZXMvZXhwZWN0ZWQv
Y3Jhc2guaHRtbFxuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJycsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgIFsnZmFpbHVyZXMvZXhwZWN0ZWQvdGV4dC5odG1sJ10sCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICdCdWcoWSkgZmFpbHVyZXMvZXhwZWN0ZWQvaW1hZ2UuaHRtbCBb
IFNraXAgICBdXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICdCdWcoeikgZmFpbHVyZXMv
ZXhwZWN0ZWQvY3Jhc2guaHRtbFxuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJycpCisK
KwogCiAgICAgZGVmIHRlc3Rfbm9fZ2V0X3JlYmFzZWxpbmluZ19mYWlsdXJlcyhzZWxmKToKICAg
ICAgICAgc2VsZi5wYXJzZV9leHAoc2VsZi5nZXRfYmFzaWNfZXhwZWN0YXRpb25zKCkpCg==
</data>
<flag name="review"
          id="178594"
          type_id="1"
          status="+"
          setter="ojan"
    />
          </attachment>
      

    </bug>

</bugzilla>