97616 2012-09-25 16:01:41 -0700 Load the linearized sRGB profile via NSData instead of CoreFoundation 2012-09-25 16:38:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned mitz oldest_to_newest 728052 0 thorton 2012-09-25 16:01:41 -0700 Load the linearized sRGB profile via NSData instead of CoreFoundation. I have a patch. 728058 1 165694 thorton 2012-09-25 16:04:09 -0700 Created attachment 165694 patch 728077 2 165694 mitz 2012-09-25 16:27:45 -0700 Comment on attachment 165694 patch View in context: https://bugs.webkit.org/attachment.cgi?id=165694&action=review > Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:193 > + linearSRGBSpace = CGColorSpaceCreateWithICCProfile((CFDataRef) iccProfileData.get()); Extra space after (CFDataRef). 728082 3 thorton 2012-09-25 16:38:15 -0700 http://trac.webkit.org/changeset/129573 165694 2012-09-25 16:04:09 -0700 2012-09-25 16:27:44 -0700 patch linear.diff text/plain 3955 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMzNiMWU1Li42YjFkNDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDktMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgTG9hZCB0aGUgbGluZWFyaXplZCBzUkdCIHByb2ZpbGUgdmlhIE5TRGF0YSBpbnN0 ZWFkIG9mIENvcmVGb3VuZGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NzYxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6bGluZWFyUkdCQ29sb3JTcGFjZVJlZik6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dE1hYy5tbToKKyAgICAgICAgKFdl YkNvcmU6OmxpbmVhclJHQkNvbG9yU3BhY2VSZWYpOgorCiAyMDEyLTA5LTI1ICBBZGFtIEtsZWlu ICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgRE9NQXR0ck1v ZGlmaWVkIGZyb20gRXZlbnRzTmFtZXMgYW5kIERvY3VtZW50OjpMaXN0ZW5lclR5cGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4 dENHLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29u dGV4dENHLmNwcAppbmRleCA1ZGRjNThhLi5hODlhZTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCkBA IC0xOTAsMjQgKzE5MCw2IEBAIHN0YXRpYyBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gc3ViaW1hZ2Uo Q0dJbWFnZVJlZiBpbWFnZSwgY29uc3QgRmxvYXRSZWN0JiByZWN0KQogCiAjZW5kaWYgLy8gQ0FD SEVfU1VCSU1BR0VTCiAKLXN0YXRpYyBDR0NvbG9yU3BhY2VSZWYgY3JlYXRlTGluZWFyU1JHQkNv bG9yU3BhY2UoKQotewotICAgIC8vIElmIHdlIGZhaWwgdG8gbG9hZCB0aGUgbGluZWFyaXplZCBz UkdCIElDQyBwcm9maWxlLCBmYWxsIGJhY2sgdG8gRGV2aWNlUkdCLgotICAgIENHQ29sb3JTcGFj ZVJlZiBsaW5lYXJTUkdCU3BhY2UgPSBkZXZpY2VSR0JDb2xvclNwYWNlUmVmKCk7Ci0gICAgCi0g ICAgQ0ZCdW5kbGVSZWYgd2ViQ29yZUJ1bmRsZSA9IENGQnVuZGxlR2V0QnVuZGxlV2l0aElkZW50 aWZpZXIoQ0ZTVFIoImNvbS5hcHBsZS5XZWJDb3JlIikpOwotICAgIFJldGFpblB0cjxDRlVSTFJl Zj4gaWNjUHJvZmlsZVVSTChDRkJ1bmRsZUNvcHlSZXNvdXJjZVVSTCh3ZWJDb3JlQnVuZGxlLCBD RlNUUigibGluZWFyU1JHQiIpLCBDRlNUUigiaWNjIiksIDApKTsKLSAgICBDRkRhdGFSZWYgaWNj UHJvZmlsZURhdGEgPSAwOwotICAgIAotICAgIGlmIChpY2NQcm9maWxlVVJMICYmIENGVVJMQ3Jl YXRlRGF0YUFuZFByb3BlcnRpZXNGcm9tUmVzb3VyY2UoMCwgaWNjUHJvZmlsZVVSTC5nZXQoKSwg JmljY1Byb2ZpbGVEYXRhLCAwLCAwLCAwKSkKLSAgICAgICAgbGluZWFyU1JHQlNwYWNlID0gQ0dD b2xvclNwYWNlQ3JlYXRlV2l0aElDQ1Byb2ZpbGUoaWNjUHJvZmlsZURhdGEpOwotICAgIAotICAg IGlmIChpY2NQcm9maWxlRGF0YSkKLSAgICAgICAgQ0ZSZWxlYXNlKGljY1Byb2ZpbGVEYXRhKTsK LSAgICAKLSAgICByZXR1cm4gbGluZWFyU1JHQlNwYWNlOwotfQotCiBzdGF0aWMgdm9pZCBzZXRD R0ZpbGxDb2xvcihDR0NvbnRleHRSZWYgY29udGV4dCwgY29uc3QgQ29sb3ImIGNvbG9yLCBDb2xv clNwYWNlIGNvbG9yU3BhY2UpCiB7CiAgICAgQ0dDb250ZXh0U2V0RmlsbENvbG9yV2l0aENvbG9y KGNvbnRleHQsIGNhY2hlZENHQ29sb3IoY29sb3IsIGNvbG9yU3BhY2UpKTsKQEAgLTIzNSwxNiAr MjE3LDEzIEBAIENHQ29sb3JTcGFjZVJlZiBzUkdCQ29sb3JTcGFjZVJlZigpCiAjZW5kaWYKIH0K IAorI2lmIFBMQVRGT1JNKFdJTikKIENHQ29sb3JTcGFjZVJlZiBsaW5lYXJSR0JDb2xvclNwYWNl UmVmKCkKIHsKICAgICAvLyBGSVhNRTogV2luZG93cyBzaG91bGQgYmUgYWJsZSB0byB1c2UgbGlu ZWFyIHNSR0IsIHRoaXMgaXMgdHJhY2tlZCBieSBodHRwOi8vd2Via2l0Lm9yZy9iLzgwMDAwLgot I2lmIFBMQVRGT1JNKFdJTikKICAgICByZXR1cm4gZGV2aWNlUkdCQ29sb3JTcGFjZVJlZigpOwot I2Vsc2UKLSAgICBzdGF0aWMgQ0dDb2xvclNwYWNlUmVmIGxpbmVhclNSR0JTcGFjZSA9IGNyZWF0 ZUxpbmVhclNSR0JDb2xvclNwYWNlKCk7Ci0gICAgcmV0dXJuIGxpbmVhclNSR0JTcGFjZTsKLSNl bmRpZgogfQorI2VuZGlmCiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybUluaXQoQ0dD b250ZXh0UmVmIGNnQ29udGV4dCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHRNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0TWFjLm1tCmluZGV4IGFkYWUyYTMu LjBhYWJmZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9HcmFwaGljc0NvbnRleHRNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dE1hYy5tbQpAQCAtMjYsNiArMjYsNyBAQAogI2ltcG9y dCAiY29uZmlnLmgiCiAjaW1wb3J0ICJHcmFwaGljc0NvbnRleHQuaCIKIAorI2ltcG9ydCAiR3Jh cGhpY3NDb250ZXh0Q0cuaCIKICNpbXBvcnQgIkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0 ZUNHLmgiCiAjaW1wb3J0IDxBcHBLaXQvQXBwS2l0Lmg+CiAjaW1wb3J0IDx3dGYvU3RkTGliRXh0 cmFzLmg+CkBAIC0xNzgsNCArMTc5LDI0IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGlu ZUZvckRvY3VtZW50TWFya2VyKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBmbG9hdCB3CiAgICAg Q0dDb250ZXh0UmVzdG9yZUdTdGF0ZShjb250ZXh0KTsKIH0KIAorQ0dDb2xvclNwYWNlUmVmIGxp bmVhclJHQkNvbG9yU3BhY2VSZWYoKQoreworICAgIHN0YXRpYyBDR0NvbG9yU3BhY2VSZWYgbGlu ZWFyU1JHQlNwYWNlID0gMDsKKworICAgIGlmIChsaW5lYXJTUkdCU3BhY2UpCisgICAgICAgIHJl dHVybiBsaW5lYXJTUkdCU3BhY2U7CisKKyAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IGljY1Byb2Zp bGVQYXRoID0gW1tOU0J1bmRsZSBidW5kbGVXaXRoSWRlbnRpZmllcjpAImNvbS5hcHBsZS5XZWJD b3JlIl0gcGF0aEZvclJlc291cmNlOkAibGluZWFyU1JHQiIgb2ZUeXBlOkAiaWNjIl07CisgICAg UmV0YWluUHRyPE5TRGF0YT4gaWNjUHJvZmlsZURhdGEoQWRvcHROUywgW1tOU0RhdGEgYWxsb2Nd IGluaXRXaXRoQ29udGVudHNPZkZpbGU6aWNjUHJvZmlsZVBhdGguZ2V0KCldKTsKKworICAgIGlm IChpY2NQcm9maWxlRGF0YSkKKyAgICAgICAgbGluZWFyU1JHQlNwYWNlID0gQ0dDb2xvclNwYWNl Q3JlYXRlV2l0aElDQ1Byb2ZpbGUoKENGRGF0YVJlZikgaWNjUHJvZmlsZURhdGEuZ2V0KCkpOwor CisgICAgLy8gSWYgd2UgZmFpbCB0byBsb2FkIHRoZSBsaW5lYXJpemVkIHNSR0IgSUNDIHByb2Zp bGUsIGZhbGwgYmFjayB0byBEZXZpY2VSR0IuCisgICAgaWYgKCFsaW5lYXJTUkdCU3BhY2UpCisg ICAgICAgIHJldHVybiBkZXZpY2VSR0JDb2xvclNwYWNlUmVmKCk7CisKKyAgICByZXR1cm4gbGlu ZWFyU1JHQlNwYWNlOworfQorCiB9Cg==