97614 2012-09-25 15:49:05 -0700 AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h 2012-09-25 16:02:17 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni dmazzoni alecflett webkit.review.bot oldest_to_newest 728038 0 dmazzoni 2012-09-25 15:49:05 -0700 AccessibilityUIElementChromium.cpp calls snprintf as of r129527 - this is fine, but it won't build on Windows without wtf/StringExtras.h because the MS VC++ compiler doesn't have snprintf built-in. 728041 1 165693 dmazzoni 2012-09-25 15:53:36 -0700 Created attachment 165693 Patch 728051 2 165693 webkit.review.bot 2012-09-25 16:01:15 -0700 Comment on attachment 165693 Patch Rejecting attachment 165693 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: it/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp Hunk #1 FAILED at 37. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14033203 728053 3 165693 alecflett 2012-09-25 16:01:59 -0700 Comment on attachment 165693 Patch I landed this when I realized the commit-queue would take too long. 728054 4 alecflett 2012-09-25 16:02:17 -0700 Committed r129568: <http://trac.webkit.org/changeset/129568> 165693 2012-09-25 15:53:36 -0700 2012-09-25 16:01:59 -0700 Patch bug-97614-20120925155417.patch text/plain 1384 dmazzoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQzOTBjZGVjYzM1ODdhYmQ5YjQ3M2NmNzRmMTVhYmU3 MTBjYjg4MC4uMDBkODIwMGY0OWNiMTEzMGQ5Njc4M2QyZDJlYjM2ZmVjYzVlNWJmMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA5LTI1ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgor CisgICAgICAgIEFYOiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Q2hyb21pdW0uY3BwIHdvbid0IGJ1 aWxkIG9uIFdpbmRvd3Mgd2l0aG91dCB3dGYvU3RyaW5nRXh0cmFzLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjE0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgd3RmL1N0cmluZ0V4dHJhcy5o IHRvIHRoZSBpbmNsdWRlcyB0byBmaXggdGhlIENocm9taXVtL1dpbmRvd3MgYnVpbGQuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0FjY2Vzc2liaWxpdHlV SUVsZW1lbnRDaHJvbWl1bS5jcHA6CisKIDIwMTItMDktMjUgIEp1bGllIFBhcmVudCAgPGpwYXJl bnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2UgdGVzdF9zaGVsbF90ZXN0cyBzaG93IHVw IGluIGZsYWtpbmVzcyBkYXNoYm9hcmQuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9UZXN0UnVubmVyL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRDaHJvbWl1bS5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0FjY2Vzc2liaWxpdHlV SUVsZW1lbnRDaHJvbWl1bS5jcHAKaW5kZXggN2IzNzNjNTFhNDBiOWU4NDExOThiMTMyOTg2NDQx YTg0MWEzNTEwNi4uYjc5NWFlYjgzNzQwNGM0ZTU4OGJkYmFlMzYzZTU4Mjk2MDk5YTQyNSAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50Q2hyb21pdW0uY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RSdW5uZXIvQWNjZXNzaWJpbGl0eVVJRWxlbWVudENocm9taXVtLmNwcApAQCAt MzcsNiArMzcsNyBAQAogI2luY2x1ZGUgInBsYXRmb3JtL1dlYlJlY3QuaCIKICNpbmNsdWRlICJw bGF0Zm9ybS9XZWJTdHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgorI2luY2x1 ZGUgPHd0Zi9TdHJpbmdFeHRyYXMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIHVzaW5n IG5hbWVzcGFjZSBzdGQ7Cg==