97612 2012-09-25 15:28:31 -0700 [Qt] Make use of ASCIILiteral in PlatformKeyboardEventQt.cpp 2012-09-26 07:03:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 marcelo.lira marcelo.lira webkit.review.bot oldest_to_newest 728017 0 marcelo.lira 2012-09-25 15:28:31 -0700 [Qt] Make use of ASCIILiteral in PlatformKeyboardEventQt.cpp 728021 1 165689 marcelo.lira 2012-09-25 15:31:15 -0700 Created attachment 165689 Patch 728511 2 165689 webkit.review.bot 2012-09-26 07:03:43 -0700 Comment on attachment 165689 Patch Clearing flags on attachment: 165689 Committed r129632: <http://trac.webkit.org/changeset/129632> 728512 3 webkit.review.bot 2012-09-26 07:03:46 -0700 All reviewed patches have been landed. Closing bug. 165689 2012-09-25 15:31:15 -0700 2012-09-26 07:03:42 -0700 Patch bug-97612-20120925193036.patch text/plain 5784 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTMzYjFlNTExMDViNTJj ZTIwMzkyMDY4OTExNGM5NzcxMzJkZmM0NC4uYjZlYTk5NDAxYTFjOGFmNGYxN2FhZjM1YjFlYmFk NzVjNjQ0MDJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTI1ICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdIE1h a2UgdXNlIG9mIEFTQ0lJTGl0ZXJhbCBpbiBQbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NjEyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RyaW5nIGxpdGVy YWxzIHJldHVybmVkIGJ5IGtleUlkZW50aWZpZXJGb3JRdEtleUNvZGUgYW5kCisgICAgICAgIGtl eVRleHRGb3JLZXlFdmVudCBub3cgbWFrZSB1c2Ugb2YgbW9yZSBlZmZpY2llbnQgQVNDSUlMaXRl cmFsLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6a2V5SWRlbnRpZmllckZvclF0S2V5Q29kZSk6CisgICAgICAg IChXZWJDb3JlOjprZXlUZXh0Rm9yS2V5RXZlbnQpOgorCiAyMDEyLTA5LTI1ICBBZGFtIEtsZWlu ICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgRE9NQXR0ck1v ZGlmaWVkIGZyb20gRXZlbnRzTmFtZXMgYW5kIERvY3VtZW50OjpMaXN0ZW5lclR5cGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0 LmNwcAppbmRleCA2MmQ4YTI0ODJiOTk4YWFmN2U4MzA3NjY1YjI0MDEwNmYyN2JiZDczLi41MTIz YThkOGM5ODNlZmU5NmE5YjdlZGQ3ZGFmNTM3MzhmNWFlYjBlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwCkBAIC00 Miw5NyArNDIsOTcgQEAgU3RyaW5nIGtleUlkZW50aWZpZXJGb3JRdEtleUNvZGUoaW50IGtleUNv ZGUpCiAgICAgc3dpdGNoIChrZXlDb2RlKSB7CiAgICAgY2FzZSBRdDo6S2V5X01lbnU6CiAgICAg Y2FzZSBRdDo6S2V5X0FsdDoKLSAgICAgICAgcmV0dXJuICJBbHQiOworICAgICAgICByZXR1cm4g QVNDSUlMaXRlcmFsKCJBbHQiKTsKICAgICBjYXNlIFF0OjpLZXlfQ2xlYXI6Ci0gICAgICAgIHJl dHVybiAiQ2xlYXIiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJDbGVhciIpOwogICAg IGNhc2UgUXQ6OktleV9Eb3duOgotICAgICAgICByZXR1cm4gIkRvd24iOworICAgICAgICByZXR1 cm4gQVNDSUlMaXRlcmFsKCJEb3duIik7CiAgICAgY2FzZSBRdDo6S2V5X0VuZDoKLSAgICAgICAg cmV0dXJuICJFbmQiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJFbmQiKTsKICAgICBj YXNlIFF0OjpLZXlfUmV0dXJuOgogICAgIGNhc2UgUXQ6OktleV9FbnRlcjoKLSAgICAgICAgcmV0 dXJuICJFbnRlciI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkVudGVyIik7CiAgICAg Y2FzZSBRdDo6S2V5X0V4ZWN1dGU6Ci0gICAgICAgIHJldHVybiAiRXhlY3V0ZSI7CisgICAgICAg IHJldHVybiBBU0NJSUxpdGVyYWwoIkV4ZWN1dGUiKTsKICAgICBjYXNlIFF0OjpLZXlfRjE6Ci0g ICAgICAgIHJldHVybiAiRjEiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJGMSIpOwog ICAgIGNhc2UgUXQ6OktleV9GMjoKLSAgICAgICAgcmV0dXJuICJGMiI7CisgICAgICAgIHJldHVy biBBU0NJSUxpdGVyYWwoIkYyIik7CiAgICAgY2FzZSBRdDo6S2V5X0YzOgotICAgICAgICByZXR1 cm4gIkYzIjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiRjMiKTsKICAgICBjYXNlIFF0 OjpLZXlfRjQ6Ci0gICAgICAgIHJldHVybiAiRjQiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRl cmFsKCJGNCIpOwogICAgIGNhc2UgUXQ6OktleV9GNToKLSAgICAgICAgcmV0dXJuICJGNSI7Cisg ICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkY1Iik7CiAgICAgY2FzZSBRdDo6S2V5X0Y2Ogot ICAgICAgICByZXR1cm4gIkY2IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiRjYiKTsK ICAgICBjYXNlIFF0OjpLZXlfRjc6Ci0gICAgICAgIHJldHVybiAiRjciOworICAgICAgICByZXR1 cm4gQVNDSUlMaXRlcmFsKCJGNyIpOwogICAgIGNhc2UgUXQ6OktleV9GODoKLSAgICAgICAgcmV0 dXJuICJGOCI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkY4Iik7CiAgICAgY2FzZSBR dDo6S2V5X0Y5OgotICAgICAgICByZXR1cm4gIkY5IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0 ZXJhbCgiRjkiKTsKICAgICBjYXNlIFF0OjpLZXlfRjEwOgotICAgICAgICByZXR1cm4gIkYxMCI7 CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkYxMCIpOwogICAgIGNhc2UgUXQ6OktleV9G MTE6Ci0gICAgICAgIHJldHVybiAiRjExIjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgi RjExIik7CiAgICAgY2FzZSBRdDo6S2V5X0YxMjoKLSAgICAgICAgcmV0dXJuICJGMTIiOworICAg ICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJGMTIiKTsKICAgICBjYXNlIFF0OjpLZXlfRjEzOgot ICAgICAgICByZXR1cm4gIkYxMyI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkYxMyIp OwogICAgIGNhc2UgUXQ6OktleV9GMTQ6Ci0gICAgICAgIHJldHVybiAiRjE0IjsKKyAgICAgICAg cmV0dXJuIEFTQ0lJTGl0ZXJhbCgiRjE0Iik7CiAgICAgY2FzZSBRdDo6S2V5X0YxNToKLSAgICAg ICAgcmV0dXJuICJGMTUiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJGMTUiKTsKICAg ICBjYXNlIFF0OjpLZXlfRjE2OgotICAgICAgICByZXR1cm4gIkYxNiI7CisgICAgICAgIHJldHVy biBBU0NJSUxpdGVyYWwoIkYxNiIpOwogICAgIGNhc2UgUXQ6OktleV9GMTc6Ci0gICAgICAgIHJl dHVybiAiRjE3IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiRjE3Iik7CiAgICAgY2Fz ZSBRdDo6S2V5X0YxODoKLSAgICAgICAgcmV0dXJuICJGMTgiOworICAgICAgICByZXR1cm4gQVND SUlMaXRlcmFsKCJGMTgiKTsKICAgICBjYXNlIFF0OjpLZXlfRjE5OgotICAgICAgICByZXR1cm4g IkYxOSI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIkYxOSIpOwogICAgIGNhc2UgUXQ6 OktleV9GMjA6Ci0gICAgICAgIHJldHVybiAiRjIwIjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0 ZXJhbCgiRjIwIik7CiAgICAgY2FzZSBRdDo6S2V5X0YyMToKLSAgICAgICAgcmV0dXJuICJGMjEi OworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJGMjEiKTsKICAgICBjYXNlIFF0OjpLZXlf RjIyOgotICAgICAgICByZXR1cm4gIkYyMiI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwo IkYyMiIpOwogICAgIGNhc2UgUXQ6OktleV9GMjM6Ci0gICAgICAgIHJldHVybiAiRjIzIjsKKyAg ICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiRjIzIik7CiAgICAgY2FzZSBRdDo6S2V5X0YyNDoK LSAgICAgICAgcmV0dXJuICJGMjQiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJGMjQi KTsKICAgICBjYXNlIFF0OjpLZXlfSGVscDoKLSAgICAgICAgcmV0dXJuICJIZWxwIjsKKyAgICAg ICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiSGVscCIpOwogICAgIGNhc2UgUXQ6OktleV9Ib21lOgot ICAgICAgICByZXR1cm4gIkhvbWUiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJIb21l Iik7CiAgICAgY2FzZSBRdDo6S2V5X0luc2VydDoKLSAgICAgICAgcmV0dXJuICJJbnNlcnQiOwor ICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJJbnNlcnQiKTsKICAgICBjYXNlIFF0OjpLZXlf TGVmdDoKLSAgICAgICAgcmV0dXJuICJMZWZ0IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJh bCgiTGVmdCIpOwogICAgIGNhc2UgUXQ6OktleV9QYWdlRG93bjoKLSAgICAgICAgcmV0dXJuICJQ YWdlRG93biI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIlBhZ2VEb3duIik7CiAgICAg Y2FzZSBRdDo6S2V5X1BhZ2VVcDoKLSAgICAgICAgcmV0dXJuICJQYWdlVXAiOworICAgICAgICBy ZXR1cm4gQVNDSUlMaXRlcmFsKCJQYWdlVXAiKTsKICAgICBjYXNlIFF0OjpLZXlfUGF1c2U6Ci0g ICAgICAgIHJldHVybiAiUGF1c2UiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJQYXVz ZSIpOwogICAgIGNhc2UgUXQ6OktleV9QcmludDoKLSAgICAgICAgcmV0dXJuICJQcmludFNjcmVl biI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIlByaW50U2NyZWVuIik7CiAgICAgY2Fz ZSBRdDo6S2V5X1JpZ2h0OgotICAgICAgICByZXR1cm4gIlJpZ2h0IjsKKyAgICAgICAgcmV0dXJu IEFTQ0lJTGl0ZXJhbCgiUmlnaHQiKTsKICAgICBjYXNlIFF0OjpLZXlfU2VsZWN0OgotICAgICAg ICByZXR1cm4gIlNlbGVjdCI7CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIlNlbGVjdCIp OwogICAgIGNhc2UgUXQ6OktleV9VcDoKLSAgICAgICAgcmV0dXJuICJVcCI7CisgICAgICAgIHJl dHVybiBBU0NJSUxpdGVyYWwoIlVwIik7CiAgICAgICAgIC8vIFN0YW5kYXJkIHNheXMgdGhhdCBE RUwgYmVjb21lcyBVKzAwN0YuCiAgICAgY2FzZSBRdDo6S2V5X0RlbGV0ZToKLSAgICAgICAgcmV0 dXJuICJVKzAwN0YiOworICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJVKzAwN0YiKTsKICAg ICBjYXNlIFF0OjpLZXlfQmFja3NwYWNlOgotICAgICAgICByZXR1cm4gIlUrMDAwOCI7CisgICAg ICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIlUrMDAwOCIpOwogICAgIGNhc2UgUXQ6OktleV9UYWI6 Ci0gICAgICAgIHJldHVybiAiVSswMDA5IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgi VSswMDA5Iik7CiAgICAgY2FzZSBRdDo6S2V5X0JhY2t0YWI6Ci0gICAgICAgIHJldHVybiAiVSsw MDA5IjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiVSswMDA5Iik7CiAgICAgZGVmYXVs dDoKICAgICAgICAgcmV0dXJuIFN0cmluZzo6Zm9ybWF0KCJVKyUwNFgiLCB0b3VwcGVyKGtleUNv ZGUpKTsKICAgICB9CkBAIC01ODUsMTEgKzU4NSwxMSBAQCBzdGF0aWMgU3RyaW5nIGtleVRleHRG b3JLZXlFdmVudChjb25zdCBRS2V5RXZlbnQqIGV2ZW50KQogICAgIGNhc2UgUXQ6OktleV9UYWI6 CiAgICAgY2FzZSBRdDo6S2V5X0JhY2t0YWI6CiAgICAgICAgIGlmIChldmVudC0+dGV4dCgpLmlz TnVsbCgpKQotICAgICAgICAgICAgcmV0dXJuICJcdCI7CisgICAgICAgICAgICByZXR1cm4gQVND SUlMaXRlcmFsKCJcdCIpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFF0OjpLZXlfRW50ZXI6 CiAgICAgICAgIGlmIChldmVudC0+dGV4dCgpLmlzTnVsbCgpKQotICAgICAgICAgICAgcmV0dXJu ICJcciI7CisgICAgICAgICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJcciIpOwogICAgIH0KICAg ICByZXR1cm4gZXZlbnQtPnRleHQoKTsKIH0K