97575 2012-09-25 10:25:00 -0700 [BlackBerry] Handling required for multiple consecutive whitespace 2012-09-25 11:12:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 727774 0 nima.ghanavatian 2012-09-25 10:25:00 -0700 Need specific handling in the case where we have multiple consecutive whitespaces which exceeds our character limit. This breaks some of the functionality employed with the visible_units methods used here to tranverse the text. 727780 1 165639 nima.ghanavatian 2012-09-25 10:33:10 -0700 Created attachment 165639 Patch 727794 2 165639 rwlbuis 2012-09-25 11:02:38 -0700 Comment on attachment 165639 Patch Looks good. 727800 3 165639 webkit.review.bot 2012-09-25 11:12:01 -0700 Comment on attachment 165639 Patch Clearing flags on attachment: 165639 Committed r129528: <http://trac.webkit.org/changeset/129528> 727801 4 webkit.review.bot 2012-09-25 11:12:04 -0700 All reviewed patches have been landed. Closing bug. 165639 2012-09-25 10:33:10 -0700 2012-09-25 11:12:01 -0700 Patch bug-97575-20120925132756.patch text/plain 6520 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMmNhYjk2NGRmNmRkMWM1YzRlOWY0YjhlODZlNTk2ZGYzNGM0MDMzLi5kYTE4NDFiNTU5 MTlkNWZlMDk1ZTA5MzZkNWY3NWU1ZmUyOTlkYzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0wOS0yNSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBIYW5kbGluZyByZXF1 aXJlZCBmb3IgbXVsdGlwbGUgY29uc2VjdXRpdmUgd2hpdGVzcGFjZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc1NzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUjIxMTY3MAorICAgICAgICBOZWVkIHNw ZWNpZmljIGhhbmRsaW5nIGluIHRoZSBjYXNlIHdoZXJlIHdlIGhhdmUgbXVsdGlwbGUKKyAgICAg ICAgY29uc2VjdXRpdmUgd2hpdGVzcGFjZXMgd2hpY2ggZXhjZWVkcyBvdXIgY2hhcmFjdGVyIGxp bWl0LiBUaGlzCisgICAgICAgIGJyZWFrcyBzb21lIG9mIHRoZSBmdW5jdGlvbmFsaXR5IGVtcGxv eWVkIHdpdGggdGhlIHZpc2libGVfdW5pdHMKKyAgICAgICAgbWV0aG9kcyB1c2VkIGhlcmUgdG8g dHJhbnZlcnNlIHRoZSB0ZXh0LgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlr ZSBGZW50b24uCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwOgorICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0Ojp0cmltV2hpdGVzcGFjZUZyb21S YW5nZSk6CisgICAgICAgIChET01TdXBwb3J0KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktp dDo6RE9NU3VwcG9ydDo6aXNFbXB0eVJhbmdlT3JBbGxTcGFjZXMpOgorICAgICAgICAqIFdlYktp dFN1cHBvcnQvRE9NU3VwcG9ydC5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpJbnB1dEhhbmRsZXI6OnNwZWxsQ2hlY2tCbG9jayk6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OklucHV0SGFuZGxlcjo6Z2V0UmFuZ2VGb3JTcGVsbENoZWNrV2l0aEZpbmVHcmFudWxh cml0eSk6CisKIDIwMTItMDktMTkgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KIAog ICAgICAgICBbQmxhY2tCZXJyeV0gQWZ0ZXIgem9vbWluZyBpbnRvIGFuIGlucHV0IGZpZWxkLCB6 b29tIG91dCB3aGVuIGZvY3VzIGlzIGxvc3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCmluZGV4IGVmMzFkYTRlMTA1ZTJh Zjg5ZTZhMmNlOWM1ODllODA5NmYzOGUxZGMuLjg5YzVkM2E4MTc5YjA4NDM0ZTExNWJiMGJmNTI5 ZmNjYTk4ZmUwMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0RPTVN1cHBvcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAiUmVu ZGVyVGV4dC5oIgogI2luY2x1ZGUgIlJlbmRlclRleHRDb250cm9sLmgiCiAjaW5jbHVkZSAiVGV4 dEl0ZXJhdG9yLmgiCisjaW5jbHVkZSAiVmlzaWJsZVBvc2l0aW9uLmgiCiAjaW5jbHVkZSAiVmlz aWJsZVNlbGVjdGlvbi5oIgogCiAjaW5jbHVkZSAiaHRtbGVkaXRpbmcuaCIKQEAgLTUzMiw2ICs1 MzMsMzUgQEAgRnJhbWUqIGluY3JlbWVudEZyYW1lKEZyYW1lKiBjdXJyLCBib29sIGZvcndhcmQs IGJvb2wgd3JhcEZsYWcpCiAgICAgICAgIDogY3Vyci0+dHJlZSgpLT50cmF2ZXJzZVByZXZpb3Vz V2l0aFdyYXAod3JhcEZsYWcpOwogfQogCitQYXNzUmVmUHRyPFJhbmdlPiB0cmltV2hpdGVzcGFj ZUZyb21SYW5nZShWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiwgVmlzaWJsZVBvc2l0aW9u IGVuZFBvc2l0aW9uKQoreworICAgIGlmIChpc0VtcHR5UmFuZ2VPckFsbFNwYWNlcyhzdGFydFBv c2l0aW9uLCBlbmRQb3NpdGlvbikpCisgICAgICAgIHJldHVybiBWaXNpYmxlU2VsZWN0aW9uKGVu ZFBvc2l0aW9uLCBlbmRQb3NpdGlvbikudG9Ob3JtYWxpemVkUmFuZ2UoKTsKKworICAgIHdoaWxl IChpc1doaXRlc3BhY2Uoc3RhcnRQb3NpdGlvbi5jaGFyYWN0ZXJBZnRlcigpKSkKKyAgICAgICAg c3RhcnRQb3NpdGlvbiA9IHN0YXJ0UG9zaXRpb24ubmV4dCgpOworCisgICAgd2hpbGUgKGlzV2hp dGVzcGFjZShlbmRQb3NpdGlvbi5jaGFyYWN0ZXJCZWZvcmUoKSkpCisgICAgICAgIGVuZFBvc2l0 aW9uID0gZW5kUG9zaXRpb24ucHJldmlvdXMoKTsKKworICAgIHJldHVybiBWaXNpYmxlU2VsZWN0 aW9uKHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uKS50b05vcm1hbGl6ZWRSYW5nZSgpOworfQor Citib29sIGlzRW1wdHlSYW5nZU9yQWxsU3BhY2VzKFZpc2libGVQb3NpdGlvbiBzdGFydFBvc2l0 aW9uLCBWaXNpYmxlUG9zaXRpb24gZW5kUG9zaXRpb24pCit7CisgICAgaWYgKHN0YXJ0UG9zaXRp b24gPT0gZW5kUG9zaXRpb24pCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgd2hpbGUgKGlz V2hpdGVzcGFjZShzdGFydFBvc2l0aW9uLmNoYXJhY3RlckFmdGVyKCkpKSB7CisgICAgICAgIHN0 YXJ0UG9zaXRpb24gPSBzdGFydFBvc2l0aW9uLm5leHQoKTsKKworICAgICAgICBpZiAoc3RhcnRQ b3NpdGlvbiA9PSBlbmRQb3NpdGlvbikKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K KworICAgIHJldHVybiBmYWxzZTsKK30KKwogfSAvLyBET01TdXBwb3J0CiB9IC8vIFdlYktpdAog fSAvLyBCbGFja0JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9ET01TdXBwb3J0LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9ET01TdXBwb3J0LmgKaW5kZXggY2RmZTBmY2ZhNGQ1MTdhYThmNWU2ZWExODBkZDYz YWRiMjg3Mjg0ZS4uZjc1YjlhNDFhMTg3OWNhOTI4NzQ4ODNmZjUyMzZkOTI0OGRiNWMyYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9y dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBv cnQuaApAQCAtMzgsNiArMzgsNyBAQCBjbGFzcyBOb2RlOwogY2xhc3MgUG9zaXRpb247CiBjbGFz cyBRdWFsaWZpZWROYW1lOwogY2xhc3MgUmFuZ2U7CitjbGFzcyBWaXNpYmxlUG9zaXRpb247CiBj bGFzcyBWaXNpYmxlU2VsZWN0aW9uOwogfQogCkBAIC05Miw2ICs5Myw5IEBAIFdlYkNvcmU6OlZp c2libGVTZWxlY3Rpb24gdmlzaWJsZVNlbGVjdGlvbkZvckNsb3Nlc3RBY3R1YWxXb3JkU3RhcnQo Y29uc3QgV2ViQ29yCiAKIFdlYkNvcmU6OkZyYW1lKiBpbmNyZW1lbnRGcmFtZShXZWJDb3JlOjpG cmFtZSogY3VyciwgYm9vbCBmb3J3YXJkLCBib29sIHdyYXBGbGFnKTsKIAorUGFzc1JlZlB0cjxX ZWJDb3JlOjpSYW5nZT4gdHJpbVdoaXRlc3BhY2VGcm9tUmFuZ2UoV2ViQ29yZTo6VmlzaWJsZVBv c2l0aW9uIHN0YXJ0UG9zaXRpb24sIFdlYkNvcmU6OlZpc2libGVQb3NpdGlvbiBlbmRQb3NpdGlv bik7Citib29sIGlzRW1wdHlSYW5nZU9yQWxsU3BhY2VzKFdlYkNvcmU6OlZpc2libGVQb3NpdGlv biwgV2ViQ29yZTo6VmlzaWJsZVBvc2l0aW9uKTsKKwogfSAvLyBET01TdXBwb3J0CiB9IC8vIFdl YktpdAogfSAvLyBCbGFja0JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA2ZDViOTlkYTE3NzU5MWM5 Y2ZmYjI2ZjhjOWM2MWNkZDhlYmU2YjFmLi5jYjZjNTIwMGE0YjkzZDc1MTUwZDM0ZjhkNWNiMjVm MGI4NGIwNjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTYxLDYgKzYxLDcgQEAKICNpbmNsdWRlICJX ZWJQYWdlQ2xpZW50LmgiCiAjaW5jbHVkZSAiV2ViUGFnZV9wLmgiCiAjaW5jbHVkZSAiV2ViU2V0 dGluZ3MuaCIKKyNpbmNsdWRlICJodG1sZWRpdGluZy5oIgogI2luY2x1ZGUgInZpc2libGVfdW5p dHMuaCIKIAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUtleWJvYXJkRXZlbnQuaD4KQEAg LTg5Miw2ICs4OTMsOCBAQCB2b2lkIElucHV0SGFuZGxlcjo6c3BlbGxDaGVja0Jsb2NrKFZpc2li bGVTZWxlY3Rpb24mIHZpc2libGVTZWxlY3Rpb24sIFRleHRDaGVjawogICAgICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHN0YXJ0T2ZDdXJyZW50TGluZSA9 IFZpc2libGVQb3NpdGlvbihyYW5nZUZvclNwZWxsQ2hlY2tpbmctPmVuZFBvc2l0aW9uKCkpOwor ICAgICAgICAgICAgZW5kT2ZDdXJyZW50TGluZSA9IGVuZE9mTGluZShzdGFydE9mQ3VycmVudExp bmUpOworICAgICAgICAgICAgcmFuZ2VGb3JTcGVsbENoZWNraW5nID0gRE9NU3VwcG9ydDo6dHJp bVdoaXRlc3BhY2VGcm9tUmFuZ2UoVmlzaWJsZVBvc2l0aW9uKHJhbmdlRm9yU3BlbGxDaGVja2lu Zy0+c3RhcnRQb3NpdGlvbigpKSwgVmlzaWJsZVBvc2l0aW9uKHJhbmdlRm9yU3BlbGxDaGVja2lu Zy0+ZW5kUG9zaXRpb24oKSkpOwogICAgICAgICB9CiAKICAgICAgICAgU3BlbGxpbmdMb2coTG9n TGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjpzcGVsbENoZWNrQmxvY2sgU3Vic3RyaW5nIHRleHQg aXMgJyVzJywgb2Ygc2l6ZSAlZCIsIHJhbmdlRm9yU3BlbGxDaGVja2luZy0+dGV4dCgpLmxhdGlu MSgpLmRhdGEoKSwgcmFuZ2VGb3JTcGVsbENoZWNraW5nLT50ZXh0KCkubGVuZ3RoKCkpOwpAQCAt OTEwLDExICs5MTMsMTIgQEAgUGFzc1JlZlB0cjxSYW5nZT4gSW5wdXRIYW5kbGVyOjpnZXRSYW5n ZUZvclNwZWxsQ2hlY2tXaXRoRmluZUdyYW51bGFyaXR5KFZpc2libGUKICAgICAgICAgLy8gQ2hl Y2sgdGhlIHRleHQgbGVuZ3RoIHdpdGhpbiB0aGlzIHJhbmdlLgogICAgICAgICBpZiAoVmlzaWJs ZVNlbGVjdGlvbihzdGFydFBvc2l0aW9uLCBlbmRPZkN1cnJlbnRXb3JkKS50b05vcm1hbGl6ZWRS YW5nZSgpLT50ZXh0KCkubGVuZ3RoKCkgPj0gTWF4U3BlbGxDaGVja2luZ1N0cmluZ0xlbmd0aCkg ewogICAgICAgICAgICAgLy8gSWYgdGhpcyBpcyBub3QgdGhlIGZpcnN0IHdvcmQsIHJldHVybiBh IFJhbmdlIHdpdGggZW5kIGJvdW5kYXJ5IHNldCB0byB0aGUgcHJldmlvdXMgd29yZC4KLSAgICAg ICAgICAgIGlmIChzdGFydE9mV29yZChlbmRPZkN1cnJlbnRXb3JkLCBMZWZ0V29yZElmT25Cb3Vu ZGFyeSkgIT0gc3RhcnRQb3NpdGlvbikKKyAgICAgICAgICAgIGlmIChzdGFydE9mV29yZChlbmRP ZkN1cnJlbnRXb3JkLCBMZWZ0V29yZElmT25Cb3VuZGFyeSkgIT0gc3RhcnRQb3NpdGlvbiAmJiAh RE9NU3VwcG9ydDo6aXNFbXB0eVJhbmdlT3JBbGxTcGFjZXMoc3RhcnRQb3NpdGlvbiwgZW5kT2ZD dXJyZW50V29yZCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIFZpc2libGVTZWxlY3Rpb24oc3Rh cnRQb3NpdGlvbiwgZW5kT2ZXb3JkKHByZXZpb3VzV29yZFBvc2l0aW9uKGVuZE9mQ3VycmVudFdv cmQpLCBMZWZ0V29yZElmT25Cb3VuZGFyeSkpLnRvTm9ybWFsaXplZFJhbmdlKCk7CiAKICAgICAg ICAgICAgIC8vIE91ciBmaXJzdCB3b3JkIGhhcyBnb25lIG92ZXIgdGhlIGNoYXJhY3RlciBsaW1p dC4gSW5jcmVtZW50IHRoZSBzdGFydGluZyBwb3NpdGlvbiBwYXN0IGFuIHVuY2hlY2thYmxlIHdv cmQuCiAgICAgICAgICAgICBzdGFydFBvc2l0aW9uID0gZW5kT2ZDdXJyZW50V29yZDsKKyAgICAg ICAgICAgIGVuZE9mQ3VycmVudFdvcmQgPSBlbmRPZldvcmQobmV4dFdvcmRQb3NpdGlvbihlbmRP ZkN1cnJlbnRXb3JkKSk7CiAgICAgICAgIH0gZWxzZSBpZiAoZW5kT2ZDdXJyZW50V29yZCA9PSBl bmRQb3NpdGlvbikgewogICAgICAgICAgICAgLy8gUmV0dXJuIHRoZSBsYXN0IHNlZ21lbnQgaWYg dGhlIGVuZCBvZiBvdXIgd29yZCBsaWVzIGF0IHRoZSBlbmQgb2YgdGhlIHJhbmdlLgogICAgICAg ICAgICAgcmV0dXJuIFZpc2libGVTZWxlY3Rpb24oc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24p LnRvTm9ybWFsaXplZFJhbmdlKCk7Cg==