97561 2012-09-25 05:32:28 -0700 [Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test 2012-09-28 06:36:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 70236 96919 1 ossy kbalazs abecsi cmarcelo kbalazs luiz menard noam ossy webkit.review.bot zoltan oldest_to_newest 727538 0 ossy 2012-09-25 05:32:28 -0700 ********* Start testing of tst_qrawwebview ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_qrawwebview::initTestCase() FAIL! : tst_qrawwebview::paint() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::paint() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(227)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(86)] FAIL! : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(227)] PASS : tst_qrawwebview::cleanupTestCase() Totals: 2 passed, 9 failed, 0 skipped ********* Finished testing of tst_qrawwebview ********* 727542 1 kbalazs 2012-09-25 05:35:14 -0700 I guess I know what is the issue here. I'm going to look into this ASAP. 727615 2 165608 kbalazs 2012-09-25 07:12:13 -0700 Created attachment 165608 Patch 729737 3 165608 kbalazs 2012-09-27 11:41:21 -0700 Comment on attachment 165608 Patch Clearing flags on attachment: 165608 Committed r129782: <http://trac.webkit.org/changeset/129782> 729738 4 kbalazs 2012-09-27 11:41:26 -0700 All reviewed patches have been landed. Closing bug. 730311 5 ossy 2012-09-28 00:29:15 -0700 Reopen, because nothing changed, tests still fail. 730319 6 kbalazs 2012-09-28 00:43:08 -0700 (In reply to comment #5) > Reopen, because nothing changed, tests still fail. Thanks, I will take a look. Strange because the patch really fixed this for me. 730349 7 kbalazs 2012-09-28 01:23:05 -0700 (In reply to comment #6) > (In reply to comment #5) > > Reopen, because nothing changed, tests still fail. > > Thanks, I will take a look. Strange because the patch really fixed this for me. After update it fails for me as well, so either I am schizophrenic and tricking myself or it is a new regression. 730500 8 kbalazs 2012-09-28 04:48:48 -0700 Yep, if I apply it on the regressing patch directly, it fixes the issue. Now I need to find out what made it wrong again. 730597 9 kbalazs 2012-09-28 06:36:39 -0700 I'm going to track the new bug in bug 97907. 165608 2012-09-25 07:12:13 -0700 2012-09-27 11:41:20 -0700 Patch bug-97561-20120925161131.patch text/plain 4709 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODJjM2Q2NGEwNDlhYzQ2 MGNmODZjNzhlMzE1YWFmMmZkYWQ1MTMzNC4uMmEzYzg5YjhkNWM2ZGNmZmVjNWRlZWZiMWU3OTY4 MGYyZjlmZDBjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTI1ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gUkVH UkVTU0lPTihyMTI4OTgwKTogSXQgYnJva2UgYWxsIFFSYXdXZWJWaWV3IEFQSSB0ZXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzU2MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBh bHdheXMgc2VuZCB0aGUgdmVyeSBmaXJzdCBSZW5kZXJOZXh0RnJhbWUgbWVzc2FnZS4KKyAgICAg ICAgQmVmb3JlIHIxMjg5ODAgaXQgd2FzIHdvcmtpbmcgYWNjaWRlbnRhbGx5IGJlY2F1c2UgaW4g dGhlIGNvbW1vbgorICAgICAgICBjYXNlIHRoZSB3ZWIgcHJvY2VzcyBzZW50IGEgRGVsZXRlQ29t cG9zaXRpbmdMYXllciBtZXNzYWdlIGF0IHNvbWUKKyAgICAgICAgcG9pbnQgYmVmb3JlIHRoZSBm b3JjZWQgcmVwYWludCB3b3VsZCB0aW1lIG91dCBhbmQgd2Ugd2FzIHNlbmRpbmcKKyAgICAgICAg dGhlIGZpcnN0IFJlbmRlck5leHRGcmFtZSB3aGVuIHJlYWN0aW5nIHRvIHRoYXQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlldy5jcHA6CisgICAgICAgIChRUmF3 V2ViVmlldzo6c2V0QWN0aXZlKTogU2V0IHRoZSBMYXllclRyZWVSZW5kZXJlciB0byBhY3RpdmUK KyAgICAgICAgYXMgd2VsbC4gSW4gdGhlIFFRdWlja1dlYlZpZXcgY2FzZSBpdCBpcyBoYW5kbGVk IGJ5IHRoZSBRdFdlYlBhZ2VTR05vZGUuCisgICAgICAgIChRUmF3V2ViVmlldzo6bGF5ZXJUcmVl UmVuZGVyZXIpOiBBZGRlZCBhIGNvbnZlbmllbmNlIGdldHRlcgorICAgICAgICBmb3IgdGhlIExh eWVyVHJlZVJlbmRlcmVyLgorICAgICAgICAoUVJhd1dlYlZpZXc6OnBhaW50KToKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlld19wLmg6CisgICAgICAgIChXZWJLaXQp OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3FyYXd3 ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9xcmF3d2Vidmlldzo6dHN0X3FyYXd3ZWJ2aWV3KTog QWRkZWQgYSBjYWxsIHRvIGFkZFF0V2ViUHJvY2Vzc1RvUGF0aAorICAgICAgICB0byBtYWtlIG15 IGFuZCB0aGUgZm9sbG93ZXIgdXNlcnMgb2YgdGhpcyB0ZXN0IGVhc2llci4KKwogMjAxMi0wOS0y NSAgS3dhbmdZb25nIENob2kgIDxreTAuY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XVtXSzJdIEFkZGVkIGhpZGVDb2xvclBpY2tlciB0ZXN0IGNhc2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcAppbmRleCAwYTdhNjg0 Y2ZjNmJmYjVlZTAzMzI3YTZkYzUxNGQ2M2FiMDQ2Zjg1Li41MzFlNTdkYmY0ODAwNDM3OGNhZWZl MzU0NmU1N2U1OGU3NzJiNTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3Jhdy9xcmF3d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9yYXcvcXJhd3dlYnZpZXcuY3BwCkBAIC0zMTksNiArMzE5LDcgQEAgdm9pZCBRUmF3 V2ViVmlldzo6c2V0QWN0aXZlKGJvb2wgYWN0aXZlKQogewogICAgIGQtPm1fYWN0aXZlID0gYWN0 aXZlOwogICAgIGQtPm1fd2ViUGFnZVByb3h5LT52aWV3U3RhdGVEaWRDaGFuZ2UoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OlZpZXdXaW5kb3dJc0FjdGl2ZSk7CisgICAgbGF5ZXJUcmVlUmVuZGVyZXIo KS0+c2V0QWN0aXZlKGFjdGl2ZSk7CiB9CiAKIFFTaXplIFFSYXdXZWJWaWV3OjpzaXplKCkgY29u c3QKQEAgLTM1MiwxNyArMzUzLDIwIEBAIFdLUGFnZVJlZiBRUmF3V2ViVmlldzo6cGFnZVJlZigp CiAgICAgcmV0dXJuIHRvQVBJKGQtPm1fd2ViUGFnZVByb3h5LmdldCgpKTsKIH0KIAotdm9pZCBR UmF3V2ViVmlldzo6cGFpbnQoY29uc3QgUU1hdHJpeDR4NCYgdHJhbnNmb3JtLCBmbG9hdCBvcGFj aXR5LCB1bnNpZ25lZCBwYWludEZsYWdzKQorV2ViS2l0OjpMYXllclRyZWVSZW5kZXJlciogUVJh d1dlYlZpZXc6OmxheWVyVHJlZVJlbmRlcmVyKCkgY29uc3QKIHsKICAgICBXZWJLaXQ6OkRyYXdp bmdBcmVhUHJveHkqIGRyYXdpbmdBcmVhID0gZC0+bV93ZWJQYWdlUHJveHktPmRyYXdpbmdBcmVh KCk7CiAgICAgaWYgKCFkcmF3aW5nQXJlYSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgV2ViS2l0 OjpMYXllclRyZWVDb29yZGluYXRvclByb3h5KiBjb29yZGluYXRvclByb3h5ID0gZHJhd2luZ0Fy ZWEtPmxheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkoKTsKLSAgICBpZiAoIWNvb3JkaW5hdG9yUHJv eHkpCi0gICAgICAgIHJldHVybjsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgV2ViS2l0OjpMYXll clRyZWVDb29yZGluYXRvclByb3h5KiBsYXllclRyZWVDb29yZGluYXRvclByb3h5ID0gZHJhd2lu Z0FyZWEtPmxheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkoKTsKKyAgICBpZiAoIWxheWVyVHJlZUNv b3JkaW5hdG9yUHJveHkpCisgICAgICAgIHJldHVybiAwOworICAgIHJldHVybiBsYXllclRyZWVD b29yZGluYXRvclByb3h5LT5sYXllclRyZWVSZW5kZXJlcigpOworfQogCi0gICAgV2ViS2l0OjpM YXllclRyZWVSZW5kZXJlciogcmVuZGVyZXIgPSBjb29yZGluYXRvclByb3h5LT5sYXllclRyZWVS ZW5kZXJlcigpOwordm9pZCBRUmF3V2ViVmlldzo6cGFpbnQoY29uc3QgUU1hdHJpeDR4NCYgdHJh bnNmb3JtLCBmbG9hdCBvcGFjaXR5LCB1bnNpZ25lZCBwYWludEZsYWdzKQoreworICAgIFdlYktp dDo6TGF5ZXJUcmVlUmVuZGVyZXIqIHJlbmRlcmVyID0gbGF5ZXJUcmVlUmVuZGVyZXIoKTsKICAg ICBpZiAoIXJlbmRlcmVyKQogICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3X3AuaCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3X3AuaAppbmRleCBmOGYxNWIwNmQ2 YTI1OWI3ZTkzZDU4ZGZkNmI2OTM3OGZhZjNlZDc3Li4wMTU4MTVhZDhjNzBhOWRlMDVkODFiYTZh NjMwMjEwYjcyMmNmN2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Jhdy9xcmF3d2Vidmlld19wLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9yYXcvcXJhd3dlYnZpZXdfcC5oCkBAIC00Nyw2ICs0NywxMCBAQCBRVF9FTkRfTkFNRVNQ QUNFCiAKIGNsYXNzIFFSYXdXZWJWaWV3UHJpdmF0ZTsKIAorbmFtZXNwYWNlIFdlYktpdCB7Citj bGFzcyBMYXllclRyZWVSZW5kZXJlcjsKK30KKwogY2xhc3MgUVJhd1dlYlZpZXdDbGllbnQgewog cHVibGljOgogICAgIHZpcnR1YWwgflFSYXdXZWJWaWV3Q2xpZW50KCkgeyB9CkBAIC05Nyw2ICsx MDEsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZW5kVG91Y2hFdmVudChRVG91Y2hFdmVudCopOwog CiBwcml2YXRlOgorICAgIFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXIqIGxheWVyVHJlZVJlbmRl cmVyKCkgY29uc3Q7CisKICAgICBRUmF3V2ViVmlld1ByaXZhdGUqIGQ7CiB9OwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FyYXd3ZWJ2aWV3L3Rz dF9xcmF3d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FyYXd3ZWJ2aWV3L3RzdF9xcmF3d2Vidmlldy5jcHAKaW5kZXggMzExMDJiODc2MjIyZTgxZTg1 Y2Y5MmI0MDE5YmM1Nzg2YzJiOWNhOC4uMjcxNDJlNmNmNWY3ZWEyMTJkZjkwYWEyZmEwMGExYzMy ZTYyMWE1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xcmF3d2Vidmlldy90c3RfcXJhd3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXJhd3dlYnZpZXcvdHN0X3FyYXd3ZWJ2aWV3LmNwcApAQCAt MTUyLDcgKzE1Miw5IEBAIHB1YmxpYzoKICAgICB0c3RfcXJhd3dlYnZpZXcoKQogICAgICAgICA6 IG1fcmVzb3VyY2VEaXIoUVN0cmluZzo6ZnJvbUxhdGluMShURVNUU19TT1VSQ0VfRElSICIvaHRt bC9yZXNvdXJjZXMiKSkKICAgICAgICAgLCBtX2Jhc2VVcmwoUVVybDo6ZnJvbUxvY2FsRmlsZShU RVNUU19TT1VSQ0VfRElSICIvaHRtbCIpLnRvU3RyaW5nKCkpCi0gICAgeyB9CisgICAgeworICAg ICAgICBhZGRRdFdlYlByb2Nlc3NUb1BhdGgoKTsKKyAgICB9CiAKIHByaXZhdGUgUV9TTE9UUzoK ICAgICB2b2lkIHBhaW50KCkgeyBydW4oJnRzdF9xcmF3d2Vidmlldzo6ZG9QYWludCwgbV9yZXNv dXJjZURpciArICIvcXdrdmlld19wYWludC5wbmciKTsgfQo=