97558 2012-09-25 05:21:38 -0700 [chromium] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on mac debug 2013-04-09 17:07:13 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 keishi keishi dpranke mifenton ojan rniwa tkent tony webkit.review.bot oldest_to_newest 727532 0 keishi 2012-09-25 05:21:38 -0700 Rebaseline test fast/forms/date/date-suggestion-picker-appearance.html 729866 1 ojan 2012-09-27 14:30:10 -0700 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fdate%2Fdate-suggestion-picker-appearance-rtl.html It appears that the text cursor is sometimes shown and sometimes hidden. Seems like a race condition. I thought we had code in DRT to explicitly make it so the cursor didn't blink and was instead always visible. 731881 2 ojan 2012-10-01 12:09:52 -0700 Ryosuke pointed me at FrameSelection::setCaretBlinkingSuspended. But that can be called by non-DRT code to set the caret blinking again. I think we need a method in Settings that disables caret blinking and makes the caret always be visible. 731887 3 dpranke 2012-10-01 12:15:00 -0700 that's a fun source of flakiness, alright. 732114 4 166569 keishi 2012-10-01 16:37:11 -0700 Created attachment 166569 Patch 732122 5 166569 ojan 2012-10-01 16:45:00 -0700 Comment on attachment 166569 Patch Thanks for working on this! I was picturing that we'd change this setting from DumpRenderTree for all tests. I can't think of any test where we'd want caret blinking to be enabled. Any test that doesn't set this and has a caret will be flaky, no? 732200 6 tkent 2012-10-01 18:44:01 -0700 If the number of setCaretBlinkingSuspended(true) calls and the number of setCaretBlinkingSuspended(false) calls are matched, we had better make FrameSelection::m_isCaretBlinkingSuspended an integer, and change the code so that setCaretBlinkingSuspended(true) increases the integer, setCaretBlinkingSuspended(false) decreases the integer, isCaretBlinkingSuspended() returns true if the integer is <= 0. 732201 7 rniwa 2012-10-01 18:44:57 -0700 I think we should first make sure that our conjuncture about the bug is correct. 732203 8 ojan 2012-10-01 18:45:58 -0700 (In reply to comment #7) > I think we should first make sure that our conjuncture about the bug is correct. What is there to verify other than the clear results in the pixel output (i.e. sometimes it passes and other times it fails with a missing caret)? 732206 9 rniwa 2012-10-01 18:50:25 -0700 (In reply to comment #8) > (In reply to comment #7) > > I think we should first make sure that our conjuncture about the bug is correct. > > What is there to verify other than the clear results in the pixel output (i.e. sometimes it passes and other times it fails with a missing caret)? I think we should at least verify that FrameSelection::setCaretBlinkingSuspended is what DRT uses to stop the blinks, and that there is some call to setCaretBlinkingSuspended during this test (with a race) that causes the test to fail sometimes. In particular, it'll be really nice if we learn what the races are. 732210 10 ojan 2012-10-01 18:54:15 -0700 As best I can tell, we were wrong when we thought DRT did something to control caret blinking. I couldn't find any code that did. It does not call setCaretBlinkingSuspended. So the race seems straightforward if I'm not mistaken. It's just that the caret is blinking. 732214 11 keishi 2012-10-01 19:02:02 -0700 (In reply to comment #10) > As best I can tell, we were wrong when we thought DRT did something to control caret blinking. I couldn't find any code that did. It does not call setCaretBlinkingSuspended. So the race seems straightforward if I'm not mistaken. It's just that the caret is blinking. That was my conclusion too. 872499 12 schenney 2013-04-09 17:07:13 -0700 Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests. 166569 2012-10-01 16:37:11 -0700 2012-10-01 16:45:00 -0700 Patch bug-97558-20121002083624.patch text/plain 8315 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0MGQzYTdlOGQyNzcz YzU3ZjAxYTc0YWE2NTQyMWJkNDY4ZjVmMC4uYjc3ODJlMWIzZDZkNjg1M2ZiYjNlOGMxNjcyOTc3 MjdmZDVjY2ZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTEwLTAxICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEJsaW5raW5nIGNhcmV0 IGlzIGNhdXNpbmcgdGVzdCB0byBiZSBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgYmxpbmtpbmcgY2FyZXQgaXMgY2F1c2luZyB0ZXN0IGRh dGUtc3VnZ2VzdGlvbi1waWNrZXItYXBwZWFyYW5jZS1ydGwuaHRtbCB0byBiZSBmbGFreS4KKyAg ICAgICAgVGhpcyBhZGRzIGEgc2V0dGluZyBzbyB3ZSBjYW4gZGlzYWJsZSBjYXJldCBibGlua2lu ZyBpbiB0ZXN0cy4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBlZGl0aW5n L0ZyYW1lU2VsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjpj YXJldEJsaW5rVGltZXJGaXJlZCk6IERvbid0IHJlZHJhdyBjYXJldCBpZiBjYXJldEJsaW5raW5n RGlzYWJsZWQgaXMgdHJ1ZS4KKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjpjYXJl dEJsaW5raW5nRGlzYWJsZWQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZWRpdGlu Zy9GcmFtZVNlbGVjdGlvbi5oOgorICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U2V0dGluZ3M6OlNldHRpbmdzKTogSW5pdGlhbGl6ZSBtX2NhcmV0Qmxpbmtp bmdEaXNhYmxlZC4KKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJDb3Jl OjpTZXR0aW5nczo6c2V0Q2FyZXRCbGlua2luZ0Rpc2FibGVkKToKKyAgICAgICAgKFdlYkNvcmU6 OlNldHRpbmdzOjpjYXJldEJsaW5raW5nRGlzYWJsZWQpOgorICAgICAgICAoU2V0dGluZ3MpOgor ICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJbnRlcm5hbFNldHRpbmdzOjpzZXRDYXJldEJsaW5raW5nRGlzYWJsZWQpOgorICAgICAgICAo V2ViQ29yZSk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmg6CisgICAgICAg IChJbnRlcm5hbFNldHRpbmdzKToKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFsU2V0dGluZ3Mu aWRsOiBBZGRlZCBjYXJldEJsaW5raW5nRGlzYWJsZWQgc28gdGhpcyBzZXR0aW5nIGNhbiBiZSB0 dXJuZWQgb24gZnJvbSB0ZXN0cy4KKwogMjAxMi0xMC0wMSAgUGhpbGlwIFJvZ2VycyAgPHBkckBn b29nbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBvdmVyemVhbG91cyBhc3NlcnQgaW4gU1ZHRWxl bWVudDo6bG9jYWxBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RnJhbWVTZWxlY3Rpb24uY3BwCmluZGV4IGY3NjZjM2NkZmM4MGY0YTNhN2JiYzRkMDg1NzgxOGIx ZmIxNWIxZTcuLjA4ZDEyM2E3MzcwOGRhYmM2ZWVkMDExNGQ3OTQwODE0NmFhODk3YjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCkBAIC0xNzg0LDcgKzE3ODQs NyBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjpjYXJldEJsaW5rVGltZXJGaXJlZChUaW1lcjxGcmFt ZVNlbGVjdGlvbj4qKQogICAgIEFTU0VSVChjYXJldElzVmlzaWJsZSgpKTsKICAgICBBU1NFUlQo aXNDYXJldCgpKTsKICAgICBib29sIGNhcmV0UGFpbnQgPSBtX2NhcmV0UGFpbnQ7Ci0gICAgaWYg KGlzQ2FyZXRCbGlua2luZ1N1c3BlbmRlZCgpICYmIGNhcmV0UGFpbnQpCisgICAgaWYgKChpc0Nh cmV0QmxpbmtpbmdTdXNwZW5kZWQoKSB8fCBjYXJldEJsaW5raW5nRGlzYWJsZWQoKSkgJiYgY2Fy ZXRQYWludCkKICAgICAgICAgcmV0dXJuOwogICAgIG1fY2FyZXRQYWludCA9ICFjYXJldFBhaW50 OwogICAgIGludmFsaWRhdGVDYXJldFJlY3QoKTsKQEAgLTIwMDMsNiArMjAwMywxMiBAQCBpbmxp bmUgYm9vbCBGcmFtZVNlbGVjdGlvbjo6dmlzdWFsV29yZE1vdmVtZW50RW5hYmxlZCgpIGNvbnN0 CiAgICAgcmV0dXJuIHNldHRpbmdzICYmIHNldHRpbmdzLT52aXN1YWxXb3JkTW92ZW1lbnRFbmFi bGVkKCk7CiB9CiAKK2lubGluZSBib29sIEZyYW1lU2VsZWN0aW9uOjpjYXJldEJsaW5raW5nRGlz YWJsZWQoKSBjb25zdAoreworICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IG1fZnJhbWUgPyBtX2Zy YW1lLT5zZXR0aW5ncygpIDogMDsKKyAgICByZXR1cm4gc2V0dGluZ3MgJiYgc2V0dGluZ3MtPmNh cmV0QmxpbmtpbmdEaXNhYmxlZCgpOworfQorCiAjaWZuZGVmIE5ERUJVRwogCiB2b2lkIEZyYW1l U2VsZWN0aW9uOjpmb3JtYXRGb3JEZWJ1Z2dlcihjaGFyKiBidWZmZXIsIHVuc2lnbmVkIGxlbmd0 aCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uaCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaAppbmRleCBhMGNl MDU5OTE1NmJkNzI5OTY5MDcxYTgzZWU0Zjk5OTQ3OWRlYjEzLi5kNGE3Y2IyYzQwYmNhMjQ0ZGQ3 OTdkMzM5NjMwZDQyYzEwMGU3MjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0ZyYW1lU2VsZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVj dGlvbi5oCkBAIC0yOTMsNiArMjkzLDggQEAgcHJpdmF0ZToKICAgCiAgICAgYm9vbCB2aXN1YWxX b3JkTW92ZW1lbnRFbmFibGVkKCkgY29uc3Q7CiAKKyAgICBib29sIGNhcmV0QmxpbmtpbmdEaXNh YmxlZCgpIGNvbnN0OworCiAgICAgRnJhbWUqIG1fZnJhbWU7CiAKICAgICBMYXlvdXRVbml0IG1f eFBvc0ZvclZlcnRpY2FsQXJyb3dOYXZpZ2F0aW9uOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9TZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcApp bmRleCAzMDY2NmM1NjE5ODMyMzliOGQ5ODlkMjgzMzEwY2YyZjZiNDZjM2M4Li43NzhkZjQzMTky N2FmMzQ4ZjVkMzM3YzFiZjJmMTQ2MzAyYjE0OTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNw cApAQCAtMjkxLDYgKzI5MSw3IEBAIFNldHRpbmdzOjpTZXR0aW5ncyhQYWdlKiBwYWdlKQogICAg ICwgbV9zeW5jWEhSSW5Eb2N1bWVudHNFbmFibGVkKHRydWUpCiAgICAgLCBtX2Nvb2tpZUVuYWJs ZWQodHJ1ZSkKICAgICAsIG1fd2luZG93Rm9jdXNSZXN0cmljdGVkKHRydWUpCisgICAgLCBtX2Nh cmV0QmxpbmtpbmdEaXNhYmxlZChmYWxzZSkKICAgICAsIG1fZGlhZ25vc3RpY0xvZ2dpbmdFbmFi bGVkKGZhbHNlKQogICAgICwgbV9zY3JvbGxpbmdQZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkKGZh bHNlKQogICAgICwgbV9zZXRJbWFnZUxvYWRpbmdTZXR0aW5nc1RpbWVyKHRoaXMsICZTZXR0aW5n czo6aW1hZ2VMb2FkaW5nU2V0dGluZ3NUaW1lckZpcmVkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9TZXR0aW5ncy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmlu ZGV4IGMxOGRmZDczMDZiNTk1NTJmZjM0MmJkMTdjMGZjMjVjYTU3ZjczMjQuLmE0NGI1MDg5N2M0 NGFiZmY0YWE0MmI2NGFlNzg5NTk4NjI0MmFkMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKQEAg LTYzMyw2ICs2MzMsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgc2V0RGlh Z25vc3RpY0xvZ2dpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkgeyBtX2RpYWdub3N0aWNMb2dnaW5n RW5hYmxlZCA9IGVuYWJsZWQ7IH0KICAgICAgICAgYm9vbCBkaWFnbm9zdGljTG9nZ2luZ0VuYWJs ZWQoKSBjb25zdCB7IHJldHVybiBtX2RpYWdub3N0aWNMb2dnaW5nRW5hYmxlZDsgfQogCisgICAg ICAgIHZvaWQgc2V0Q2FyZXRCbGlua2luZ0Rpc2FibGVkKGJvb2wgZGlzYWJsZWQpIHsgbV9jYXJl dEJsaW5raW5nRGlzYWJsZWQgPSBkaXNhYmxlZDsgfQorICAgICAgICBib29sIGNhcmV0Qmxpbmtp bmdEaXNhYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fY2FyZXRCbGlua2luZ0Rpc2FibGVkOyB9CisK ICAgICBwcml2YXRlOgogICAgICAgICBleHBsaWNpdCBTZXR0aW5ncyhQYWdlKik7CiAKQEAgLTgx NCw2ICs4MTcsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgYm9vbCBtX3dpbmRv d0ZvY3VzUmVzdHJpY3RlZCA6IDE7CiAKKyAgICAgICAgYm9vbCBtX2NhcmV0QmxpbmtpbmdEaXNh YmxlZCA6IDE7CisKICAgICAgICAgYm9vbCBtX2RpYWdub3N0aWNMb2dnaW5nRW5hYmxlZCA6IDE7 CiAKICAgICAgICAgYm9vbCBtX3Njcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQgOiAx OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKaW5kZXggYmI5 ZWVkNmIxMzU2ZTExOGExNTYyZmY0ZDJkYzI0MGMzNWYwNWI2Ny4uZmVjNWIxOTNkYTE1ZmRlYzMy ZjRlZWNkMDkxZDlkM2EyMjc4ZGVhYiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFsU2V0dGluZ3MuY3BwCkBAIC02NjcsNCArNjY3LDEwIEBAIHZvaWQgSW50ZXJuYWxTZXR0aW5n czo6c2V0SW1hZ2VzRW5hYmxlZChib29sIGVuYWJsZWQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAg IHNldHRpbmdzKCktPnNldEltYWdlc0VuYWJsZWQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQgSW50ZXJu YWxTZXR0aW5nczo6c2V0Q2FyZXRCbGlua2luZ0Rpc2FibGVkKGJvb2wgZGlzYWJsZWQsIEV4Y2Vw dGlvbkNvZGUmIGVjKQoreworICAgIEludGVybmFsU2V0dGluZ3NHdWFyZEZvclNldHRpbmdzKCk7 CisgICAgc2V0dGluZ3MoKS0+c2V0Q2FyZXRCbGlua2luZ0Rpc2FibGVkKGRpc2FibGVkKTsKK30K KwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdz LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuaAppbmRleCBiZTg4 MTBkZTY2ODJiYzg3ZDQ0NzZiZjkzZDlhMGQ4MDI5YWUwOTA4Li43ZmQ4ZjNkNTYxODExOWMyYmY0 MmU4YzBmOTQ3ZmFjYzM1ZmY1NmFhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFsU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFs U2V0dGluZ3MuaApAQCAtMTQ5LDYgKzE0OSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFN0b3Jh Z2VCbG9ja2luZ1BvbGljeShjb25zdCBTdHJpbmcmLCBFeGNlcHRpb25Db2RlJik7CiAgICAgdm9p ZCBzZXRMYW5nQXR0cmlidXRlQXdhcmVGb3JtQ29udHJvbFVJRW5hYmxlZChib29sKTsKICAgICB2 b2lkIHNldEltYWdlc0VuYWJsZWQoYm9vbCBlbmFibGVkLCBFeGNlcHRpb25Db2RlJik7CisgICAg dm9pZCBzZXRDYXJldEJsaW5raW5nRGlzYWJsZWQoYm9vbCwgRXhjZXB0aW9uQ29kZSYpOwogCiBw cml2YXRlOgogICAgIGV4cGxpY2l0IEludGVybmFsU2V0dGluZ3MoUGFnZSopOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmlkbCBiL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5pZGwKaW5kZXggZDhhOGFhZjhiYmE4MTU4 MjA0Yzk1Njk0YjE0YjgzNDMxY2M2Mjg1My4uNWRiYTQzM2NhNzQ2NWMxOGIyNTFhMzgwMjY1Mzc3 OGQ4Mjg1YjNlOSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNl dHRpbmdzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3Mu aWRsCkBAIC03MCw2ICs3MCw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICB2b2lkIHNldFdp bmRvd0ZvY3VzUmVzdHJpY3RlZChpbiBib29sZWFuIHJlc3RyaWN0ZWQpIHJhaXNlcyhET01FeGNl cHRpb24pOwogICAgICAgICB2b2lkIHNldERpYWxvZ0VsZW1lbnRFbmFibGVkKGluIGJvb2xlYW4g ZW5hYmxlZCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgICAgIHZvaWQgc2V0TGFuZ0F0dHJp YnV0ZUF3YXJlRm9ybUNvbnRyb2xVSUVuYWJsZWQoaW4gYm9vbGVhbiBlbmFibGVkKTsKKyAgICAg ICAgdm9pZCBzZXRDYXJldEJsaW5raW5nRGlzYWJsZWQoaW4gYm9vbGVhbiBkaXNhYmxlZCkgcmFp c2VzKERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAgdm9pZCBzZXRQYWdpbmF0aW9uKGluIERPTVN0 cmluZyBtb2RlLCBpbiBsb25nIGdhcCwgaW4gW09wdGlvbmFsXSBsb25nIHBhZ2VMZW5ndGgpIHJh aXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICBzZXF1ZW5jZTxTdHJpbmc+IHVzZXJQcmVmZXJy ZWRMYW5ndWFnZXMoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ZDlmNWY4NWU5NDBlYjYyNGNlZWVhYmNhZWE5ZWM3YTNl NzVmNGVmLi5jMDM4M2JlOWI0MjgwYTVkZjU0NGZlN2ViY2NhOTE4MjRlMGYxZTFiIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMTAtMDEgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgQmxpbmtpbmcgY2FyZXQgaXMgY2F1c2luZyB0ZXN0IHRvIGJlIGZs YWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzU1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vZmFzdC9mb3Jtcy9kYXRlL2RhdGUtc3VnZ2VzdGlvbi1waWNrZXItYXBw ZWFyYW5jZS1ydGwuaHRtbDogVXNlIGNhcmV0QmxpbmtpbmdEaXNhYmxlZC4KKwogMjAxMi0xMC0w MSAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBh cHBlYXJhbmNlIHRlc3RzIGZvciBtdWx0aXBsZSBmaWVsZHMgbW9udGggaW5wdXQgVUkKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZm9ybXMvZGF0ZS9kYXRl LXN1Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2UtcnRsLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9mYXN0L2Zvcm1zL2RhdGUvZGF0ZS1zdWdnZXN0aW9uLXBpY2tlci1hcHBl YXJhbmNlLXJ0bC5odG1sCmluZGV4IDgwYjQxMDAzNTJhY2FiY2NhZTFlOTJmYWViMTk0YWI4YWRi NTM1NzYuLjA5NWQwMzBjNGZiMjUxYTczMmJkMmViODNlZmUyYzU0N2Q3YmYzNmIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZm9ybXMvZGF0ZS9kYXRlLXN1 Z2dlc3Rpb24tcGlja2VyLWFwcGVhcmFuY2UtcnRsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vZmFzdC9mb3Jtcy9kYXRlL2RhdGUtc3VnZ2VzdGlvbi1waWNrZXItYXBw ZWFyYW5jZS1ydGwuaHRtbApAQCAtMjYsOCArMjYsMTAgQEAKIDxzY3JpcHQ+CiB0ZXN0UnVubmVy LmR1bXBBc1RleHQodHJ1ZSk7CiB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLWlmICh3aW5k b3cuaW50ZXJuYWxzKQoraWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsKICAgICBpbnRlcm5hbHMuc2V0 dGluZ3Muc2V0RW5hYmxlTW9ja1BhZ2VQb3B1cCh0cnVlKTsKKyAgICBpbnRlcm5hbHMuc2V0dGlu Z3Muc2V0Q2FyZXRCbGlua2luZ0Rpc2FibGVkKHRydWUpOworfQogCiBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnZGF0ZScpLmZvY3VzKCk7CiBpZiAod2luZG93LmV2ZW50U2VuZGVyKQo=