97553 2012-09-25 04:23:40 -0700 [GTK] Add Undo / Redo method to WebKit2 GTK+ API 2012-09-25 08:18:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 spena spena cgarcia gustavo gyuyoung.kim mrobinson rakuco webkit.review.bot oldest_to_newest 727496 0 spena 2012-09-25 04:23:40 -0700 [GTK] Add Undo / Redo method to WebKit2 GTK+ API 727499 1 165579 spena 2012-09-25 04:25:12 -0700 Created attachment 165579 Patch 727501 2 webkit.review.bot 2012-09-25 04:27:08 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 727581 3 165579 mrobinson 2012-09-25 06:36:15 -0700 Comment on attachment 165579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > + * webkit_web_view_can_execute_editing_command(). It's only possible > + * to undo a command when it has been previously issued. Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here? 727585 4 spena 2012-09-25 06:44:20 -0700 (In reply to comment #3) > (From update of attachment 165579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > > + * webkit_web_view_can_execute_editing_command(). It's only possible > > + * to undo a command when it has been previously issued. > > Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here? I guess this is a language mistake from my side. I meant that you need to generate a command if you want to later undo it, and to generate a command you'll need some interaction. 727632 5 mrobinson 2012-09-25 07:24:45 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 165579 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review > > > > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82 > > > + * webkit_web_view_can_execute_editing_command(). It's only possible > > > + * to undo a command when it has been previously issued. Maybe just say "It's only possible to undo a command after a previously executed editing operation." I think that covers the case of the operation coming from either the WebKit API or the user. 727640 6 165613 spena 2012-09-25 07:49:40 -0700 Created attachment 165613 Patch 727662 7 165613 webkit.review.bot 2012-09-25 08:18:29 -0700 Comment on attachment 165613 Patch Clearing flags on attachment: 165613 Committed r129510: <http://trac.webkit.org/changeset/129510> 727663 8 webkit.review.bot 2012-09-25 08:18:33 -0700 All reviewed patches have been landed. Closing bug. 165579 2012-09-25 04:25:12 -0700 2012-09-25 07:49:35 -0700 Patch bug-97553-20120925132431.patch text/plain 3099 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTE3YTg5MWFmZTUxYjAy MDI2NTJiZmNiZjM2NjQxOWM3NTg2ZmZjZi4uMzExOTI1YmM3YTZkMjNjYTQ3ZmZkN2UxNTNjYzk1 ZGQ3YzY1N2JiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTI1ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgVW5kbyAvIFJl ZG8gbWV0aG9kIHRvIFdlYktpdDIgR1RLKyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBtYWNyb3MgZm9yIFVuZG8gLyBSZWRvIHN1cHBv cnQsIGFuZCBpbmNsdWRlIHRoZW0KKyAgICAgICAgaW4gdGhlIGRvY3VtZW50YXRpb24uCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0OgorCiAy MDEyLTA5LTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV0tQcm9j ZXNzR3JvdXAgY2FuJ3QgbG9hZCBpbmplY3RlZCBidW5kbGUgd2l0aCBmaWxlIFVSTApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RWRpdGluZ0NvbW1h bmRzLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29t bWFuZHMuaAppbmRleCAzNmM3MmEwZDNkNzQ1M2NmMDdmZjM1ZmViN2RiOWVlOGM2NDRmMjViLi4w NjIwMmE5ZTljZDFlZDljZDZhY2UwM2JmNDc3MGZkMTU2YWQ2NTBlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMu aApAQCAtNjcsMTEgKzY3LDMzIEBAIEdfQkVHSU5fREVDTFMKICAqCiAgKiBUaGUgc2VsZWN0IGFs bCBjb21tYW5kLiBTZWxlY3RzIGFsbCB0aGUgY29udGVudCBvZiB0aGUgY3VycmVudCB0ZXh0IGZp ZWxkIGluCiAgKiBhICNXZWJLaXRXZWJWaWV3LgotICogSXQgaXMgYWx3YXlzIHBvc3NpYmxlIHRv IHNlbGVjdCBhbGwgdGV4dCwgbm8gbWF0dGVyIHdoZXRlciB0aGUgI1dlYktpdFdlYlZpZXcgY29u dGVudAotICogaXMgZWRpdGFibGUgb3Igbm90LiBZb3UgY2FuIHN0aWxsIGNoZWNrIGl0IHdpdGgg d2Via2l0X3dlYl92aWV3X2Nhbl9leGVjdXRlX2VkaXRpbmdfY29tbWFuZCgpLgorICogSXQgaXMg YWx3YXlzIHBvc3NpYmxlIHRvIHNlbGVjdCBhbGwgdGV4dCwgbm8gbWF0dGVyIHdoZXRoZXIgdGhl CisgKiAjV2ViS2l0V2ViVmlldyBjb250ZW50IGlzIGVkaXRhYmxlIG9yIG5vdC4gWW91IGNhbiBz dGlsbCBjaGVjayBpdAorICogd2l0aCB3ZWJraXRfd2ViX3ZpZXdfY2FuX2V4ZWN1dGVfZWRpdGlu Z19jb21tYW5kKCkuCiAgKi8KICNkZWZpbmUgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1Rf QUxMICJTZWxlY3RBbGwiCiAKKy8qKgorICogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9VTkRPOgor ICoKKyAqIFRoZSB1bmRvIGNvbW1hbmQuIFVuZG9lcyB0aGUgbGFzdCBlZGl0aW5nIGNvbW1hbmQg aW4gYSAjV2ViS2l0V2ViVmlldy4KKyAqIFlvdSBjYW4gY2hlY2sgd2hldGhlciBpdCdzIHBvc3Np YmxlIHRvIGV4ZWN1dGUgdGhlIGNvbW1hbmQgd2l0aAorICogd2Via2l0X3dlYl92aWV3X2Nhbl9l eGVjdXRlX2VkaXRpbmdfY29tbWFuZCgpLiBJdCdzIG9ubHkgcG9zc2libGUKKyAqIHRvIHVuZG8g YSBjb21tYW5kIHdoZW4gaXQgaGFzIGJlZW4gcHJldmlvdXNseSBpc3N1ZWQuCisgKi8KKyNkZWZp bmUgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9VTkRPICJVbmRvIgorCisvKioKKyAqIFdFQktJVF9F RElUSU5HX0NPTU1BTkRfUkVETzoKKyAqCisgKiBUaGUgcmVkbyBjb21tYW5kLiBSZWRvZXMgYSBw cmV2aW91c2x5IHVuZG9uZSBlZGl0aW5nIGNvbW1hbmQgaW4KKyAqIGEgI1dlYktpdFdlYlZpZXcu CisgKiBZb3UgY2FuIGNoZWNrIHdoZXRoZXIgaXQncyBwb3NzaWJsZSB0byBleGVjdXRlIHRoZSBj b21tYW5kIHdpdGgKKyAqIHdlYmtpdF93ZWJfdmlld19jYW5fZXhlY3V0ZV9lZGl0aW5nX2NvbW1h bmQoKS4gSXQncyBvbmx5IHBvc3NpYmxlCisgKiB0byByZWRvIGEgY29tbWFuZCB3aGVuIGl0IGhh cyBiZWVuIHByZXZpb3VzbHkgdW5kb25lLgorICovCisjZGVmaW5lIFdFQktJVF9FRElUSU5HX0NP TU1BTkRfUkVETyAiUmVkbyIKKwogR19FTkRfREVDTFMKIAogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMu dHh0IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNl Y3Rpb25zLnR4dAppbmRleCBiYmY5NzliNjRhZGE0YTZjMGZlYTlhMDBjMmFiMjJlNGE4YmY1YWYy Li4xODI3YjZiMTZjMmE5NmIxMjJmY2E0NDRkZWNkZjFkNGQyY2E1N2ZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMu dHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0 ay1zZWN0aW9ucy50eHQKQEAgLTcxLDYgKzcxLDggQEAgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9D VVQKIFdFQktJVF9FRElUSU5HX0NPTU1BTkRfQ09QWQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9Q QVNURQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMCitXRUJLSVRfRURJVElOR19D T01NQU5EX1VORE8KK1dFQktJVF9FRElUSU5HX0NPTU1BTkRfUkVETwogCiA8U1VCU0VDVElPTj4K IHdlYmtpdF93ZWJfdmlld19uZXcK 165613 2012-09-25 07:49:40 -0700 2012-09-25 08:18:29 -0700 Patch bug-97553-20120925164900.patch text/plain 3110 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTE3YTg5MWFmZTUxYjAy MDI2NTJiZmNiZjM2NjQxOWM3NTg2ZmZjZi4uMzExOTI1YmM3YTZkMjNjYTQ3ZmZkN2UxNTNjYzk1 ZGQ3YzY1N2JiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTI1ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgVW5kbyAvIFJl ZG8gbWV0aG9kIHRvIFdlYktpdDIgR1RLKyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBtYWNyb3MgZm9yIFVuZG8gLyBSZWRvIHN1cHBv cnQsIGFuZCBpbmNsdWRlIHRoZW0KKyAgICAgICAgaW4gdGhlIGRvY3VtZW50YXRpb24uCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0OgorCiAy MDEyLTA5LTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV0tQcm9j ZXNzR3JvdXAgY2FuJ3QgbG9hZCBpbmplY3RlZCBidW5kbGUgd2l0aCBmaWxlIFVSTApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RWRpdGluZ0NvbW1h bmRzLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29t bWFuZHMuaAppbmRleCAzNmM3MmEwZDNkNzQ1M2NmMDdmZjM1ZmViN2RiOWVlOGM2NDRmMjViLi40 MzczOTU3MTA2OTAxYjkwZGRkYTU3ZjZmYTM2NmVhMzRiZWU2YjBkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRFZGl0aW5nQ29tbWFuZHMu aApAQCAtNjcsMTEgKzY3LDMzIEBAIEdfQkVHSU5fREVDTFMKICAqCiAgKiBUaGUgc2VsZWN0IGFs bCBjb21tYW5kLiBTZWxlY3RzIGFsbCB0aGUgY29udGVudCBvZiB0aGUgY3VycmVudCB0ZXh0IGZp ZWxkIGluCiAgKiBhICNXZWJLaXRXZWJWaWV3LgotICogSXQgaXMgYWx3YXlzIHBvc3NpYmxlIHRv IHNlbGVjdCBhbGwgdGV4dCwgbm8gbWF0dGVyIHdoZXRlciB0aGUgI1dlYktpdFdlYlZpZXcgY29u dGVudAotICogaXMgZWRpdGFibGUgb3Igbm90LiBZb3UgY2FuIHN0aWxsIGNoZWNrIGl0IHdpdGgg d2Via2l0X3dlYl92aWV3X2Nhbl9leGVjdXRlX2VkaXRpbmdfY29tbWFuZCgpLgorICogSXQgaXMg YWx3YXlzIHBvc3NpYmxlIHRvIHNlbGVjdCBhbGwgdGV4dCwgbm8gbWF0dGVyIHdoZXRoZXIgdGhl CisgKiAjV2ViS2l0V2ViVmlldyBjb250ZW50IGlzIGVkaXRhYmxlIG9yIG5vdC4gWW91IGNhbiBz dGlsbCBjaGVjayBpdAorICogd2l0aCB3ZWJraXRfd2ViX3ZpZXdfY2FuX2V4ZWN1dGVfZWRpdGlu Z19jb21tYW5kKCkuCiAgKi8KICNkZWZpbmUgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1Rf QUxMICJTZWxlY3RBbGwiCiAKKy8qKgorICogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9VTkRPOgor ICoKKyAqIFRoZSB1bmRvIGNvbW1hbmQuIFVuZG9lcyB0aGUgbGFzdCBlZGl0aW5nIGNvbW1hbmQg aW4gYSAjV2ViS2l0V2ViVmlldy4KKyAqIFlvdSBjYW4gY2hlY2sgd2hldGhlciBpdCdzIHBvc3Np YmxlIHRvIGV4ZWN1dGUgdGhlIGNvbW1hbmQgd2l0aAorICogd2Via2l0X3dlYl92aWV3X2Nhbl9l eGVjdXRlX2VkaXRpbmdfY29tbWFuZCgpLiBJdCdzIG9ubHkgcG9zc2libGUKKyAqIHRvIHVuZG8g YSBjb21tYW5kIGFmdGVyIGEgcHJldmlvdXNseSBleGVjdXRlZCBlZGl0aW5nIG9wZXJhdGlvbi4K KyAqLworI2RlZmluZSBXRUJLSVRfRURJVElOR19DT01NQU5EX1VORE8gIlVuZG8iCisKKy8qKgor ICogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9SRURPOgorICoKKyAqIFRoZSByZWRvIGNvbW1hbmQu IFJlZG9lcyBhIHByZXZpb3VzbHkgdW5kb25lIGVkaXRpbmcgY29tbWFuZCBpbgorICogYSAjV2Vi S2l0V2ViVmlldy4KKyAqIFlvdSBjYW4gY2hlY2sgd2hldGhlciBpdCdzIHBvc3NpYmxlIHRvIGV4 ZWN1dGUgdGhlIGNvbW1hbmQgd2l0aAorICogd2Via2l0X3dlYl92aWV3X2Nhbl9leGVjdXRlX2Vk aXRpbmdfY29tbWFuZCgpLiBJdCdzIG9ubHkgcG9zc2libGUKKyAqIHRvIHJlZG8gYSBjb21tYW5k IHdoZW4gaXQgaGFzIGJlZW4gcHJldmlvdXNseSB1bmRvbmUuCisgKi8KKyNkZWZpbmUgV0VCS0lU X0VESVRJTkdfQ09NTUFORF9SRURPICJSZWRvIgorCiBHX0VORF9ERUNMUwogCiAjZW5kaWYKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0 ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dl YmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4IGJiZjk3OWI2NGFkYTRhNmMwZmVhOWEwMGMyYWIy MmU0YThiZjVhZjIuLjE4MjdiNmIxNmMyYTk2YjEyMmZjYTQ0NGRlY2RmMWQ0ZDJjYTU3ZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0 ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9j cy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtNzEsNiArNzEsOCBAQCBXRUJLSVRfRURJVElO R19DT01NQU5EX0NVVAogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9DT1BZCiBXRUJLSVRfRURJVElO R19DT01NQU5EX1BBU1RFCiBXRUJLSVRfRURJVElOR19DT01NQU5EX1NFTEVDVF9BTEwKK1dFQktJ VF9FRElUSU5HX0NPTU1BTkRfVU5ETworV0VCS0lUX0VESVRJTkdfQ09NTUFORF9SRURPCiAKIDxT VUJTRUNUSU9OPgogd2Via2l0X3dlYl92aWV3X25ldwo=