97549 2012-09-25 03:37:26 -0700 [EFL] unskip toDataURL tests 2012-09-25 04:44:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 727470 0 jussi.kukkonen 2012-09-25 03:37:26 -0700 We should unskip these: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html EFL port only supports "image/png" but that is the only one that is required by spec (and not testing that support is bad). I'll attach patch. I've also filed bug 97544 for supporting other image formats in future. 727480 1 165574 jussi.kukkonen 2012-09-25 03:48:03 -0700 Created attachment 165574 Patch 727482 2 165574 cdumez 2012-09-25 03:49:32 -0700 Comment on attachment 165574 Patch LGTM. 727483 3 165574 jussi.kukkonen 2012-09-25 03:49:36 -0700 Comment on attachment 165574 Patch cq would be appreciated 727508 4 165574 webkit.review.bot 2012-09-25 04:44:18 -0700 Comment on attachment 165574 Patch Clearing flags on attachment: 165574 Committed r129488: <http://trac.webkit.org/changeset/129488> 727510 5 webkit.review.bot 2012-09-25 04:44:22 -0700 All reviewed patches have been landed. Closing bug. 165574 2012-09-25 03:48:03 -0700 2012-09-25 04:44:18 -0700 Patch bug-97549-20120925134722.patch text/plain 3385 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDgzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWE0OTAzMjdmMjY2YzYxMjAyZTM4 MDk5MTE1ZjI1ZmRmOTE3OGE4My4uYjhhN2FmODFiMTE0Zjk3YThiYzdhNzgyMzgxZWE3MmE4MGUw YWE1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTI1ICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSB1bnNraXAgdG9EYXRh VVJMIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NzU0OQorCisgICAgICAgIFVucmV2aWV3ZWQgRUZMIGdhcmRlbmluZy4KKworICAgICAgICBF RkwgcG9ydCBvbmx5IHN1cHBvcnRzICJpbWFnZS9wbmciIGF0IHRoZSBtb21lbnQgYnV0IG9ubHkg cG5nIGlzIGFjdHVhbGx5IHJlcXVpcmVkCisgICAgICAgIGJ5IHNwZWMgYW5kIG5vdCB0ZXN0aW5n IHJlcXVpcmVkIHN1cHBvcnQgaXMgYmFkLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBw ZWQ6CisgICAgICAgICogcGxhdGZvcm0vZWZsL2Zhc3QvY2FudmFzL2NhbnZhcy10b0RhdGFVUkwt Y2FzZS1pbnNlbnNpdGl2ZS1taW1ldHlwZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IHBsYXRmb3JtL2VmbC9mYXN0L2NhbnZhcy90b0RhdGFVUkwtc3VwcG9ydGVkVHlwZXMtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKwogMjAxMi0wOS0yNSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFw aGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBEYWlseSBnYXJk ZW5pbmcuIFNraXAgYSBmZXcgZmFpbGluZyB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQK aW5kZXggYTFhYmUyZTFhZTNjODUyY2FlZDgwZDAwNzYwMTYzMTNlODE5YjcwOC4uYjJjNGRkZjky YWM4NDYxNGVkMDc3NWI2YzRkODA5ZWI4ZDIxNTA0ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBw ZWQKQEAgLTE0NCwxMCArMTQ0LDYgQEAgZmFzdC9ldmVudHMvYXR0ZW1wdC1zY3JvbGwtd2l0aC1u by1zY3JvbGxiYXJzLmh0bWwKICMgQlVHOiBubyBtb3VzZW91dCBldmVudCBiZWluZyBzZW50CiBm YXN0L2V2ZW50cy9tb3VzZW91dC1vbi13aW5kb3cuaHRtbAogCi0jIEJVRzogPGNhbnZhcz4ncyB0 b0RhdGFVUkwgaGFzIHByb2JsZW1zIHdpdGggbm9uLWltYWdlL3BuZyBtaW1ldHlwZXMKLWZhc3Qv Y2FudmFzL2NhbnZhcy10b0RhdGFVUkwtY2FzZS1pbnNlbnNpdGl2ZS1taW1ldHlwZS5odG1sCi1m YXN0L2NhbnZhcy90b0RhdGFVUkwtc3VwcG9ydGVkVHlwZXMuaHRtbAotCiAjIEJVRzogd3Jvbmcg dGVzdCByZXN1bHRzIHRoYXQgbmVlZCBpbnZlc3RpZ2F0aW9uCiBjb21wb3NpdGluZy9jaGVja2Vy Ym9hcmQuaHRtbAogY29tcG9zaXRpbmcvZnJhbWVzZXRzL2NvbXBvc2l0ZWQtZnJhbWUtYWxpZ25t ZW50Lmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L2NhbnZh cy9jYW52YXMtdG9EYXRhVVJMLWNhc2UtaW5zZW5zaXRpdmUtbWltZXR5cGUtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvY2FudmFzL2NhbnZhcy10b0RhdGFVUkwt Y2FzZS1pbnNlbnNpdGl2ZS1taW1ldHlwZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzY0OTRi NDJhZDZmYmRkNWY1NGFiYzVmNWE0YmVjMGFmOTA0ZjA3YQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L2NhbnZhcy9jYW52YXMtdG9EYXRhVVJMLWNhc2Ut aW5zZW5zaXRpdmUtbWltZXR5cGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1Rlc3Qg dGhhdCB0b0RhdGFVUkwobWltZVR5cGUpIGlnbm9yZXMgdGhlIGNhc2Ugb2YgJ21pbWVUeXBlJy4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdHJ5TWltZVR5cGUoJ2ltYWdl L3BuZycpIGlzICdpbWFnZS9wbmcnCitQQVNTIHRyeU1pbWVUeXBlKCdpTUFnZS9QbmcnKSBpcyAn aW1hZ2UvcG5nJworUEFTUyB0cnlNaW1lVHlwZSgnSU1BR0UvUE5HJykgaXMgJ2ltYWdlL3BuZycK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvZmFzdC9jYW52YXMvdG9EYXRhVVJMLXN1 cHBvcnRlZFR5cGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0 L2NhbnZhcy90b0RhdGFVUkwtc3VwcG9ydGVkVHlwZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu Ljk1MjM3MjY3NmM0NjFlMjliM2MxY2VlYTQ0M2EyNjczOGRiYzljOTUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvZmFzdC9jYW52YXMvdG9EYXRhVVJMLXN1cHBv cnRlZFR5cGVzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMwIEBACisgVGhlIEFjdHVhbCBDYW52 YXMgCitHaXZlbiBNSU1FVHlwZTogaW1hZ2UvcG5nCitVc2VkIE1JTUVUeXBlOiBpbWFnZS9wbmcK K01JTUUgdHlwZXMgYXJlIHRoZSBTQU1FLgorCitHaXZlbiBNSU1FVHlwZTogaW1hZ2UvanBlZwor VXNlZCBNSU1FVHlwZTogaW1hZ2UvcG5nCitNSU1FIHR5cGVzIERJRkZFUi4KKworR2l2ZW4gTUlN RVR5cGU6IGltYWdlL2dpZgorVXNlZCBNSU1FVHlwZTogaW1hZ2UvcG5nCitNSU1FIHR5cGVzIERJ RkZFUi4KKworR2l2ZW4gTUlNRVR5cGU6IAorVXNlZCBNSU1FVHlwZTogaW1hZ2UvcG5nCitNSU1F IHR5cGVzIERJRkZFUi4KKworR2l2ZW4gTUlNRVR5cGU6IG51bGwKK1VzZWQgTUlNRVR5cGU6IGlt YWdlL3BuZworTUlNRSB0eXBlcyBESUZGRVIuCisKK0dpdmVuIE1JTUVUeXBlOiB1bmRlZmluZWQK K1VzZWQgTUlNRVR5cGU6IGltYWdlL3BuZworTUlNRSB0eXBlcyBESUZGRVIuCisKK0dpdmVuIE1J TUVUeXBlOiBpbWFnZS94LXdlYmtpdGJpdG1hcAorVXNlZCBNSU1FVHlwZTogaW1hZ2UvcG5nCitN SU1FIHR5cGVzIERJRkZFUi4KKworCg==