97526 2012-09-24 22:53:10 -0700 Bug in numeric accessors on global environment 2012-09-24 23:38:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough ggaren oldest_to_newest 727302 0 barraclough 2012-09-24 22:53:10 -0700 I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/ The sparsemap is failing to map back from the global object to the window shell. A test case would need to resolve a numeric property name against the global environment. 727303 1 165526 barraclough 2012-09-24 22:55:25 -0700 Created attachment 165526 Fix 727307 2 ggaren 2012-09-24 23:03:07 -0700 To do an assignment directly to the global object, you need to do it lexically, and not using "this" or "window". Perhaps calling bare __defineSetter__() and __defineGetter__() with a numeric property will do it. 727308 3 165526 ggaren 2012-09-24 23:03:37 -0700 Comment on attachment 165526 Fix r=me 727312 4 barraclough 2012-09-24 23:10:59 -0700 (In reply to comment #2) > To do an assignment directly to the global object, you need to do it lexically, and not using "this" or "window". Perhaps calling bare __defineSetter__() and __defineGetter__() with a numeric property will do it. Sadly __defineSetter__/__defineGetter__ will replace the current getter/setter, rather than calling it. :-/ I need something equivalent to window[0] = foo; i.e. something that will do a [[Put]] rather than a [[DefineOwnProperty]], but where the base is the global environment. Still haven't worked out how to do this for a numeric name. 727333 5 barraclough 2012-09-24 23:38:13 -0700 Fixed in r129458 165526 2012-09-24 22:55:25 -0700 2012-09-24 23:03:36 -0700 Fix 97526.patch text/plain 2156 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NDU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA5LTI0ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBCdWcgaW4gbnVtZXJpYyBhY2Nlc3NvcnMgb24gZ2xvYmFsIGVudmlyb25tZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzUyNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkndmUgaGl0 IHRoaXMgYXNzZXJ0IGluIHRlc3QyNjIgaW4gYnJvd3NlciwgYnV0IGhhdmVuJ3QgeWV0IHdvcmtl ZCBvdXQgaG93IHRvIHJlcHJvIGluIGEgdGVzdCBjYXNlIDotLworICAgICAgICBUaGUgc3BhcnNl bWFwIGlzIGZhaWxpbmcgdG8gbWFwIGJhY2sgZnJvbSB0aGUgZ2xvYmFsIG9iamVjdCB0byB0aGUg d2luZG93IHNoZWxsLgorICAgICAgICBBIHRlc3QgY2FzZSB3b3VsZCBuZWVkIHRvIHJlc29sdmUg YSBudW1lcmljIHByb3BlcnR5IG5hbWUgYWdhaW5zdCB0aGUgZ2xvYmFsIGVudmlyb25tZW50Lgor CisgICAgICAgIChKU0M6OlNwYXJzZUFycmF5RW50cnk6OmdldCk6CisgICAgICAgIChKU0M6OlNw YXJzZUFycmF5RW50cnk6OnB1dCk6CisgICAgICAgICAgICAtIEFkZCBtaXNzaW5nIHRvVGhpc09i amVjdCBjYWxscy4KKwogMjAxMi0wOS0yNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBpc24ndCBhd2FyZSBvZiBpbmRleGVk IHN0b3JhZ2UsIGJ1dCBzaG91bGQgYmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1NwYXJzZUFycmF5VmFsdWVNYXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1NwYXJzZUFycmF5VmFsdWVNYXAuY3BwCShyZXZpc2lvbiAxMjk0Mzcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TcGFyc2VBcnJheVZhbHVlTWFwLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTU5LDcgKzE1OSw3IEBAIEpTVmFsdWUgU3BhcnNlQXJyYXlF bnRyeTo6Z2V0KEV4ZWNTdGF0ZSoKIAogICAgIENhbGxEYXRhIGNhbGxEYXRhOwogICAgIENhbGxU eXBlIGNhbGxUeXBlID0gZ2V0dGVyLT5tZXRob2RUYWJsZSgpLT5nZXRDYWxsRGF0YShnZXR0ZXIs IGNhbGxEYXRhKTsKLSAgICByZXR1cm4gY2FsbChleGVjLCBnZXR0ZXIsIGNhbGxUeXBlLCBjYWxs RGF0YSwgYXJyYXksIGV4ZWMtPmVtcHR5TGlzdCgpKTsKKyAgICByZXR1cm4gY2FsbChleGVjLCBn ZXR0ZXIsIGNhbGxUeXBlLCBjYWxsRGF0YSwgYXJyYXktPm1ldGhvZFRhYmxlKCktPnRvVGhpc09i amVjdChhcnJheSwgZXhlYyksIGV4ZWMtPmVtcHR5TGlzdCgpKTsKIH0KIAogdm9pZCBTcGFyc2VB cnJheUVudHJ5OjpwdXQoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHRoaXNWYWx1ZSwgU3BhcnNl QXJyYXlWYWx1ZU1hcCogbWFwLCBKU1ZhbHVlIHZhbHVlLCBib29sIHNob3VsZFRocm93KQpAQCAt MTg5LDYgKzE4OSw4IEBAIHZvaWQgU3BhcnNlQXJyYXlFbnRyeTo6cHV0KEV4ZWNTdGF0ZSogZXgK ICAgICBDYWxsVHlwZSBjYWxsVHlwZSA9IHNldHRlci0+bWV0aG9kVGFibGUoKS0+Z2V0Q2FsbERh dGEoc2V0dGVyLCBjYWxsRGF0YSk7CiAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIgYXJnczsKICAg ICBhcmdzLmFwcGVuZCh2YWx1ZSk7CisgICAgaWYgKHRoaXNWYWx1ZS5pc09iamVjdCgpKQorICAg ICAgICB0aGlzVmFsdWUgPSBhc09iamVjdCh0aGlzVmFsdWUpLT5tZXRob2RUYWJsZSgpLT50b1Ro aXNPYmplY3QoYXNPYmplY3QodGhpc1ZhbHVlKSwgZXhlYyk7CiAgICAgY2FsbChleGVjLCBzZXR0 ZXIsIGNhbGxUeXBlLCBjYWxsRGF0YSwgdGhpc1ZhbHVlLCBhcmdzKTsKIH0KIAo=