<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97525</bug_id>
          
          <creation_ts>2012-09-24 22:34:41 -0700</creation_ts>
          <short_desc>Remove HAVE_SBRK since we never set use_sbrk to true</short_desc>
          <delta_ts>2012-09-25 13:40:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Pratik Solanki">psolanki</assigned_to>
          <cc>benjamin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>ggaren</cc>
    
    <cc>mifenton</cc>
    
    <cc>psolanki</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>727292</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-09-24 22:34:41 -0700</bug_when>
    <thetext>TCSystemAlloc.cpp has code inside HAVE(SBRK). However, we never really use sbrk() since the call to it is governed by the use_sbrk flag and that was set to false in 2005 in r10701 for bug 5243. We can move that code to be inside ifndef WTF_CHANGES.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727293</commentid>
    <comment_count>1</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-09-24 22:34:54 -0700</bug_when>
    <thetext>&lt;rdar://problem/12363601&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727295</commentid>
    <comment_count>2</comment_count>
      <attachid>165522</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-09-24 22:41:59 -0700</bug_when>
    <thetext>Created attachment 165522
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727309</commentid>
    <comment_count>3</comment_count>
      <attachid>165522</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2012-09-24 23:05:41 -0700</bug_when>
    <thetext>Comment on attachment 165522
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727310</commentid>
    <comment_count>4</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-09-24 23:06:44 -0700</bug_when>
    <thetext>Thanks Geoff. I&apos;ll wait for the EWS bots to finish the builds before checking this in. Just in case...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727917</commentid>
    <comment_count>5</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2012-09-25 13:40:30 -0700</bug_when>
    <thetext>Committed r129549: &lt;http://trac.webkit.org/changeset/129549&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165522</attachid>
            <date>2012-09-24 22:41:59 -0700</date>
            <delta_ts>2012-09-24 23:05:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97525-20120924224120.patch</filename>
            <type>text/plain</type>
            <size>4560</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDkyODdjOTIzNTgwNzIzNmRkMDRkNmJl
MGRiZWFhNmRlOTMzNDM1ZjUuLjUwODI3ZGRkNzkxN2M2YmZmNmM0NTE5YTFmZGI3ZjU4ZjIwNjIx
MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDktMjQgIFByYXRpayBTb2xhbmtpICA8cHNv
bGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBIQVZFX1NCUksgc2luY2Ugd2UgbmV2
ZXIgc2V0IHVzZV9zYnJrIHRvIHRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTk3NTI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMjM2MzYwMT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29k
ZSB1bmRlciBIQVZFKFNCUkspIGhhcyBub3QgYmVlbiB1c2VkIHNpbmNlIDIwMDUuIFdlIHVzZSBt
bWFwIG5vdCBzYnJrIGZvciBGYXN0TWFsbG9jCisgICAgICAgIG5vdCBzYnJrLiBXZSBjYW4ganVz
dCByZW1vdmUgdGhlIGRlZmluZSBhbmQgbW92ZSBhbGwgb2YgdGhpcyBjb2RlIGluc2lkZSAjaWZu
ZGVmCisgICAgICAgIFdURl9DSEFOR0VTLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6Cisg
ICAgICAgICogd3RmL1RDU3lzdGVtQWxsb2MuY3BwOgorICAgICAgICAoVENNYWxsb2NfU3lzdGVt
QWxsb2MpOgorCiAyMDEyLTA5LTIxICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRp
Z2lhLmNvbT4KIAogICAgICAgICBbUXRdIEVycm9yIG91dCBlYXJseSBpZiB3ZSBkb24ndCBoYXZl
IElDVSBhdmFpbGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGVkNTY4Nzg0
MzliMjljMWY0ODBhYWE2ZmE5YWE3ZmMxMDQ1NzY5YzMuLjVmMzcxZjUzY2Q4MjU4MDU0OWZjMjY5
MWQ3YTZiZjU2OTVjN2RlYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D
aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDEzIEBACisyMDEyLTA5LTI0ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNv
bT4KKworICAgICAgICBSZW1vdmUgSEFWRV9TQlJLIHNpbmNlIHdlIG5ldmVyIHNldCB1c2Vfc2Jy
ayB0byB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05NzUyNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIzNjM2MDE+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9BYm91
dERhdGFIYXZlRmVhdHVyZXMuaW46IFJlbXZvZSBTQlJLIGZyb20gbGlzdC4KKwogMjAxMi0wOS0y
MSAgTGlhbmdodWkgQ2hlbiAgPGxpYWNoZW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy
eV0gUmVhbGx5IGZpeCBidWcgOTU0ODggdGhhdCB1c2VyIGNhbiBnZXQgdGhlIGF1dGhlbnRpY2F0
aW9uIGNoYWxsZW5nZSBkaWFsb2cgd2hpbGUgdGhlIG90aGVyIHRhYiBoYXMgZm9jdXMuCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZv
cm0uaAppbmRleCAwYmU0YmIwN2RjMjhmYzkxMTYyZWQzMDY1YWNiMTUyMDlmMjFkM2UyLi4zODU0
ZTAyMzAyZjJmYzhiMDNkMDQ4MTJkMzM0ZDM3YjQwMmY4OWY5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTY5
OCw3ICs2OTgsNiBAQAogI2RlZmluZSBIQVZFX0xBTkdJTkZPX0ggMQogI2RlZmluZSBIQVZFX01N
QVAgMQogI2RlZmluZSBIQVZFX01FUkdFU09SVCAxCi0jZGVmaW5lIEhBVkVfU0JSSyAxCiAjZGVm
aW5lIEhBVkVfU1RSSU5HU19IIDEKICNkZWZpbmUgSEFWRV9TWVNfUEFSQU1fSCAxCiAjZGVmaW5l
IEhBVkVfU1lTX1RJTUVfSCAxCkBAIC03MzksNyArNzM4LDYgQEAKICNkZWZpbmUgSEFWRV9NTUFQ
IDEKICNkZWZpbmUgSEFWRV9NQURWX0ZSRUVfUkVVU0UgMQogI2RlZmluZSBIQVZFX01BRFZfRlJF
RSAxCi0jZGVmaW5lIEhBVkVfU0JSSyAxCiAjZGVmaW5lIEhBVkVfU1RSSU5HU19IIDEKICNkZWZp
bmUgSEFWRV9TWVNfUEFSQU1fSCAxCiAjZGVmaW5lIEhBVkVfU1lTX1RJTUVfSCAxCkBAIC03NDks
NyArNzQ3LDYgQEAKIAogI2RlZmluZSBIQVZFX0VSUk5PX0ggMQogI2RlZmluZSBIQVZFX05NQVAg
MQotI2RlZmluZSBIQVZFX1NCUksgMQogI2RlZmluZSBIQVZFX1NUUklOR1NfSCAxCiAjZGVmaW5l
IEhBVkVfU1lTX1BBUkFNX0ggMQogI2RlZmluZSBIQVZFX1NZU19USU1FX0ggMQpAQCAtNzYxLDcg
Kzc1OCw2IEBACiAjZGVmaW5lIEhBVkVfRVJSTk9fSCAxCiAjZGVmaW5lIEhBVkVfTEFOR0lORk9f
SCAxCiAjZGVmaW5lIEhBVkVfTU1BUCAxCi0jZGVmaW5lIEhBVkVfU0JSSyAxCiAjZGVmaW5lIEhB
VkVfU1RSSU5HU19IIDEKICNkZWZpbmUgSEFWRV9TWVNfUEFSQU1fSCAxCiAjZGVmaW5lIEhBVkVf
U1lTX1RJTUVfSCAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UQ1N5c3RlbUFsbG9jLmNw
cCBiL1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCmluZGV4IGE0ZjY1OTc2MTE2YTVk
NWMyYjVkNzc4OWQ4ZTUxMjgzNWVhODVkYjQuLmY1NDcwODVlNmNmNDQ3YjYxM2Y0MDA3YmRiOWYw
OWMzNmViNjc2OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3Bw
CisrKyBiL1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCkBAIC03NSw5ICs3NSw2IEBA
IHN0YXRpYyBzaXplX3QgcGFnZXNpemUgPSAwOwogLy8gdG8gZ2V0IGFzIG11Y2ggdmlydHVhbCBt
ZW1vcnkgYXMgcG9zc2libGUuCiAjaWZuZGVmIFdURl9DSEFOR0VTCiBzdGF0aWMgYm9vbCB1c2Vf
ZGV2bWVtID0gZmFsc2U7Ci0jZW5kaWYKLQotI2lmIEhBVkUoU0JSSykKIHN0YXRpYyBib29sIHVz
ZV9zYnJrID0gZmFsc2U7CiAjZW5kaWYKIApAQCAtMTA3LDcgKzEwNCw3IEBAIHN0YXRpYyBjb25z
dCBpbnQzMl90IEZMQUdTX21hbGxvY19kZXZtZW1fc3RhcnQgPSAwOwogc3RhdGljIGNvbnN0IGlu
dDMyX3QgRkxBR1NfbWFsbG9jX2Rldm1lbV9saW1pdCA9IDA7CiAjZW5kaWYKIAotI2lmIEhBVkUo
U0JSSykKKyNpZm5kZWYgV1RGX0NIQU5HRVMKIAogc3RhdGljIHZvaWQqIFRyeVNicmsoc2l6ZV90
IHNpemUsIHNpemVfdCAqYWN0dWFsX3NpemUsIHNpemVfdCBhbGlnbm1lbnQpIHsKICAgc2l6ZSA9
ICgoc2l6ZSArIGFsaWdubWVudCAtIDEpIC8gYWxpZ25tZW50KSAqIGFsaWdubWVudDsKQEAgLTE0
OSw3ICsxNDYsNyBAQCBzdGF0aWMgdm9pZCogVHJ5U2JyayhzaXplX3Qgc2l6ZSwgc2l6ZV90ICph
Y3R1YWxfc2l6ZSwgc2l6ZV90IGFsaWdubWVudCkgewogICByZXR1cm4gcmVpbnRlcnByZXRfY2Fz
dDx2b2lkKj4ocHRyKTsKIH0KIAotI2VuZGlmIC8qIEhBVkUoU0JSSykgKi8KKyNlbmRpZiAvKiBp
Zm5kZWYoV1RGX0NIQU5HRVMpICovCiAKICNpZiBIQVZFKE1NQVApCiAKQEAgLTM0OSw5ICszNDYs
NyBAQCB2b2lkKiBUQ01hbGxvY19TeXN0ZW1BbGxvYyhzaXplX3Qgc2l6ZSwgc2l6ZV90ICphY3R1
YWxfc2l6ZSwgc2l6ZV90IGFsaWdubWVudCkgewogICAgICAgdm9pZCogcmVzdWx0ID0gVHJ5RGV2
TWVtKHNpemUsIGFjdHVhbF9zaXplLCBhbGlnbm1lbnQpOwogICAgICAgaWYgKHJlc3VsdCAhPSBO
VUxMKSByZXR1cm4gcmVzdWx0OwogICAgIH0KLSNlbmRpZgogICAgIAotI2lmIEhBVkUoU0JSSykK
ICAgICBpZiAodXNlX3NicmsgJiYgIXNicmtfZmFpbHVyZSkgewogICAgICAgdm9pZCogcmVzdWx0
ID0gVHJ5U2JyayhzaXplLCBhY3R1YWxfc2l6ZSwgYWxpZ25tZW50KTsKICAgICAgIGlmIChyZXN1
bHQgIT0gTlVMTCkgcmV0dXJuIHJlc3VsdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh
Y2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFIYXZlRmVhdHVyZXMuaW4gYi9Tb3VyY2Uv
V2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQWJvdXREYXRhSGF2ZUZlYXR1cmVzLmlu
CmluZGV4IGE5ZWM1ZjI4ZWJlMTA2NjcxYTMzOWFhOTlhZWQ2ZmIyZDE3YTliMjYuLmQ2MDRjMzE4
YmUxNzhjZjMyMzY0MDIxMjAyOTA4YWYxNTMyNGIyZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFIYXZlRmVhdHVyZXMuaW4KKysr
IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Fib3V0RGF0YUhhdmVG
ZWF0dXJlcy5pbgpAQCAtMzUsNyArMzUsNiBAQCBQVEhSRUFEX1NFVE5BTUVfTlAKIFFUNQogUkVB
RExJTkUKIFJVTkxPT1BfVElNRVIKLVNCUksKIFNJR05BTF9ICiBTVERJTlRfSAogU1RSSU5HX0gK
</data>
<flag name="review"
          id="177589"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>