97523 2012-09-24 21:58:17 -0700 [EFL] Update minimal required versions 2012-09-25 12:15:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos adamk adamk gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 727284 0 laszlo.gombos 2012-09-24 21:58:17 -0700 It seems that there are 2 place in the source tree where the minimal required version for the dependencies are stored; 1./ OptionsEfl.cmake and 2./ jhbuild.modules. I propose that we should try to keep the 2 aligned or alternatively we should only enforce the version check in one place but not in the other place. 727285 1 165520 laszlo.gombos 2012-09-24 22:02:59 -0700 Created attachment 165520 use the same versions in both places 727391 2 165520 webkit.review.bot 2012-09-25 01:14:36 -0700 Comment on attachment 165520 use the same versions in both places Clearing flags on attachment: 165520 Committed r129472: <http://trac.webkit.org/changeset/129472> 727392 3 webkit.review.bot 2012-09-25 01:14:40 -0700 All reviewed patches have been landed. Closing bug. 727511 4 rakuco 2012-09-25 04:44:44 -0700 We normally bump the required versions in OptionsEfl.cmake with less frequency than in jhbuild.modules because the purpose of those two files is different -- the former is used even by people who are not developing the port and thus might not need the latest version of everything (we do not require EFL API from the 1.2 releases IIRC, for example), while the latter is used basically so that we generate consistent test results across different installations. 727863 5 adamk 2012-09-25 12:14:54 -0700 Reopening to attach new patch. 727864 6 adamk 2012-09-25 12:15:33 -0700 Erp, sorry for the noise, webkit-patch mishandling. 165520 2012-09-24 22:02:59 -0700 2012-09-25 12:14:46 -0700 use the same versions in both places 97523.patch text/plain 2221 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTQ1 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5 LTI0ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gVXBkYXRlIG1pbmltYWwgcmVxdWlyZWQgdmVyc2lvbnMgZm9yIGRlcGVuZGVuY2llcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc1MjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIHNhbWUg dmVyc2lvbnMgbnVtYmVycyBmb3IgZGVwZW5kZW5jaWVzIGFzIGluIFRvb2xzL2VmbC9qaGJ1aWxk Lm1vZHVsZXMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwog MjAxMi0wOS0yNCAgQnl1bmd3b28gTGVlICA8Ync4MC5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0NNYWtlXSBDaGFuZ2UgaGFyZGNvZGVkICdsaWInIGFuZCAnYmluJyBpbiBDTWFrZUxpc3Rz LnR4dCB0byAnTElCX0lOU1RBTExfRElSJyBhbmQgJ0VYRUNfSU5TVEFMTF9ESVInLgpJbmRleDog U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9uIDEyOTQ1MSkKKysrIFNvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC03LDcgKzcsNyBAQCBBRERfREVGSU5JVElP TlMoLURCVUlMRElOR19FRkxfXz0xKQogQUREX0RFRklOSVRJT05TKC1EV1RGX1BMQVRGT1JNX0VG TD0xKQogU0VUKFdURl9QTEFURk9STV9FRkwgMSkKIAotRklORF9QQUNLQUdFKENhaXJvIDEuMTAg UkVRVUlSRUQpCitGSU5EX1BBQ0tBR0UoQ2Fpcm8gMS4xMC4yIFJFUVVJUkVEKQogRklORF9QQUNL QUdFKEZvbnRjb25maWcgMi44LjAgUkVRVUlSRUQpCiBGSU5EX1BBQ0tBR0UoU3FsaXRlIFJFUVVJ UkVEKQogRklORF9QQUNLQUdFKExpYlhtbDIgMi42IFJFUVVJUkVEKQpAQCAtMTgsNyArMTgsNyBA QCBGSU5EX1BBQ0tBR0UoSlBFRyBSRVFVSVJFRCkKIEZJTkRfUEFDS0FHRShQTkcgUkVRVUlSRUQp CiBGSU5EX1BBQ0tBR0UoWkxJQiBSRVFVSVJFRCkKIAotRklORF9QQUNLQUdFKEdMSUIgMi4zMS44 IFJFUVVJUkVEIENPTVBPTkVOVFMgZ2lvIGdvYmplY3QgZ3RocmVhZCkKK0ZJTkRfUEFDS0FHRShH TElCIDIuMzMuMiBSRVFVSVJFRCBDT01QT05FTlRTIGdpbyBnb2JqZWN0IGd0aHJlYWQpCiBGSU5E X1BBQ0tBR0UoTGliU291cCAyLjM5LjQuMSBSRVFVSVJFRCkKIFNFVChFTkFCTEVfR0xJQl9TVVBQ T1JUIE9OKQogCkBAIC0xMDUsMTUgKzEwNSwxNSBAQCBJRiAoRU5BQkxFX0VDT1JFX1gpCiBFTkRJ RiAoKQogCiBGSU5EX1BBQ0tBR0UoRWluYSAxLjIgUkVRVUlSRUQpCi1GSU5EX1BBQ0tBR0UoRXZh cyAxLjAgUkVRVUlSRUQpCitGSU5EX1BBQ0tBR0UoRXZhcyAxLjIgUkVRVUlSRUQpCiBGSU5EX1BB Q0tBR0UoRWNvcmUgMS4yIENPTVBPTkVOVFMgRXZhcyBGaWxlIElucHV0ICR7RUNPUkVfQURESVRJ T05BTF9DT01QT05FTlRTfSkKLUZJTkRfUEFDS0FHRShFZGplIDEuMCBSRVFVSVJFRCkKK0ZJTkRf UEFDS0FHRShFZGplIDEuMiBSRVFVSVJFRCkKIEZJTkRfUEFDS0FHRShFZXplIDEuMiBSRVFVSVJF RCkKLUZJTkRfUEFDS0FHRShFZnJlZXQgMS4wIFJFUVVJUkVEKQotRklORF9QQUNLQUdFKEVfREJ1 cyAxLjEgQ09NUE9ORU5UUyBFVUtpdCkKK0ZJTkRfUEFDS0FHRShFZnJlZXQgMS4yIFJFUVVJUkVE KQorRklORF9QQUNLQUdFKEVfREJ1cyAxLjIgQ09NUE9ORU5UUyBFVUtpdCkKIAotRklORF9QQUNL QUdFKEZyZWV0eXBlIFJFUVVJUkVEKQotRklORF9QQUNLQUdFKEhhcmZCdXp6IFJFUVVJUkVEKQor RklORF9QQUNLQUdFKEZyZWV0eXBlIDIuNC4yIFJFUVVJUkVEKQorRklORF9QQUNLQUdFKEhhcmZC dXp6IDAuOS4yIFJFUVVJUkVEKQogU0VUKFdURl9VU0VfRlJFRVRZUEUgMSkKIFNFVChXVEZfVVNF X0hBUkZCVVpaX05HIDEpCiBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX0ZSRUVUWVBFPTEpCg==