97517 2012-09-24 21:15:59 -0700 REGRESSION(r129448): multiple fields time input UI doesn't use system time format settings on Chromium-Mac 2012-09-25 21:53:44 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin keishi tkent webkit.review.bot oldest_to_newest 727249 0 yosin 2012-09-24 21:15:59 -0700 We should use NSLocale object returned by [NSLocale currentLocale] if browser language/@lang equals [[NSLocal currentLocale] localeIdentifier]. 727251 1 yosin 2012-09-24 21:16:51 -0700 Imported from http://crbug.com/152080 - Input type=time can not convert time to 24hr format after OS format changed 727277 2 165517 keishi 2012-09-24 21:46:08 -0700 Created attachment 165517 Patch 727279 3 165517 yosin 2012-09-24 21:49:35 -0700 Comment on attachment 165517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165517&action=review > Source/WebKit/chromium/src/WebPagePopupImpl.cpp:42 > #include "PagePopupClient.h" Please remove WebPagePopupImpl.cpp from this patch. This changes are unrelated. 727280 4 165518 keishi 2012-09-24 21:50:12 -0700 Created attachment 165518 Patch 727283 5 165518 yosin 2012-09-24 21:57:48 -0700 Comment on attachment 165518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165518&action=review > Source/WebCore/platform/text/mac/LocaleMac.mm:55 > + return normalizedLocale.left(separatorPosition); Is it OK to compare only language part? It seems that short date format for en_CA and en_US are different. CA yy-MM-dd GB dd/MM/yyyy http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_CA.xml http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_GB.xml Should we have another bug to fix this? 727432 6 165518 tkent 2012-09-25 02:34:05 -0700 Comment on attachment 165518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165518&action=review >> Source/WebCore/platform/text/mac/LocaleMac.mm:55 >> + return normalizedLocale.left(separatorPosition); > > Is it OK to compare only language part? > > It seems that short date format for en_CA and en_US are different. > > CA yy-MM-dd > GB dd/MM/yyyy > > http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_CA.xml > http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_GB.xml > > Should we have another bug to fix this? Yeah, It should be a separated issue. 727434 7 165518 webkit.review.bot 2012-09-25 02:39:12 -0700 Comment on attachment 165518 Patch Clearing flags on attachment: 165518 Committed r129480: <http://trac.webkit.org/changeset/129480> 727435 8 webkit.review.bot 2012-09-25 02:39:15 -0700 All reviewed patches have been landed. Closing bug. 727719 9 165518 darin 2012-09-25 09:31:25 -0700 Comment on attachment 165518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165518&action=review > Source/WebCore/platform/text/mac/LocaleMac.mm:66 > + return [[NSLocale alloc] initWithLocaleIdentifier:locale]; This leaks the NSLocale object. > Source/WebCore/platform/text/mac/LocaleMac.mm:-71 > - : m_locale([[NSLocale alloc] initWithLocaleIdentifier:localeIdentifier]) This old incorrect code leaked the NSLocale object. > Source/WebCore/platform/text/mac/LocaleMac.mm:102 > + return adoptPtr(new LocaleMac([[NSLocale alloc] initWithLocaleIdentifier:localeIdentifier])); This leaks the NSLocale object. 728194 10 keishi 2012-09-25 21:53:44 -0700 (In reply to comment #8) > All reviewed patches have been landed. Closing bug. (In reply to comment #9) > (From update of attachment 165518 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165518&action=review > > > Source/WebCore/platform/text/mac/LocaleMac.mm:66 > > + return [[NSLocale alloc] initWithLocaleIdentifier:locale]; > > This leaks the NSLocale object. > I filed a bug Bug 97628 . 165517 2012-09-24 21:46:08 -0700 2012-09-24 21:49:35 -0700 Patch bug-97517-20120925134528.patch text/plain 7437 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVlOTQwN2M1YjMwM2Ix ZjA3YTc4NWY1OTZiMDYyNjhjZmQ1MTc0ZS4uNjg0ZDUwNDU4YTI5NWJiMmE5MjA5MjJkMTg0OWIy YTYxODE1OGI1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTI0ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEy OTQ0OCk6IG11bHRpcGxlIGZpZWxkcyB0aW1lIGlucHV0IFVJIGRvZXNuJ3QgdXNlIHN5c3RlbSB0 aW1lIGZvcm1hdCBzZXR0aW5ncyBvbiBDaHJvbWl1bS1NYWMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBsb2NhbGUgW05TTG9jYWxlIGN1 cnJlbnRMb2NhbGVdIGlmIGJyb3dzZXIgbGFuZ3VhZ2UvQGxhbmcgZXF1YWxzIFtbTlNMb2NhbCBj dXJyZW50TG9jYWxlXSBsb2NhbGVJZGVudGlmaWVyXS4gT3RoZXJ3aXNlIGl0IHdvbid0IHVzZSB0 aGUgY3VzdG9tIHRpbWUgZm9ybWF0IHRoYXQgdGhlIHVzZXIgaGFzIHNldC4KKworICAgICAgICBO byBuZXcgdGVzdHMuIFVuYWJsZSB0byB0ZXN0IGJlY2F1c2Ugd2UgbmVlZCB0byBjaGFuZ2Ugc3lz dGVtIGxvY2FsZSBzZXR0aW5ncy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvbWFjL0xvY2Fs ZU1hYy5oOgorICAgICAgICAoTG9jYWxlTWFjKToKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L21h Yy9Mb2NhbGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpsYW5ndWFnZUZyb21Mb2NhbGUpOiBN b3ZlZCB0byB0b3AuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmRldGVy bWluZUxvY2FsZSk6IE1vZGlmaWVkIHNvIGl0IHRha2VzIGEgbG9jYWxlIGFzIGFuIGFyZ3VtZW50 LgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxpemVyOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29y ZTo6TG9jYWxlTWFjOjpMb2NhbGVNYWMpOiBBZGRlZCBjaGVja3MgZm9yIGludmFsaWQgbG9jYWxl cyB0byB0aGlzIGNvbnN0cnVjdG9yIGFuZCByZW1vdmVkIHRoZSBvdGhlciBvbmUgc28gd2UgZG9u J3QgaGF2ZSBkdXBsaWNhdGVkIGNvZGUuCisgICAgICAgIChXZWJDb3JlOjpMb2NhbGVNYWM6OmNy ZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpMb2NhbGVNYWM6OmN1cnJlbnRMb2NhbGUpOgorCiAy MDEyLTA5LTI0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBSZWdyZXNzaW9uIGFmdGVyIHIxMjkzMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK aW5kZXggZWEzNGFlMDkzNjg1ZjUwMDhiNjU2MDQ1Yzg1OGE0Y2M0ODRjN2YxNy4uMTg3MTAxNjY0 Y2ExZjc3ODljZjBmN2IwZGVkNjUzMjk5YmY2ZWIzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0yNCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlA d2Via2l0Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFBhZ2UgcG9wdXAgZG9lc24ndCBjaGFu Z2UgbW91c2UgY3Vyc29yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NzQ1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEltcGxlbWVudCBQYWdlUG9wdXBDaHJvbWVDbGllbnQ6OnNldEN1cnNvci4KKworICAg ICAgICAqIHNyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcDoKKwogMjAxMi0wOS0yMyAgS2Vpc2hpIEhh dHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgc3VnZ2VzdGlvblBpY2tl ciB0byBDYWxlbmRhclBpY2tlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v dGV4dC9tYWMvTG9jYWxlTWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9M b2NhbGVNYWMuaAppbmRleCAyNmNhNmEyMjAyNDk4NTNmMjE0MTYyYWVmNmUwYTk5MGZmOWI3ZTUz Li4wZTQ4YzJlOTY5ODllN2I4NmYzMjYyYjA1NzU2ZDNhYzhhNzQ2NjY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMuaApAQCAtNDcsNiArNDcsNyBAQCBj bGFzcyBEYXRlQ29tcG9uZW50czsKIGNsYXNzIExvY2FsZU1hYyA6IHB1YmxpYyBMb2NhbGl6ZXIg ewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzT3duUHRyPExvY2FsZU1hYz4gY3JlYXRlKGNvbnN0 IFN0cmluZyYpOworICAgIHN0YXRpYyBQYXNzT3duUHRyPExvY2FsZU1hYz4gY3JlYXRlKE5TTG9j YWxlKik7CiAgICAgc3RhdGljIExvY2FsZU1hYyogY3VycmVudExvY2FsZSgpOwogICAgIH5Mb2Nh bGVNYWMoKTsKICAgICBkb3VibGUgcGFyc2VEYXRlKGNvbnN0IFN0cmluZyYpOwpAQCAtNjcsNyAr NjgsNiBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgTG9jYWxlTWFjKE5TTG9j YWxlKik7Ci0gICAgZXhwbGljaXQgTG9jYWxlTWFjKGNvbnN0IFN0cmluZyYpOwogICAgIE5TRGF0 ZUZvcm1hdHRlciAqY3JlYXRlU2hvcnREYXRlRm9ybWF0dGVyKCk7CiAgICAgdmlydHVhbCB2b2lk IGluaXRpYWxpemVMb2NhbGl6ZXJEYXRhKCkgT1ZFUlJJREU7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvbWFjL0xvY2FsZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvbWFjL0xvY2FsZU1hYy5tbQppbmRleCA5MWVjZTRkMDY1ZDMxOGZlOTQ4 MjdmYjQ2NGUzOTVhYzYyOWMxMTJjLi5lMzgxYzAyMmQ1NDJjNzZlMDc3MjVhMjM3YzZjNTA5NDhl MjZlNTNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2Nh bGVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFj Lm1tCkBAIC00NSw5ICs0NSwzMCBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKK3N0YXRpYyBpbmxpbmUgU3RyaW5nIGxhbmd1YWdlRnJvbUxvY2FsZShjb25z dCBTdHJpbmcmIGxvY2FsZSkKK3sKKyAgICBTdHJpbmcgbm9ybWFsaXplZExvY2FsZSA9IGxvY2Fs ZTsKKyAgICBub3JtYWxpemVkTG9jYWxlLnJlcGxhY2UoJy0nLCAnXycpOworICAgIHNpemVfdCBz ZXBhcmF0b3JQb3NpdGlvbiA9IG5vcm1hbGl6ZWRMb2NhbGUuZmluZCgnXycpOworICAgIGlmIChz ZXBhcmF0b3JQb3NpdGlvbiA9PSBub3RGb3VuZCkKKyAgICAgICAgcmV0dXJuIG5vcm1hbGl6ZWRM b2NhbGU7CisgICAgcmV0dXJuIG5vcm1hbGl6ZWRMb2NhbGUubGVmdChzZXBhcmF0b3JQb3NpdGlv bik7Cit9CisKK3N0YXRpYyBOU0xvY2FsZSogZGV0ZXJtaW5lTG9jYWxlKGNvbnN0IFN0cmluZyYg bG9jYWxlKQoreworICAgIE5TTG9jYWxlKiBjdXJyZW50TG9jYWxlID0gW05TTG9jYWxlIGN1cnJl bnRMb2NhbGVdOworICAgIFN0cmluZyBjdXJyZW50TG9jYWxlTGFuZ3VhZ2UgPSBsYW5ndWFnZUZy b21Mb2NhbGUoU3RyaW5nKFtjdXJyZW50TG9jYWxlIGxvY2FsZUlkZW50aWZpZXJdKSk7CisgICAg U3RyaW5nIGxvY2FsZUxhbmd1YWdlID0gbGFuZ3VhZ2VGcm9tTG9jYWxlKGxvY2FsZSk7CisgICAg aWYgKGVxdWFsSWdub3JpbmdDYXNlKGN1cnJlbnRMb2NhbGVMYW5ndWFnZSwgbG9jYWxlTGFuZ3Vh Z2UpKQorICAgICAgICByZXR1cm4gY3VycmVudExvY2FsZTsKKyAgICAvLyBJdCBzZWVtcyBpbml0 V2l0aExvY2FsZUlkZW50aWZpZXIgYWNjZXB0cyBkYXNoLXNlcGFyYXRlZCBsb2NhbGUgaWRlbnRp Zmllci4KKyAgICByZXR1cm4gW1tOU0xvY2FsZSBhbGxvY10gaW5pdFdpdGhMb2NhbGVJZGVudGlm aWVyOmxvY2FsZV07Cit9CisKIFBhc3NPd25QdHI8TG9jYWxpemVyPiBMb2NhbGl6ZXI6OmNyZWF0 ZShjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsZSkKIHsKLSAgICByZXR1cm4gTG9jYWxlTWFjOjpj cmVhdGUobG9jYWxlLnN0cmluZygpKTsKKyAgICByZXR1cm4gTG9jYWxlTWFjOjpjcmVhdGUoZGV0 ZXJtaW5lTG9jYWxlKGxvY2FsZS5zdHJpbmcoKSkpOwogfQogCiBzdGF0aWMgTlNEYXRlRm9ybWF0 dGVyKiBjcmVhdGVEYXRlVGltZUZvcm1hdHRlcihOU0xvY2FsZSogbG9jYWxlLCBOU0RhdGVGb3Jt YXR0ZXJTdHlsZSBkYXRlU3R5bGUsIE5TRGF0ZUZvcm1hdHRlclN0eWxlIHRpbWVTdHlsZSkKQEAg LTY1LDEyICs4Niw2IEBAIExvY2FsZU1hYzo6TG9jYWxlTWFjKE5TTG9jYWxlKiBsb2NhbGUpCiAg ICAgOiBtX2xvY2FsZShsb2NhbGUpCiAgICAgLCBtX2RpZEluaXRpYWxpemVOdW1iZXJEYXRhKGZh bHNlKQogewotfQotCi1Mb2NhbGVNYWM6OkxvY2FsZU1hYyhjb25zdCBTdHJpbmcmIGxvY2FsZUlk ZW50aWZpZXIpCi0gICAgOiBtX2xvY2FsZShbW05TTG9jYWxlIGFsbG9jXSBpbml0V2l0aExvY2Fs ZUlkZW50aWZpZXI6bG9jYWxlSWRlbnRpZmllcl0pCi0gICAgLCBtX2RpZEluaXRpYWxpemVOdW1i ZXJEYXRhKGZhbHNlKQotewogICAgIE5TQXJyYXkqIGF2YWlsYWJsZUxhbmd1YWdlcyA9IFtOU0xv Y2FsZSBJU09MYW5ndWFnZUNvZGVzXTsKICAgICAvLyBOU0xvY2FsZSByZXR1cm5zIGEgbG93ZXIg Y2FzZSBOU0xvY2FsZUxhbmd1YWdlQ29kZSBzbyB3ZSBkb24ndCBoYXZlIGNhcmUgYWJvdXQgY2Fz ZS4KICAgICBOU1N0cmluZyogbGFuZ3VhZ2UgPSBbbV9sb2NhbGUuZ2V0KCkgb2JqZWN0Rm9yS2V5 Ok5TTG9jYWxlTGFuZ3VhZ2VDb2RlXTsKQEAgLTg0LDMzICs5OSwxNyBAQCBMb2NhbGVNYWM6On5M b2NhbGVNYWMoKQogCiBQYXNzT3duUHRyPExvY2FsZU1hYz4gTG9jYWxlTWFjOjpjcmVhdGUoY29u c3QgU3RyaW5nJiBsb2NhbGVJZGVudGlmaWVyKQogewotICAgIHJldHVybiBhZG9wdFB0cihuZXcg TG9jYWxlTWFjKGxvY2FsZUlkZW50aWZpZXIpKTsKKyAgICByZXR1cm4gYWRvcHRQdHIobmV3IExv Y2FsZU1hYyhbW05TTG9jYWxlIGFsbG9jXSBpbml0V2l0aExvY2FsZUlkZW50aWZpZXI6bG9jYWxl SWRlbnRpZmllcl0pKTsKIH0KIAotc3RhdGljIGlubGluZSBTdHJpbmcgbGFuZ3VhZ2VGcm9tTG9j YWxlKGNvbnN0IFN0cmluZyYgbG9jYWxlKQorUGFzc093blB0cjxMb2NhbGVNYWM+IExvY2FsZU1h Yzo6Y3JlYXRlKE5TTG9jYWxlKiBsb2NhbGUpCiB7Ci0gICAgU3RyaW5nIG5vcm1hbGl6ZWRMb2Nh bGUgPSBsb2NhbGU7Ci0gICAgbm9ybWFsaXplZExvY2FsZS5yZXBsYWNlKCctJywgJ18nKTsKLSAg ICBzaXplX3Qgc2VwYXJhdG9yUG9zaXRpb24gPSBub3JtYWxpemVkTG9jYWxlLmZpbmQoJ18nKTsK LSAgICBpZiAoc2VwYXJhdG9yUG9zaXRpb24gPT0gbm90Rm91bmQpCi0gICAgICAgIHJldHVybiBu b3JtYWxpemVkTG9jYWxlOwotICAgIHJldHVybiBub3JtYWxpemVkTG9jYWxlLmxlZnQoc2VwYXJh dG9yUG9zaXRpb24pOwotfQotCi1zdGF0aWMgTlNMb2NhbGUqIGRldGVybWluZUxvY2FsZSgpCi17 Ci0gICAgTlNMb2NhbGUqIGN1cnJlbnRMb2NhbGUgPSBbTlNMb2NhbGUgY3VycmVudExvY2FsZV07 Ci0gICAgU3RyaW5nIGN1cnJlbnRMb2NhbGVMYW5ndWFnZSA9IGxhbmd1YWdlRnJvbUxvY2FsZShT dHJpbmcoW2N1cnJlbnRMb2NhbGUgbG9jYWxlSWRlbnRpZmllcl0pKTsKLSAgICBTdHJpbmcgYnJv d3Nlckxhbmd1YWdlID0gbGFuZ3VhZ2VGcm9tTG9jYWxlKGRlZmF1bHRMYW5ndWFnZSgpKTsKLSAg ICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UoY3VycmVudExvY2FsZUxhbmd1YWdlLCBicm93c2VyTGFu Z3VhZ2UpKQotICAgICAgICByZXR1cm4gY3VycmVudExvY2FsZTsKLSAgICAvLyBJdCBzZWVtcyBp bml0V2l0aExvY2FsZUlkZW50aWZpZXIgYWNjZXB0cyBkYXNoLXNlcGFyYXRlZCBsb2NhbGUgaWRl bnRpZmllci4KLSAgICByZXR1cm4gW1tOU0xvY2FsZSBhbGxvY10gaW5pdFdpdGhMb2NhbGVJZGVu dGlmaWVyOmRlZmF1bHRMYW5ndWFnZSgpXTsKKyAgICByZXR1cm4gYWRvcHRQdHIobmV3IExvY2Fs ZU1hYyhsb2NhbGUpKTsKIH0KIAogTG9jYWxlTWFjKiBMb2NhbGVNYWM6OmN1cnJlbnRMb2NhbGUo KQogewotICAgIHN0YXRpYyBMb2NhbGVNYWMqIGN1cnJlbnRMb2NhbGUgPSBuZXcgTG9jYWxlTWFj KGRldGVybWluZUxvY2FsZSgpKTsKKyAgICBzdGF0aWMgTG9jYWxlTWFjKiBjdXJyZW50TG9jYWxl ID0gbmV3IExvY2FsZU1hYyhkZXRlcm1pbmVMb2NhbGUoZGVmYXVsdExhbmd1YWdlKCkpKTsKICAg ICByZXR1cm4gY3VycmVudExvY2FsZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAppbmRleCA5ODBmODFhOGFiMGVkYmUzNGU2NTcyZWY2 ZjdlYjlhYjY0MDYyMzM4Li4yYzE1ZmRiMWU0ZTFkYmU2NDAwZDZhMDVkMjZjZTA0NTU1YzRjZjBl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNw cApAQCAtNDIsOCArNDIsMTAgQEAKICNpbmNsdWRlICJQYWdlUG9wdXBDbGllbnQuaCIKICNpbmNs dWRlICJQYWdlV2lkZ2V0RGVsZWdhdGUuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgorI2luY2x1 ZGUgIldlYkN1cnNvckluZm8uaCIKICNpbmNsdWRlICJXZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5o IgogI2luY2x1ZGUgIldlYlBhZ2VQb3B1cC5oIgorI2luY2x1ZGUgIldlYlZpZXdDbGllbnQuaCIK ICNpbmNsdWRlICJXZWJWaWV3SW1wbC5oIgogI2luY2x1ZGUgIldlYldpZGdldENsaWVudC5oIgog CkBAIC0xMjQsNiArMTI2LDEyIEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiBGbG9hdFNpemUo MCwgMCk7CiAgICAgfQogCisgICAgdmlydHVhbCB2b2lkIHNldEN1cnNvcihjb25zdCBDdXJzb3Im IGN1cnNvcikgT1ZFUlJJREUKKyAgICB7CisgICAgICAgIGlmIChtX3BvcHVwLT5tX3dlYlZpZXct PmNsaWVudCgpKQorICAgICAgICAgICAgbV9wb3B1cC0+bV93ZWJWaWV3LT5jbGllbnQoKS0+ZGlk Q2hhbmdlQ3Vyc29yKFdlYkN1cnNvckluZm8oY3Vyc29yKSk7CisgICAgfQorCiAgICAgV2ViUGFn ZVBvcHVwSW1wbCogbV9wb3B1cDsKIH07CiAK 165518 2012-09-24 21:50:12 -0700 2012-09-25 09:31:25 -0700 Patch bug-97517-20120925134932.patch text/plain 5856 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVlOTQwN2M1YjMwM2Ix ZjA3YTc4NWY1OTZiMDYyNjhjZmQ1MTc0ZS4uNjg0ZDUwNDU4YTI5NWJiMmE5MjA5MjJkMTg0OWIy YTYxODE1OGI1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTI0ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEy OTQ0OCk6IG11bHRpcGxlIGZpZWxkcyB0aW1lIGlucHV0IFVJIGRvZXNuJ3QgdXNlIHN5c3RlbSB0 aW1lIGZvcm1hdCBzZXR0aW5ncyBvbiBDaHJvbWl1bS1NYWMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBsb2NhbGUgW05TTG9jYWxlIGN1 cnJlbnRMb2NhbGVdIGlmIGJyb3dzZXIgbGFuZ3VhZ2UvQGxhbmcgZXF1YWxzIFtbTlNMb2NhbCBj dXJyZW50TG9jYWxlXSBsb2NhbGVJZGVudGlmaWVyXS4gT3RoZXJ3aXNlIGl0IHdvbid0IHVzZSB0 aGUgY3VzdG9tIHRpbWUgZm9ybWF0IHRoYXQgdGhlIHVzZXIgaGFzIHNldC4KKworICAgICAgICBO byBuZXcgdGVzdHMuIFVuYWJsZSB0byB0ZXN0IGJlY2F1c2Ugd2UgbmVlZCB0byBjaGFuZ2Ugc3lz dGVtIGxvY2FsZSBzZXR0aW5ncy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvbWFjL0xvY2Fs ZU1hYy5oOgorICAgICAgICAoTG9jYWxlTWFjKToKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L21h Yy9Mb2NhbGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpsYW5ndWFnZUZyb21Mb2NhbGUpOiBN b3ZlZCB0byB0b3AuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmRldGVy bWluZUxvY2FsZSk6IE1vZGlmaWVkIHNvIGl0IHRha2VzIGEgbG9jYWxlIGFzIGFuIGFyZ3VtZW50 LgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxpemVyOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29y ZTo6TG9jYWxlTWFjOjpMb2NhbGVNYWMpOiBBZGRlZCBjaGVja3MgZm9yIGludmFsaWQgbG9jYWxl cyB0byB0aGlzIGNvbnN0cnVjdG9yIGFuZCByZW1vdmVkIHRoZSBvdGhlciBvbmUgc28gd2UgZG9u J3QgaGF2ZSBkdXBsaWNhdGVkIGNvZGUuCisgICAgICAgIChXZWJDb3JlOjpMb2NhbGVNYWM6OmNy ZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpMb2NhbGVNYWM6OmN1cnJlbnRMb2NhbGUpOgorCiAy MDEyLTA5LTI0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBSZWdyZXNzaW9uIGFmdGVyIHIxMjkzMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3RleHQvbWFjL0xvY2FsZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKaW5kZXggMjZjYTZhMjIwMjQ5ODUzZjIxNDE2MmFlZjZl MGE5OTBmZjliN2U1My4uMGU0OGMyZTk2OTg5ZTdiODZmMzI2MmIwNTc1NmQzYWM4YTc0NjY2OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKQEAgLTQ3 LDYgKzQ3LDcgQEAgY2xhc3MgRGF0ZUNvbXBvbmVudHM7CiBjbGFzcyBMb2NhbGVNYWMgOiBwdWJs aWMgTG9jYWxpemVyIHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc093blB0cjxMb2NhbGVNYWM+ IGNyZWF0ZShjb25zdCBTdHJpbmcmKTsKKyAgICBzdGF0aWMgUGFzc093blB0cjxMb2NhbGVNYWM+ IGNyZWF0ZShOU0xvY2FsZSopOwogICAgIHN0YXRpYyBMb2NhbGVNYWMqIGN1cnJlbnRMb2NhbGUo KTsKICAgICB+TG9jYWxlTWFjKCk7CiAgICAgZG91YmxlIHBhcnNlRGF0ZShjb25zdCBTdHJpbmcm KTsKQEAgLTY3LDcgKzY4LDYgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IExv Y2FsZU1hYyhOU0xvY2FsZSopOwotICAgIGV4cGxpY2l0IExvY2FsZU1hYyhjb25zdCBTdHJpbmcm KTsKICAgICBOU0RhdGVGb3JtYXR0ZXIgKmNyZWF0ZVNob3J0RGF0ZUZvcm1hdHRlcigpOwogICAg IHZpcnR1YWwgdm9pZCBpbml0aWFsaXplTG9jYWxpemVyRGF0YSgpIE9WRVJSSURFOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0KaW5kZXggOTFlY2U0 ZDA2NWQzMThmZTk0ODI3ZmI0NjRlMzk1YWM2MjljMTEyYy4uZTM4MWMwMjJkNTQyYzc2ZTA3NzI1 YTIzN2M2YzUwOTQ4ZTI2ZTUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v dGV4dC9tYWMvTG9jYWxlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv bWFjL0xvY2FsZU1hYy5tbQpAQCAtNDUsOSArNDUsMzAgQEAgdXNpbmcgbmFtZXNwYWNlIHN0ZDsK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitzdGF0aWMgaW5saW5lIFN0cmluZyBsYW5ndWFnZUZy b21Mb2NhbGUoY29uc3QgU3RyaW5nJiBsb2NhbGUpCit7CisgICAgU3RyaW5nIG5vcm1hbGl6ZWRM b2NhbGUgPSBsb2NhbGU7CisgICAgbm9ybWFsaXplZExvY2FsZS5yZXBsYWNlKCctJywgJ18nKTsK KyAgICBzaXplX3Qgc2VwYXJhdG9yUG9zaXRpb24gPSBub3JtYWxpemVkTG9jYWxlLmZpbmQoJ18n KTsKKyAgICBpZiAoc2VwYXJhdG9yUG9zaXRpb24gPT0gbm90Rm91bmQpCisgICAgICAgIHJldHVy biBub3JtYWxpemVkTG9jYWxlOworICAgIHJldHVybiBub3JtYWxpemVkTG9jYWxlLmxlZnQoc2Vw YXJhdG9yUG9zaXRpb24pOworfQorCitzdGF0aWMgTlNMb2NhbGUqIGRldGVybWluZUxvY2FsZShj b25zdCBTdHJpbmcmIGxvY2FsZSkKK3sKKyAgICBOU0xvY2FsZSogY3VycmVudExvY2FsZSA9IFtO U0xvY2FsZSBjdXJyZW50TG9jYWxlXTsKKyAgICBTdHJpbmcgY3VycmVudExvY2FsZUxhbmd1YWdl ID0gbGFuZ3VhZ2VGcm9tTG9jYWxlKFN0cmluZyhbY3VycmVudExvY2FsZSBsb2NhbGVJZGVudGlm aWVyXSkpOworICAgIFN0cmluZyBsb2NhbGVMYW5ndWFnZSA9IGxhbmd1YWdlRnJvbUxvY2FsZShs b2NhbGUpOworICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShjdXJyZW50TG9jYWxlTGFuZ3VhZ2Us IGxvY2FsZUxhbmd1YWdlKSkKKyAgICAgICAgcmV0dXJuIGN1cnJlbnRMb2NhbGU7CisgICAgLy8g SXQgc2VlbXMgaW5pdFdpdGhMb2NhbGVJZGVudGlmaWVyIGFjY2VwdHMgZGFzaC1zZXBhcmF0ZWQg bG9jYWxlIGlkZW50aWZpZXIuCisgICAgcmV0dXJuIFtbTlNMb2NhbGUgYWxsb2NdIGluaXRXaXRo TG9jYWxlSWRlbnRpZmllcjpsb2NhbGVdOworfQorCiBQYXNzT3duUHRyPExvY2FsaXplcj4gTG9j YWxpemVyOjpjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbGUpCiB7Ci0gICAgcmV0dXJu IExvY2FsZU1hYzo6Y3JlYXRlKGxvY2FsZS5zdHJpbmcoKSk7CisgICAgcmV0dXJuIExvY2FsZU1h Yzo6Y3JlYXRlKGRldGVybWluZUxvY2FsZShsb2NhbGUuc3RyaW5nKCkpKTsKIH0KIAogc3RhdGlj IE5TRGF0ZUZvcm1hdHRlciogY3JlYXRlRGF0ZVRpbWVGb3JtYXR0ZXIoTlNMb2NhbGUqIGxvY2Fs ZSwgTlNEYXRlRm9ybWF0dGVyU3R5bGUgZGF0ZVN0eWxlLCBOU0RhdGVGb3JtYXR0ZXJTdHlsZSB0 aW1lU3R5bGUpCkBAIC02NSwxMiArODYsNiBAQCBMb2NhbGVNYWM6OkxvY2FsZU1hYyhOU0xvY2Fs ZSogbG9jYWxlKQogICAgIDogbV9sb2NhbGUobG9jYWxlKQogICAgICwgbV9kaWRJbml0aWFsaXpl TnVtYmVyRGF0YShmYWxzZSkKIHsKLX0KLQotTG9jYWxlTWFjOjpMb2NhbGVNYWMoY29uc3QgU3Ry aW5nJiBsb2NhbGVJZGVudGlmaWVyKQotICAgIDogbV9sb2NhbGUoW1tOU0xvY2FsZSBhbGxvY10g aW5pdFdpdGhMb2NhbGVJZGVudGlmaWVyOmxvY2FsZUlkZW50aWZpZXJdKQotICAgICwgbV9kaWRJ bml0aWFsaXplTnVtYmVyRGF0YShmYWxzZSkKLXsKICAgICBOU0FycmF5KiBhdmFpbGFibGVMYW5n dWFnZXMgPSBbTlNMb2NhbGUgSVNPTGFuZ3VhZ2VDb2Rlc107CiAgICAgLy8gTlNMb2NhbGUgcmV0 dXJucyBhIGxvd2VyIGNhc2UgTlNMb2NhbGVMYW5ndWFnZUNvZGUgc28gd2UgZG9uJ3QgaGF2ZSBj YXJlIGFib3V0IGNhc2UuCiAgICAgTlNTdHJpbmcqIGxhbmd1YWdlID0gW21fbG9jYWxlLmdldCgp IG9iamVjdEZvcktleTpOU0xvY2FsZUxhbmd1YWdlQ29kZV07CkBAIC04NCwzMyArOTksMTcgQEAg TG9jYWxlTWFjOjp+TG9jYWxlTWFjKCkKIAogUGFzc093blB0cjxMb2NhbGVNYWM+IExvY2FsZU1h Yzo6Y3JlYXRlKGNvbnN0IFN0cmluZyYgbG9jYWxlSWRlbnRpZmllcikKIHsKLSAgICByZXR1cm4g YWRvcHRQdHIobmV3IExvY2FsZU1hYyhsb2NhbGVJZGVudGlmaWVyKSk7CisgICAgcmV0dXJuIGFk b3B0UHRyKG5ldyBMb2NhbGVNYWMoW1tOU0xvY2FsZSBhbGxvY10gaW5pdFdpdGhMb2NhbGVJZGVu dGlmaWVyOmxvY2FsZUlkZW50aWZpZXJdKSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgU3RyaW5nIGxh bmd1YWdlRnJvbUxvY2FsZShjb25zdCBTdHJpbmcmIGxvY2FsZSkKK1Bhc3NPd25QdHI8TG9jYWxl TWFjPiBMb2NhbGVNYWM6OmNyZWF0ZShOU0xvY2FsZSogbG9jYWxlKQogewotICAgIFN0cmluZyBu b3JtYWxpemVkTG9jYWxlID0gbG9jYWxlOwotICAgIG5vcm1hbGl6ZWRMb2NhbGUucmVwbGFjZSgn LScsICdfJyk7Ci0gICAgc2l6ZV90IHNlcGFyYXRvclBvc2l0aW9uID0gbm9ybWFsaXplZExvY2Fs ZS5maW5kKCdfJyk7Ci0gICAgaWYgKHNlcGFyYXRvclBvc2l0aW9uID09IG5vdEZvdW5kKQotICAg ICAgICByZXR1cm4gbm9ybWFsaXplZExvY2FsZTsKLSAgICByZXR1cm4gbm9ybWFsaXplZExvY2Fs ZS5sZWZ0KHNlcGFyYXRvclBvc2l0aW9uKTsKLX0KLQotc3RhdGljIE5TTG9jYWxlKiBkZXRlcm1p bmVMb2NhbGUoKQotewotICAgIE5TTG9jYWxlKiBjdXJyZW50TG9jYWxlID0gW05TTG9jYWxlIGN1 cnJlbnRMb2NhbGVdOwotICAgIFN0cmluZyBjdXJyZW50TG9jYWxlTGFuZ3VhZ2UgPSBsYW5ndWFn ZUZyb21Mb2NhbGUoU3RyaW5nKFtjdXJyZW50TG9jYWxlIGxvY2FsZUlkZW50aWZpZXJdKSk7Ci0g ICAgU3RyaW5nIGJyb3dzZXJMYW5ndWFnZSA9IGxhbmd1YWdlRnJvbUxvY2FsZShkZWZhdWx0TGFu Z3VhZ2UoKSk7Ci0gICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGN1cnJlbnRMb2NhbGVMYW5ndWFn ZSwgYnJvd3Nlckxhbmd1YWdlKSkKLSAgICAgICAgcmV0dXJuIGN1cnJlbnRMb2NhbGU7Ci0gICAg Ly8gSXQgc2VlbXMgaW5pdFdpdGhMb2NhbGVJZGVudGlmaWVyIGFjY2VwdHMgZGFzaC1zZXBhcmF0 ZWQgbG9jYWxlIGlkZW50aWZpZXIuCi0gICAgcmV0dXJuIFtbTlNMb2NhbGUgYWxsb2NdIGluaXRX aXRoTG9jYWxlSWRlbnRpZmllcjpkZWZhdWx0TGFuZ3VhZ2UoKV07CisgICAgcmV0dXJuIGFkb3B0 UHRyKG5ldyBMb2NhbGVNYWMobG9jYWxlKSk7CiB9CiAKIExvY2FsZU1hYyogTG9jYWxlTWFjOjpj dXJyZW50TG9jYWxlKCkKIHsKLSAgICBzdGF0aWMgTG9jYWxlTWFjKiBjdXJyZW50TG9jYWxlID0g bmV3IExvY2FsZU1hYyhkZXRlcm1pbmVMb2NhbGUoKSk7CisgICAgc3RhdGljIExvY2FsZU1hYyog Y3VycmVudExvY2FsZSA9IG5ldyBMb2NhbGVNYWMoZGV0ZXJtaW5lTG9jYWxlKGRlZmF1bHRMYW5n dWFnZSgpKSk7CiAgICAgcmV0dXJuIGN1cnJlbnRMb2NhbGU7CiB9CiAK