97509 2012-09-24 18:29:30 -0700 [GTK][EFL] Remove cairo prefix from include statements 2012-09-24 20:55:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Cairo, Gtk P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim mrobinson rakuco webkit.review.bot oldest_to_newest 727157 0 laszlo.gombos 2012-09-24 18:29:30 -0700 It seems that most source files include cairo headers (e.g. cairo.h) assuming that the directory that contains the cairo header file are in the include path (which is indeed the case); however a few source files include cairo headers with a cairo prefix (e.g. cairo/cairo.h). This makes the build system unnecessary inconsistent, and in my case led to a build failure. 727180 1 165496 laszlo.gombos 2012-09-24 18:44:09 -0700 Created attachment 165496 first try 727227 2 165496 gyuyoung.kim 2012-09-24 20:23:44 -0700 Comment on attachment 165496 first try Looks fine. 727237 3 165496 webkit.review.bot 2012-09-24 20:55:07 -0700 Comment on attachment 165496 first try Clearing flags on attachment: 165496 Committed r129450: <http://trac.webkit.org/changeset/129450> 727238 4 webkit.review.bot 2012-09-24 20:55:11 -0700 All reviewed patches have been landed. Closing bug. 165496 2012-09-24 18:44:09 -0700 2012-09-24 20:55:07 -0700 first try 97509.patch text/plain 4195 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTQ0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTI0ICBMYXN6bG8g R29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS11bRUZMXSBSZW1v dmUgY2Fpcm8gcHJlZml4IGZyb20gaW5jbHVkZSBzdGF0ZW1lbnRzIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc1MDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBidWlsZCBzeXN0ZW0gY29u c2lzdGVudCBieSBhbHdheXMgYXNzdW1pbmcgdGhhdCBkaXJlY3RvcnkKKyAgICAgICAgdGhhdCBp bmNsdWRlcyB0aGUgY2Fpcm8gaGVhZGVycyBpcyBpbmNsdWRlZCBpbiB0aGUgaW5jbHVkZSBwYXRo LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBpcyBubyBuZXcgZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHBsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZUNhaXJvLmNw cDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR3RrV2lkZ2V0QmFja2luZ1N0b3JlWDExLmNwcDoK KyAgICAgICAgKiBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcDoKKwogMjAxMi0wOS0yNCAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdMXSBJbnRlbCBN YWMgbmVlZHMgYnVpbHQtaW4gZnVuY3Rpb24gZW11bGF0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVDYWlyby5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8u Y3BwCShyZXZpc2lvbiAxMjkxMzkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9X aWRnZXRCYWNraW5nU3RvcmVDYWlyby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyLDcgKzIyLDcg QEAKIAogI2luY2x1ZGUgIkNhaXJvVXRpbGl0aWVzLmgiCiAjaW5jbHVkZSAiUmVmUHRyQ2Fpcm8u aCIKLSNpbmNsdWRlIDxjYWlyby9jYWlyby5oPgorI2luY2x1ZGUgPGNhaXJvLmg+CiAKICNpZiBQ TEFURk9STShHVEspCiAjaW5jbHVkZSAiR3RrVmVyc2lvbmluZy5oIgpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1dpZGdldEJhY2tpbmdTdG9yZVgxMS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1dpZGdldEJhY2tpbmdTdG9yZVgx MS5jcHAJKHJldmlzaW9uIDEyOTEzOSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9H dGtXaWRnZXRCYWNraW5nU3RvcmVYMTEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw4ICsyMiw4 IEBACiAjaW5jbHVkZSAiR3RrVmVyc2lvbmluZy5oIgogI2luY2x1ZGUgIlJlZlB0ckNhaXJvLmgi CiAjaW5jbHVkZSA8WDExL1hsaWIuaD4KLSNpbmNsdWRlIDxjYWlyby9jYWlyby14bGliLmg+Ci0j aW5jbHVkZSA8Y2Fpcm8vY2Fpcm8uaD4KKyNpbmNsdWRlIDxjYWlyby14bGliLmg+CisjaW5jbHVk ZSA8Y2Fpcm8uaD4KICNpbmNsdWRlIDxnZGsvZ2RreC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAko cmV2aXNpb24gMTI5MTM5KQorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmll d0d0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2LDcgKzc2LDcgQEAKICNkZWZpbmUgQm9vbCBp bnQgLy8gdGhpcyBnb3QgdW5kZWZpbmVkIHNvbWV3aGVyZQogI2RlZmluZSBTdGF0dXMgaW50IC8v IGRpdHRvCiAjaW5jbHVkZSA8WDExL2V4dGVuc2lvbnMvWHJlbmRlci5oPgotI2luY2x1ZGUgPGNh aXJvL2NhaXJvLXhsaWIuaD4KKyNpbmNsdWRlIDxjYWlyby14bGliLmg+CiAjaW5jbHVkZSA8Z2Rr L2dka3guaD4KIAogdXNpbmcgSlNDOjpFeGVjU3RhdGU7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lv biAxMjk0NDApCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNiBAQAorMjAxMi0wOS0yNCAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtHVEtdW0VGTF0gUmVtb3ZlIGNhaXJvIHByZWZpeCBmcm9tIGlu Y2x1ZGUgc3RhdGVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTc1MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIHRoZSBidWlsZCBzeXN0ZW0gY29uc2lzdGVudCBieSBhbHdheXMgYXNzdW1p bmcgdGhhdCBkaXJlY3RvcnkgCisgICAgICAgIHRoYXQgaW5jbHVkZXMgdGhlIGNhaXJvIGhlYWRl cnMgaXMgaW5jbHVkZWQgaW4gdGhlIGluY2x1ZGUgcGF0aC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9jYWlyby9CYWNraW5nU3RvcmVDYWlyby5jcHA6CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHA6CisKIDIwMTItMDktMjQgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjkzODguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvY2Fpcm8vQmFja2luZ1N0b3JlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9jYWlyby9CYWNraW5nU3RvcmVDYWlyby5jcHAJKHJldmlzaW9uIDEyOTEz OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9jYWlyby9CYWNraW5nU3RvcmVDYWlyby5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAKICNpbmNsdWRlICJVcGRhdGVJbmZv LmgiCiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGlj c0NvbnRleHQuaD4KLSNpbmNsdWRlIDxjYWlyby9jYWlyby5oPgorI2luY2x1ZGUgPGNhaXJvLmg+ CiAKICNpZiBQTEFURk9STShFRkwpCiAjaW5jbHVkZSAiZXdrX3ZpZXdfcHJpdmF0ZS5oIgpJbmRl eDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2Fw ZVBsdWdpblgxMS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAJKHJldmlzaW9uIDEyOTEz OSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0 c2NhcGVQbHVnaW5YMTEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBACiAjZWxp ZiBQTEFURk9STShHVEspCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0Q2Fpcm8uaCIKICNpbmNs dWRlICJSZWZQdHJDYWlyby5oIgotI2luY2x1ZGUgPGNhaXJvL2NhaXJvLXhsaWIuaD4KKyNpbmNs dWRlIDxjYWlyby14bGliLmg+CiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgogI2lmbmRlZiBHVEtfQVBJ X1ZFUlNJT05fMgogI2luY2x1ZGUgPGd0ay9ndGt4Lmg+Cg==