97502 2012-09-24 17:15:56 -0700 JSC: add a debugging utility for the C++ llint backend. 2012-09-24 17:39:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren oldest_to_newest 727106 0 mark.lam 2012-09-24 17:15:56 -0700 Added the "cloopDo" instruction that can be used to insert instrumentation in the llint generated code. For example, when debugging, we can add the following into a llint ASM file: cloopDo // printf("I was here!!!\n"); The llint C++ backend will insert whatever is in the // comment as a C++ statement into the generated LLIntAssembly.h file at the location where we insert this cloopDo instruction into the llint ASM instruction stream. cloopDo instructions should only be used for debugging the C++ llint. They should not be left in the llint ASM file when we're done debugging. Support for the cloopDo instruction is left enabled by default for convenience. It does not affect the produced code if not used. 727112 1 165474 mark.lam 2012-09-24 17:20:30 -0700 Created attachment 165474 Fix. 727114 2 165474 ggaren 2012-09-24 17:26:18 -0700 Comment on attachment 165474 Fix. View in context: https://bugs.webkit.org/attachment.cgi?id=165474&action=review r=me > Source/JavaScriptCore/offlineasm/parser.rb:107 > + # We need to parse annotations regardless of whether the backend does > + # anything with them or not. This comment should explain why. 727123 3 mark.lam 2012-09-24 17:39:38 -0700 (In reply to comment #2) > > Source/JavaScriptCore/offlineasm/parser.rb:107 > > + # We need to parse annotations regardless of whether the backend does > > + # anything with them or not. > > This comment should explain why. The comment has been updated. Landed in http://trac.webkit.org/changeset/129434. 165474 2012-09-24 17:20:30 -0700 2012-09-24 17:26:17 -0700 Fix. bug-97502.patch text/plain 3507 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NDMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA5LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgY2xvb3BEbyBpbnN0cnVjdGlvbiBmb3IgZGVidWdnaW5nIHRoZSBsbGludCBDKysgYmFja2Vu ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NTAy LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2Zm bGluZWFzbS9jbG9vcC5yYjoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYjoK KyAgICAgICAgKiBvZmZsaW5lYXNtL3BhcnNlci5yYjoKKwogMjAxMi0wOS0yNCAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgYSBtaXNzaW5nICJpZiBWQUxV RV9QUk9GSUxFUiIgYXJvdW5kIGFuIGFjY2VzcyB0byBBcnJheVByb2ZpbGUgcmVjb3JkLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIJKHJldmlzaW9uIDEy OTQyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCSh3b3Jr aW5nIGNvcHkpCkBAIC01MDcsNyArNTA3LDcgQEAgZW5kCiBjbGFzcyBJbnN0cnVjdGlvbgogICAg IGRlZiBsb3dlckNfTE9PUAogICAgICAgICAkYXNtLmNvZGVPcmlnaW4gY29kZU9yaWdpblN0cmlu ZyBpZiAkZW5hYmxlQ29kZU9yaWdpbkNvbW1lbnRzCi0gICAgICAgICRhc20uYW5ub3RhdGlvbiBh bm5vdGF0aW9uIGlmICRlbmFibGVJbnN0ckFubm90YXRpb25zCisgICAgICAgICRhc20uYW5ub3Rh dGlvbiBhbm5vdGF0aW9uIGlmICRlbmFibGVJbnN0ckFubm90YXRpb25zICYmIChvcGNvZGUgIT0g ImNsb29wRG8iKQogCiAgICAgICAgIGNhc2Ugb3Bjb2RlCiAgICAgICAgIHdoZW4gImFkZGkiCkBA IC05ODEsNiArOTgxLDEyIEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHdoZW4gImNsb29w Q2FsbFNsb3dQYXRoIgogICAgICAgICAgICAgY2xvb3BFbWl0Q2FsbFNsb3dQYXRoKG9wZXJhbmRz KQogCisgICAgICAgICMgRm9yIGRlYnVnZ2luZyBvbmx5LiBUaGlzIGlzIHVzZWQgdG8gaW5zZXJ0 IGluc3RydW1lbnRhdGlvbiBpbnRvIHRoZQorICAgICAgICAjIGdlbmVyYXRlZCBMTEludEFzc2Vt Ymx5LmggZHVyaW5nIGxsaW50IGRldmVsb3BtZW50IG9ubHkuIERvIG5vdCB1c2UKKyAgICAgICAg IyBmb3IgcHJvZHVjdGlvbiBjb2RlLgorICAgICAgICB3aGVuICJjbG9vcERvIgorICAgICAgICAg ICAgJGFzbS5wdXRjICIje2Fubm90YXRpb259IgorCiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IGxvd2VyRGVmYXVsdAogICAgICAgICBlbmQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9v ZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIJKHJldmlzaW9uIDEyOTQyNikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgkod29ya2luZyBj b3B5KQpAQCAtMjI3LDYgKzIyNywxNCBAQCBDWFhfSU5TVFJVQ1RJT05TID0KICAgICAgImNsb29w Q2FsbEpTRnVuY3Rpb24iLCAgIyBvcGVyYW5kczogY2FsbGVlCiAgICAgICJjbG9vcENhbGxOYXRp dmUiLCAgICAgICMgb3BlcmFuZHM6IGNhbGxlZQogICAgICAiY2xvb3BDYWxsU2xvd1BhdGgiLCAg ICAjIG9wZXJhbmRzOiBjYWxsVGFyZ2V0LCBjdXJyZW50RnJhbWUsIGN1cnJlbnRQQworCisgICAg ICMgRm9yIGRlYnVnZ2luZyBvbmx5OgorICAgICAjIFRha2VzIG5vIG9wZXJhbmRzIGJ1dCBzaW1w bHkgZW1pdHMgd2hhdGV2ZXIgZm9sbG93cyBpbiAvLyBjb21tZW50cyBhcworICAgICAjIGEgbGlu ZSBvZiBDKysgY29kZSBpbiB0aGUgZ2VuZXJhdGVkIExMSW50QXNzZW1ibHkuaCBmaWxlLiBUaGlz IGNhbiBiZQorICAgICAjIHVzZWQgdG8gaW5zZXJ0IGluc3RydW1lbnRhdGlvbiBpbnRvIHRoZSBp bnRlcnByZXRlciBsb29wIHRvIGluc3BlY3QKKyAgICAgIyB2YXJpYWJsZXMgb2YgaW50ZXJlc3Qu IERvIG5vdCBsZWF2ZSB0aGVzZSBpbnN0cnVjdGlvbnMgaW4gcHJvZHVjdGlvbgorICAgICAjIGNv ZGUuCisgICAgICJjbG9vcERvIiwgICAgICAgICAgICAgICMgbm8gb3BlcmFuZHMKICAgICBdCiAK IElOU1RSVUNUSU9OUyA9IE1BQ1JPX0lOU1RSVUNUSU9OUyArIFg4Nl9JTlNUUlVDVElPTlMgKyBB Uk12N19JTlNUUlVDVElPTlMgKyBDWFhfSU5TVFJVQ1RJT05TCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20vcGFyc2VyLnJiCShyZXZpc2lvbiAxMjk0MjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIJKHdvcmtpbmcgY29weSkKQEAg LTEwMyw3ICsxMDMsOSBAQCBkZWYgbGV4KHN0ciwgZmlsZU5hbWUpCiAgICAgICAgICAgICBhbm5v dGF0aW9uVHlwZSA9IHdoaXRlc3BhY2VGb3VuZCA/IDpsb2NhbCA6IDpnbG9iYWwKICAgICAgICAg d2hlbiAvXEFcbi8KICAgICAgICAgICAgICMgV2UndmUgZm91bmQgYSAnXG4nLiAgRW1pdCB0aGUg bGFzdCBjb21tZW50IHJlY29yZGVkIGlmIGFwcHJvcHJpYXRlOgotICAgICAgICAgICAgaWYgJGVu YWJsZUluc3RyQW5ub3RhdGlvbnMgYW5kIGFubm90YXRpb24KKyAgICAgICAgICAgICMgV2UgbmVl ZCB0byBwYXJzZSBhbm5vdGF0aW9ucyByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlIGJhY2tlbmQg ZG9lcworICAgICAgICAgICAgIyBhbnl0aGluZyB3aXRoIHRoZW0gb3Igbm90LgorICAgICAgICAg ICAgaWYgYW5ub3RhdGlvbgogICAgICAgICAgICAgICAgIHJlc3VsdCA8PCBBbm5vdGF0aW9uLm5l dyhDb2RlT3JpZ2luLm5ldyhmaWxlTmFtZSwgbGluZU51bWJlciksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFubm90YXRpb25UeXBlLCBhbm5vdGF0aW9uKQogICAg ICAgICAgICAgICAgIGFubm90YXRpb24gPSBuaWwK