97490 2012-09-24 15:40:05 -0700 REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build 2012-09-25 00:33:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 90675 1 ossy vivekgalatage ossy pfeldman vivekgalatage oldest_to_newest 727051 0 ossy 2012-09-24 15:40:05 -0700 build log from Qt minimal bot: ... /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::openInNewTab(WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::windowObjectCleared()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestDetachWindow()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::sendMessageToBackend(WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::frontendLoaded()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal(WebCore::InspectorController*, WebCore::Page*, WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings>)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorClient::doDispatchMessageOnFrontendPage(WebCore::Page*, WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestAttachWindow()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::moveWindowBy(float, float)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `typeinfo for WebCore::InspectorFrontendClientLocal' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight(unsigned int)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `vtable for WebCore::InspectorFrontendClientLocal::Settings' ... 727350 1 165537 vivekgalatage 2012-09-25 00:22:26 -0700 Created attachment 165537 Patch 727355 2 165537 ossy 2012-09-25 00:31:32 -0700 Comment on attachment 165537 Patch r=me 727357 3 165537 ossy 2012-09-25 00:33:15 -0700 Comment on attachment 165537 Patch Clearing flags on attachment: 165537 Committed r129464: <http://trac.webkit.org/changeset/129464> 727358 4 ossy 2012-09-25 00:33:20 -0700 All reviewed patches have been landed. Closing bug. 165537 2012-09-25 00:22:26 -0700 2012-09-25 00:33:15 -0700 Patch bug-97490-20120925125139.patch text/plain 1614 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTQ2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTI1ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjEyOTM0Nik6IEl0IGJyb2tlICFFTkFCTEUoSU5TUEVDVE9SKSBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0OTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZHVtbXkgY2xhc3MgaW1wbGVt ZW50YXRpb24gbXVzdCBiZSB1bmRlciB0aGUgRU5BQkxFKElOU1BFQ1RPUikKKyAgICAgICAgZ3Vh cmQuIEFkZGVkIHRoZW0gdG8gcHJldmVudCBmcm9tIGJyYWtpbmcgdGhlIGJ1aWxkIHdpdGggLS1t aW5pbWFsCisgICAgICAgIG9wdGlvbiBmb3IgYnVpbGQtd2Via2l0CisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIGFzIGNhdXNlZCBieSBtaXNzaW5nIGNvbXBpbGUgZ3VhcmQuCisKKyAgICAgICAgKiB0 ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0wOS0yNCAg Qm8gTGl1ICA8Ym9saXVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbGFuZCAiQWRkIGluLXBs YWNlIHJlbG9hZCBiZWhhdmlvciB0byBJbWFnZXNFbmFibGVkIHNldHRpbmciIHdpdGggb3B0aW1p emF0aW9ucwpJbmRleDogU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkocmV2aXNpb24g MTI5NDU2KQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDksNiArMTA5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBu YW1lc3BhY2UgSFRNTE5hbWVzOwogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKIGNsYXNzIEluc3Bl Y3RvckZyb250ZW5kQ2xpZW50RHVtbXkgOiBwdWJsaWMgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRM b2NhbCB7CiBwdWJsaWM6CiAgICAgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnREdW1teShJbnNwZWN0 b3JDb250cm9sbGVyKiwgUGFnZSopOwpAQCAtMTUyLDYgKzE1Myw3IEBAIGJvb2wgSW5zcGVjdG9y RnJvbnRlbmRDaGFubmVsRHVtbXk6OnNlbmQKIHsKICAgICByZXR1cm4gSW5zcGVjdG9yQ2xpZW50 Ojpkb0Rpc3BhdGNoTWVzc2FnZU9uRnJvbnRlbmRQYWdlKG1fZnJvbnRlbmRQYWdlLCBtZXNzYWdl KTsKIH0KKyNlbmRpZiAvLyBFTkFCTEUoSU5TUEVDVE9SKQogCiBzdGF0aWMgYm9vbCBtYXJrZXJU eXBlc0Zyb20oY29uc3QgU3RyaW5nJiBtYXJrZXJUeXBlLCBEb2N1bWVudE1hcmtlcjo6TWFya2Vy VHlwZXMmIHJlc3VsdCkKIHsK