97480 2012-09-24 13:59:40 -0700 flex-grow should be 1 when omitted from flex shorthand 2012-09-24 14:34:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62048 1 tony tony cmarcelo macpherson menard ojan webkit.review.bot oldest_to_newest 726979 0 tony 2012-09-24 13:59:40 -0700 flex-grow should be 1 when omitted from flex shorthand 726980 1 165443 tony 2012-09-24 14:01:15 -0700 Created attachment 165443 Patch 726981 2 tony 2012-09-24 14:02:11 -0700 http://www.w3.org/TR/css3-flexbox/#flex-common is very explicit about this. 727012 3 165443 webkit.review.bot 2012-09-24 14:34:54 -0700 Comment on attachment 165443 Patch Clearing flags on attachment: 165443 Committed r129414: <http://trac.webkit.org/changeset/129414> 727013 4 webkit.review.bot 2012-09-24 14:34:57 -0700 All reviewed patches have been landed. Closing bug. 165443 2012-09-24 14:01:15 -0700 2012-09-24 14:34:54 -0700 Patch bug-97480-20120924140036.patch text/plain 7328 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRkNGFlZmM1NGQxNjM3 ODY4ZGM0ZWEyMzVkOTM3MjIzYTVjODQ0Yy4uZDI5ZDAyYWU2MDY3YTJhOWFiYTYwNGZlNGY2YzBm ZTcyYmQ2ZDk4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI0ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZmxleC1ncm93IHNob3VsZCBi ZSAxIHdoZW4gb21pdHRlZCBmcm9tIGZsZXggc2hvcnRoYW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgdXNpbmcgMCwgYmFzZWQgb24gYW4g b3V0ZGF0ZWQgdmVyc2lvbiBvZiB0aGUgc3BlYy4KKworICAgICAgICBUZXN0czogY3NzMy9mbGV4 Ym94L2ZsZXgtcHJvcGVydHktcGFyc2luZy5odG1sCisgICAgICAgICAgICAgICBjc3MzL2ZsZXhi b3gvZmxleC1hbGdvcml0aG0uaHRtbDogTmV3IHRlc3QgY2FzZS4KKworICAgICAgICAqIGNzcy9D U1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUZsZXgpOgor CiAyMDEyLTA5LTI0ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAg ICAgICAgIE1lZGlhU3RyZWFtIEFQSTogRml4IHRoZSBpbmNvcnJlY3RseSBzcGVsbGVkIFJUQ1Bl ZXJDb25uZWN0aW9uOjpvbm5lZ290aWF0aW9ubmVlZGVkIGNhbGxiYWNrCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwCmluZGV4IGVmZDliYWUzYTA2OGRkZTVlZDE5ZWY4M2NhNzU0Yzc2MjZlODE4MzAu LjlhOTIyZjE5MTI3Zjk2OTk2MjZiMGNmMzNiMzgzM2NmMjZkMzBmODQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCkBAIC01OTk0LDcgKzU5OTQsNyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VG bGV4KENTU1BhcnNlclZhbHVlTGlzdCogYXJncywgYm9vbCBpbXBvcnRhbnQpCiAgICAgfQogCiAg ICAgaWYgKGZsZXhHcm93ID09IHVuc2V0VmFsdWUpCi0gICAgICAgIGZsZXhHcm93ID0gMDsKKyAg ICAgICAgZmxleEdyb3cgPSAxOwogICAgIGlmIChmbGV4U2hyaW5rID09IHVuc2V0VmFsdWUpCiAg ICAgICAgIGZsZXhTaHJpbmsgPSAxOwogICAgIGlmICghZmxleEJhc2lzKQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDk1NTA3 ZTFjMzI5MmQyOWMyNDI2MWY3NmZlNjk3MDhhNTlkMWJlYTUuLjFkOGJjOTZhYzhmMTg2MWRkYzJm MzIzMjkxYjI1MTNiZGM2ZjZmNWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOS0yNCAg VG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGZsZXgtZ3JvdyBzaG91 bGQgYmUgMSB3aGVuIG9taXR0ZWQgZnJvbSBmbGV4IHNob3J0aGFuZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVzdHMgZHVlIHRvIGRlZmF1 bHQgQ1NTIHZhbHVlIGNoYW5nZXMuCisKKyAgICAgICAgKiBjc3MzL2ZsZXhib3gvZmxleC1hbGdv cml0aG0tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGNzczMvZmxleGJveC9mbGV4LWFsZ29yaXRo bS5odG1sOiBBZGQgdGVzdCBjYXNlIHVzaW5nIC13ZWJraXQtZmxleDogYXV0by4KKyAgICAgICAg KiBjc3MzL2ZsZXhib3gvZmxleC1wcm9wZXJ0eS1wYXJzaW5nLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBjc3MzL2ZsZXhib3gvZmxleC1wcm9wZXJ0eS1wYXJzaW5nLmh0bWw6CisKIDIwMTItMDkt MjQgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLiBSZW1vdmluZyBXaW5kb3dzIHNwZWNpZmljIHJlc3VsdHMgZm9yIGZhc3QvdGV4dC9pbnRl cm5hdGlvbmFsL2Zsb2F0LWFzLW9ubHktY2hpbGQtb2YtaXNvbGF0ZS1jcmFzaCB0aGF0IHdlcmUg YWRkZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTk4Lgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtYWxnb3JpdGhtLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4LWFsZ29yaXRobS1leHBlY3Rl ZC50eHQKaW5kZXggYmIxMDA0NjJmMzFmYjU3MTlhMjFjYjNkNGRmMDczZmM0ZWZkNmRjNy4uYmZl NzA5MTRiOWRiZDMxMTYwMzEwNmFhOGIxYjFiMTAzODkyMjQzZCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtYWxnb3JpdGhtLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleC1hbGdvcml0aG0tZXhwZWN0ZWQudHh0CkBAIC0yMiw0 ICsyMiw1IEBAIFBBU1MKIFBBU1MKIFBBU1MKIFBBU1MKK1BBU1MKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtYWxnb3JpdGhtLmh0bWwgYi9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvZmxleC1hbGdvcml0aG0uaHRtbAppbmRleCA4ZDE1NWYzMDU3NmU5OTY4NjYw M2UwMWNkZjJjMGNiMzM1ODA4ZDc4Li44MDhmOGI2MjFmZDk3M2Q4ZThkMjg2ZTlmZTQxODM4NmY5 NWEyYjMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleC1hbGdvcml0 aG0uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleC1hbGdvcml0aG0uaHRt bApAQCAtMTc1LDYgKzE3NSwxNiBAQCBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgIDxkaXYgZGF0 YS1leHBlY3RlZC13aWR0aD0iMjAwIiBzdHlsZT0iLXdlYmtpdC1mbGV4OiAxIj48L2Rpdj4KIDwv ZGl2PgogCis8ZGl2IGNsYXNzPSJmbGV4Ym94Ij4KKyAgPGRpdiBkYXRhLWV4cGVjdGVkLXdpZHRo PSIyMDAiIHN0eWxlPSItd2Via2l0LWZsZXg6IGF1dG8iPgorICAgICAgPGRpdiBzdHlsZT0id2lk dGg6IDEwMHB4OyI+PC9kaXY+CisgIDwvZGl2PgorICA8ZGl2IGRhdGEtZXhwZWN0ZWQtd2lkdGg9 IjEwMCIgc3R5bGU9Ii13ZWJraXQtZmxleDogYXV0byI+PC9kaXY+CisgIDxkaXYgZGF0YS1leHBl Y3RlZC13aWR0aD0iMzAwIiBzdHlsZT0iLXdlYmtpdC1mbGV4OiBhdXRvIj4KKyAgICAgIDxkaXYg c3R5bGU9IndpZHRoOiAyMDBweDsiPjwvZGl2PgorICA8L2Rpdj4KKzwvZGl2PgorCiA8IS0tIFRl c3QgYm9yZGVyL3BhZGRpbmcvbWFyZ2luIG9uIHRoZSBmbGV4Ym94IGl0c2VsZi4gLS0+CiA8ZGl2 IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjgzMCIgc3R5bGU9ImJvcmRlcjogMTBweCBzb2xpZDsgZGlz cGxheTogaW5saW5lLWJsb2NrOyI+CiAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI3MDAi IHN0eWxlPSJkaXNwbGF5OiAtd2Via2l0LWZsZXg7IHBhZGRpbmctbGVmdDogMTBweDsgcGFkZGlu Zy1yaWdodDogMjBweDsgYm9yZGVyLWxlZnQ6IDMwcHggc29saWQ7IGJvcmRlci1yaWdodDogNDBw eCBzb2xpZDsgbWFyZ2luLWxlZnQ6IDUwcHg7IG1hcmdpbi1yaWdodDo2MHB4OyIgY2xhc3M9ImZs ZXhib3ggIj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4LXByb3Bl cnR5LXBhcnNpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgt cHJvcGVydHktcGFyc2luZy1leHBlY3RlZC50eHQKaW5kZXggNjNjOGI4MDFlYTI3OGE3OTlmNzA2 MjVhNTAwYWJjYjVmZTQ1ZTM1NC4uYWI4Y2JkZjU0NWZjMTllZjQ2YjA4M2ExZjY3MDEzODI0ZWI1 MDc1NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtcHJvcGVydHkt cGFyc2luZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgt cHJvcGVydHktcGFyc2luZy1leHBlY3RlZC50eHQKQEAgLTE1LDE0ICsxNSwxNCBAQCBQQVNTIGZs ZXhpdGVtLnN0eWxlLndlYmtpdEZsZXggaXMgIjAgMSAwcHgiCiBQQVNTIGdldENvbXB1dGVkU3R5 bGUoZmxleGl0ZW0pLndlYmtpdEZsZXggaXMgIjAgMSAwcHgiCiBQQVNTIGZsZXhpdGVtLnN0eWxl LndlYmtpdEZsZXggaXMgIjEuNSAxIDBweCIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZShmbGV4aXRl bSkud2Via2l0RmxleCBpcyAiMS41IDEgMHB4IgotUEFTUyBmbGV4aXRlbS5zdHlsZS53ZWJraXRG bGV4IGlzICIwIDEgYXV0byIKLVBBU1MgZ2V0Q29tcHV0ZWRTdHlsZShmbGV4aXRlbSkud2Via2l0 RmxleCBpcyAiMCAxIGF1dG8iCi1QQVNTIGZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXggaXMgIjAg MSAxcHgiCi1QQVNTIGdldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0pLndlYmtpdEZsZXggaXMgIjAg MSAxcHgiCi1QQVNTIGZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXggaXMgIjAgMSAyZW0iCi1QQVNT IGdldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0pLndlYmtpdEZsZXggaXMgIjAgMSAzMnB4IgotUEFT UyBmbGV4aXRlbS5zdHlsZS53ZWJraXRGbGV4IGlzICIwIDEgMHB4IgotUEFTUyBnZXRDb21wdXRl ZFN0eWxlKGZsZXhpdGVtKS53ZWJraXRGbGV4IGlzICIwIDEgMHB4IgorUEFTUyBmbGV4aXRlbS5z dHlsZS53ZWJraXRGbGV4IGlzICIxIDEgYXV0byIKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZShmbGV4 aXRlbSkud2Via2l0RmxleCBpcyAiMSAxIGF1dG8iCitQQVNTIGZsZXhpdGVtLnN0eWxlLndlYmtp dEZsZXggaXMgIjEgMSAxcHgiCitQQVNTIGdldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0pLndlYmtp dEZsZXggaXMgIjEgMSAxcHgiCitQQVNTIGZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXggaXMgIjEg MSAyZW0iCitQQVNTIGdldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0pLndlYmtpdEZsZXggaXMgIjEg MSAzMnB4IgorUEFTUyBmbGV4aXRlbS5zdHlsZS53ZWJraXRGbGV4IGlzICIxIDEgMHB4IgorUEFT UyBnZXRDb21wdXRlZFN0eWxlKGZsZXhpdGVtKS53ZWJraXRGbGV4IGlzICIxIDEgMHB4IgogUEFT UyBmbGV4aXRlbS5zdHlsZS53ZWJraXRGbGV4IGlzICIwIDAgYXV0byIKIFBBU1MgZ2V0Q29tcHV0 ZWRTdHlsZShmbGV4aXRlbSkud2Via2l0RmxleCBpcyAiMCAwIGF1dG8iCiBQQVNTIGZsZXhpdGVt LnN0eWxlLndlYmtpdEZsZXggaXMgIjAgMCAwcHgiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvZmxleC1wcm9wZXJ0eS1wYXJzaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3Mz L2ZsZXhib3gvZmxleC1wcm9wZXJ0eS1wYXJzaW5nLmh0bWwKaW5kZXggM2YzMDFkZDgxYjA2YjNh ZWE4NjJlODQxMzMxYzIyYjBkZTg3ODIyMi4uYWJiNjMyNDdjNjFkM2EwZTRhYWJjNTRjNTUxMjYw NjI4ZDExYzAxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtcHJv cGVydHktcGFyc2luZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4LXBy b3BlcnR5LXBhcnNpbmcuaHRtbApAQCAtNDAsMjAgKzQwLDIwIEBAIHNob3VsZEJlRXF1YWxUb1N0 cmluZygnZmxleGl0ZW0uc3R5bGUud2Via2l0RmxleCcsICcxLjUgMSAwcHgnKTsKIHNob3VsZEJl RXF1YWxUb1N0cmluZygnZ2V0Q29tcHV0ZWRTdHlsZShmbGV4aXRlbSkud2Via2l0RmxleCcsICcx LjUgMSAwcHgnKTsKIAogZmxleGl0ZW0uc3R5bGUud2Via2l0RmxleCA9ICdhdXRvJzsKLXNob3Vs ZEJlRXF1YWxUb1N0cmluZygnZmxleGl0ZW0uc3R5bGUud2Via2l0RmxleCcsICcwIDEgYXV0bycp Owotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdnZXRDb21wdXRlZFN0eWxlKGZsZXhpdGVtKS53ZWJr aXRGbGV4JywgJzAgMSBhdXRvJyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2ZsZXhpdGVtLnN0 eWxlLndlYmtpdEZsZXgnLCAnMSAxIGF1dG8nKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygnZ2V0 Q29tcHV0ZWRTdHlsZShmbGV4aXRlbSkud2Via2l0RmxleCcsICcxIDEgYXV0bycpOwogCiBmbGV4 aXRlbS5zdHlsZS53ZWJraXRGbGV4ID0gJzFweCc7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2Zs ZXhpdGVtLnN0eWxlLndlYmtpdEZsZXgnLCAnMCAxIDFweCcpOwotc2hvdWxkQmVFcXVhbFRvU3Ry aW5nKCdnZXRDb21wdXRlZFN0eWxlKGZsZXhpdGVtKS53ZWJraXRGbGV4JywgJzAgMSAxcHgnKTsK K3Nob3VsZEJlRXF1YWxUb1N0cmluZygnZmxleGl0ZW0uc3R5bGUud2Via2l0RmxleCcsICcxIDEg MXB4Jyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2dldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0p LndlYmtpdEZsZXgnLCAnMSAxIDFweCcpOwogCiBmbGV4aXRlbS5zdHlsZS53ZWJraXRGbGV4ID0g JzJlbSc7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2ZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXgn LCAnMCAxIDJlbScpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdnZXRDb21wdXRlZFN0eWxlKGZs ZXhpdGVtKS53ZWJraXRGbGV4JywgJzAgMSAzMnB4Jyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmco J2ZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXgnLCAnMSAxIDJlbScpOworc2hvdWxkQmVFcXVhbFRv U3RyaW5nKCdnZXRDb21wdXRlZFN0eWxlKGZsZXhpdGVtKS53ZWJraXRGbGV4JywgJzEgMSAzMnB4 Jyk7CiAKIGZsZXhpdGVtLnN0eWxlLndlYmtpdEZsZXggPSAnMHB4JzsKLXNob3VsZEJlRXF1YWxU b1N0cmluZygnZmxleGl0ZW0uc3R5bGUud2Via2l0RmxleCcsICcwIDEgMHB4Jyk7Ci1zaG91bGRC ZUVxdWFsVG9TdHJpbmcoJ2dldENvbXB1dGVkU3R5bGUoZmxleGl0ZW0pLndlYmtpdEZsZXgnLCAn MCAxIDBweCcpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdmbGV4aXRlbS5zdHlsZS53ZWJraXRG bGV4JywgJzEgMSAwcHgnKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygnZ2V0Q29tcHV0ZWRTdHls ZShmbGV4aXRlbSkud2Via2l0RmxleCcsICcxIDEgMHB4Jyk7CiAKIGZsZXhpdGVtLnN0eWxlLndl YmtpdEZsZXggPSAnbm9uZSc7CiBmbGV4aXRlbS5zdHlsZS53ZWJraXRGbGV4ID0gJy0yJzsgLy8g SW52YWxpZCwgcmV0dXJuIHByZXZpb3VzIHZhbHVlLgo=