97479 2012-09-24 13:43:16 -0700 [Qt] Fix build with newer Qt 5 2012-09-25 01:09:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot webkit.review.bot abecsi hausmann ossy vestbo oldest_to_newest 726964 0 webkit.review.bot 2012-09-24 13:43:16 -0700 http://trac.webkit.org/changeset/129343 broke the build: It broke the build (Requested by Ossy_NIGHT on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 726965 1 165439 webkit.review.bot 2012-09-24 13:43:47 -0700 Created attachment 165439 ROLLOUT of r129343 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 726968 2 165439 ossy 2012-09-24 13:47:26 -0700 Comment on attachment 165439 ROLLOUT of r129343 Clearing flags on attachment: 165439 Committed r129407: <http://trac.webkit.org/changeset/129407> 726969 3 ossy 2012-09-24 13:47:31 -0700 All reviewed patches have been landed. Closing bug. 726971 4 ossy 2012-09-24 13:50:14 -0700 The original patch was rolled out, but I can't reopen the original bug, because there isn't bug report for this patch. In this case, I think, we should use this bug to track this regression. 726973 5 ossy 2012-09-24 13:53:59 -0700 here is the build log: /ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:32:37: error: private/qquickwebpage_p.h: No such file or directory /ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:33:37: error: private/qquickwebview_p.h: No such file or directory /ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:34:45: error: private/qwebiconimageprovider_p.h: No such file or directory /ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:35:39: error: private/qwebloadrequest_p.h: No such file or directory /ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:36:45: error: private/qwebnavigationrequest_p.h: No such file or directory 727374 6 hausmann 2012-09-25 00:54:41 -0700 (In reply to comment #4) > The original patch was rolled out, but I can't reopen the original bug, > because there isn't bug report for this patch. In this case, I think, we > should use this bug to track this regression. Agreed. I'll adjust the title to reflect what this was actually trying to fix :) 727380 7 165547 hausmann 2012-09-25 00:55:56 -0700 Created attachment 165547 Patch 727387 8 hausmann 2012-09-25 01:08:28 -0700 Same fix landed again with version guard Committed r129471: <http://trac.webkit.org/changeset/129471> 165439 2012-09-24 13:43:47 -0700 2012-09-25 00:55:52 -0700 ROLLOUT of r129343 bug-97479-20120924205015.patch text/plain 2765 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXBpLnByaSBi L1NvdXJjZS9hcGkucHJpCmluZGV4IGI0NjY5NmZlM2Y5OTViZDllNTdiMGM5OTk4ODdmOTY3M2Nj M2M3NmIuLjQ1M2MwZWNkMTBkZGJjOGQ3NjJjNTE4ZjkzNTRmY2ZmYjRjMGIxN2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9hcGkucHJpCisrKyBiL1NvdXJjZS9hcGkucHJpCkBAIC0zMSwxMCArMzEsNiBA QCBNT0RVTEUgPSB3ZWJraXQKIFFUX0FQSV9ERVBFTkRTID0gY29yZSBndWkgbmV0d29yawogYnVp bGQ/KHdlYmtpdDEpOiBRVF9BUElfREVQRU5EUyArPSB3aWRnZXRzCiAKLSMgV2Ugd2FudCB0aGUg UXRXZWJLaXQgQVBJIGZvcndhcmRpbmcgaW5jbHVkZXMgdG8gbGl2ZSBpbiB0aGUgcm9vdCBidWls ZCBkaXIuCi1NT0RVTEVfQkFTRV9ESVIgPSAkJF9QUk9fRklMRV9QV0RfCi1NT0RVTEVfQkFTRV9P VVRESVIgPSAkJFJPT1RfQlVJTERfRElSCi0KICMgV2UgbG9hZCB0aGUgcmVsZXZhbnQgbW9kdWxl cyBoZXJlLCBzbyB0aGF0IHRoZSBlZmZlY3RzIG9mIGVhY2ggbW9kdWxlCiAjIG9uIHRoZSBRVCB2 YXJpYWJsZSBjYW4gYmUgcGlja2VkIHVwIHdoZW4gd2UgbGF0ZXIgbG9hZChxdF9tb2R1bGUpLgog bG9hZCh3ZWJraXRfbW9kdWxlcykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCAxN2QxZmYzMTFkOWViYjA4ZDRiMDU4OTk5ZTQ0YTBhN2JjOTRmZTQ3 Li43MzI4NjhlMmIzMDkwN2I3ZDFiYThjNzA1OWM0OTk5Y2QyY2U5OWM2IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTItMDktMjQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjkzNDMuCisgICAgICAgIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyOTM0MworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0NzkKKworICAgICAgICBJdCBicm9rZSB0aGUgYnVp bGQgKFJlcXVlc3RlZCBieSBPc3N5X05JR0hUIG9uICN3ZWJraXQpLgorCisgICAgICAgICogcW1h a2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmY6CisKIDIwMTItMDktMjQgIFphbiBE b2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBbR3RrXSBVbnNraXAg dGhlIFNoYWRvdyBET00gbGF5b3V0IHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3Nw ZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZGVmYXVsdF9wcmUucHJmCmluZGV4IGFmMjVhYTg0YmFjMmI2Yzg0ZTMyNTMyOTg2MWQyYWU3 NTljNTM5OTUuLmJiMTliNTc5YTUyNDQzZWQwYzUxYzRhOWVmYzNlYmRjYWNjNjczMGQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCisrKyBi L1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCkBAIC0yNSw4ICsy NSw2IEBAIFJPT1RfV0VCS0lUX0RJUiA9ICQkcmVwbGFjZShQV0QsIC9Ub29scy9xbWFrZS9ta3Nw ZWNzL2ZlYXR1cmVzJCwpCiBXRUJLSVRfU1VCRElSID0gJCRyZXBsYWNlKF9QUk9fRklMRV9QV0Rf LCAkJHtST09UX1dFQktJVF9ESVJ9LCkKIFJPT1RfQlVJTERfRElSID0gJCRyZXBsYWNlKE9VVF9Q V0QsICQke1dFQktJVF9TVUJESVJ9JCwpCiAKLSMgIyMjIEZJWE1FOiBSZW1vdmUgdGhpcyBhZnRl ciBRdCA1IGJldGEgMi4gU3luY3F0IGlzIG5vdCBjYWxsZWQgZnJvbSBkZWZhdWx0X3ByZS5wcmYK LSMgYW55bW9yZSwgc28gdGhpcyB3YXMgbW92ZWQgdG8gYXBpLnByaS4KICMgV2Ugd2FudCB0aGUg UXRXZWJLaXQgQVBJIGZvcndhcmRpbmcgaW5jbHVkZXMgdG8gbGl2ZSBpbiB0aGUgcm9vdCBidWls ZCBkaXIuCiBNT0RVTEVfQkFTRV9ESVIgPSAkJFJPT1RfV0VCS0lUX0RJUgogTU9EVUxFX0JBU0Vf T1VURElSID0gJCRST09UX0JVSUxEX0RJUgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl TG9nCmluZGV4IDI3Y2I1MWQxZGQxYzQwZDA3YjA0ZWExNjRkMGYzZmNjNTZkM2RmM2MuLjU1MjQ1 ZTZjMGMzYjRmZDYzZTE2MGFlZTM2ZDAyMzg5YTZiZjc5ZTMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxv ZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxMi0wOS0yNCAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKKyAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjEyOTM0My4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvMTI5MzQzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzQ3OQorCisgICAgICAgIEl0IGJyb2tlIHRoZSBidWlsZCAoUmVxdWVzdGVkIGJ5IE9z c3lfTklHSFQgb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBTb3VyY2UvYXBpLnByaToKKworMjAx Mi0wOS0yNCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyOTM4OC4KICAgICAgICAgaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTI5Mzg4CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ3Nwo= 165547 2012-09-25 00:55:56 -0700 2012-09-25 01:09:44 -0700 Patch bug-97479-20120925095756.patch text/plain 3088 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXBpLnByaSBi L1NvdXJjZS9hcGkucHJpCmluZGV4IDQ1M2MwZWNkMTBkZGJjOGQ3NjJjNTE4ZjkzNTRmY2ZmYjRj MGIxN2IuLjgxNWNkNzdhOTg0MzVhNTJiOWM4NTU1ODc1N2ZmZGExMmFiZjY1MDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9hcGkucHJpCisrKyBiL1NvdXJjZS9hcGkucHJpCkBAIC0zMSw2ICszMSwxMyBA QCBNT0RVTEUgPSB3ZWJraXQKIFFUX0FQSV9ERVBFTkRTID0gY29yZSBndWkgbmV0d29yawogYnVp bGQ/KHdlYmtpdDEpOiBRVF9BUElfREVQRU5EUyArPSB3aWRnZXRzCiAKK3FtYWtlVmVyc2lvbj0k JFtRTUFLRV9WRVJTSU9OXQorZXF1YWxzKHFtYWtlVmVyc2lvbiwgMy4wKSB7CisgICAgIyBXZSB3 YW50IHRoZSBRdFdlYktpdCBBUEkgZm9yd2FyZGluZyBpbmNsdWRlcyB0byBsaXZlIGluIHRoZSBy b290IGJ1aWxkIGRpci4KKyAgICBNT0RVTEVfQkFTRV9ESVIgPSAkJF9QUk9fRklMRV9QV0RfCisg ICAgTU9EVUxFX0JBU0VfT1VURElSID0gJCRST09UX0JVSUxEX0RJUgorfQorCiAjIFdlIGxvYWQg dGhlIHJlbGV2YW50IG1vZHVsZXMgaGVyZSwgc28gdGhhdCB0aGUgZWZmZWN0cyBvZiBlYWNoIG1v ZHVsZQogIyBvbiB0aGUgUVQgdmFyaWFibGUgY2FuIGJlIHBpY2tlZCB1cCB3aGVuIHdlIGxhdGVy IGxvYWQocXRfbW9kdWxlKS4KIGxvYWQod2Via2l0X21vZHVsZXMpCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmI3OWIxMzM3NGM5YWViZWI0MWZk NDQyMjIyZTI2MjVhZmFjNmIwMC4uYmM3NzM2NTg1ZTMwOTI3YmVmOGQ3OGUyNDQ4MGQ3N2UxMjU5 ZTI5YSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTI0ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNt YW5uQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdIEZpeCBidWlsZCB3aXRoIGxhdGVzdCBRdCA1 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ3OQor CisgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCisKKyAgICAgICAgVGhlIHZh cmlhYmxlcyBmb3Igc3luY3F0IGhhbmRsaW5nIGFyZSBub3cgc2V0IGluIGFwaS5wcmksIGJ1dCBs ZXQncyBhZGQgYSBjb21tZW50IGhlcmUgdGhhdCB3ZSBjYW4KKyAgICAgICAgcmVtb3ZlIHRoZW0g ZnJvbSBkZWZhdWx0X3ByZS5wcmYgb25jZSB3ZSdyZSBwYXN0IFF0IDUgYmV0YTIuCisKKyAgICAg ICAgKiBxbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZjoKKwogMjAxMi0wOS0y NCAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVuZXhw ZWN0ZWQgcmVmdGVzdCBwYXNzZXMgYXJlIG9ubHkgcmVwb3J0ZWQgd2hlbiBwaXhlbCB0ZXN0aW5n IGlzIGVuYWJsZWQgaW4gcmVzdWx0cy5odG1sIGFzIHdlbGwKZGlmZiAtLWdpdCBhL1Rvb2xzL3Ft YWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVj cy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmYKaW5kZXggYmIxOWI1NzlhNTI0NDNlZDBjNTFjNGE5 ZWZjM2ViZGNhY2M2NzMwZC4uYWYyNWFhODRiYWMyYjZjODRlMzI1MzI5ODYxZDJhZTc1OWM1Mzk5 NSAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5w cmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmYKQEAg LTI1LDYgKzI1LDggQEAgUk9PVF9XRUJLSVRfRElSID0gJCRyZXBsYWNlKFBXRCwgL1Rvb2xzL3Ft YWtlL21rc3BlY3MvZmVhdHVyZXMkLCkKIFdFQktJVF9TVUJESVIgPSAkJHJlcGxhY2UoX1BST19G SUxFX1BXRF8sICQke1JPT1RfV0VCS0lUX0RJUn0sKQogUk9PVF9CVUlMRF9ESVIgPSAkJHJlcGxh Y2UoT1VUX1BXRCwgJCR7V0VCS0lUX1NVQkRJUn0kLCkKIAorIyAjIyMgRklYTUU6IFJlbW92ZSB0 aGlzIGFmdGVyIFF0IDUgYmV0YSAyLiBTeW5jcXQgaXMgbm90IGNhbGxlZCBmcm9tIGRlZmF1bHRf cHJlLnByZgorIyBhbnltb3JlLCBzbyB0aGlzIHdhcyBtb3ZlZCB0byBhcGkucHJpLgogIyBXZSB3 YW50IHRoZSBRdFdlYktpdCBBUEkgZm9yd2FyZGluZyBpbmNsdWRlcyB0byBsaXZlIGluIHRoZSBy b290IGJ1aWxkIGRpci4KIE1PRFVMRV9CQVNFX0RJUiA9ICQkUk9PVF9XRUJLSVRfRElSCiBNT0RV TEVfQkFTRV9PVVRESVIgPSAkJFJPT1RfQlVJTERfRElSCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggZTRhODI1NTQ0NWM1MDY1OGY4MGQyMTk2ZDljZWZmYWFiM2VlZTZj Zi4uODdlNzE2Y2M5YjNjMDZhZjBkNTA5YWNhOGExYmZkODYwZWNlMmNlYSAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTI0ICBT aW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd IEZpeCBidWlsZCB3aXRoIGxhdGVzdCBRdCA1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ3OQorCisgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5l IFZlc3Riw7guCisKKyAgICAgICAgRGVmaW5lIE1PRFVMRV9CQVNFX0RJUiBiZWZvcmUgbG9hZGlu ZyBxdF9tb2R1bGUucHJmLCB3aGljaCBub3cgY2FsbHMgc3luY3F0LiBNT0RVTEVfQkFTRV9ESVIg aXMKKyAgICAgICAgcGFzc2VkIGFzIGxhc3QgcGFyYW1ldGVyIChzb3VyY2UgZGlyKSB0byBzeW5j cXQgbm93LCBzbyBzZXQgaXQgdG8gdGhlIGRpcmVjdG9yeSB0aGF0IGNvbnRhaW5zCisgICAgICAg IHN5bmMucHJvZmlsZS4KKworICAgICAgICAqIFNvdXJjZS9hcGkucHJpOgorCiAyMDEyLTA5LTI0 ICBCbyBMaXUgIDxib2xpdUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVsYW5kICJBZGQgaW4t cGxhY2UgcmVsb2FkIGJlaGF2aW9yIHRvIEltYWdlc0VuYWJsZWQgc2V0dGluZyIgd2l0aCBvcHRp bWl6YXRpb25zCg==