97476 2012-09-24 12:39:34 -0700 GraphicsContext3D::compileShader is using incorrect string length in GraphicsContext3DOpenGLCommon.cpp 2013-01-04 05:36:37 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leoyang leoyang dino eric noam webkit.review.bot oldest_to_newest 726924 0 leoyang 2012-09-24 12:39:34 -0700 int translatedShaderLength = translatedShaderSource.length(); ^ it is the length of String. But the following code is using it as the length of the CString of the String. 726926 1 165431 leoyang 2012-09-24 12:43:31 -0700 Created attachment 165431 Patch 727139 2 165431 dino 2012-09-24 17:58:38 -0700 Comment on attachment 165431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165431&action=review > Source/WebCore/ChangeLog:11 > + * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: > + (WebCore::GraphicsContext3D::compileShader): Since this is so easy to describe, it would be nice to explain what you did here. 727648 3 165614 leoyang 2012-09-25 08:03:56 -0700 Created attachment 165614 Patch for land 727901 4 165614 webkit.review.bot 2012-09-25 13:15:55 -0700 Comment on attachment 165614 Patch for land Clearing flags on attachment: 165614 Committed r129547: <http://trac.webkit.org/changeset/129547> 800036 5 eric 2013-01-04 00:53:04 -0800 Attachment 165431 was posted by a committer and has review+, assigning to Leo Yang for commit. 800158 6 165431 leoyang 2013-01-04 05:35:47 -0800 Comment on attachment 165431 Patch The patch has been landed. 800159 7 leoyang 2013-01-04 05:36:37 -0800 Close. 165431 2012-09-24 12:43:31 -0700 2013-01-04 05:35:47 -0800 Patch 0001-GraphicsContext3D-compileShader-is-using-incorrect-s.patch text/plain 2394 leoyang RnJvbSA5MTQ0ZTNhMjIzNmM1NGIxY2FhNWJiYjhmZmNiZDkzYjVhMDNkY2ExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBNb24s IDI0IFNlcCAyMDEyIDE1OjQxOjUzIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gR3JhcGhpY3NDb250 ZXh0M0Q6OmNvbXBpbGVTaGFkZXIgaXMgdXNpbmcgaW5jb3JyZWN0IHN0cmluZwogbGVuZ3RoIGlu IEdyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk3NDc2CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCk5v IG5ldyB0ZXN0cyBiZWNhdXNlIGl0J3Mgbm90IHRlc3RhYmxlIGluIHdlYmtpdCB0ZXN0IHJ1bm5l ci4KCiogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29t bW9uLmNwcDoKKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpjb21waWxlU2hhZGVyKToKLS0t CiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MTIgKysrKysrKysrKysrCiAuLi4vb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9u LmNwcCAgICAgICB8ICAgIDMgKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGM1MmVkNmMuLjEyOGI5YzUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0yNCAgTGVvIFlhbmcgIDxsZW95YW5nQHJpbS5j b20+CisKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFkZXIgaXMgdXNpbmcg aW5jb3JyZWN0IHN0cmluZyBsZW5ndGggaW4gR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24u Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ3 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIGl0J3Mgbm90IHRlc3RhYmxlIGluIHdlYmtpdCB0ZXN0IHJ1bm5lci4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y29t cGlsZVNoYWRlcik6CisKIDIwMTItMDktMjQgIFNlYW4gV2FuZyAgPFh1ZXdlbi5XYW5nQHRvcmNo bW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQmFzaWMgYXV0aGVudGljYXRp b24gY2hhbGxlbmdlIGNyZWRlbnRpYWxzIGZvciBzdG9yZWQgY3JlZGVudGlhbHMgYWdhaW4gYWZ0 ZXIgcmVzdGFydGluZyBicm93c2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3Bl bkdMQ29tbW9uLmNwcAppbmRleCBkODFlOWU2Li40ZmZmZWU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xD b21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9H cmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKQEAgLTQ1NCwxMCArNDU0LDkgQEAgdm9p ZCBHcmFwaGljc0NvbnRleHQzRDo6Y29tcGlsZVNoYWRlcihQbGF0Zm9ybTNET2JqZWN0IHNoYWRl cikKICAgICBpZiAoIXRyYW5zbGF0ZWRTaGFkZXJTb3VyY2UubGVuZ3RoKCkpCiAgICAgICAgIHJl dHVybjsKIAotICAgIGludCB0cmFuc2xhdGVkU2hhZGVyTGVuZ3RoID0gdHJhbnNsYXRlZFNoYWRl clNvdXJjZS5sZW5ndGgoKTsKLQogICAgIGNvbnN0IENTdHJpbmcmIHRyYW5zbGF0ZWRTaGFkZXJD U3RyaW5nID0gdHJhbnNsYXRlZFNoYWRlclNvdXJjZS51dGY4KCk7CiAgICAgY29uc3QgY2hhciog dHJhbnNsYXRlZFNoYWRlclB0ciA9IHRyYW5zbGF0ZWRTaGFkZXJDU3RyaW5nLmRhdGEoKTsKKyAg ICBpbnQgdHJhbnNsYXRlZFNoYWRlckxlbmd0aCA9IHRyYW5zbGF0ZWRTaGFkZXJDU3RyaW5nLmxl bmd0aCgpOwogICAgIAogICAgIDo6Z2xTaGFkZXJTb3VyY2Uoc2hhZGVyLCAxLCAmdHJhbnNsYXRl ZFNoYWRlclB0ciwgJnRyYW5zbGF0ZWRTaGFkZXJMZW5ndGgpOwogICAgIAotLSAKMS43LjUuNAoK 165614 2012-09-25 08:03:56 -0700 2012-09-25 13:15:54 -0700 Patch for land 0001-GraphicsContext3D-compileShader-is-using-incorrect-s.patch text/plain 2786 leoyang RnJvbSBkODQzYjg3ODBlNTA2NGVmZDg2MDNjY2Y2NjI2NTIzNTQ0NTExZTUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBUdWUs IDI1IFNlcCAyMDEyIDExOjAyOjA4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gR3JhcGhpY3NDb250 ZXh0M0Q6OmNvbXBpbGVTaGFkZXIgaXMgdXNpbmcgaW5jb3JyZWN0IHN0cmluZwogbGVuZ3RoIGlu IEdyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk3NDc2CgpSZXZpZXdlZCBieSBEZWFuIEphY2tzb24uCgpObyBu ZXcgdGVzdHMgYmVjYXVzZSBpdCdzIG5vdCB0ZXN0YWJsZSBpbiB3ZWJraXQgdGVzdCBydW5uZXIu CgoqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1v bi5jcHA6CihXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y29tcGlsZVNoYWRlcik6ClVzZSB0 cmFuc2xhdGVkU2hhZGVyQ1N0cmluZy5sZW5ndGgoKSBpbnN0ZWFkIG9mIHRyYW5zbGF0ZWRTaGFk ZXJTb3VyY2UubGVuZ3RoKCkKZm9yIHRoZSBzaGFkZXIgc291cmNlIGxlbmd0aCBiZWNhdXNlIHdl IGFyZSB1c2luZyB0cmFuc2xhdGVkU2hhZGVyQ1N0cmluZy5kYXRhKCkKZm9yIGdsU2hhZGVyU291 cmNlKCkuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogLi4uL29wZW5nbC9HcmFwaGljc0NvbnRleHQz RE9wZW5HTENvbW1vbi5jcHAgICAgICAgfCAgICAzICstLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNTJlZDZjLi5lYTVm YTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDktMjQgIExlbyBZYW5nICA8 bGVveWFuZ0ByaW0uY29tPgorCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEOjpjb21waWxlU2hh ZGVyIGlzIHVzaW5nIGluY29ycmVjdCBzdHJpbmcgbGVuZ3RoIGluIEdyYXBoaWNzQ29udGV4dDNE T3BlbkdMQ29tbW9uLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTc0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBEZWFuIEphY2tzb24uCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgaXQncyBub3QgdGVzdGFibGUgaW4gd2Via2l0IHRl c3QgcnVubmVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNz Q29udGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDNEOjpjb21waWxlU2hhZGVyKToKKyAgICAgICAgVXNlIHRyYW5zbGF0ZWRTaGFkZXJDU3Ry aW5nLmxlbmd0aCgpIGluc3RlYWQgb2YgdHJhbnNsYXRlZFNoYWRlclNvdXJjZS5sZW5ndGgoKQor ICAgICAgICBmb3IgdGhlIHNoYWRlciBzb3VyY2UgbGVuZ3RoIGJlY2F1c2Ugd2UgYXJlIHVzaW5n IHRyYW5zbGF0ZWRTaGFkZXJDU3RyaW5nLmRhdGEoKQorICAgICAgICBmb3IgZ2xTaGFkZXJTb3Vy Y2UoKS4KKwogMjAxMi0wOS0yNCAgU2VhbiBXYW5nICA8WHVld2VuLldhbmdAdG9yY2htb2JpbGUu Y29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBCYXNpYyBhdXRoZW50aWNhdGlvbiBjaGFs bGVuZ2UgY3JlZGVudGlhbHMgZm9yIHN0b3JlZCBjcmVkZW50aWFscyBhZ2FpbiBhZnRlciByZXN0 YXJ0aW5nIGJyb3dzZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21t b24uY3BwCmluZGV4IGQ4MWU5ZTYuLjRmZmZlZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNz Q29udGV4dDNET3BlbkdMQ29tbW9uLmNwcApAQCAtNDU0LDEwICs0NTQsOSBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDNEOjpjb21waWxlU2hhZGVyKFBsYXRmb3JtM0RPYmplY3Qgc2hhZGVyKQogICAg IGlmICghdHJhbnNsYXRlZFNoYWRlclNvdXJjZS5sZW5ndGgoKSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgaW50IHRyYW5zbGF0ZWRTaGFkZXJMZW5ndGggPSB0cmFuc2xhdGVkU2hhZGVyU291cmNl Lmxlbmd0aCgpOwotCiAgICAgY29uc3QgQ1N0cmluZyYgdHJhbnNsYXRlZFNoYWRlckNTdHJpbmcg PSB0cmFuc2xhdGVkU2hhZGVyU291cmNlLnV0ZjgoKTsKICAgICBjb25zdCBjaGFyKiB0cmFuc2xh dGVkU2hhZGVyUHRyID0gdHJhbnNsYXRlZFNoYWRlckNTdHJpbmcuZGF0YSgpOworICAgIGludCB0 cmFuc2xhdGVkU2hhZGVyTGVuZ3RoID0gdHJhbnNsYXRlZFNoYWRlckNTdHJpbmcubGVuZ3RoKCk7 CiAgICAgCiAgICAgOjpnbFNoYWRlclNvdXJjZShzaGFkZXIsIDEsICZ0cmFuc2xhdGVkU2hhZGVy UHRyLCAmdHJhbnNsYXRlZFNoYWRlckxlbmd0aCk7CiAgICAgCi0tIAoxLjcuNS40Cgo=