97466 2012-09-24 10:49:34 -0700 [chromium] adding a page overlay causes endless update loop when accelerated compositing is used 2012-09-25 08:30:53 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 caseq caseq jamesr nduca pfeldman vsevik xiyuan oldest_to_newest 726836 0 caseq 2012-09-24 10:49:34 -0700 0. In chromium, navigate to about:flags, assure "GPU compositing on all pages" and "FPS counter" are enabled 1. Navigate to about:blank 2. Open DevTools 3. Observe FPS graph is still 4. Switch to Elements panel and hover <body>, so bluish page overlay is visible 5. Observe we're doing a steady 60fps 726840 1 165410 caseq 2012-09-24 10:55:56 -0700 Created attachment 165410 Patch 726844 2 165411 caseq 2012-09-24 11:00:12 -0700 Created attachment 165411 Patch 726867 3 jamesr 2012-09-24 11:27:38 -0700 In https://bugs.webkit.org/show_bug.cgi?id=73235#c9, Vsevolod Vlasov said: "Inspector needs invalidating on each composite because highlighted element might have moved, but I am not sure you ever need to invalidate dimming layer at all.". Is that no longer the case? Is inspector taking care of invalidating the overlay when the highlighted elements moves nowadays? 726947 4 caseq 2012-09-24 13:08:50 -0700 (In reply to comment #3) > In https://bugs.webkit.org/show_bug.cgi?id=73235#c9, Vsevolod Vlasov said: "Inspector needs invalidating on each composite because highlighted element might have moved, but I am not sure you ever need to invalidate dimming layer at all.". Is that no longer the case? Is inspector taking care of invalidating the overlay when the highlighted elements moves nowadays? We stopped updating the element position during animation some time ago, when we migrated the overlay to be an HTML page, so I don't think it's relevant now -- basically, all it does now is invalidating the view, while we only update element position on change of the element being inspected. I guess, if we ever need this again, the right place would be from InspectorOverlay::update(), based on invalidations generated from within the layout() of the overlay page. The best place to call update() would perhaps be animate() rather than composite(), as it's where the highlighted element may be moved and it would be early enough to process the change in the element position within the same frame. 727100 5 jamesr 2012-09-24 17:07:49 -0700 OK. Is there any way to have tests for the behavior we want for inspector so instead of guessing we can just run the test and see if we need it or not? 727664 6 caseq 2012-09-25 08:24:02 -0700 Committed r129511: <http://trac.webkit.org/changeset/129511> 727671 7 caseq 2012-09-25 08:30:53 -0700 (In reply to comment #5) > OK. Is there any way to have tests for the behavior we want for inspector so instead of guessing we can just run the test and see if we need it or not? We can do that at least for current behavior (i.e. when we do not update overlay on each animation) -- this would basically be a regression test for this bug. Adding it as bug 97567. 165410 2012-09-24 10:55:56 -0700 2012-09-24 11:00:07 -0700 Patch bug-97466-20120924215516.patch text/plain 1487 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM0MGVlZDZhZjc5MDQwZmJjNTllOGQ2ODVkZjhlNTM4OWJkMzM0Y2IuLmQ1OWU4NGU4ZDM4YjUx NDE5MjgxZjUyNzcwMmI5YzYzYmE1NWY4MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMjQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIGFkZGluZyBhIHBhZ2Ugb3ZlcmxheSBjYXVz ZXMgZW5kbGVzcyB1cGRhdGUgbG9vcCB3aGVuIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIHVz ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90 IHVwZGF0ZSBvdmVybGF5cyB3aGVuIGNvbXBvc2l0aW5nKCkgLS0gZG9pbmcgc28gdWx0aW1hdGVs eSBjYXVzZXMgaW52YWxpZGF0aW9uCisgICAgICAgIG9mIHRoZSB2aWV3LCBoZW5jZSBhbm90aGVy IHVwZGF0ZSBhbmQgYW5vdGhlciBjYWxsIGRvIGNvbXBvc2l0ZSgpLiBMYXllcnMgc2hvdWxkIGJl CisgICAgICAgIHVwZGF0ZWQgb25seSB3aGVuIHRoZWlyIGNvbnRlbnQgY2hhbmdlcy4KKworICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs Ojpjb21wb3NpdGUpOgorCiAyMDEyLTA5LTI0ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjIyNDMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggNzY0YWU2ZGNh MWFhYTVlYjJkYmNmMmY3MDNkYmEwM2Y2Y2U0ODZhMS4uOGJiYTlkZTZlMjQwMWFjOTkzNTQxMDMy ZGE2ZDJhYTlhODkwZTBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcApAQCAtMTgxOSw5ICsxODE5LDYgQEAgdm9pZCBXZWJWaWV3SW1wbDo6Y29tcG9zaXRl KGJvb2wpCiAgICAgICAgIGlmICghcGFnZSgpKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAg ICAgIGlmIChtX3BhZ2VPdmVybGF5cykKLSAgICAgICAgICAgIG1fcGFnZU92ZXJsYXlzLT51cGRh dGUoKTsKLQogICAgICAgICBtX2xheWVyVHJlZVZpZXctPmNvbXBvc2l0ZSgpOwogICAgIH0KICNl bmRpZgo= 165411 2012-09-24 11:00:12 -0700 2012-09-24 17:08:10 -0700 Patch bug-97466-20120924215932.patch text/plain 1489 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM0MGVlZDZhZjc5MDQwZmJjNTllOGQ2ODVkZjhlNTM4OWJkMzM0Y2IuLjMwZWUxMjY0ZmJmNTY2 OGZlOWEwMWU4Zjk2NWUyZDc2ZGM0NGYzMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMjQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIGFkZGluZyBhIHBhZ2Ugb3ZlcmxheSBjYXVz ZXMgZW5kbGVzcyB1cGRhdGUgbG9vcCB3aGVuIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIHVz ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90 IHVwZGF0ZSBvdmVybGF5cyB3aGVuIGNvbXBvc2l0aW5nKCkgLS0gZG9pbmcgc28gdWx0aW1hdGVs eSBjYXVzZXMgaW52YWxpZGF0aW9uCisgICAgICAgIG9mIHRoZSB2aWV3LCBoZW5jZSBhbm90aGVy IHVwZGF0ZSBhbmQgYW5vdGhlciBjYWxsIGRvIGNvbXBvc2l0ZSgpLiBPdmVybGF5cyBzaG91bGQg YmUKKyAgICAgICAgdXBkYXRlZCBvbmx5IHdoZW4gdGhlaXIgY29udGVudCBjaGFuZ2VzLgorCisg ICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0lt cGw6OmNvbXBvc2l0ZSk6CisKIDIwMTItMDktMjQgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMjI0My4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA3NjRhZTZk Y2ExYWFhNWViMmRiY2YyZjcwM2RiYTAzZjZjZTQ4NmExLi44YmJhOWRlNmUyNDAxYWM5OTM1NDEw MzJkYTZkMmFhOWE4OTBlMGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwCkBAIC0xODE5LDkgKzE4MTksNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpjb21wb3Np dGUoYm9vbCkKICAgICAgICAgaWYgKCFwYWdlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAg ICAgICAgaWYgKG1fcGFnZU92ZXJsYXlzKQotICAgICAgICAgICAgbV9wYWdlT3ZlcmxheXMtPnVw ZGF0ZSgpOwotCiAgICAgICAgIG1fbGF5ZXJUcmVlVmlldy0+Y29tcG9zaXRlKCk7CiAgICAgfQog I2VuZGlmCg==