97462 2012-09-24 09:46:28 -0700 Web Inspector: [TextEditor] fix tab unindent selection restore 2012-09-26 02:08:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov bweinstein joepeck keishi loislo me pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 726769 0 aandrey 2012-09-24 09:46:28 -0700 Selection would be wrongly restored on tab unindent in the following example: " var a = 1; var" b = 2; (where selection is marked by quotes) which will become: "var a = 1; v"ar b = 2; while should be: "var a = 1; var" b = 2; Patch to follow. 726775 1 165402 aandrey 2012-09-24 09:48:54 -0700 Created attachment 165402 Patch 726782 2 165402 pfeldman 2012-09-24 09:54:51 -0700 Comment on attachment 165402 Patch A test? 726788 3 aandrey 2012-09-24 09:58:28 -0700 @Nikita, have you written any test on the indent/unindent feature? 726797 4 me 2012-09-24 10:02:18 -0700 Andrey, http://trac.webkit.org/browser/trunk/LayoutTests/inspector/editor/indentation.html 726799 5 aandrey 2012-09-24 10:05:38 -0700 Thanks! Will update the patch with a test. 727461 6 165569 aandrey 2012-09-25 03:21:08 -0700 Created attachment 165569 Patch 728332 7 165569 webkit.review.bot 2012-09-26 02:08:36 -0700 Comment on attachment 165569 Patch Clearing flags on attachment: 165569 Committed r129613: <http://trac.webkit.org/changeset/129613> 728333 8 webkit.review.bot 2012-09-26 02:08:40 -0700 All reviewed patches have been landed. Closing bug. 165402 2012-09-24 09:48:54 -0700 2012-09-24 10:07:13 -0700 Patch bug-97462-20120924204814.patch text/plain 1837 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk2ZGNlNGUzYzczYTEz OWI1MWFhMDhhYTBlZGJmMDUzYzVjZjc4MS4uNjUzOTNjMmI3M2EwOWIwOTczOGQyYjNhOTdkNWJi MWRkNGEyZWIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTI0ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtUZXh0RWRpdG9yXSBmaXggdGFiIHVuaW5kZW50IHNlbGVjdGlvbiByZXN0b3JlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbGVjdGlvbiB3b3Vs ZCBiZSB3cm9uZ2x5IHJlc3RvcmVkIG9uIHRhYiB1bmluZGVudCB3aGVuIHRoZSBsYXN0IGxpbmUg ZG9lcyBub3QgbmVlZCB0byBiZSB1bmluZGVudGVkIHVubGlrZSB0aGUgb3RoZXJzLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fdW5pbmRlbnRMaW5l cy5nZXQgdmFyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnBy b3RvdHlwZS5fdW5pbmRlbnRMaW5lcyk6CisKIDIwMTItMDktMjQgIEpvbmF0aGFuIExpdSAgPG5l dDE0N0BnbWFpbC5jb20+CiAKICAgICAgICAgVXNlIHVuc2lnbmVkIGNoYXIgZm9yIGJpdGZpZWxk IGluc3RlYWQgb2YgdW5zaWduZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcwppbmRleCBmOTBiOTAyZTNiYzBlNTdj ZDllZjYxNmJkZTkyZDU2NDQ3OGIxNzlkLi5lZTkyMDk4Y2RiMjc0YzVkNDAzZGMzM2ZkNTkxMWUz MGVjNmRjMmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RlZmF1bHRUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKQEAgLTE1NjMsMTEgKzE1NjMsMTAgQEAgV2ViSW5z cGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgICAgICAgICBp ZiAobGluZU51bWJlciA9PT0gcmFuZ2Uuc3RhcnRMaW5lKQogICAgICAgICAgICAgICAgIG5ld1Jh bmdlLnN0YXJ0Q29sdW1uID0gTWF0aC5tYXgoMCwgbmV3UmFuZ2Uuc3RhcnRDb2x1bW4gLSBsaW5l SW5kZW50TGVuZ3RoKTsKKyAgICAgICAgICAgIGlmIChsaW5lTnVtYmVyID09PSByYW5nZS5lbmRM aW5lKQorICAgICAgICAgICAgICAgIG5ld1JhbmdlLmVuZENvbHVtbiA9IE1hdGgubWF4KDAsIG5l d1JhbmdlLmVuZENvbHVtbiAtIGxpbmVJbmRlbnRMZW5ndGgpOwogICAgICAgICB9CiAKLSAgICAg ICAgaWYgKGxpbmVJbmRlbnRMZW5ndGgpCi0gICAgICAgICAgICBuZXdSYW5nZS5lbmRDb2x1bW4g PSBNYXRoLm1heCgwLCBuZXdSYW5nZS5lbmRDb2x1bW4gLSBsaW5lSW5kZW50TGVuZ3RoKTsKLQog ICAgICAgICB0aGlzLl9sYXN0RWRpdGVkUmFuZ2UgPSBuZXdSYW5nZTsKIAogICAgICAgICByZXR1 cm4gbmV3UmFuZ2U7Cg== 165569 2012-09-25 03:21:08 -0700 2012-09-26 02:08:36 -0700 Patch bug-97462-20120925142027.patch text/plain 4038 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM0Y2QxZWY0ZDVjMmM5 MTI5ZjZmMjVhMjVlYzQ5NGY1NzM2MDE5Zi4uY2FkNjM4ZDU0MjM1YThkNDhlZGZkOGI3OWU1YTMw MGJkZjljNzYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTI1ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtUZXh0RWRpdG9yXSBmaXggdGFiIHVuaW5kZW50IHNlbGVjdGlvbiByZXN0b3JlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQ2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbGVjdGlvbiB3b3Vs ZCBiZSB3cm9uZ2x5IHJlc3RvcmVkIG9uIHRhYiB1bmluZGVudCB3aGVuIHRoZSBsYXN0IGxpbmUg ZG9lcyBub3QgbmVlZCB0byBiZSB1bmluZGVudGVkIHVubGlrZSB0aGUgb3RoZXJzLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fdW5pbmRlbnRMaW5l cy5nZXQgdmFyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnBy b3RvdHlwZS5fdW5pbmRlbnRMaW5lcyk6CisKIDIwMTItMDktMjQgIEFuZHJleSBBZGFpa2luICA8 YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1dlYkdMXSBG aXJzdCBzdGVwIHRvd2FyZHMgMkQgY2FudmFzIGluc3RydW1lbnRhdGlvbiBpbiBpbmplY3RlZCBz Y3JpcHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVm YXVsdFRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Rl ZmF1bHRUZXh0RWRpdG9yLmpzCmluZGV4IDY5Yzg3Y2UxMjkwOWU5MDliYTA1YmYxMzg1YjQwYmMx YWNlNWJlODUuLjQ0ZTg0N2UwY2I0NThmMmQ2YjZhZWEzYTI5NjI0YjNkMGIxZjhlZGIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0 b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4 dEVkaXRvci5qcwpAQCAtMTU2MywxMSArMTU2MywxMCBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgICAgIGlmIChsaW5lTnVtYmVyID09 PSByYW5nZS5zdGFydExpbmUpCiAgICAgICAgICAgICAgICAgbmV3UmFuZ2Uuc3RhcnRDb2x1bW4g PSBNYXRoLm1heCgwLCBuZXdSYW5nZS5zdGFydENvbHVtbiAtIGxpbmVJbmRlbnRMZW5ndGgpOwor ICAgICAgICAgICAgaWYgKGxpbmVOdW1iZXIgPT09IHJhbmdlLmVuZExpbmUpCisgICAgICAgICAg ICAgICAgbmV3UmFuZ2UuZW5kQ29sdW1uID0gTWF0aC5tYXgoMCwgbmV3UmFuZ2UuZW5kQ29sdW1u IC0gbGluZUluZGVudExlbmd0aCk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAobGluZUluZGVu dExlbmd0aCkKLSAgICAgICAgICAgIG5ld1JhbmdlLmVuZENvbHVtbiA9IE1hdGgubWF4KDAsIG5l d1JhbmdlLmVuZENvbHVtbiAtIGxpbmVJbmRlbnRMZW5ndGgpOwotCiAgICAgICAgIHRoaXMuX2xh c3RFZGl0ZWRSYW5nZSA9IG5ld1JhbmdlOwogCiAgICAgICAgIHJldHVybiBuZXdSYW5nZTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCBkMzAyOGI2YjA0NjRlZTk4YjcxMTgwMTIxMDAxYzJjNGFjZGYyZTIyLi41MGZhZTc2MTU5 YTZmMGY0ZDhjMmYwNzZkZjMwNWRhZjUwNjU1MWIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTItMDktMjUgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgV2ViIEluc3BlY3RvcjogW1RleHRFZGl0b3JdIGZpeCB0YWIgdW5pbmRlbnQgc2VsZWN0aW9u IHJlc3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3NDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgdGVzdCBmb3IgYW4gdW5pbmRlbnRhdGlvbiBjb3JuZXIgY2FzZS4KKworICAgICAgICAq IGluc3BlY3Rvci9lZGl0b3IvaW5kZW50YXRpb24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGlu c3BlY3Rvci9lZGl0b3IvaW5kZW50YXRpb24uaHRtbDoKKwogMjAxMi0wOS0yNCAgUmFwaGFlbCBL dWJvIGRhIENvc3RhICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9lZGl0b3IvaW5kZW50YXRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2VkaXRvci9pbmRlbnRhdGlvbi1leHBlY3RlZC50eHQKaW5kZXggMjhiMTZjMDI5MTY1 YjdlNGY3MGQ5ZGExMjI5MGIyYjYyY2NmMzUwNy4uY2I3ZGM1OWY1NjdiMWI2ZjMyNTY3YzViZWI1 MmQzZTE5MjJlZjM0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VkaXRvci9p bmRlbnRhdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VkaXRv ci9pbmRlbnRhdGlvbi1leHBlY3RlZC50eHQKQEAgLTE4LDYgKzE4LDEyIEBAIEFmdGVyIHVuaW5k ZW50aW5nIHR3byBmdWxseSBzZWxlY3RlZCBsaW5lcwogICovCiBTZWxlY3Rpb24gMCwwIDIsMAog CitBZnRlciB1bmluZGVudGluZyB0d28gcGFydGlhbGx5IHNlbGVjdGVkIGxpbmVzIChidWcgOTc0 NjIpCisvKgorKiBhIGNvbW1lbnQKKyAqLworU2VsZWN0aW9uIDAsMSAxLDYKKwogQWZ0ZXIgdW5p bmRlbnRpbmcgdGhyZWUgcGFydGlhbGx5IHNlbGVjdGVkIGxpbmVzCiAvKgogKiBhIGNvbW1lbnQK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lZGl0b3IvaW5kZW50YXRpb24uaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9lZGl0b3IvaW5kZW50YXRpb24uaHRtbAppbmRleCBi M2VjNGRmZjU2ODBhMTkxMzM1OTM5MDg4Nzc2MTM3ZTc0MTIzMzZmLi5lNTFhMGQ1MTY1OTg3MGZk M2M4ZTdhNjc4MWMyNzc0NzlhNDc5MGQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZWRpdG9yL2luZGVudGF0aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Vk aXRvci9pbmRlbnRhdGlvbi5odG1sCkBAIC0zMSw2ICszMSw5IEBAIGZ1bmN0aW9uIHRlc3QoKQog ICAgIHNlbGVjdGlvbiA9IHRleHRFZGl0b3JNYWluUGFuZWwuX3VuaW5kZW50TGluZXMobmV3IFdl Ykluc3BlY3Rvci5UZXh0UmFuZ2UoMCwgMCwgMiwgMCkpOwogICAgIGR1bXBUZXh0TW9kZWwoIkFm dGVyIHVuaW5kZW50aW5nIHR3byBmdWxseSBzZWxlY3RlZCBsaW5lcyIpOwogCisgICAgc2VsZWN0 aW9uID0gdGV4dEVkaXRvck1haW5QYW5lbC5fdW5pbmRlbnRMaW5lcyhuZXcgV2ViSW5zcGVjdG9y LlRleHRSYW5nZSgwLCA1LCAxLCA2KSk7CisgICAgZHVtcFRleHRNb2RlbCgiQWZ0ZXIgdW5pbmRl bnRpbmcgdHdvIHBhcnRpYWxseSBzZWxlY3RlZCBsaW5lcyAoYnVnIDk3NDYyKSIpOworCiAgICAg c2VsZWN0aW9uID0gdGV4dEVkaXRvck1haW5QYW5lbC5fdW5pbmRlbnRMaW5lcyhuZXcgV2ViSW5z cGVjdG9yLlRleHRSYW5nZSgwLCAwLCAyLCAzKSk7CiAgICAgZHVtcFRleHRNb2RlbCgiQWZ0ZXIg dW5pbmRlbnRpbmcgdGhyZWUgcGFydGlhbGx5IHNlbGVjdGVkIGxpbmVzIik7CiAK