97460 2012-09-24 09:30:43 -0700 [GTK] Add Select All method to WebKit2 GTK+ API 2012-09-24 12:53:26 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 spena spena cgarcia gustavo gyuyoung.kim mrobinson rakuco webkit.review.bot oldest_to_newest 726745 0 spena 2012-09-24 09:30:43 -0700 [GTK] Add Select All method to WebKit2 GTK+ API 726767 1 165400 spena 2012-09-24 09:45:07 -0700 Created attachment 165400 Patch 726772 2 spena 2012-09-24 09:48:06 -0700 Updating component and adding Carlos to CC. Carlos, I'm not sure if the unit test is a bit redundat right now, checking the same both when it's editable or not. What do you think? Do you think I should be testing anything else? 726777 3 webkit.review.bot 2012-09-24 09:50:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 726821 4 165400 mrobinson 2012-09-24 10:36:42 -0700 Comment on attachment 165400 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165400&action=review Nice work. The tests you have written are more than adequate, in my opinion. I just have a few minor nits. Do you mind just uploading a new patch and then I can commit it for you. > Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:59 > + void executeEditingCommand(const char* command) > + { > + webkit_web_view_execute_editing_command(m_webView, command); > + } > + Since this method just does one thing, it probably makes a bit more sense just do call webkit_web_view_execute_editing_command from the test. It makes it a bit more clear what API you are actually testing there. > Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:157 > + // Initially only the subspan is selected Just a minor nit here. Comments in WebKit should have a period at the end. 726850 5 165414 spena 2012-09-24 11:07:08 -0700 Created attachment 165414 Patch 726852 6 spena 2012-09-24 11:07:52 -0700 (In reply to comment #5) > Created an attachment (id=165414) [details] > Patch Addressing Martin's comments here 726931 7 165414 webkit.review.bot 2012-09-24 12:53:22 -0700 Comment on attachment 165414 Patch Clearing flags on attachment: 165414 Committed r129399: <http://trac.webkit.org/changeset/129399> 726933 8 webkit.review.bot 2012-09-24 12:53:26 -0700 All reviewed patches have been landed. Closing bug. 165400 2012-09-24 09:45:07 -0700 2012-09-24 11:07:00 -0700 Patch bug-97460-20120924184427.patch text/plain 6577 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDllZWE0NDI2MWFjNGUx NzUzZTYwNjEzNmY4NTY2MWM1YWFlNjFkMS4uNzMxZWRlYzQ3MTIxNTY1ODIxNDA1ZWM2MjkzMzg1 MDMyYmY2ZjBkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTI0ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgU2VsZWN0IEFs bCBtZXRob2QgdG8gV2ViS2l0MiBHVEsrIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGb2xsb3dpbmcgdGhlIHNhbWUgYXBwcm9hY2ggdXNlZCB3aGVu IGFkZGVkIEN1dCwgQ29weSBhbmQgUGFzdGUsCisgICAgICAgIHRoZSBTZWxlY3QgQWxsIG1ldGhv ZCBpcyBhZGRlZCB0byB0aGUgV2ViS2l0MiBHVEsrIEFQSS4KKworICAgICAgICBUaGlzIGludHJv ZHVjZXMgYSBuZXcgbWFjcm8gaW4gdGhlIFdlYktpdEVkaXRpbmdDb21tYW5kcywKKyAgICAgICAg dXBkYXRlcyB0aGUgZG9jdW1lbnRhdGlvbiwgYW5kIGluY2x1ZGVzIGEgbmV3IHVuaXQgdGVzdC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRpbmdDb21tYW5kcy5oOiBB ZGQgYSBuZXcgbWFjcm8gZm9yCisgICAgICAgIHRoZSBTZWxlY3QgQWxsIGNvbW1hbmQuCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dDogSW5j bHVkZSB0aGUgU2VsZWN0IEFsbAorICAgICAgICBjb21tYW5kIGluIHRoZSBkb2N1bWVudGF0aW9u LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJWaWV3RWRpdG9yLmNw cDogQ292ZXIgdGhlIG5ldyBjb21tYW5kCisgICAgICAgIHdpdGggYSB1bml0IHRlc3QuCisgICAg ICAgICh0ZXN0V2ViVmlld0VkaXRvclNlbGVjdEFsbCk6CisgICAgICAgIChiZWZvcmVBbGwpOgor CiAyMDEyLTA5LTIzICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtFRkxdW1dLMl0gQWRkIHNldHRpbmcgdG8gdG9nZ2xlIGRldmVsb3BlciBleHRlbnNp b25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRF ZGl0aW5nQ29tbWFuZHMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEVkaXRpbmdDb21tYW5kcy5oCmluZGV4IGY4NWJmMzFiZGU2OTkyMzVhYzBhM2QwNjVmNjBjMjM4 ZWU2Y2I0NGMuLjM2YzcyYTBkM2Q3NDUzY2YwN2ZmMzVmZWI3ZGI5ZWU4YzY0NGYyNWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRpbmdDb21t YW5kcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRp bmdDb21tYW5kcy5oCkBAIC02Miw2ICs2MiwxNSBAQCBHX0JFR0lOX0RFQ0xTCiAgKi8KICNkZWZp bmUgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9QQVNURSAiUGFzdGUiCiAKKy8qKgorICogV0VCS0lU X0VESVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMOgorICoKKyAqIFRoZSBzZWxlY3QgYWxsIGNvbW1h bmQuIFNlbGVjdHMgYWxsIHRoZSBjb250ZW50IG9mIHRoZSBjdXJyZW50IHRleHQgZmllbGQgaW4K KyAqIGEgI1dlYktpdFdlYlZpZXcuCisgKiBJdCBpcyBhbHdheXMgcG9zc2libGUgdG8gc2VsZWN0 IGFsbCB0ZXh0LCBubyBtYXR0ZXIgd2hldGVyIHRoZSAjV2ViS2l0V2ViVmlldyBjb250ZW50Cisg KiBpcyBlZGl0YWJsZSBvciBub3QuIFlvdSBjYW4gc3RpbGwgY2hlY2sgaXQgd2l0aCB3ZWJraXRf d2ViX3ZpZXdfY2FuX2V4ZWN1dGVfZWRpdGluZ19jb21tYW5kKCkuCisgKi8KKyNkZWZpbmUgV0VC S0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMICJTZWxlY3RBbGwiCiAKIEdfRU5EX0RFQ0xT CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9k b2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4IDRmNWIzNmM0ZDUyMzU0NTkyNjhiZmIx MjNjOTNlYjdhYzMyZGZlNjUuLmJiZjk3OWI2NGFkYTRhNmMwZmVhOWEwMGMyYWIyMmU0YThiZjVh ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtNzAsNiArNzAsNyBAQCBXZWJLaXRT YXZlTW9kZQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9DVVQKIFdFQktJVF9FRElUSU5HX0NPTU1B TkRfQ09QWQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9QQVNURQorV0VCS0lUX0VESVRJTkdfQ09N TUFORF9TRUxFQ1RfQUxMCiAKIDxTVUJTRUNUSU9OPgogd2Via2l0X3dlYl92aWV3X25ldwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYlZp ZXdFZGl0b3IuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVz dFdlYlZpZXdFZGl0b3IuY3BwCmluZGV4IDk3ZWJlNWIyNzM0M2MyOTQ4MmQ1NDRhNTVlYzQ0ZTUy OTk2YjU0ZjMuLjczNzUwZWRlNjVlZjliZjlmYjIyODdkMmI1MDU3ZWM0Yjc4N2ZiZGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJWaWV3 RWRpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9U ZXN0V2ViVmlld0VkaXRvci5jcHAKQEAgLTUyLDYgKzUyLDExIEBAIHB1YmxpYzoKICAgICAgICAg cmV0dXJuIG1fY2FuRXhlY3V0ZUVkaXRpbmdDb21tYW5kOwogICAgIH0KIAorICAgIHZvaWQgZXhl Y3V0ZUVkaXRpbmdDb21tYW5kKGNvbnN0IGNoYXIqIGNvbW1hbmQpCisgICAgeworICAgICAgICB3 ZWJraXRfd2ViX3ZpZXdfZXhlY3V0ZV9lZGl0aW5nX2NvbW1hbmQobV93ZWJWaWV3LCBjb21tYW5k KTsKKyAgICB9CisKICAgICBzdGF0aWMgZ2Jvb2xlYW4gd2FpdEZvckNsaXBib2FyZFRleHQoRWRp dG9yVGVzdCogdGVzdCkKICAgICB7CiAgICAgICAgIHRlc3QtPm1fdHJpZXNDb3VudCsrOwpAQCAt MTMxLDEwICsxMzYsNzAgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdFZGl0b3JDdXRDb3B5UGFz dGVFZGl0YWJsZShFZGl0b3JUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGUKICAgICBnX2Fzc2VydF9j bXBzdHIoY2xpcGJvYXJkVGV4dC5nZXQoKSwgPT0sICJBbGwgd29yayBhbmQgbm8gcGxheSBtYWtl IEphY2sgYSBkdWxsIGJveS4iKTsKIH0KIAorc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdFZGl0b3JT ZWxlY3RBbGxOb25FZGl0YWJsZShFZGl0b3JUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQorewor ICAgIHN0YXRpYyBjb25zdCBjaGFyKiBzZWxlY3RlZFNwYW5IVE1MID0gIjxodG1sPjxib2R5IGNv bnRlbnRFZGl0YWJsZT1cImZhbHNlXCI+IgorICAgICAgICAiPHNwYW4gaWQ9XCJtYWluc3Bhblwi PkFsbCB3b3JrIGFuZCBubyBwbGF5IDxzcGFuIGlkPVwic3Vic3BhblwiPm1ha2UgSmFjayBhIGR1 bGw8L3NwYW4+IGJveS48L3NwYW4+IgorICAgICAgICAiPHNjcmlwdD5kb2N1bWVudC5nZXRTZWxl Y3Rpb24oKS5jb2xsYXBzZSgpO1xuIgorICAgICAgICAiZG9jdW1lbnQuZ2V0U2VsZWN0aW9uKCku c2VsZWN0QWxsQ2hpbGRyZW4oZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3N1YnNwYW4nKSk7XG4i CisgICAgICAgICI8L3NjcmlwdD48L2JvZHk+PC9odG1sPiI7CisKKyAgICBnX2Fzc2VydCh0ZXN0 LT5jYW5FeGVjdXRlRWRpdGluZ0NvbW1hbmQoV0VCS0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1Rf QUxMKSk7CisKKyAgICB0ZXN0LT5sb2FkSHRtbChzZWxlY3RlZFNwYW5IVE1MLCAwKTsKKyAgICB0 ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsKKworICAgIGdfYXNzZXJ0KHRlc3QtPmNhbkV4 ZWN1dGVFZGl0aW5nQ29tbWFuZChXRUJLSVRfRURJVElOR19DT01NQU5EX1NFTEVDVF9BTEwpKTsK KworICAgIHRlc3QtPmNvcHlDbGlwYm9hcmQoKTsKKyAgICBHT3duUHRyPGNoYXI+IGNsaXBib2Fy ZFRleHQoZ3RrX2NsaXBib2FyZF93YWl0X2Zvcl90ZXh0KHRlc3QtPm1fY2xpcGJvYXJkKSk7CisK KyAgICAvLyBJbml0aWFsbHkgb25seSB0aGUgc3Vic3BhbiBpcyBzZWxlY3RlZAorICAgIGdfYXNz ZXJ0X2NtcHN0cihjbGlwYm9hcmRUZXh0LmdldCgpLCA9PSwgIm1ha2UgSmFjayBhIGR1bGwiKTsK KworICAgIHRlc3QtPmV4ZWN1dGVFZGl0aW5nQ29tbWFuZChXRUJLSVRfRURJVElOR19DT01NQU5E X1NFTEVDVF9BTEwpOworICAgIHRlc3QtPmNvcHlDbGlwYm9hcmQoKTsKKyAgICBjbGlwYm9hcmRU ZXh0LnNldChndGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQodGVzdC0+bV9jbGlwYm9hcmQpKTsK KworICAgIC8vIFRoZSBtYWluc3BhbiBzaG91bGQgYmUgc2VsZWN0ZWQgYWZ0ZXIgY2FsbGluZyBT RUxFQ1RfQUxMCisgICAgZ19hc3NlcnRfY21wc3RyKGNsaXBib2FyZFRleHQuZ2V0KCksID09LCAi QWxsIHdvcmsgYW5kIG5vIHBsYXkgbWFrZSBKYWNrIGEgZHVsbCBib3kuIik7Cit9CisKK3N0YXRp YyB2b2lkIHRlc3RXZWJWaWV3RWRpdG9yU2VsZWN0QWxsRWRpdGFibGUoRWRpdG9yVGVzdCogdGVz dCwgZ2NvbnN0cG9pbnRlcikKK3sKKyAgICBzdGF0aWMgY29uc3QgY2hhciogc2VsZWN0ZWRTcGFu SFRNTCA9ICI8aHRtbD48Ym9keSBjb250ZW50RWRpdGFibGU9XCJ0cnVlXCI+IgorICAgICAgICAi PHNwYW4gaWQ9XCJtYWluc3BhblwiPkFsbCB3b3JrIGFuZCBubyBwbGF5IDxzcGFuIGlkPVwic3Vi c3BhblwiPm1ha2UgSmFjayBhIGR1bGw8L3NwYW4+IGJveS48L3NwYW4+IgorICAgICAgICAiPHNj cmlwdD5kb2N1bWVudC5nZXRTZWxlY3Rpb24oKS5jb2xsYXBzZSgpO1xuIgorICAgICAgICAiZG9j dW1lbnQuZ2V0U2VsZWN0aW9uKCkuc2VsZWN0QWxsQ2hpbGRyZW4oZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3N1YnNwYW4nKSk7XG4iCisgICAgICAgICI8L3NjcmlwdD48L2JvZHk+PC9odG1sPiI7 CisKKyAgICBnX2Fzc2VydCh0ZXN0LT5jYW5FeGVjdXRlRWRpdGluZ0NvbW1hbmQoV0VCS0lUX0VE SVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMKSk7CisKKyAgICB0ZXN0LT5sb2FkSHRtbChzZWxlY3Rl ZFNwYW5IVE1MLCAwKTsKKyAgICB0ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsKKworICAg IGdfYXNzZXJ0KHRlc3QtPmNhbkV4ZWN1dGVFZGl0aW5nQ29tbWFuZChXRUJLSVRfRURJVElOR19D T01NQU5EX1NFTEVDVF9BTEwpKTsKKworICAgIHRlc3QtPmNvcHlDbGlwYm9hcmQoKTsKKyAgICBH T3duUHRyPGNoYXI+IGNsaXBib2FyZFRleHQoZ3RrX2NsaXBib2FyZF93YWl0X2Zvcl90ZXh0KHRl c3QtPm1fY2xpcGJvYXJkKSk7CisKKyAgICAvLyBJbml0aWFsbHkgb25seSB0aGUgc3Vic3BhbiBp cyBzZWxlY3RlZAorICAgIGdfYXNzZXJ0X2NtcHN0cihjbGlwYm9hcmRUZXh0LmdldCgpLCA9PSwg Im1ha2UgSmFjayBhIGR1bGwiKTsKKworICAgIHRlc3QtPmV4ZWN1dGVFZGl0aW5nQ29tbWFuZChX RUJLSVRfRURJVElOR19DT01NQU5EX1NFTEVDVF9BTEwpOworICAgIHRlc3QtPmNvcHlDbGlwYm9h cmQoKTsKKyAgICBjbGlwYm9hcmRUZXh0LnNldChndGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQo dGVzdC0+bV9jbGlwYm9hcmQpKTsKKworICAgIC8vIFRoZSBtYWluc3BhbiBzaG91bGQgYmUgc2Vs ZWN0ZWQgYWZ0ZXIgY2FsbGluZyBTRUxFQ1RfQUxMCisgICAgZ19hc3NlcnRfY21wc3RyKGNsaXBi b2FyZFRleHQuZ2V0KCksID09LCAiQWxsIHdvcmsgYW5kIG5vIHBsYXkgbWFrZSBKYWNrIGEgZHVs bCBib3kuIik7Cit9CisKIHZvaWQgYmVmb3JlQWxsKCkKIHsKICAgICBFZGl0b3JUZXN0OjphZGQo IldlYktpdFdlYlZpZXciLCAiY3V0LWNvcHktcGFzdGUvbm9uLWVkaXRhYmxlIiwgdGVzdFdlYlZp ZXdFZGl0b3JDdXRDb3B5UGFzdGVOb25FZGl0YWJsZSk7CiAgICAgRWRpdG9yVGVzdDo6YWRkKCJX ZWJLaXRXZWJWaWV3IiwgImN1dC1jb3B5LXBhc3RlL2VkaXRhYmxlIiwgdGVzdFdlYlZpZXdFZGl0 b3JDdXRDb3B5UGFzdGVFZGl0YWJsZSk7CisgICAgRWRpdG9yVGVzdDo6YWRkKCJXZWJLaXRXZWJW aWV3IiwgInNlbGVjdC1hbGwvbm9uLWVkaXRhYmxlIiwgdGVzdFdlYlZpZXdFZGl0b3JTZWxlY3RB bGxOb25FZGl0YWJsZSk7CisgICAgRWRpdG9yVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInNl bGVjdC1hbGwvZWRpdGFibGUiLCB0ZXN0V2ViVmlld0VkaXRvclNlbGVjdEFsbEVkaXRhYmxlKTsK IH0KIAogdm9pZCBhZnRlckFsbCgpCg== 165414 2012-09-24 11:07:08 -0700 2012-09-24 12:53:22 -0700 Patch bug-97460-20120924200628.patch text/plain 6322 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDllZWE0NDI2MWFjNGUx NzUzZTYwNjEzNmY4NTY2MWM1YWFlNjFkMS4uNzMxZWRlYzQ3MTIxNTY1ODIxNDA1ZWM2MjkzMzg1 MDMyYmY2ZjBkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTI0ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgU2VsZWN0IEFs bCBtZXRob2QgdG8gV2ViS2l0MiBHVEsrIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGb2xsb3dpbmcgdGhlIHNhbWUgYXBwcm9hY2ggdXNlZCB3aGVu IGFkZGVkIEN1dCwgQ29weSBhbmQgUGFzdGUsCisgICAgICAgIHRoZSBTZWxlY3QgQWxsIG1ldGhv ZCBpcyBhZGRlZCB0byB0aGUgV2ViS2l0MiBHVEsrIEFQSS4KKworICAgICAgICBUaGlzIGludHJv ZHVjZXMgYSBuZXcgbWFjcm8gaW4gdGhlIFdlYktpdEVkaXRpbmdDb21tYW5kcywKKyAgICAgICAg dXBkYXRlcyB0aGUgZG9jdW1lbnRhdGlvbiwgYW5kIGluY2x1ZGVzIGEgbmV3IHVuaXQgdGVzdC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRpbmdDb21tYW5kcy5oOiBB ZGQgYSBuZXcgbWFjcm8gZm9yCisgICAgICAgIHRoZSBTZWxlY3QgQWxsIGNvbW1hbmQuCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dDogSW5j bHVkZSB0aGUgU2VsZWN0IEFsbAorICAgICAgICBjb21tYW5kIGluIHRoZSBkb2N1bWVudGF0aW9u LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJWaWV3RWRpdG9yLmNw cDogQ292ZXIgdGhlIG5ldyBjb21tYW5kCisgICAgICAgIHdpdGggYSB1bml0IHRlc3QuCisgICAg ICAgICh0ZXN0V2ViVmlld0VkaXRvclNlbGVjdEFsbCk6CisgICAgICAgIChiZWZvcmVBbGwpOgor CiAyMDEyLTA5LTIzICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtFRkxdW1dLMl0gQWRkIHNldHRpbmcgdG8gdG9nZ2xlIGRldmVsb3BlciBleHRlbnNp b25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRF ZGl0aW5nQ29tbWFuZHMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEVkaXRpbmdDb21tYW5kcy5oCmluZGV4IGY4NWJmMzFiZGU2OTkyMzVhYzBhM2QwNjVmNjBjMjM4 ZWU2Y2I0NGMuLjM2YzcyYTBkM2Q3NDUzY2YwN2ZmMzVmZWI3ZGI5ZWU4YzY0NGYyNWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRpbmdDb21t YW5kcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVkaXRp bmdDb21tYW5kcy5oCkBAIC02Miw2ICs2MiwxNSBAQCBHX0JFR0lOX0RFQ0xTCiAgKi8KICNkZWZp bmUgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9QQVNURSAiUGFzdGUiCiAKKy8qKgorICogV0VCS0lU X0VESVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMOgorICoKKyAqIFRoZSBzZWxlY3QgYWxsIGNvbW1h bmQuIFNlbGVjdHMgYWxsIHRoZSBjb250ZW50IG9mIHRoZSBjdXJyZW50IHRleHQgZmllbGQgaW4K KyAqIGEgI1dlYktpdFdlYlZpZXcuCisgKiBJdCBpcyBhbHdheXMgcG9zc2libGUgdG8gc2VsZWN0 IGFsbCB0ZXh0LCBubyBtYXR0ZXIgd2hldGVyIHRoZSAjV2ViS2l0V2ViVmlldyBjb250ZW50Cisg KiBpcyBlZGl0YWJsZSBvciBub3QuIFlvdSBjYW4gc3RpbGwgY2hlY2sgaXQgd2l0aCB3ZWJraXRf d2ViX3ZpZXdfY2FuX2V4ZWN1dGVfZWRpdGluZ19jb21tYW5kKCkuCisgKi8KKyNkZWZpbmUgV0VC S0lUX0VESVRJTkdfQ09NTUFORF9TRUxFQ1RfQUxMICJTZWxlY3RBbGwiCiAKIEdfRU5EX0RFQ0xT CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9k b2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4IDRmNWIzNmM0ZDUyMzU0NTkyNjhiZmIx MjNjOTNlYjdhYzMyZGZlNjUuLmJiZjk3OWI2NGFkYTRhNmMwZmVhOWEwMGMyYWIyMmU0YThiZjVh ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtNzAsNiArNzAsNyBAQCBXZWJLaXRT YXZlTW9kZQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9DVVQKIFdFQktJVF9FRElUSU5HX0NPTU1B TkRfQ09QWQogV0VCS0lUX0VESVRJTkdfQ09NTUFORF9QQVNURQorV0VCS0lUX0VESVRJTkdfQ09N TUFORF9TRUxFQ1RfQUxMCiAKIDxTVUJTRUNUSU9OPgogd2Via2l0X3dlYl92aWV3X25ldwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYlZp ZXdFZGl0b3IuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVz dFdlYlZpZXdFZGl0b3IuY3BwCmluZGV4IDk3ZWJlNWIyNzM0M2MyOTQ4MmQ1NDRhNTVlYzQ0ZTUy OTk2YjU0ZjMuLjkzMzE1ZGI2OGQ2NzUxMWMyNTVjMWZjOGI0NDEyZTg5NzhlYTY0OTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJWaWV3 RWRpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9U ZXN0V2ViVmlld0VkaXRvci5jcHAKQEAgLTEzMSwxMCArMTMxLDcwIEBAIHN0YXRpYyB2b2lkIHRl c3RXZWJWaWV3RWRpdG9yQ3V0Q29weVBhc3RlRWRpdGFibGUoRWRpdG9yVGVzdCogdGVzdCwgZ2Nv bnN0cG9pbnRlCiAgICAgZ19hc3NlcnRfY21wc3RyKGNsaXBib2FyZFRleHQuZ2V0KCksID09LCAi QWxsIHdvcmsgYW5kIG5vIHBsYXkgbWFrZSBKYWNrIGEgZHVsbCBib3kuIik7CiB9CiAKK3N0YXRp YyB2b2lkIHRlc3RXZWJWaWV3RWRpdG9yU2VsZWN0QWxsTm9uRWRpdGFibGUoRWRpdG9yVGVzdCog dGVzdCwgZ2NvbnN0cG9pbnRlcikKK3sKKyAgICBzdGF0aWMgY29uc3QgY2hhciogc2VsZWN0ZWRT cGFuSFRNTCA9ICI8aHRtbD48Ym9keSBjb250ZW50RWRpdGFibGU9XCJmYWxzZVwiPiIKKyAgICAg ICAgIjxzcGFuIGlkPVwibWFpbnNwYW5cIj5BbGwgd29yayBhbmQgbm8gcGxheSA8c3BhbiBpZD1c InN1YnNwYW5cIj5tYWtlIEphY2sgYSBkdWxsPC9zcGFuPiBib3kuPC9zcGFuPiIKKyAgICAgICAg IjxzY3JpcHQ+ZG9jdW1lbnQuZ2V0U2VsZWN0aW9uKCkuY29sbGFwc2UoKTtcbiIKKyAgICAgICAg ImRvY3VtZW50LmdldFNlbGVjdGlvbigpLnNlbGVjdEFsbENoaWxkcmVuKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdzdWJzcGFuJykpO1xuIgorICAgICAgICAiPC9zY3JpcHQ+PC9ib2R5PjwvaHRt bD4iOworCisgICAgZ19hc3NlcnQodGVzdC0+Y2FuRXhlY3V0ZUVkaXRpbmdDb21tYW5kKFdFQktJ VF9FRElUSU5HX0NPTU1BTkRfU0VMRUNUX0FMTCkpOworCisgICAgdGVzdC0+bG9hZEh0bWwoc2Vs ZWN0ZWRTcGFuSFRNTCwgMCk7CisgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CisK KyAgICBnX2Fzc2VydCh0ZXN0LT5jYW5FeGVjdXRlRWRpdGluZ0NvbW1hbmQoV0VCS0lUX0VESVRJ TkdfQ09NTUFORF9TRUxFQ1RfQUxMKSk7CisKKyAgICB0ZXN0LT5jb3B5Q2xpcGJvYXJkKCk7Cisg ICAgR093blB0cjxjaGFyPiBjbGlwYm9hcmRUZXh0KGd0a19jbGlwYm9hcmRfd2FpdF9mb3JfdGV4 dCh0ZXN0LT5tX2NsaXBib2FyZCkpOworCisgICAgLy8gSW5pdGlhbGx5IG9ubHkgdGhlIHN1YnNw YW4gaXMgc2VsZWN0ZWQuCisgICAgZ19hc3NlcnRfY21wc3RyKGNsaXBib2FyZFRleHQuZ2V0KCks ID09LCAibWFrZSBKYWNrIGEgZHVsbCIpOworCisgICAgd2Via2l0X3dlYl92aWV3X2V4ZWN1dGVf ZWRpdGluZ19jb21tYW5kKHRlc3QtPm1fd2ViVmlldywgV0VCS0lUX0VESVRJTkdfQ09NTUFORF9T RUxFQ1RfQUxMKTsKKyAgICB0ZXN0LT5jb3B5Q2xpcGJvYXJkKCk7CisgICAgY2xpcGJvYXJkVGV4 dC5zZXQoZ3RrX2NsaXBib2FyZF93YWl0X2Zvcl90ZXh0KHRlc3QtPm1fY2xpcGJvYXJkKSk7CisK KyAgICAvLyBUaGUgbWFpbnNwYW4gc2hvdWxkIGJlIHNlbGVjdGVkIGFmdGVyIGNhbGxpbmcgU0VM RUNUX0FMTC4KKyAgICBnX2Fzc2VydF9jbXBzdHIoY2xpcGJvYXJkVGV4dC5nZXQoKSwgPT0sICJB bGwgd29yayBhbmQgbm8gcGxheSBtYWtlIEphY2sgYSBkdWxsIGJveS4iKTsKK30KKworc3RhdGlj IHZvaWQgdGVzdFdlYlZpZXdFZGl0b3JTZWxlY3RBbGxFZGl0YWJsZShFZGl0b3JUZXN0KiB0ZXN0 LCBnY29uc3Rwb2ludGVyKQoreworICAgIHN0YXRpYyBjb25zdCBjaGFyKiBzZWxlY3RlZFNwYW5I VE1MID0gIjxodG1sPjxib2R5IGNvbnRlbnRFZGl0YWJsZT1cInRydWVcIj4iCisgICAgICAgICI8 c3BhbiBpZD1cIm1haW5zcGFuXCI+QWxsIHdvcmsgYW5kIG5vIHBsYXkgPHNwYW4gaWQ9XCJzdWJz cGFuXCI+bWFrZSBKYWNrIGEgZHVsbDwvc3Bhbj4gYm95Ljwvc3Bhbj4iCisgICAgICAgICI8c2Ny aXB0PmRvY3VtZW50LmdldFNlbGVjdGlvbigpLmNvbGxhcHNlKCk7XG4iCisgICAgICAgICJkb2N1 bWVudC5nZXRTZWxlY3Rpb24oKS5zZWxlY3RBbGxDaGlsZHJlbihkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnc3Vic3BhbicpKTtcbiIKKyAgICAgICAgIjwvc2NyaXB0PjwvYm9keT48L2h0bWw+IjsK KworICAgIGdfYXNzZXJ0KHRlc3QtPmNhbkV4ZWN1dGVFZGl0aW5nQ29tbWFuZChXRUJLSVRfRURJ VElOR19DT01NQU5EX1NFTEVDVF9BTEwpKTsKKworICAgIHRlc3QtPmxvYWRIdG1sKHNlbGVjdGVk U3BhbkhUTUwsIDApOworICAgIHRlc3QtPndhaXRVbnRpbExvYWRGaW5pc2hlZCgpOworCisgICAg Z19hc3NlcnQodGVzdC0+Y2FuRXhlY3V0ZUVkaXRpbmdDb21tYW5kKFdFQktJVF9FRElUSU5HX0NP TU1BTkRfU0VMRUNUX0FMTCkpOworCisgICAgdGVzdC0+Y29weUNsaXBib2FyZCgpOworICAgIEdP d25QdHI8Y2hhcj4gY2xpcGJvYXJkVGV4dChndGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQodGVz dC0+bV9jbGlwYm9hcmQpKTsKKworICAgIC8vIEluaXRpYWxseSBvbmx5IHRoZSBzdWJzcGFuIGlz IHNlbGVjdGVkLgorICAgIGdfYXNzZXJ0X2NtcHN0cihjbGlwYm9hcmRUZXh0LmdldCgpLCA9PSwg Im1ha2UgSmFjayBhIGR1bGwiKTsKKworICAgIHdlYmtpdF93ZWJfdmlld19leGVjdXRlX2VkaXRp bmdfY29tbWFuZCh0ZXN0LT5tX3dlYlZpZXcsIFdFQktJVF9FRElUSU5HX0NPTU1BTkRfU0VMRUNU X0FMTCk7CisgICAgdGVzdC0+Y29weUNsaXBib2FyZCgpOworICAgIGNsaXBib2FyZFRleHQuc2V0 KGd0a19jbGlwYm9hcmRfd2FpdF9mb3JfdGV4dCh0ZXN0LT5tX2NsaXBib2FyZCkpOworCisgICAg Ly8gVGhlIG1haW5zcGFuIHNob3VsZCBiZSBzZWxlY3RlZCBhZnRlciBjYWxsaW5nIFNFTEVDVF9B TEwuCisgICAgZ19hc3NlcnRfY21wc3RyKGNsaXBib2FyZFRleHQuZ2V0KCksID09LCAiQWxsIHdv cmsgYW5kIG5vIHBsYXkgbWFrZSBKYWNrIGEgZHVsbCBib3kuIik7Cit9CisKIHZvaWQgYmVmb3Jl QWxsKCkKIHsKICAgICBFZGl0b3JUZXN0OjphZGQoIldlYktpdFdlYlZpZXciLCAiY3V0LWNvcHkt cGFzdGUvbm9uLWVkaXRhYmxlIiwgdGVzdFdlYlZpZXdFZGl0b3JDdXRDb3B5UGFzdGVOb25FZGl0 YWJsZSk7CiAgICAgRWRpdG9yVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgImN1dC1jb3B5LXBh c3RlL2VkaXRhYmxlIiwgdGVzdFdlYlZpZXdFZGl0b3JDdXRDb3B5UGFzdGVFZGl0YWJsZSk7Cisg ICAgRWRpdG9yVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInNlbGVjdC1hbGwvbm9uLWVkaXRh YmxlIiwgdGVzdFdlYlZpZXdFZGl0b3JTZWxlY3RBbGxOb25FZGl0YWJsZSk7CisgICAgRWRpdG9y VGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInNlbGVjdC1hbGwvZWRpdGFibGUiLCB0ZXN0V2Vi Vmlld0VkaXRvclNlbGVjdEFsbEVkaXRhYmxlKTsKIH0KIAogdm9pZCBhZnRlckFsbCgpCg==