97458 2012-09-24 08:57:15 -0700 [GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link clicked navigation action 2012-09-24 09:31:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 726720 0 cgarcia 2012-09-24 08:57:15 -0700 We are setting it to true when the load is started by using the API 726725 1 165394 cgarcia 2012-09-24 09:03:35 -0700 Created attachment 165394 Patch 726727 2 webkit.review.bot 2012-09-24 09:08:04 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 726739 3 165394 xan.lopez 2012-09-24 09:25:29 -0700 Comment on attachment 165394 Patch Yeah, much better. 726747 4 cgarcia 2012-09-24 09:31:52 -0700 Committed r129380: <http://trac.webkit.org/changeset/129380> 165394 2012-09-24 09:03:35 -0700 2012-09-24 09:25:29 -0700 Patch wk2-fix-is-loading.diff text/plain 5892 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOGJkZWJlLi5lMmRkNTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTItMDktMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYktpdFdlYlZpZXc6aXMtbG9hZGluZyBpcyBub3QgdXBkYXRl ZCB3aGVuIHRoZSBpcyBsb2FkZWQgaXMgc3RhcnRlZCBieSBsaW5rIGNsaWNrZWQgbmF2aWdhdGlv biBhY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3NDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViS2l0V2ViVmlldzppcy1sb2FkaW5nIGlzIHNldCB0byBUUlVFIHdoZW4gdGhlIGxvYWQgaXMg c3RhcnRlZAorICAgICAgICBieSB1c2luZyB0aGUgQVBJLiBXZSB3YW50IHRvIG1ha2Ugc3VyZSB0 aGF0IGJvdGggVVJJIGFuZAorICAgICAgICBpcy1sb2FkaW5nIGFyZSB1cGRhdGVkIGJlZm9yZSBs b2FkLXN0YXJ0ZWQgaXMgZW1pdHRlZCwgc28gd2UgY2FuCisgICAgICAgIHVwZGF0ZSBib3RoIHJp Z2h0IGJlZm9yZSBlbWl0dGluZyBsb2FkLXN0YXJ0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdFbWl0TG9h ZENoYW5nZWQpOiBVcGRhdGUgYm90aCB1cmkgYW5kIGlzLWxvYWRpbmcKKyAgICAgICAgcHJvcGVy dGllcyBiZWZvcmUgZW1pdHRpbmcgbG9hZC1jaGFuZ2VkIHNpZ25hbCB3aXRoCisgICAgICAgIFdF QktJVF9MT0FEX1NUQVJURUQuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfbG9hZF91cmkpOiBE b24ndCBjYWxsCisgICAgICAgIHdlYmtpdFdlYlZpZXdTZXRJc0xvYWRpbmcoKS4KKyAgICAgICAg KHdlYmtpdF93ZWJfdmlld19sb2FkX2h0bWwpOiBEaXR0by4KKyAgICAgICAgKHdlYmtpdF93ZWJf dmlld19sb2FkX2FsdGVybmF0ZV9odG1sKTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfd2ViX3Zp ZXdfbG9hZF9wbGFpbl90ZXh0KTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfbG9h ZF9yZXF1ZXN0KTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfcmVsb2FkKTogRGl0 dG8uCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfcmVsb2FkX2J5cGFzc19jYWNoZSk6IERpdHRv LgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2dvX2JhY2spOiBEaXR0by4KKyAgICAgICAgKHdl YmtpdF93ZWJfdmlld19nb19mb3J3YXJkKTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfd2ViX3Zp ZXdfZ29fdG9fYmFja19mb3J3YXJkX2xpc3RfaXRlbSk6IERpdHRvLgorCiAyMDEyLTA5LTI0ICBL d2FuZ1lvbmcgQ2hvaSAgPGt5MC5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dL Ml0gSW52YWxpZCBmZWF0dXJpbmcgb2YgSU5QVVRfVFlQRV9DT0xPUiBpbiB0ZXN0X2V3azJfdmll dy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAKaW5kZXggNDVjMzgyMS4uY2YxZGQ2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKQEAgLTExNTUsNyArMTE1NSw5IEBA IHN0YXRpYyB2b2lkIHNldENlcnRpZmljYXRlVG9NYWluUmVzb3VyY2UoV2ViS2l0V2ViVmlldyog d2ViVmlldykKIAogc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0VtaXRMb2FkQ2hhbmdlZChXZWJL aXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRMb2FkRXZlbnQgbG9hZEV2ZW50KQogewotICAgIGlm IChsb2FkRXZlbnQgPT0gV0VCS0lUX0xPQURfRklOSVNIRUQpIHsKKyAgICBpZiAobG9hZEV2ZW50 ID09IFdFQktJVF9MT0FEX1NUQVJURUQpCisgICAgICAgIHdlYmtpdFdlYlZpZXdTZXRJc0xvYWRp bmcod2ViVmlldywgdHJ1ZSk7CisgICAgZWxzZSBpZiAobG9hZEV2ZW50ID09IFdFQktJVF9MT0FE X0ZJTklTSEVEKSB7CiAgICAgICAgIHdlYmtpdFdlYlZpZXdTZXRJc0xvYWRpbmcod2ViVmlldywg ZmFsc2UpOwogICAgICAgICB3ZWJWaWV3LT5wcml2LT53YWl0aW5nRm9yTWFpblJlc291cmNlID0g ZmFsc2U7CiAgICAgICAgIHdlYmtpdFdlYlZpZXdEaXNjb25uZWN0TWFpblJlc291cmNlUmVzcG9u c2VDaGFuZ2VkU2lnbmFsSGFuZGxlcih3ZWJWaWV3KTsKQEAgLTE1NjEsNyArMTU2Myw2IEBAIHZv aWQgd2Via2l0X3dlYl92aWV3X2xvYWRfdXJpKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0 IGdjaGFyKiB1cmkpCiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IHVybChBZG9wdFdLLCBXS1VS TENyZWF0ZVdpdGhVVEY4Q1N0cmluZyh1cmkpKTsKICAgICBXZWJQYWdlUHJveHkqIHBhZ2UgPSB3 ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpOwog ICAgIFdLUGFnZUxvYWRVUkwodG9BUEkocGFnZSksIHVybC5nZXQoKSk7Ci0gICAgd2Via2l0V2Vi Vmlld1NldElzTG9hZGluZyh3ZWJWaWV3LCB0cnVlKTsKIH0KIAogLyoqCkBAIC0xNTg5LDcgKzE1 OTAsNiBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19sb2FkX2h0bWwoV2ViS2l0V2ViVmlldyogd2Vi VmlldywgY29uc3QgZ2NoYXIqIGNvbnRlbnQsIGNvbgogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5n UmVmPiBjb250ZW50UmVmKEFkb3B0V0ssICBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhj b250ZW50KSk7CiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IGJhc2VVUklSZWYgPSBiYXNlVVJJ ID8gYWRvcHRXSyhXS1VSTENyZWF0ZVdpdGhVVEY4Q1N0cmluZyhiYXNlVVJJKSkgOiAwOwogICAg IFdLUGFnZUxvYWRIVE1MU3RyaW5nKHRvQVBJKHBhZ2UpLCBjb250ZW50UmVmLmdldCgpLCBiYXNl VVJJUmVmLmdldCgpKTsKLSAgICB3ZWJraXRXZWJWaWV3U2V0SXNMb2FkaW5nKHdlYlZpZXcsIHRy dWUpOwogfQogCiAvKioKQEAgLTE2MTYsNyArMTYxNiw2IEBAIHZvaWQgd2Via2l0X3dlYl92aWV3 X2xvYWRfYWx0ZXJuYXRlX2h0bWwoV2ViS2l0V2ViVmlldyogd2ViVmlldywgY29uc3QgZ2NoYXIq IGNvCiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IGJhc2VVUkwgPSBiYXNlVVJJID8gYWRvcHRX SyhXS1VSTENyZWF0ZVdpdGhVVEY4Q1N0cmluZyhiYXNlVVJJKSkgOiAwOwogICAgIFdlYlBhZ2VQ cm94eSogcGFnZSA9IHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFT RSh3ZWJWaWV3KSk7CiAgICAgV0tQYWdlTG9hZEFsdGVybmF0ZUhUTUxTdHJpbmcodG9BUEkocGFn ZSksIGh0bWxTdHJpbmcuZ2V0KCksIGJhc2VVUkwuZ2V0KCksIGNvbnRlbnRVUkwuZ2V0KCkpOwot ICAgIHdlYmtpdFdlYlZpZXdTZXRJc0xvYWRpbmcod2ViVmlldywgdHJ1ZSk7CiB9CiAKIC8qKgpA QCAtMTYzNiw3ICsxNjM1LDYgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfbG9hZF9wbGFpbl90ZXh0 KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGdjaGFyKiBwbGFpblQKICAgICBXZWJQYWdl UHJveHkqIHBhZ2UgPSB3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JB U0Uod2ViVmlldykpOwogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBwbGFpblRleHRSZWYo QWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcocGxhaW5UZXh0KSk7CiAgICAg V0tQYWdlTG9hZFBsYWluVGV4dFN0cmluZyh0b0FQSShwYWdlKSwgcGxhaW5UZXh0UmVmLmdldCgp KTsKLSAgICB3ZWJraXRXZWJWaWV3U2V0SXNMb2FkaW5nKHdlYlZpZXcsIHRydWUpOwogfQogCiAv KioKQEAgLTE2NTcsNyArMTY1NSw2IEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X2xvYWRfcmVxdWVz dChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRVUklSZXF1ZXN0KiByZXF1CiAgICAgV0tS ZXRhaW5QdHI8V0tVUkxSZXF1ZXN0UmVmPiB3a1JlcXVlc3QoQWRvcHRXSywgV0tVUkxSZXF1ZXN0 Q3JlYXRlV2l0aFdLVVJMKHdrVVJMLmdldCgpKSk7CiAgICAgV2ViUGFnZVByb3h5KiBwYWdlID0g d2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdFQktJVF9XRUJfVklFV19CQVNFKHdlYlZpZXcpKTsK ICAgICBXS1BhZ2VMb2FkVVJMUmVxdWVzdCh0b0FQSShwYWdlKSwgd2tSZXF1ZXN0LmdldCgpKTsK LSAgICB3ZWJraXRXZWJWaWV3U2V0SXNMb2FkaW5nKHdlYlZpZXcsIHRydWUpOwogfQogCiAvKioK QEAgLTE2ODksNyArMTY4Niw2IEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X3JlbG9hZChXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3KQogICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVX KHdlYlZpZXcpKTsKIAogICAgIFdLUGFnZVJlbG9hZCh0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdl dFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKSk7Ci0gICAgd2Via2l0V2ViVmll d1NldElzTG9hZGluZyh3ZWJWaWV3LCB0cnVlKTsKIH0KIAogLyoqCkBAIC0xNzA0LDcgKzE3MDAs NiBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19yZWxvYWRfYnlwYXNzX2NhY2hlKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcpCiAgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2Vi VmlldykpOwogCiAgICAgV0tQYWdlUmVsb2FkRnJvbU9yaWdpbih0b0FQSSh3ZWJraXRXZWJWaWV3 QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKSk7Ci0gICAgd2Via2l0 V2ViVmlld1NldElzTG9hZGluZyh3ZWJWaWV3LCB0cnVlKTsKIH0KIAogLyoqCkBAIC0xNzU3LDcg KzE3NTIsNiBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19nb19iYWNrKFdlYktpdFdlYlZpZXcqIHdl YlZpZXcpCiAgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykp OwogCiAgICAgV0tQYWdlR29CYWNrKHRvQVBJKHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXRUJL SVRfV0VCX1ZJRVdfQkFTRSh3ZWJWaWV3KSkpKTsKLSAgICB3ZWJraXRXZWJWaWV3U2V0SXNMb2Fk aW5nKHdlYlZpZXcsIHRydWUpOwogfQogCiAvKioKQEAgLTE3ODgsNyArMTc4Miw2IEBAIHZvaWQg d2Via2l0X3dlYl92aWV3X2dvX2ZvcndhcmQoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBn X3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSk7CiAKICAgICBXS1Bh Z2VHb0ZvcndhcmQodG9BUEkod2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdFQktJVF9XRUJfVklF V19CQVNFKHdlYlZpZXcpKSkpOwotICAgIHdlYmtpdFdlYlZpZXdTZXRJc0xvYWRpbmcod2ViVmll dywgdHJ1ZSk7CiB9CiAKIC8qKgpAQCAtMTk2Miw3ICsxOTU1LDYgQEAgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfZ29fdG9fYmFja19mb3J3YXJkX2xpc3RfaXRlbShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3 LCBXZWJLaXQKIAogICAgIFdLUGFnZUdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKHRvQVBJKHdlYmtp dFdlYlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRSh3ZWJWaWV3KSkpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdlYmtpdEJhY2tGb3J3YXJkTGlzdEl0ZW1H ZXRXS0l0ZW0obGlzdEl0ZW0pKTsKLSAgICB3ZWJraXRXZWJWaWV3U2V0SXNMb2FkaW5nKHdlYlZp ZXcsIHRydWUpOwogfQogCiAvKioK