97454 2012-09-24 07:43:37 -0700 [Chromium] Page popup doesn't change mouse cursor 2012-11-30 03:22:19 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 726655 0 keishi 2012-09-24 07:43:37 -0700 Right now page popup doesn't set cursor. 726659 1 165381 keishi 2012-09-24 07:48:45 -0700 Created attachment 165381 Patch 727181 2 165381 tkent 2012-09-24 18:44:36 -0700 Comment on attachment 165381 Patch Does the cursor return to the correct appearance when the popup is closed? 733718 3 keishi 2012-10-03 08:17:52 -0700 (In reply to comment #2) > (From update of attachment 165381 [details]) > Does the cursor return to the correct appearance when the popup is closed? So far I've only tested Win and Mac. Win works perfectly without this patch. Cursor is updated when closing. On mac: Using esc key to close: cursor will be hidden. Select date to close: cursor will not be updated. Select popup works the same way so maybe this is the expected behavior. I should test Cocoa. 734297 4 keishi 2012-10-03 18:51:50 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 165381 [details] [details]) > > Does the cursor return to the correct appearance when the popup is closed? > > So far I've only tested Win and Mac. > > Win works perfectly without this patch. Cursor is updated when closing. > > On mac: > Using esc key to close: cursor will be hidden. > Select date to close: cursor will not be updated. > Select popup works the same way so maybe this is the expected behavior. I should test Cocoa. On Linux it works perfectly like Windows. On windows and linux mousemove events do not fire on the main web view, but fires when the popup closes. On mac the mousemoves reach both the page popup and main web view, resulting in bit of flickering when moving the mouse fast. Cocoa updates the mouse cursor when closing a popup menu. 779975 5 176932 keishi 2012-11-30 02:57:27 -0800 Created attachment 176932 Patch 779976 6 keishi 2012-11-30 02:59:31 -0800 I think the ideal solution would be to change the native view for PagePopupWidget to a NSWindow or a custom NSView subclassed to override event propagation. 779977 7 176932 tkent 2012-11-30 03:03:48 -0800 Comment on attachment 176932 Patch looks ok 779983 8 176932 webkit.review.bot 2012-11-30 03:22:16 -0800 Comment on attachment 176932 Patch Clearing flags on attachment: 176932 Committed r136222: <http://trac.webkit.org/changeset/136222> 779984 9 webkit.review.bot 2012-11-30 03:22:19 -0800 All reviewed patches have been landed. Closing bug. 165381 2012-09-24 07:48:45 -0700 2012-11-30 02:57:23 -0800 Patch bug-97454-20120924234806.patch text/plain 1609 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVhMzRhZTA5MzY4NWY1MDA4YjY1NjA0NWM4NThhNGNjNDg0YzdmMTcuLjE4NzEwMTY2NGNhMWY3 Nzg5Y2YwZjdiMGRlZDY1MzI5OWJmNmViM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMjQgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBQYWdlIHBvcHVwIGRvZXNuJ3QgY2hhbmdlIG1v dXNlIGN1cnNvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTc0NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgUGFnZVBvcHVwQ2hyb21lQ2xpZW50OjpzZXRDdXJzb3IuCisKKyAgICAgICAg KiBzcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHA6CisKIDIwMTItMDktMjMgIEtlaXNoaSBIYXR0b3Jp ICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHN1Z2dlc3Rpb25QaWNrZXIgdG8g Q2FsZW5kYXJQaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBhZ2VQb3B1cEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBv cHVwSW1wbC5jcHAKaW5kZXggOTgwZjgxYThhYjBlZGJlMzRlNjU3MmVmNmY3ZWI5YWI2NDA2MjMz OC4uMmMxNWZkYjFlNGUxZGJlNjQwMGQ2YTA1ZDI2Y2UwNDU1NWM0Y2YwZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAKQEAgLTQyLDggKzQy LDEwIEBACiAjaW5jbHVkZSAiUGFnZVBvcHVwQ2xpZW50LmgiCiAjaW5jbHVkZSAiUGFnZVdpZGdl dERlbGVnYXRlLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKKyNpbmNsdWRlICJXZWJDdXJzb3JJ bmZvLmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudENvbnZlcnNpb24uaCIKICNpbmNsdWRlICJX ZWJQYWdlUG9wdXAuaCIKKyNpbmNsdWRlICJXZWJWaWV3Q2xpZW50LmgiCiAjaW5jbHVkZSAiV2Vi Vmlld0ltcGwuaCIKICNpbmNsdWRlICJXZWJXaWRnZXRDbGllbnQuaCIKIApAQCAtMTI0LDYgKzEy NiwxMiBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gRmxvYXRTaXplKDAsIDApOwogICAgIH0K IAorICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJzb3IpIE9WRVJS SURFCisgICAgeworICAgICAgICBpZiAobV9wb3B1cC0+bV93ZWJWaWV3LT5jbGllbnQoKSkKKyAg ICAgICAgICAgIG1fcG9wdXAtPm1fd2ViVmlldy0+Y2xpZW50KCktPmRpZENoYW5nZUN1cnNvcihX ZWJDdXJzb3JJbmZvKGN1cnNvcikpOworICAgIH0KKwogICAgIFdlYlBhZ2VQb3B1cEltcGwqIG1f cG9wdXA7CiB9OwogCg== 176932 2012-11-30 02:57:27 -0800 2012-11-30 03:22:16 -0800 Patch bug-97454-20121130195458.patch text/plain 2945 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkwNDg1ZGJhMWU1MTc2ZjU0OTY5NmNhZTVmM2U0NDk0ZGQ3MTVjNDQuLjJlYmUxNmVmZmU2YTk4 NTI4NGM3NDlmNjU5YzJlMzhjYjZlNzJlY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTEtMzAgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBQYWdlIHBvcHVwIGRvZXNuJ3QgY2hhbmdlIG1v dXNlIGN1cnNvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTc0NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgbW91c2UgY3Vyc29yIHNob3VsZCBjaGFuZ2UgYmFzZWQgb24gdGhlIHBhZ2UgcG9wdXAg Y29udGVudCBhbmQgbm90IHRoZSBtYWluIHdpbmRvdyBjb250ZW50LgorICAgICAgICBPbiBNYWMg dGhlIG1vdXNlbW92ZSBldmVudCBwcm9wYWdhdGVzIHRvIGJvdGggdGhlIHBhZ2UgcG9wdXAgYW5k IG1haW4gd2luZG93IGNhdXNpbmcgdGhlIGN1cnNvciB0byBmbGlja2VyLgorICAgICAgICBUaGUg Y2hhbmdlIHRvIENocm9tZUNsaWVudEltcGwgc3RvcHMgdGhhdC4KKworICAgICAgICAqIHNyYy9D aHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6 c2V0Q3Vyc29yKTogT24gTWFjLCBkb24ndCB1cGRhdGUgdGhlIG1vdXNlIGN1cnNvciBpZiBhIHBv cHVwIGlzIG9wZW4uCisgICAgICAgICogc3JjL1dlYlBhZ2VQb3B1cEltcGwuY3BwOiBJbXBsZW1l bnQgc2V0Q3Vyc29yIHNvIHRoZSBtb3VzZSBjdXJzb3IgZ2V0cyBzZXQgYmFzZWQgb24gdGhlIHBh Z2UgcG9wdXAgY29udGVudC4KKwogMjAxMi0xMS0zMCAgTWloYWkgTWFlcmVhbiAgPG1tYWVyZWFu QGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTUmVnaW9uc10gd2hlbiBXZWJLaXQgdXNlcyBWOCwg dGhlcmUgc2hvdWxkIGJlIGEgc2luZ2xlIHZhcmlhYmxlIHRvIHN0b3JlIGlmIHRoZSBDU1MgUmVn aW9ucyBmZWF0dXJlIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv Q2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggZTYxN2U4ZjVhYzE5MmY4NmQzZGYxYzI0MmU4NmQw ZGRhNGMyODBmZS4uNDIxNWFkNzAwMmQ0ODRjZTc0NjYyMmRiYTBmYjg4MjliYTIwNjViMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAg LTgyNSw2ICs4MjUsMTIgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzZXRDdXJzb3JIaWRkZW5V bnRpbE1vdXNlTW92ZXMoYm9vbCkKIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzZXRDdXJzb3Io Y29uc3QgV2ViQ3Vyc29ySW5mbyYgY3Vyc29yKQogeworI2lmIE9TKERBUldJTikKKyAgICAvLyBP biBNYWMgdGhlIG1vdXNlbW92ZSBldmVudCBwcm9wYWdhdGVzIHRvIGJvdGggdGhlIHBvcHVwIGFu ZCBtYWluIHdpbmRvdy4KKyAgICAvLyBJZiBhIHBvcHVwIGlzIG9wZW4gd2UgZG9uJ3Qgd2FudCB0 aGUgbWFpbiB3aW5kb3cgdG8gY2hhbmdlIHRoZSBjdXJzb3IuCisgICAgaWYgKG1fd2ViVmlldy0+ aGFzT3BlbmVkUG9wdXAoKSkKKyAgICAgICAgcmV0dXJuOworI2VuZGlmCiAgICAgaWYgKG1fd2Vi Vmlldy0+Y2xpZW50KCkpCiAgICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmRpZENoYW5nZUN1 cnNvcihjdXJzb3IpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViUGFnZVBvcHVwSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdl UG9wdXBJbXBsLmNwcAppbmRleCA1Mzg4MmY5ZTdjNjI4ZjRmNGY3YTAyMDk2MDU5ODY1NDk1MWZh ZDY2Li5jNGI5MzRhYWE1NzU0NTUxODVmNmVjZGUyZjk5NDc5NmVkZGVkOTAyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcApAQCAtNDIsNiAr NDIsNyBAQAogI2luY2x1ZGUgIlBhZ2VQb3B1cENsaWVudC5oIgogI2luY2x1ZGUgIlBhZ2VXaWRn ZXREZWxlZ2F0ZS5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCisjaW5jbHVkZSAiV2ViQ3Vyc29y SW5mby5oIgogI2luY2x1ZGUgIldlYklucHV0RXZlbnRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAi V2ViUGFnZVBvcHVwLmgiCiAjaW5jbHVkZSAiV2ViU2V0dGluZ3NJbXBsLmgiCkBAIC0xMzEsNiAr MTMyLDEyIEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiBQbGF0Zm9ybVBhZ2VDbGllbnQodGhp cyk7CiAgICAgfQogCisgICAgdmlydHVhbCB2b2lkIHNldEN1cnNvcihjb25zdCBXZWJDb3JlOjpD dXJzb3ImIGN1cnNvcikgT1ZFUlJJREUKKyAgICB7CisgICAgICAgIGlmIChtX3BvcHVwLT5tX3dl YlZpZXctPmNsaWVudCgpKQorICAgICAgICAgICAgbV9wb3B1cC0+bV93ZWJWaWV3LT5jbGllbnQo KS0+ZGlkQ2hhbmdlQ3Vyc29yKFdlYkN1cnNvckluZm8oY3Vyc29yKSk7CisgICAgfQorCiAgICAg Ly8gUGFnZUNsaWVudENocm9taXVtIG1ldGhvZHM6CiAgICAgdmlydHVhbCBXZWJLaXQ6OldlYlNj cmVlbkluZm8gc2NyZWVuSW5mbygpIE9WRVJSSURFCiAgICAgewo=