97447 2012-09-24 05:39:06 -0700 sizeof(CSSRule) compile assertion failure 2012-09-24 07:40:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P1 Blocker --- 0 net147 webkit-unassigned cmarcelo darin fpizlo hausmann macpherson menard rniwa webkit.review.bot oldest_to_newest 726579 0 net147 2012-09-24 05:39:06 -0700 COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay_small) fails when building with MinGW-w64 GCC 4.7.2. It previously compiled successfully with MinGW-w64 GCC 4.6.3. The problem seems to be a change in the default behavior when padding bitfields. MinGW GCC 4.7.x uses -mms-bitfields by default while MinGW GCC 4.6.x doesn't. Since the underlying type is unsigned, it pads to 32-bit when it should really be padding to 8-bit. 726582 1 165359 net147 2012-09-24 05:43:45 -0700 Created attachment 165359 Patch. 726652 2 165359 webkit.review.bot 2012-09-24 07:39:58 -0700 Comment on attachment 165359 Patch. Clearing flags on attachment: 165359 Committed r129365: <http://trac.webkit.org/changeset/129365> 726653 3 webkit.review.bot 2012-09-24 07:40:01 -0700 All reviewed patches have been landed. Closing bug. 165359 2012-09-24 05:43:45 -0700 2012-09-24 07:39:58 -0700 Patch. bug-97447.patch text/plain 2010 net147 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTM1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTI0ICBKb25hdGhh biBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIFVzZSB1bnNpZ25lZCBjaGFyIGZv ciBiaXRmaWVsZCBpbnN0ZWFkIG9mIHVuc2lnbmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOb3QgYWxsIGNvbXBpbGVycyB3aWxsIHBhZCBhbiB1bnNp Z25lZCBiaXRmaWVsZCB0byB0aGUgc21hbGxlc3Qgc2l6ZS4KKyAgICAgICAgVXNlIHVuc2lnbmVk IGNoYXIgaW5zdGVhZCBvZiB1bnNpZ25lZCB0byByZWR1Y2UgcGFkZGluZyBmb3IgY29tcGlsZXJz CisgICAgICAgIHRoYXQgcGFkIHRvIHRoZSB1bmRlcmx5aW5nIHR5cGUuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBUaGVyZSBpcyBhbHJlYWR5IGEgY29tcGlsZS10aW1lIGFzc2VydGlvbi4KKwor ICAgICAgICAqIGNzcy9DU1NSdWxlLmNwcDoKKyAgICAgICAgKFNhbWVTaXplQXNDU1NSdWxlKToK KyAgICAgICAgKiBjc3MvQ1NTUnVsZS5oOgorICAgICAgICAoQ1NTUnVsZSk6CisKIDIwMTItMDkt MjQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjpFWENfQkFEX0FDQ0VTUyB1cG9uIGNsb3NpbmcgcGFnZSB3aXRoIG5vZGUgaGln aGxpZ2h0ZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5jcHAJKHJldmlzaW9uIDEyOTM1MSkKKysr IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTEg KzQwLDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RydWN0IFNhbWVTaXplQXNDU1NSdWxl IDogcHVibGljIFJlZkNvdW50ZWQ8U2FtZVNpemVBc0NTU1J1bGU+IHsKLSNpZiBVU0UoSlNDKQot ICAgIGNoYXIgYml0ZmllbGRzOwotI2Vsc2UKLSAgICB1bnNpZ25lZCBiaXRmaWVsZHM7Ci0jZW5k aWYKKyAgICB1bnNpZ25lZCBjaGFyIGJpdGZpZWxkczsKICAgICB2b2lkKiBwb2ludGVyVW5pb247 CiB9OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmgJKHJldmlzaW9uIDEyOTM1MSkKKysrIFNvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNyw5ICsxMjcsOSBA QCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCByZXBvcnRCYXNlQ2xhc3NNZW1vcnlVc2FnZShNZW1vcnlP YmplY3RJbmZvKikgY29uc3Q7CiAKIHByaXZhdGU6Ci0gICAgbXV0YWJsZSB1bnNpZ25lZCBtX2hh c0NhY2hlZFNlbGVjdG9yVGV4dCA6IDE7Ci0gICAgdW5zaWduZWQgbV9wYXJlbnRJc1J1bGUgOiAx OwotICAgIHVuc2lnbmVkIG1fdHlwZSA6IDU7CisgICAgbXV0YWJsZSB1bnNpZ25lZCBjaGFyIG1f aGFzQ2FjaGVkU2VsZWN0b3JUZXh0IDogMTsKKyAgICB1bnNpZ25lZCBjaGFyIG1fcGFyZW50SXNS dWxlIDogMTsKKyAgICB1bnNpZ25lZCBjaGFyIG1fdHlwZSA6IDU7CiAgICAgdW5pb24gewogICAg ICAgICBDU1NSdWxlKiBtX3BhcmVudFJ1bGU7CiAgICAgICAgIENTU1N0eWxlU2hlZXQqIG1fcGFy ZW50U3R5bGVTaGVldDsK