97442 2012-09-24 02:56:26 -0700 Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time 2012-09-24 09:36:12 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey aandrey apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 726502 0 aandrey 2012-09-24 02:56:26 -0700 The conditional breakpoint popup may not show up the first time we click on the gutter. Also the popup will close itself on any mouse click event, even if it's targeted to the input box itself. Example to repro: - goto http://learningwebgl.com/lessons/lesson05/index.html - open Source panel, select the file glMatrix-0.9.5.min.js - mouse right click on the gutter on line 25 and choose "Add Conditional Breakpoint..." - observe the popup opens and closes immediately - do the same action on line 25 to edit the breakpoint - now the popup should not close - mouse click on the input box to observe the popup closing Patch to follow. 726504 1 165339 aandrey 2012-09-24 03:04:27 -0700 Created attachment 165339 Patch 726751 2 165339 webkit.review.bot 2012-09-24 09:36:08 -0700 Comment on attachment 165339 Patch Clearing flags on attachment: 165339 Committed r129381: <http://trac.webkit.org/changeset/129381> 726752 3 webkit.review.bot 2012-09-24 09:36:12 -0700 All reviewed patches have been landed. Closing bug. 165339 2012-09-24 03:04:27 -0700 2012-09-24 09:36:08 -0700 Patch bug-97442-20120924140347.patch text/plain 6857 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVmMGM1NWQzODU1Mzlh MTUxYjY1ZDgwZTIwN2UzNWZjMzE0ZmVmMi4uZjdjNjUwZjA1NjUxMDA2ZWM0ZTcyNmEzNjViOGZm ZDJmMWNkZjlmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEyLTA5LTI0ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtUZXh0RWRpdG9yXSBjb25kaXRpb25hbCBicmVha3BvaW50IHBvcHVwIG5vdCBzaG93aW5n IHVwIHRoZSBmaXJzdCB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NzQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIDEpIFRoZSBjb25kaXRpb25hbCBicmVha3BvaW50IHBvcHVwIG1heSBub3Qgc2hv dyB1cCB0aGUgZmlyc3QgdGltZSB3ZSBjbGljayBvbiB0aGUgZ3V0dGVyLgorICAgICAgICBUaGlz IHdhcyB0aGUgY2FzZSBiZWNhdXNlIHRoZSBwb3B1cCBkZWNvcmF0aW9uIGVsZW1lbnQgd291bGQg YmUgZGVsZXRlZCBmcm9tIHRoZSBsaW5lIHdoaWxlCisgICAgICAgIGl0IHdhcyBiZWluZyBoaWdo bGlnaHRlZCBhbmQgYXBwZW5kZWQgYWZ0ZXJ3YXJkcy4gTm93IHdlIGRvIG5vdCByZW1vdmUgZGVj b3JhdGlvbnMgZnJvbSB0aGUKKyAgICAgICAgRE9NIHdoaWxlIGhpZ2hsaWdodGluZy4KKworICAg ICAgICAyKSBBbHNvIHRoZSBwb3B1cCB3aWxsIGNsb3NlIGl0c2VsZiBvbiBhbnkgbW91c2UgY2xp Y2sgZXZlbnQsIGV2ZW4gaWYgaXQncyB0YXJnZXRlZCB0byB0aGUKKyAgICAgICAgaW5wdXQgYm94 IGl0c2VsZi4gVGhpcyB3YXMgZHVlIHRvIHBvaW50ZXItZXZlbnRzOiBub25lOyBDU1Mgc3R5bGUg Zm9yIHRoZSBwYXJlbnQgZWxlbWVudC4KKyAgICAgICAgTm93IHdlIGp1c3Qgb3ZlcnJpZGUgdGhp cyBzdHlsZSBmb3IgdGhlIGlucHV0IGJveC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvRGVmYXVsdFRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ck1haW5QYW5lbC5wcm90b3R5cGUuX3BhaW50TGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUuX2luc2VydFNwYW5CZWZvcmUpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlLl9pbnNlcnRUZXh0 Tm9kZUJlZm9yZSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3Nz OgorICAgICAgICAoLnNvdXJjZS1mcmFtZS1icmVha3BvaW50LWNvbmRpdGlvbik6CisKKzIwMTIt MDktMjQgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogW1RleHRFZGl0b3JdIExpbmUgbnVtYmVycyBvdXQgb2Ygc3luYyBhZnRl ciBjbG9zaW5nIGJyZWFrcG9pbnQgY29uZGl0aW9uIGVkaXRvcgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY1MTAKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKaW5kZXgg ZjkwYjkwMmUzYmMwZTU3Y2Q5ZWY2MTZiZGU5MmQ1NjQ0NzhiMTc5ZC4uNjljODdjZTEyOTA5ZTkw OWJhMDViZjEzODViNDBiYzFhY2U1YmU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCkBAIC0xODYzLDEwICsx ODYzLDIxIEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgIGlmICghaGlnaGxpZ2h0KQogICAgICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICAgICAgbGluZVJvdy5yZW1vdmVDaGlsZHJlbigpOworICAgICAgICAgICAgdmFyIGRl Y29yYXRpb25zRWxlbWVudCA9IGxpbmVSb3cuZGVjb3JhdGlvbnNFbGVtZW50OworICAgICAgICAg ICAgaWYgKCFkZWNvcmF0aW9uc0VsZW1lbnQpCisgICAgICAgICAgICAgICAgbGluZVJvdy5yZW1v dmVDaGlsZHJlbigpOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgd2hpbGUg KHRydWUpIHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIGNoaWxkID0gbGluZVJvdy5maXJzdENo aWxkOworICAgICAgICAgICAgICAgICAgICBpZiAoIWNoaWxkIHx8IGNoaWxkID09PSBkZWNvcmF0 aW9uc0VsZW1lbnQpCisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAg ICAgICAgICAgbGluZVJvdy5yZW1vdmVDaGlsZChjaGlsZCk7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgfQorCiAgICAgICAgICAgICB2YXIgbGluZSA9IHRoaXMuX3RleHRNb2RlbC5s aW5lKGxpbmVOdW1iZXIpOwogICAgICAgICAgICAgaWYgKCFsaW5lKQotICAgICAgICAgICAgICAg IGxpbmVSb3cuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYnIiKSk7CisgICAg ICAgICAgICAgICAgbGluZVJvdy5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi YnIiKSwgZGVjb3JhdGlvbnNFbGVtZW50KTsKIAogICAgICAgICAgICAgdmFyIHBsYWluVGV4dFN0 YXJ0ID0gLTE7CiAgICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8IGxpbmUubGVuZ3RoOykg ewpAQCAtMTg4MywyMSArMTg5NCwxOSBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgICAgIGorKzsKICAgICAgICAgICAgICAg ICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBpZiAocGxhaW5UZXh0U3RhcnQgIT09IC0x KSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICB0aGlzLl9hcHBlbmRUZXh0Tm9kZShsaW5lUm93 LCBsaW5lLnN1YnN0cmluZyhwbGFpblRleHRTdGFydCwgaikpOworICAgICAgICAgICAgICAgICAg ICAgICAgdGhpcy5faW5zZXJ0VGV4dE5vZGVCZWZvcmUobGluZVJvdywgZGVjb3JhdGlvbnNFbGVt ZW50LCBsaW5lLnN1YnN0cmluZyhwbGFpblRleHRTdGFydCwgaikpOwogICAgICAgICAgICAgICAg ICAgICAgICAgcGxhaW5UZXh0U3RhcnQgPSAtMTsKICAgICAgICAgICAgICAgICAgICAgICAgIC0t dGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNDcmVkaXQ7CiAgICAgICAgICAgICAgICAgICAgIH0K LSAgICAgICAgICAgICAgICAgICAgdGhpcy5fYXBwZW5kU3BhbihsaW5lUm93LCBsaW5lLnN1YnN0 cmluZyhqLCBqICsgYXR0cmlidXRlLmxlbmd0aCksIGF0dHJpYnV0ZS50b2tlblR5cGUpOworICAg ICAgICAgICAgICAgICAgICB0aGlzLl9pbnNlcnRTcGFuQmVmb3JlKGxpbmVSb3csIGRlY29yYXRp b25zRWxlbWVudCwgbGluZS5zdWJzdHJpbmcoaiwgaiArIGF0dHJpYnV0ZS5sZW5ndGgpLCBhdHRy aWJ1dGUudG9rZW5UeXBlKTsKICAgICAgICAgICAgICAgICAgICAgaiArPSBhdHRyaWJ1dGUubGVu Z3RoOwogICAgICAgICAgICAgICAgICAgICAtLXRoaXMuX3BhaW50TGluZXNPcGVyYXRpb25zQ3Jl ZGl0OwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmIChw bGFpblRleHRTdGFydCAhPT0gLTEpIHsKLSAgICAgICAgICAgICAgICB0aGlzLl9hcHBlbmRUZXh0 Tm9kZShsaW5lUm93LCBsaW5lLnN1YnN0cmluZyhwbGFpblRleHRTdGFydCwgbGluZS5sZW5ndGgp KTsKKyAgICAgICAgICAgICAgICB0aGlzLl9pbnNlcnRUZXh0Tm9kZUJlZm9yZShsaW5lUm93LCBk ZWNvcmF0aW9uc0VsZW1lbnQsIGxpbmUuc3Vic3RyaW5nKHBsYWluVGV4dFN0YXJ0LCBsaW5lLmxl bmd0aCkpOwogICAgICAgICAgICAgICAgIC0tdGhpcy5fcGFpbnRMaW5lc09wZXJhdGlvbnNDcmVk aXQ7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAobGluZVJvdy5kZWNvcmF0aW9uc0Vs ZW1lbnQpCi0gICAgICAgICAgICAgICAgbGluZVJvdy5hcHBlbmRDaGlsZChsaW5lUm93LmRlY29y YXRpb25zRWxlbWVudCk7CiAgICAgICAgIH0gZmluYWxseSB7CiAgICAgICAgICAgICBpZiAodGhp cy5fcmFuZ2VUb01hcmsgJiYgdGhpcy5fcmFuZ2VUb01hcmsuc3RhcnRMaW5lID09PSBsaW5lTnVt YmVyKQogICAgICAgICAgICAgICAgIHRoaXMuX21hcmtlZFJhbmdlRWxlbWVudCA9IFdlYkluc3Bl Y3Rvci5oaWdobGlnaHRTZWFyY2hSZXN1bHQobGluZVJvdywgdGhpcy5fcmFuZ2VUb01hcmsuc3Rh cnRDb2x1bW4sIHRoaXMuX3JhbmdlVG9NYXJrLmVuZENvbHVtbiAtIHRoaXMuX3JhbmdlVG9NYXJr LnN0YXJ0Q29sdW1uKTsKQEAgLTIwNTAsMjAgKzIwNTksMjEgQEAgV2ViSW5zcGVjdG9yLlRleHRF ZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgLyoqCiAgICAgICogQHBhcmFtIHtF bGVtZW50fSBlbGVtZW50CisgICAgICogQHBhcmFtIHtFbGVtZW50fSBvbGRDaGlsZAogICAgICAq IEBwYXJhbSB7c3RyaW5nfSBjb250ZW50CiAgICAgICogQHBhcmFtIHtzdHJpbmd9IGNsYXNzTmFt ZQogICAgICAqLwotICAgIF9hcHBlbmRTcGFuOiBmdW5jdGlvbihlbGVtZW50LCBjb250ZW50LCBj bGFzc05hbWUpCisgICAgX2luc2VydFNwYW5CZWZvcmU6IGZ1bmN0aW9uKGVsZW1lbnQsIG9sZENo aWxkLCBjb250ZW50LCBjbGFzc05hbWUpCiAgICAgewogICAgICAgICBpZiAoY2xhc3NOYW1lID09 PSAiaHRtbC1yZXNvdXJjZS1saW5rIiB8fCBjbGFzc05hbWUgPT09ICJodG1sLWV4dGVybmFsLWxp bmsiKSB7Ci0gICAgICAgICAgICBlbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX2NyZWF0ZUxpbmso Y29udGVudCwgY2xhc3NOYW1lID09PSAiaHRtbC1leHRlcm5hbC1saW5rIikpOworICAgICAgICAg ICAgZWxlbWVudC5pbnNlcnRCZWZvcmUodGhpcy5fY3JlYXRlTGluayhjb250ZW50LCBjbGFzc05h bWUgPT09ICJodG1sLWV4dGVybmFsLWxpbmsiKSwgb2xkQ2hpbGQpOwogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAKICAgICAgICAgdmFyIHNwYW4gPSB0aGlzLl9jYWNoZWRTcGFucy5w b3AoKSB8fCBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CiAgICAgICAgIHNwYW4uY2xh c3NOYW1lID0gIndlYmtpdC0iICsgY2xhc3NOYW1lOwogICAgICAgICBzcGFuLnRleHRDb250ZW50 ID0gY29udGVudDsKLSAgICAgICAgZWxlbWVudC5hcHBlbmRDaGlsZChzcGFuKTsKKyAgICAgICAg ZWxlbWVudC5pbnNlcnRCZWZvcmUoc3Bhbiwgb2xkQ2hpbGQpOwogICAgICAgICBpZiAoISgic3Bh bnMiIGluIGVsZW1lbnQpKQogICAgICAgICAgICAgZWxlbWVudC5zcGFucyA9IFtdOwogICAgICAg ICBlbGVtZW50LnNwYW5zLnB1c2goc3Bhbik7CkBAIC0yMDcxLDE2ICsyMDgxLDE3IEBAIFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgIC8qKgogICAg ICAqIEBwYXJhbSB7RWxlbWVudH0gZWxlbWVudAorICAgICAqIEBwYXJhbSB7RWxlbWVudH0gb2xk Q2hpbGQKICAgICAgKiBAcGFyYW0ge3N0cmluZ30gdGV4dAogICAgICAqLwotICAgIF9hcHBlbmRU ZXh0Tm9kZTogZnVuY3Rpb24oZWxlbWVudCwgdGV4dCkKKyAgICBfaW5zZXJ0VGV4dE5vZGVCZWZv cmU6IGZ1bmN0aW9uKGVsZW1lbnQsIG9sZENoaWxkLCB0ZXh0KQogICAgIHsKICAgICAgICAgdmFy IHRleHROb2RlID0gdGhpcy5fY2FjaGVkVGV4dE5vZGVzLnBvcCgpOwogICAgICAgICBpZiAodGV4 dE5vZGUpCiAgICAgICAgICAgICB0ZXh0Tm9kZS5ub2RlVmFsdWUgPSB0ZXh0OwogICAgICAgICBl bHNlCiAgICAgICAgICAgICB0ZXh0Tm9kZSA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHRleHQp OwotICAgICAgICBlbGVtZW50LmFwcGVuZENoaWxkKHRleHROb2RlKTsKKyAgICAgICAgZWxlbWVu dC5pbnNlcnRCZWZvcmUodGV4dE5vZGUsIG9sZENoaWxkKTsKICAgICAgICAgaWYgKCEoInRleHRO b2RlcyIgaW4gZWxlbWVudCkpCiAgICAgICAgICAgICBlbGVtZW50LnRleHROb2RlcyA9IFtdOwog ICAgICAgICBlbGVtZW50LnRleHROb2Rlcy5wdXNoKHRleHROb2RlKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwppbmRleCBkNWIxMzA5N2Jl ZGI1ZjQ1MmFhOWM1YTQyZTRlN2FhMDVhOTY4MTA1Li4xYzEyNmVhOGVmMzkwOGFiYWU1NDA0NjUw ZmEzYjNjODA5NWJkYTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9pbnNwZWN0b3IuY3NzCkBAIC0yMzQ4LDYgKzIzNDgsNyBAQCBsaS5icmVha3BvaW50LWhp dCAuYnJlYWtwb2ludC1oaXQtbWFya2VyIHsKICAgICAtd2Via2l0LWJvcmRlci1yYWRpdXM6IDdw eDsKICAgICBib3JkZXI6IDJweCBzb2xpZCByZ2IoMTY5LCAxNzIsIDIwMyk7CiAgICAgd2lkdGg6 IDkwJTsKKyAgICBwb2ludGVyLWV2ZW50czogYXV0bzsKIH0KIAogLnNvdXJjZS1mcmFtZS1icmVh a3BvaW50LW1lc3NhZ2Ugewo=