97438 2012-09-24 01:52:17 -0700 [Forms] We should disconnect DateTimeEditElement and DateTimeFieldElement on layout() 2012-09-25 21:02:59 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin tkent oldest_to_newest 726460 0 yosin 2012-09-24 01:52:17 -0700 DateTimeEditElement::layout() calls removeChild() for DateTimeFieldElement during layout(). Although, we don't call DateTimeFieldElement::removeEventHandler() to disconnect DateTImeEditElement and DateTimeFieldElement. 726468 1 165332 yosin 2012-09-24 02:02:47 -0700 Created attachment 165332 Patch 1 726469 2 165332 yosin 2012-09-24 02:03:15 -0700 Comment on attachment 165332 Patch 1 Could you review this patch? Thanks in advance. 728167 3 165332 tkent 2012-09-25 20:15:06 -0700 Comment on attachment 165332 Patch 1 ok 728177 4 165332 yosin 2012-09-25 21:02:55 -0700 Comment on attachment 165332 Patch 1 Clearing flags on attachment: 165332 Committed r129591: <http://trac.webkit.org/changeset/129591> 728178 5 yosin 2012-09-25 21:02:59 -0700 All reviewed patches have been landed. Closing bug. 165332 2012-09-24 02:02:47 -0700 2012-09-25 21:02:54 -0700 Patch 1 bug-97438-20120924180208.patch text/plain 1765 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZkNmZhODNjMGU2YmY3 NDFlZmFkZDI1MTdlNzZkZmVmMWY0ZTUzNC4uOWQ2MjVlNzJkYTZiZWVhMWQ2YzBiZTk1NjNkZDI4 MDVkY2RhODNjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI0ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBXZSBz aG91bGQgZGlzY29ubmVjdCBEYXRlVGltZUVkaXRFbGVtZW50IGFuZCBEYXRlVGltZUZpZWxkRWxl bWVudCBvbiBsYXlvdXQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTc0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGlzIGZvciBjb2RlIGNsZWFudXAuIEl0IGlzIGJldHRlciB0byBk aXNjb25uZWN0IERhdGVUaW1lRmllbGRFbGVtZW50CisgICAgICAgIGZyb20gRGF0ZVRpbWVFZGl0 RWxlbWVudCB3aGVuIERhdGVUaW1lRWRpdEVsZW1lbnQgZG9lc24ndCBoYXZlCisgICAgICAgIHBv aW50ZXJzIHRvIERhdGVUaW1lRmllbGRFbGVtZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g VGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIGh0bWwvc2hh ZG93L0RhdGVUaW1lRWRpdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0ZVRpbWVF ZGl0RWxlbWVudDo6cmVzZXRGaWVsZHMpOiBDaGFuZ2VkIHRvIGNhbGwgRGF0ZVRpbWVGaWVsZEVs ZW1lbnQ6OnJlbW92ZUV2ZW50SGFuZGxlcigpCisgICAgICAgIGZvciBleGlzdGluZyBmaWVsZHMg dG8gZGlzY29ubmVjdCBEYXRlVGltZUVkaXRFbGVtZW50IGFuZCBEYXRlVGltZUZpZWxkRWxlbWVu dC4KKwogMjAxMi0wOS0yMyAgQnl1bmd3b28gTGVlICA8Ync4MC5sZWVAZ21haWwuY29tPgogCiAg ICAgICAgIEZpeCBidWlsZCB3YXJuaW5ncyA6IC1XdW51c2VkLXBhcmFtZXRlciwgLVdwYXJlbnRo ZXNlcywgLVd1bmluaXRpYWxpemVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9z aGFkb3cvRGF0ZVRpbWVFZGl0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRv dy9EYXRlVGltZUVkaXRFbGVtZW50LmNwcAppbmRleCAwN2JlZmQ4NzQxOGY5YTM3MzA2OGI0MWUx NmIyZjU1ZjNiNWRjNTJlLi5iZTRkMmVmZDI3MjE2MTBlNjQ2MWI4ZmI3MDhkNmIzNDdlNDM2Mzhm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUVkaXRFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUVkaXRFbGVt ZW50LmNwcApAQCAtMzc0LDYgKzM3NCw4IEBAIHZvaWQgRGF0ZVRpbWVFZGl0RWxlbWVudDo6cmVh ZE9ubHlTdGF0ZUNoYW5nZWQoKQogCiB2b2lkIERhdGVUaW1lRWRpdEVsZW1lbnQ6OnJlc2V0Rmll bGRzKCkKIHsKKyAgICBmb3IgKHNpemVfdCBmaWVsZEluZGV4ID0gMDsgZmllbGRJbmRleCA8IG1f ZmllbGRzLnNpemUoKTsgKytmaWVsZEluZGV4KQorICAgICAgICBtX2ZpZWxkc1tmaWVsZEluZGV4 XS0+cmVtb3ZlRXZlbnRIYW5kbGVyKCk7CiAgICAgbV9maWVsZHMuc2hyaW5rKDApOwogfQogCg==