97435 2012-09-24 01:01:23 -0700 JSArray::putByIndex asserts with readonly property on prototype 2012-09-24 17:20:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 barraclough fpizlo oldest_to_newest 726441 0 barraclough 2012-09-24 01:01:23 -0700 Object.defineProperty(Array.prototype, 0, { writable: false }); [42].concat(); 726476 1 barraclough 2012-09-24 02:11:39 -0700 <rdar://problem/12357084> [REGRESSION] JSArray::putByIndex asserts with readonly property on prototype 727092 2 165469 fpizlo 2012-09-24 17:00:31 -0700 Created attachment 165469 the patch 727097 3 165469 ggaren 2012-09-24 17:04:58 -0700 Comment on attachment 165469 the patch r=me 727111 4 fpizlo 2012-09-24 17:20:22 -0700 Landed in http://trac.webkit.org/changeset/129432 165469 2012-09-24 17:00:31 -0700 2012-09-24 17:04:58 -0700 the patch fixputbyindex.patch text/plain 7002 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NDI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDEyLTA5LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNBcnJheTo6cHV0QnlJbmRleCBhc3NlcnRzIHdpdGggcmVhZG9ubHkgcHJvcGVydHkgb24gcHJv dG90eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NzQzNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIzNTcwODQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQm95LCB0aGVyZSB3ZXJlIHNvbWUgcHJv YmxlbXM6CisgICAgICAgIAorICAgICAgICAtIHB1dERpcmVjdEluZGV4KCkgc2hvdWxkIGtub3cg dGhhdCBpdCBjYW4gc2V0IHRoZSBpbmRleCBxdWlja2x5IGV2ZW4gaWYgaXQncyBhIGhvbGUgYW5k IHdlJ3JlCisgICAgICAgICAgaW4gU2xvd1B1dCBtb2RlLCBzaW5jZSB0aGF0J3MgdGhlIHdob2xl IHBvaW50IG9mIFB1dERpcmVjdC4KKyAgICAgICAgCisgICAgICAgIC0gV2Ugc2hvdWxkIGhhdmUg YSBmYXN0IHBhdGggZm9yIHB1dEJ5SW5kZXgoKS4KKyAgICAgICAgCisgICAgICAgIC0gVGhlIExp dGVyYWxQYXJzZXIgc2hvdWxkIG5vdCB1c2UgcHVzaCgpLCBzaW5jZSB0aGF0IG1heSB0aHJvdyBp ZiB3ZSdyZSBoYXZpbmcgYSBiYWQgdGltZS4KKworICAgICAgICAqIGludGVycHJldGVyL0ludGVy cHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6ZXZhbCk6CisgICAgICAgICogcnVudGltZS9KU09i amVjdC5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cHV0QnlJbmRleElubGluZSk6CisgICAg ICAgIChKU09iamVjdCk6CisgICAgICAgIChKU0M6OkpTT2JqZWN0OjpwdXREaXJlY3RJbmRleCk6 CisgICAgICAgICogcnVudGltZS9MaXRlcmFsUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6Ojpw YXJzZSk6CisKIDIwMTItMDktMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZGVkIGEgbWlzc2luZyAiaWYgVkFMVUVfUFJPRklMRVIiIGFyb3VuZCBhbiBhY2Nl c3MgdG8gQXJyYXlQcm9maWxlIHJlY29yZC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAkocmV2aXNpb24gMTI5NDAzKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTY2LDYgKzE2Niw5IEBAIEpTVmFsdWUgZXZhbChDYWxsRnJhbWUqIGNhbGxG cmFtZSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHBhcnNlZE9iamVjdDsgICAgICAgICAg ICAgICAgCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIC8vIElm IHRoZSBsaXRlcmFsIHBhcnNlciBiYWlsZWQsIGl0IHNob3VsZCBub3QgaGF2ZSB0aHJvd24gZXhj ZXB0aW9ucy4KKyAgICAgICAgQVNTRVJUKCFjYWxsRnJhbWUtPmdsb2JhbERhdGEoKS5leGNlcHRp b24pOwogCiAgICAgICAgIEpTVmFsdWUgZXhjZXB0aW9uVmFsdWU7CiAgICAgICAgIGV2YWwgPSBj YWxsZXJDb2RlQmxvY2stPmV2YWxDb2RlQ2FjaGUoKS5nZXRTbG93KGNhbGxGcmFtZSwgY2FsbGVy Q29kZUJsb2NrLT5vd25lckV4ZWN1dGFibGUoKSwgY2FsbGVyQ29kZUJsb2NrLT5pc1N0cmljdE1v ZGUoKSwgcHJvZ3JhbVNvdXJjZSwgY2FsbGVyU2NvcGVDaGFpbiwgZXhjZXB0aW9uVmFsdWUpOwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCShyZXZpc2lvbiAx Mjk0MDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzIsNiArMTcyLDE1IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBK U19FWFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCBwdXQoSlNDZWxsKiwgRXhlY1N0YXRlKiwgUHJv cGVydHlOYW1lLCBKU1ZhbHVlLCBQdXRQcm9wZXJ0eVNsb3QmKTsKICAgICAgICAgSlNfRVhQT1JU X1BSSVZBVEUgc3RhdGljIHZvaWQgcHV0QnlJbmRleChKU0NlbGwqLCBFeGVjU3RhdGUqLCB1bnNp Z25lZCBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIGJvb2wgc2hvdWxkVGhyb3cpOwogICAgICAgICAK KyAgICAgICAgdm9pZCBwdXRCeUluZGV4SW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgdW5zaWduZWQg cHJvcGVydHlOYW1lLCBKU1ZhbHVlIHZhbHVlLCBib29sIHNob3VsZFRocm93KQorICAgICAgICB7 CisgICAgICAgICAgICBpZiAoY2FuU2V0SW5kZXhRdWlja2x5KHByb3BlcnR5TmFtZSkpIHsKKyAg ICAgICAgICAgICAgICBzZXRJbmRleFF1aWNrbHkoZXhlYy0+Z2xvYmFsRGF0YSgpLCBwcm9wZXJ0 eU5hbWUsIHZhbHVlKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9Cisg ICAgICAgICAgICBtZXRob2RUYWJsZSgpLT5wdXRCeUluZGV4KHRoaXMsIGV4ZWMsIHByb3BlcnR5 TmFtZSwgdmFsdWUsIHNob3VsZFRocm93KTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAg Ly8gVGhpcyBpcyBzaW1pbGFyIHRvIHRoZSBwdXREaXJlY3QqIG1ldGhvZHM6CiAgICAgICAgIC8v ICAtIHRoZSBwcm90b3R5cGUgY2hhaW4gaXMgbm90IGNvbnN1bHRlZAogICAgICAgICAvLyAgLSBh Y2Nlc3NvcnMgYXJlIG5vdCBjYWxsZWQuCkBAIC0xNzksNyArMTg4LDcgQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgICAgIC8vIFRoaXMgbWV0aG9kIGNyZWF0ZXMgYSBwcm9wZXJ0eSB3aXRoIGF0dHJp YnV0ZXMgd3JpdGFibGUsIGVudW1lcmFibGUgYW5kIGNvbmZpZ3VyYWJsZSBhbGwgc2V0IHRvIHRy dWUuCiAgICAgICAgIGJvb2wgcHV0RGlyZWN0SW5kZXgoRXhlY1N0YXRlKiBleGVjLCB1bnNpZ25l ZCBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUgdmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMsIFB1dERp cmVjdEluZGV4TW9kZSBtb2RlKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIWF0dHJpYnV0 ZXMgJiYgY2FuU2V0SW5kZXhRdWlja2x5KHByb3BlcnR5TmFtZSkpIHsKKyAgICAgICAgICAgIGlm ICghYXR0cmlidXRlcyAmJiBjYW5TZXRJbmRleFF1aWNrbHlGb3JQdXREaXJlY3QocHJvcGVydHlO YW1lKSkgewogICAgICAgICAgICAgICAgIHNldEluZGV4UXVpY2tseShleGVjLT5nbG9iYWxEYXRh KCksIHByb3BlcnR5TmFtZSwgdmFsdWUpOwogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwog ICAgICAgICAgICAgfQpAQCAtMjM1LDYgKzI0NCwxOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAKKyAgICAgICAgYm9vbCBjYW5TZXRJbmRleFF1 aWNrbHlGb3JQdXREaXJlY3QodW5zaWduZWQgaSkKKyAgICAgICAgeworICAgICAgICAgICAgc3dp dGNoIChzdHJ1Y3R1cmUoKS0+aW5kZXhpbmdUeXBlKCkpIHsKKyAgICAgICAgICAgIGNhc2UgQUxM X0JMQU5LX0lOREVYSU5HX1RZUEVTOgorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgICAgIGNhc2UgQUxMX0FSUkFZX1NUT1JBR0VfSU5ERVhJTkdfVFlQRVM6CisgICAgICAg ICAgICAgICAgcmV0dXJuIGkgPCBtX2J1dHRlcmZseS0+YXJyYXlTdG9yYWdlKCktPnZlY3Rvckxl bmd0aCgpOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICB9 CisgICAgICAgIH0KKyAgICAgICAgCiAgICAgICAgIHZvaWQgc2V0SW5kZXhRdWlja2x5KEpTR2xv YmFsRGF0YSYgZ2xvYmFsRGF0YSwgdW5zaWduZWQgaSwgSlNWYWx1ZSB2KQogICAgICAgICB7CiAg ICAgICAgICAgICBzd2l0Y2ggKHN0cnVjdHVyZSgpLT5pbmRleGluZ1R5cGUoKSkgewpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTGl0ZXJhbFBhcnNlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTGl0ZXJhbFBhcnNlci5jcHAJKHJl dmlzaW9uIDEyOTQwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xpdGVyYWxQ YXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzAsNyArNTcwLDggQEAgSlNWYWx1ZSBMaXRl cmFsUGFyc2VyPENoYXJUeXBlPjo6cGFyc2UoUAogICAgICAgICAgICAgICAgIGdvdG8gc3RhcnRQ YXJzZUV4cHJlc3Npb247CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBjYXNlIERvUGFyc2VB cnJheUVuZEV4cHJlc3Npb246IHsKLSAgICAgICAgICAgICAgICAgYXNBcnJheShvYmplY3RTdGFj ay5sYXN0KCkpLT5wdXNoKG1fZXhlYywgbGFzdFZhbHVlKTsKKyAgICAgICAgICAgICAgICBKU0Fy cmF5KiBhcnJheSA9IGFzQXJyYXkob2JqZWN0U3RhY2subGFzdCgpKTsKKyAgICAgICAgICAgICAg ICBhcnJheS0+cHV0RGlyZWN0SW5kZXgobV9leGVjLCBhcnJheS0+bGVuZ3RoKCksIGxhc3RWYWx1 ZSk7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgaWYgKG1fbGV4ZXIuY3VycmVu dFRva2VuKCkudHlwZSA9PSBUb2tDb21tYSkKICAgICAgICAgICAgICAgICAgICAgZ290byBkb1Bh cnNlQXJyYXlTdGFydEV4cHJlc3Npb247CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjk0MjgpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAx Mi0wOS0yNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEpTQXJy YXk6OnB1dEJ5SW5kZXggYXNzZXJ0cyB3aXRoIHJlYWRvbmx5IHByb3BlcnR5IG9uIHByb3RvdHlw ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0MzUK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMzU3MDg0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9jb25jYXQtd2hpbGUtaGF2aW5n LWEtYmFkLXRpbWUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMv Y29uY2F0LXdoaWxlLWhhdmluZy1hLWJhZC10aW1lLmpzOiBBZGRlZC4KKwogMjAxMi0wOS0yNCAg Um9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu IE1hcmsgaHR0cC90ZXN0cy9zZWN1cml0eS9pbmFjdGl2ZS1kb2N1bWVudC13aXRoLWVtcHR5LXNl Y3VyaXR5LW9yaWdpbi5odG1sIHdoaWxlIEdlb2ZmIEdhcmVuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2pzL2NvbmNhdC13aGlsZS1oYXZpbmctYS1iYWQtdGltZS5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvY29uY2F0LXdoaWxlLWhhdmluZy1hLWJhZC10aW1lLmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvbmNhdC13aGlsZS1oYXZpbmct YS1iYWQtdGltZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUg SFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNj cmlwdCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvY29uY2F0LXdoaWxlLWhhdmluZy1hLWJh ZC10aW1lLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2NvbmNhdC13aGlsZS1oYXZpbmctYS1iYWQtdGltZS5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9jb25jYXQtd2hpbGUtaGF2 aW5nLWEtYmFkLXRpbWUuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Nj cmlwdC10ZXN0cy9jb25jYXQtd2hpbGUtaGF2aW5nLWEtYmFkLXRpbWUuanMJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsOCBAQAorZGVzY3JpcHRpb24oCisiVGVzdHMgdGhlIGJlaGF2aW9yIG9mIEFy cmF5LnByb3RvdHlwZS5jb25jYXQgd2hpbGUgdGhlIGFycmF5IGlzIGhhdmluZyBhIGJhZCB0aW1l IGR1ZSB0byBvbmUgb2YgdGhlIGVsZW1lbnRzIHdlIGFyZSBjb25jYXRlbmF0aW5nLiIKKyk7CisK K09iamVjdC5kZWZpbmVQcm9wZXJ0eShBcnJheS5wcm90b3R5cGUsIDAsIHsgd3JpdGFibGU6IGZh bHNlIH0pOworc2hvdWxkQmUoIls0Ml0uY29uY2F0KCkiLCAiWzQyXSIpOworCisK