97431 2012-09-24 00:26:46 -0700 [EFL][WK2] Add callback functions for WKPageFindClient 2012-09-27 06:00:00 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cdumez gyuyoung.kim haraken laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 726422 0 jinwoo7.song 2012-09-24 00:26:46 -0700 Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions. 726425 1 165321 jinwoo7.song 2012-09-24 00:31:22 -0700 Created attachment 165321 patch 726691 2 165321 cdumez 2012-09-24 08:29:10 -0700 Comment on attachment 165321 patch Can we unit test this? 727256 3 jinwoo7.song 2012-09-24 21:21:43 -0700 (In reply to comment #2) > (From update of attachment 165321 [details]) > Can we unit test this? Sure, we can make a unit test. I'll add the unit test and upload a new patch. 727258 4 165321 gyuyoung.kim 2012-09-24 21:28:38 -0700 Comment on attachment 165321 patch View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42 > +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo) It looks we can remove /*string*/. string doesn't represent anything. > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47 > +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo) ditto. 727390 5 jinwoo7.song 2012-09-25 01:14:12 -0700 (In reply to comment #4) > (From update of attachment 165321 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42 > > +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo) > > It looks we can remove /*string*/. string doesn't represent anything. > Absolutely right! > > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47 > > +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo) > > ditto. 728156 6 165719 jinwoo7.song 2012-09-25 19:33:43 -0700 Created attachment 165719 Patch 728157 7 jinwoo7.song 2012-09-25 19:36:05 -0700 The unit test for didFindString() and didFailToFindString() have beend added. But the unit test for didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet. So I'll make that API and unit test in another patch. 728262 8 165719 cdumez 2012-09-26 00:13:30 -0700 Comment on attachment 165719 Patch Looks sane. 729163 9 165719 laszlo.gombos 2012-09-26 20:04:41 -0700 Comment on attachment 165719 Patch lgtm, r=me. 729165 10 165719 webkit.review.bot 2012-09-26 20:11:18 -0700 Comment on attachment 165719 Patch Rejecting attachment 165719 from review queue. laszlo.gombos@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 729166 11 165719 gyuyoung.kim 2012-09-26 20:12:10 -0700 Comment on attachment 165719 Patch Clear cq+ because Gombos reviews has problem. 729451 12 165719 laszlo.gombos 2012-09-27 05:54:58 -0700 Comment on attachment 165719 Patch r=me 729453 13 165719 webkit.review.bot 2012-09-27 05:59:55 -0700 Comment on attachment 165719 Patch Clearing flags on attachment: 165719 Committed r129758: <http://trac.webkit.org/changeset/129758> 729454 14 webkit.review.bot 2012-09-27 06:00:00 -0700 All reviewed patches have been landed. Closing bug. 165321 2012-09-24 00:31:22 -0700 2012-09-25 19:33:40 -0700 patch findString.patch text/plain 3069 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzODk0MTIzLi43ZDkyMTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDktMjMgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gQWRkIGNhbGxiYWNrIGZ1bmN0aW9ucyBmb3IgV0tQYWdlRmlu ZENsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTc0MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgZGlkRmFpbFRvRmluZFN0cmluZygpIGFuZCBkaWRDb3VudFN0cmluZ01hdGNoZXMoKSBmb3Ig V0tQYWdlRmluZENsaWVudCdzIGNhbGxiYWNrIGZ1bmN0aW9ucy4KKyAgICAgICAgQWxzbywgSSBj aGFuZ2VkIHRoZSAndW5zaW5nZWQgaW50JyB0byAndW5zaWduZWQnIGluIHRoZSBwYXJhbWV0ZXIg dHlwZSBhbmQgcmVtb3ZlZCB1bm5lY2Vzc2FyeQorICAgICAgICB0eXBlIGNvbnZlcnNpb24uCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tf dmlld190ZXh0X2ZvdW5kKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19m aW5kX2NsaWVudC5jcHA6CisgICAgICAgIChkaWRGaW5kU3RyaW5nKToKKyAgICAgICAgKGRpZEZh aWxUb0ZpbmRTdHJpbmcpOgorICAgICAgICAoZGlkQ291bnRTdHJpbmdNYXRjaGVzKToKKyAgICAg ICAgKGV3a192aWV3X2ZpbmRfY2xpZW50X2F0dGFjaCk6CisKIDIwMTItMDktMjIgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBJbnN0YWxsIFdlYlByb2Nlc3MgWFBDIHNl cnZpY2VzIGludG8gdGhlIHJpZ2h0IHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDEwYTY4YzQuLjUyNDI5NTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTEwMDcsNyArMTAw Nyw3IEBAIGNvbnN0IGNoYXIqIGV3a192aWV3X3RpdGxlX2dldChjb25zdCBFdmFzX09iamVjdCog ZXdrVmlldykKICAqCiAgKiBFbWl0cyBzaWduYWw6ICJ0ZXh0LGZvdW5kIiB3aXRoIHRoZSBudW1i ZXIgb2YgbWF0Y2hlcy4KICAqLwotdm9pZCBld2tfdmlld190ZXh0X2ZvdW5kKEV2YXNfT2JqZWN0 KiBld2tWaWV3LCB1bnNpZ25lZCBpbnQgbWF0Y2hDb3VudCkKK3ZvaWQgZXdrX3ZpZXdfdGV4dF9m b3VuZChFdmFzX09iamVjdCogZXdrVmlldywgdW5zaWduZWQgbWF0Y2hDb3VudCkKIHsKICAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0ZXh0LGZvdW5kIiwgJm1h dGNoQ291bnQpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3ZpZXdfZmluZF9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXdfZmluZF9jbGllbnQuY3BwCmluZGV4IDYzN2U3YWUuLjI0NGNhN2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X2ZpbmRf Y2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll d19maW5kX2NsaWVudC5jcHAKQEAgLTM2LDcgKzM2LDE3IEBAIHN0YXRpYyBpbmxpbmUgRXZhc19P YmplY3QqIHRvRXdrVmlldyhjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogCiBzdGF0aWMgdm9pZCBk aWRGaW5kU3RyaW5nKFdLUGFnZVJlZiwgV0tTdHJpbmdSZWYgLypzdHJpbmcqLywgdW5zaWduZWQg bWF0Y2hDb3VudCwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKLSAgICBld2tfdmlld190ZXh0 X2ZvdW5kKHRvRXdrVmlldyhjbGllbnRJbmZvKSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgaW50Piht YXRjaENvdW50KSk7CisgICAgZXdrX3ZpZXdfdGV4dF9mb3VuZCh0b0V3a1ZpZXcoY2xpZW50SW5m byksIG1hdGNoQ291bnQpOworfQorCitzdGF0aWMgdm9pZCBkaWRGYWlsVG9GaW5kU3RyaW5nKFdL UGFnZVJlZiwgV0tTdHJpbmdSZWYgLypzdHJpbmcqLywgY29uc3Qgdm9pZCogY2xpZW50SW5mbykK K3sKKyAgICBld2tfdmlld190ZXh0X2ZvdW5kKHRvRXdrVmlldyhjbGllbnRJbmZvKSwgMCk7Cit9 CisKK3N0YXRpYyB2b2lkIGRpZENvdW50U3RyaW5nTWF0Y2hlcyhXS1BhZ2VSZWYsIFdLU3RyaW5n UmVmIC8qc3RyaW5nKi8sIHVuc2lnbmVkIG1hdGNoQ291bnQsIGNvbnN0IHZvaWQqIGNsaWVudElu Zm8pCit7CisgICAgZXdrX3ZpZXdfdGV4dF9mb3VuZCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIG1h dGNoQ291bnQpOwogfQogCiB2b2lkIGV3a192aWV3X2ZpbmRfY2xpZW50X2F0dGFjaChXS1BhZ2VS ZWYgcGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcpCkBAIC00Niw1ICs1Niw3IEBAIHZvaWQg ZXdrX3ZpZXdfZmluZF9jbGllbnRfYXR0YWNoKFdLUGFnZVJlZiBwYWdlUmVmLCBFdmFzX09iamVj dCogZXdrVmlldykKICAgICBmaW5kQ2xpZW50LnZlcnNpb24gPSBrV0tQYWdlRmluZENsaWVudEN1 cnJlbnRWZXJzaW9uOwogICAgIGZpbmRDbGllbnQuY2xpZW50SW5mbyA9IGV3a1ZpZXc7CiAgICAg ZmluZENsaWVudC5kaWRGaW5kU3RyaW5nID0gZGlkRmluZFN0cmluZzsKKyAgICBmaW5kQ2xpZW50 LmRpZEZhaWxUb0ZpbmRTdHJpbmcgPSBkaWRGYWlsVG9GaW5kU3RyaW5nOworICAgIGZpbmRDbGll bnQuZGlkQ291bnRTdHJpbmdNYXRjaGVzID0gZGlkQ291bnRTdHJpbmdNYXRjaGVzOwogICAgIFdL UGFnZVNldFBhZ2VGaW5kQ2xpZW50KHBhZ2VSZWYsICZmaW5kQ2xpZW50KTsKIH0K 165719 2012-09-25 19:33:43 -0700 2012-09-27 05:59:55 -0700 Patch bug-97431-20120926113259.patch text/plain 6445 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWQ4NjlhMThlYjZkODFi MDZjMDg2YTAxM2FmNTI2Mjg5YzM0YzkwMy4uNTcxODNiNmMwNTcxYmMxMTM1MjAyNDU1NDAzODcw ZTM4M2U0NjVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTI1ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IEFkZCBjYWxsYmFjayBmdW5jdGlvbnMgZm9yIFdLUGFnZUZpbmRDbGllbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDMxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGRpZEZhaWxUb0ZpbmRTdHJp bmcoKSBhbmQgZGlkQ291bnRTdHJpbmdNYXRjaGVzKCkgZm9yIFdLUGFnZUZpbmRDbGllbnQncyBj YWxsYmFjayBmdW5jdGlvbnMuCisgICAgICAgIFRoZSB1bml0IHRlc3QgZm9yIGRpZEZpbmRTdHJp bmcoKSBhbmQgZGlkRmFpbFRvRmluZFN0cmluZygpIGhhdmUgYmVlbmQgYWRkZWQuIFRoZSB1bml0 IHRlc3QgZm9yCisgICAgICAgIGRpZENvdW50U3RyaW5nTWF0Y2hlcygpIG5lZWRzIGEgQVBJIHdo aWNoIHdyYXBzIHRoZSBXS1BhZ2VDb3VudFN0cmluZ01hdGNoZXMgYnV0IGl0IGlzIG5vdCBleGlz dHMgeWV0LgorICAgICAgICBBZGRpdGlvbmFseSwgSSBjaGFuZ2VkIHRoZSAndW5zaW5nZWQgaW50 JyB0byAndW5zaWduZWQnIGluIHRoZSBwYXJhbWV0ZXIgdHlwZSBhbmQgcmVtb3ZlZCB1bm5lY2Vz c2FyeQorICAgICAgICB0eXBlIGNvbnZlcnNpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld190ZXh0X2ZpbmQpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXdfZmluZF9jbGllbnQuY3BwOgorICAgICAgICAoZGlkRmluZFN0cmluZyk6 CisgICAgICAgIChkaWRGYWlsVG9GaW5kU3RyaW5nKToKKyAgICAgICAgKGRpZENvdW50U3RyaW5n TWF0Y2hlcyk6CisgICAgICAgIChld2tfdmlld19maW5kX2NsaWVudF9hdHRhY2gpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcDoKKyAgICAgICAg KG9uVGV4dEZvdW5kKToKKyAgICAgICAgKFRFU1RfRik6CisKIDIwMTItMDktMjUgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4gSSByZW1vdmVkIHRo aXMgZnVuY3Rpb24gYXMgYSBwYXJ0IG9mIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDEwYTY4YzQwNDE5YWEzNzA3NjliMzlmNjI1YzBmNmU3 ZWU0YmEzYjkuLmExN2U2N2ZmMDA5ODI3ZDViMzEwNTdhM2ZkYzY0OTg1NmE0ZGE0MDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTE1MTcs NyArMTUxNyw3IEBAIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oRVdLX0ZJTkRfT1BUSU9O U19TSE9XX09WRVJMQVksIGtXS0ZpbmRPcHRpb25zU2hvd092CiBDT01QSUxFX0FTU0VSVF9NQVRD SElOR19FTlVNKEVXS19GSU5EX09QVElPTlNfU0hPV19GSU5EX0lORElDQVRPUiwga1dLRmluZE9w dGlvbnNTaG93RmluZEluZGljYXRvcik7CiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEVX S19GSU5EX09QVElPTlNfU0hPV19ISUdITElHSFQsIGtXS0ZpbmRPcHRpb25zU2hvd0hpZ2hsaWdo dCk7CiAKLUVpbmFfQm9vbCBld2tfdmlld190ZXh0X2ZpbmQoRXZhc19PYmplY3QqIGV3a1ZpZXcs IGNvbnN0IGNoYXIqIHRleHQsIEV3a19GaW5kX09wdGlvbnMgb3B0aW9ucywgdW5zaWduZWQgaW50 IG1heE1hdGNoQ291bnQpCitFaW5hX0Jvb2wgZXdrX3ZpZXdfdGV4dF9maW5kKEV2YXNfT2JqZWN0 KiBld2tWaWV3LCBjb25zdCBjaGFyKiB0ZXh0LCBFd2tfRmluZF9PcHRpb25zIG9wdGlvbnMsIHVu c2lnbmVkIG1heE1hdGNoQ291bnQpCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihl d2tWaWV3LCBzbWFydERhdGEsIGZhbHNlKTsKICAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRV Uk4oc21hcnREYXRhLCBwcml2LCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuaAppbmRleCAxM2YxMzhjODdjMDc2NWIwZmNkZWU4YmVjMzY5Y2VkN2Zj MTc4YjFlLi4zZTVmYTkyYTM3NjQ5MzhhY2M2YzNiMDZiYjQ0NGFhMDcwMmFhZTZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKQEAgLTYyMiw3ICs2MjIs NyBAQCBFQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9z ZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0IGNoYQogKgogKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBv biBzdWNjZXNzLCBAYyBFSU5BX0ZBTFNFIG9uIGVycm9ycwogKi8KLUVBUEkgRWluYV9Cb29sIGV3 a192aWV3X3RleHRfZmluZChFdmFzX09iamVjdCAqbywgY29uc3QgY2hhciAqdGV4dCwgRXdrX0Zp bmRfT3B0aW9ucyBvcHRpb25zLCB1bnNpZ25lZCBpbnQgbWF4X21hdGNoX2NvdW50KTsKK0VBUEkg RWluYV9Cb29sIGV3a192aWV3X3RleHRfZmluZChFdmFzX09iamVjdCAqbywgY29uc3QgY2hhciAq dGV4dCwgRXdrX0ZpbmRfT3B0aW9ucyBvcHRpb25zLCB1bnNpZ25lZCBtYXhfbWF0Y2hfY291bnQp OwogCiAvKioKICogQ2xlYXJzIHRoZSBoaWdobGlnaHQgb2Ygc2VhcmNoZWQgdGV4dC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X2ZpbmRfY2xp ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X2ZpbmRf Y2xpZW50LmNwcAppbmRleCA2MzdlN2FlYzIwYmUzMDhkNjExNGQ5ZjZhN2JkM2U3ZjI1YjMzNTEz Li4xZWRjM2NiZmQzMjdjZmRhYWMwOWU5YWY4YjJmODEyZGY4Zjk4M2M0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19maW5kX2NsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfZmluZF9jbGll bnQuY3BwCkBAIC0zNCw5ICszNCwxOSBAQCBzdGF0aWMgaW5saW5lIEV2YXNfT2JqZWN0KiB0b0V3 a1ZpZXcoY29uc3Qgdm9pZCogY2xpZW50SW5mbykKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RXZh c19PYmplY3QqPihjb25zdF9jYXN0PHZvaWQqPihjbGllbnRJbmZvKSk7CiB9CiAKLXN0YXRpYyB2 b2lkIGRpZEZpbmRTdHJpbmcoV0tQYWdlUmVmLCBXS1N0cmluZ1JlZiAvKnN0cmluZyovLCB1bnNp Z25lZCBtYXRjaENvdW50LCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQorc3RhdGljIHZvaWQgZGlk RmluZFN0cmluZyhXS1BhZ2VSZWYsIFdLU3RyaW5nUmVmLCB1bnNpZ25lZCBtYXRjaENvdW50LCBj b25zdCB2b2lkKiBjbGllbnRJbmZvKQogewotICAgIGV3a192aWV3X3RleHRfZm91bmQodG9Fd2tW aWV3KGNsaWVudEluZm8pLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBpbnQ+KG1hdGNoQ291bnQpKTsK KyAgICBld2tfdmlld190ZXh0X2ZvdW5kKHRvRXdrVmlldyhjbGllbnRJbmZvKSwgbWF0Y2hDb3Vu dCk7Cit9CisKK3N0YXRpYyB2b2lkIGRpZEZhaWxUb0ZpbmRTdHJpbmcoV0tQYWdlUmVmLCBXS1N0 cmluZ1JlZiwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBld2tfdmlld190ZXh0X2Zv dW5kKHRvRXdrVmlldyhjbGllbnRJbmZvKSwgMCk7Cit9CisKK3N0YXRpYyB2b2lkIGRpZENvdW50 U3RyaW5nTWF0Y2hlcyhXS1BhZ2VSZWYsIFdLU3RyaW5nUmVmLCB1bnNpZ25lZCBtYXRjaENvdW50 LCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIGV3a192aWV3X3RleHRfZm91bmQodG9F d2tWaWV3KGNsaWVudEluZm8pLCBtYXRjaENvdW50KTsKIH0KIAogdm9pZCBld2tfdmlld19maW5k X2NsaWVudF9hdHRhY2goV0tQYWdlUmVmIHBhZ2VSZWYsIEV2YXNfT2JqZWN0KiBld2tWaWV3KQpA QCAtNDYsNSArNTYsNyBAQCB2b2lkIGV3a192aWV3X2ZpbmRfY2xpZW50X2F0dGFjaChXS1BhZ2VS ZWYgcGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiAgICAgZmluZENsaWVudC52ZXJzaW9u ID0ga1dLUGFnZUZpbmRDbGllbnRDdXJyZW50VmVyc2lvbjsKICAgICBmaW5kQ2xpZW50LmNsaWVu dEluZm8gPSBld2tWaWV3OwogICAgIGZpbmRDbGllbnQuZGlkRmluZFN0cmluZyA9IGRpZEZpbmRT dHJpbmc7CisgICAgZmluZENsaWVudC5kaWRGYWlsVG9GaW5kU3RyaW5nID0gZGlkRmFpbFRvRmlu ZFN0cmluZzsKKyAgICBmaW5kQ2xpZW50LmRpZENvdW50U3RyaW5nTWF0Y2hlcyA9IGRpZENvdW50 U3RyaW5nTWF0Y2hlczsKICAgICBXS1BhZ2VTZXRQYWdlRmluZENsaWVudChwYWdlUmVmLCAmZmlu ZENsaWVudCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggNzNmM2FjNzQ5NTZmOTVhZTI5MThl Njc4MDkyY2M4YjVjMzkwN2Y4NS4uNTliYzRiMDUyODcwYzY4YmNkZWEyYmI5YTlkZWJmOGVmY2Zm YjQxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtNzg3LDMgKzc4Nyw0MCBAQCBURVNUX0YoRVdL MlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudCkKIAogICAgIGVpbmFfbGlz dF9mcmVlKHBvaW50cyk7CiB9CisKK3N0YXRpYyB2b2lkIG9uVGV4dEZvdW5kKHZvaWQqIHVzZXJE YXRhLCBFdmFzX09iamVjdCosIHZvaWQqIGV2ZW50SW5mbykKK3sKKyAgICBpbnQqIHJlc3VsdCA9 IHN0YXRpY19jYXN0PGludCo+KHVzZXJEYXRhKTsKKyAgICB1bnNpZ25lZCogbWF0Y2hDb3VudCA9 IHN0YXRpY19jYXN0PHVuc2lnbmVkKj4oZXZlbnRJbmZvKTsKKworICAgICpyZXN1bHQgPSAqbWF0 Y2hDb3VudDsKK30KKworVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X3RleHRfZmlu ZCkKK3sKKyAgICBjb25zdCBjaGFyIHRleHRGaW5kSFRNTFtdID0KKyAgICAgICAgIjwhRE9DVFlQ RSBodG1sPiIKKyAgICAgICAgIjxodG1sPiIKKyAgICAgICAgIjxib2R5PiIKKyAgICAgICAgImFw cGxlIGFwcGxlIGFwcGxlIGJhbmFuYSBiYW5hbmEgY29jb251dCIKKyAgICAgICAgIjwvYm9keT4i CisgICAgICAgICI8L2h0bWw+IjsKKyAgICBld2tfdmlld19odG1sX3N0cmluZ19sb2FkKHdlYlZp ZXcoKSwgdGV4dEZpbmRIVE1MLCAwLCAwKTsKKyAgICB3YWl0VW50aWxMb2FkRmluaXNoZWQoKTsK KworICAgIGludCBtYXRjaENvdW50ID0gLTE7CisgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJh Y2tfYWRkKHdlYlZpZXcoKSwgInRleHQsZm91bmQiLCBvblRleHRGb3VuZCwgJm1hdGNoQ291bnQp OworCisgICAgZXdrX3ZpZXdfdGV4dF9maW5kKHdlYlZpZXcoKSwgImFwcGxlIiwgRVdLX0ZJTkRf T1BUSU9OU19TSE9XX09WRVJMQVksIDEwMCk7CisgICAgd2hpbGUgKG1hdGNoQ291bnQgPCAwKQor ICAgICAgICBlY29yZV9tYWluX2xvb3BfaXRlcmF0ZSgpOworICAgIEVYUEVDVF9FUSgzLCBtYXRj aENvdW50KTsKKworICAgIG1hdGNoQ291bnQgPSAtMTsKKyAgICBld2tfdmlld190ZXh0X2ZpbmQo d2ViVmlldygpLCAibWFuZ28iLCBFV0tfRklORF9PUFRJT05TX1NIT1dfT1ZFUkxBWSwgMTAwKTsK KyAgICB3aGlsZSAobWF0Y2hDb3VudCA8IDApCisgICAgICAgIGVjb3JlX21haW5fbG9vcF9pdGVy YXRlKCk7CisgICAgRVhQRUNUX0VRKDAsIG1hdGNoQ291bnQpOworCisgICAgZXZhc19vYmplY3Rf c21hcnRfY2FsbGJhY2tfZGVsKHdlYlZpZXcoKSwgInRleHQsZm91bmQiLCBvblRleHRGb3VuZCk7 Cit9Cg==