97419 2012-09-23 19:06:03 -0700 [CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR' 2012-09-24 20:21:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bw80.lee bw80.lee gyuyoung.kim mxie paroga rakuco webkit.review.bot oldest_to_newest 726333 0 bw80.lee 2012-09-23 19:06:03 -0700 There is hardcoded 'lib' and 'bin' in CMakeLists.txt, and this might be better to be changed to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'. 726372 1 bw80.lee 2012-09-23 21:26:19 -0700 I tested on Debug/Release and it works ok. 726492 2 165337 bw80.lee 2012-09-24 02:38:41 -0700 Created attachment 165337 Patch 726697 3 165337 paroga 2012-09-24 08:35:13 -0700 Comment on attachment 165337 Patch look ok to me 726698 4 165337 rakuco 2012-09-24 08:36:13 -0700 Comment on attachment 165337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165337&action=review > ChangeLog:3 > + Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'. Please use the [CMake] prefix for CMake-related bugs. > ChangeLog:11 > + Currently, 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR' is used for > + hardcoded 'lib' and 'bin' directory. > + Apply this to set the below variables. > + CMAKE_ARCHIVE_OUTPUT_DIRECTORY, CMAKE_LIBRARY_OUTPUT_DIRECTORY, CMAKE_RUNTIME_OUTPUT_DIRECTORY This explanation is hard to understand. Just saying something like "Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of hardcoding lib and bin for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY" would be easier to grasp. 726716 5 165337 bw80.lee 2012-09-24 08:47:24 -0700 Comment on attachment 165337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165337&action=review >> ChangeLog:3 >> + Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'. > > Please use the [CMake] prefix for CMake-related bugs. Ok~ I'll add it. >> ChangeLog:11 >> + CMAKE_ARCHIVE_OUTPUT_DIRECTORY, CMAKE_LIBRARY_OUTPUT_DIRECTORY, CMAKE_RUNTIME_OUTPUT_DIRECTORY > > This explanation is hard to understand. Just saying something like "Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of hardcoding lib and bin for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY" would be easier to grasp. Ok~ it'll be more clear :) 726719 6 mxie 2012-09-24 08:53:07 -0700 Sorry, why do you want to remove this line? -INCLUDE(OptionsCommon) 726721 7 165393 bw80.lee 2012-09-24 08:57:30 -0700 Created attachment 165393 Patch 726738 8 bw80.lee 2012-09-24 09:23:36 -0700 (In reply to comment #6) > Sorry, why do you want to remove this line? > > -INCLUDE(OptionsCommon) The line is not removed. it is moved to the above (#132). 726805 9 165393 rakuco 2012-09-24 10:10:55 -0700 Comment on attachment 165393 Patch Looks fine, thanks. 726813 10 mxie 2012-09-24 10:28:50 -0700 (In reply to comment #8) > (In reply to comment #6) > > Sorry, why do you want to remove this line? > > > > -INCLUDE(OptionsCommon) > The line is not removed. it is moved to the above (#132). I don't know how I missed that. Sorry! :( 727159 11 bw80.lee 2012-09-24 18:31:18 -0700 (In reply to comment #10) > (In reply to comment #8) > > (In reply to comment #6) > > > Sorry, why do you want to remove this line? > > > > > > -INCLUDE(OptionsCommon) > > The line is not removed. it is moved to the above (#132). > > I don't know how I missed that. Sorry! :( No problem :) 727224 12 165393 webkit.review.bot 2012-09-24 20:21:54 -0700 Comment on attachment 165393 Patch Clearing flags on attachment: 165393 Committed r129447: <http://trac.webkit.org/changeset/129447> 727225 13 webkit.review.bot 2012-09-24 20:21:58 -0700 All reviewed patches have been landed. Closing bug. 165337 2012-09-24 02:38:41 -0700 2012-09-24 08:57:24 -0700 Patch bug-97419-20120924183755.patch text/plain 2457 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDk5CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDVmZjRlZGM0OTNlZWNiYmM0ZDE3ZGU5NTVlYjBkOWE4ZjVj ZTZkYzQuLmE5MWYyNTU5OWIwOWU4NzMwNjM1MDgzMjBjODhlYmMyNWQ0MWMwYTEgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zNiwxMCArMzYsNiBA QCBTRVQoREVSSVZFRF9TT1VSQ0VTX1dFQktJVDJfRElSICIke0NNQUtFX0JJTkFSWV9ESVJ9L0Rl cml2ZWRTb3VyY2VzL1dlYktpdDIiKQogCiBTRVQoQ01BS0VfTU9EVUxFX1BBVEggIiR7Q01BS0Vf U09VUkNFX0RJUn0vU291cmNlL2NtYWtlIikKIAotU0VUKENNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJ UkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L2xpYikKLVNFVChDTUFLRV9MSUJSQVJZX09VVFBV VF9ESVJFQ1RPUlkgJHtDTUFLRV9CSU5BUllfRElSfS9saWIpCi1TRVQoQ01BS0VfUlVOVElNRV9P VVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vYmluKQotCiBJTkNMVURFKFdlYktp dE1hY3JvcykKIElOQ0xVREUoV2ViS2l0RlMpCiBJTkNMVURFKFdlYktpdEhlbHBlcnMpCkBAIC0x MzEsOSArMTI3LDE2IEBAIFNFVChXZWJLaXQyX0xJQlJBUllfVFlQRSBTSEFSRUQpCiBTRVQoV2Vi Q29yZVRlc3RTdXBwb3J0X0xJQlJBUllfVFlQRSBTVEFUSUMpCiAKICMgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KKyMgQ29tbW9uIG9wdGlvbnMKKyMtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK0lOQ0xVREUo T3B0aW9uc0NvbW1vbikKK1NFVChDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUlkgJHtDTUFL RV9CSU5BUllfRElSfS8ke0xJQl9JTlNUQUxMX0RJUn0pCitTRVQoQ01BS0VfTElCUkFSWV9PVVRQ VVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vJHtMSUJfSU5TVEFMTF9ESVJ9KQorU0VU KENNQUtFX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9LyR7RVhF Q19JTlNUQUxMX0RJUn0pCisKKyMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgUG9ydC1zcGVjaWZp YyBvcHRpb25zCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi1JTkNMVURFKE9wdGlvbnNDb21tb24p CiBJTkNMVURFKE9wdGlvbnMke1BPUlR9KQogCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCmRpZmYg LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWMzY2FkZDBhZTM0ODMzMDE1MGVh NzM4NzUwNmM5N2Q3ZWQ3YTI5Yy4uMmM0MGFkZGVlNWYzZWVlZDkzN2YxNzMzMGQyZTdlNDFjOGFh ZWRmMSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA5LTIzICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBDaGFuZ2UgaGFyZGNvZGVkICdsaWInIGFuZCAnYmluJyBpbiBDTWFrZUxpc3RzLnR4 dCB0byAnTElCX0lOU1RBTExfRElSJyBhbmQgJ0VYRUNfSU5TVEFMTF9ESVInLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0MTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksICdMSUJfSU5T VEFMTF9ESVInIGFuZCAnRVhFQ19JTlNUQUxMX0RJUicgaXMgdXNlZCBmb3IKKyAgICAgICAgaGFy ZGNvZGVkICdsaWInIGFuZCAnYmluJyBkaXJlY3RvcnkuCisgICAgICAgIEFwcGx5IHRoaXMgdG8g c2V0IHRoZSBiZWxvdyB2YXJpYWJsZXMuCisgICAgICAgIENNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJ UkVDVE9SWSwgQ01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZLCBDTUFLRV9SVU5USU1FX09V VFBVVF9ESVJFQ1RPUlkKKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICBVc2Ug JHtMSUJfSU5TVEFMTF9ESVJ9IGluc3RlYWQgb2YgaGFyZGNvZGluZyAibGliIi4KKyAgICAgICAg VXNlICR7RVhFQ19JTlNUQUxMX0RJUn0gaW5zdGVhZCBvZiBoYXJkY29kaW5nICJiaW4iLgorCiAy MDEyLTA5LTE4ICBTYWlsZXNoIEFncmF3YWwgIDxzYWlsQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBDaHJvbWl1bTogU2Nyb2xsYmFyIHdpdGggdGlja21hcmtzIGRvZXNuJ3QgcmVzcG9uZCB0byBj bGlja3MK 165393 2012-09-24 08:57:30 -0700 2012-09-24 20:21:54 -0700 Patch bug-97419-20120925005645.patch text/plain 2358 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDk5CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDVmZjRlZGM0OTNlZWNiYmM0ZDE3ZGU5NTVlYjBkOWE4ZjVj ZTZkYzQuLmE5MWYyNTU5OWIwOWU4NzMwNjM1MDgzMjBjODhlYmMyNWQ0MWMwYTEgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zNiwxMCArMzYsNiBA QCBTRVQoREVSSVZFRF9TT1VSQ0VTX1dFQktJVDJfRElSICIke0NNQUtFX0JJTkFSWV9ESVJ9L0Rl cml2ZWRTb3VyY2VzL1dlYktpdDIiKQogCiBTRVQoQ01BS0VfTU9EVUxFX1BBVEggIiR7Q01BS0Vf U09VUkNFX0RJUn0vU291cmNlL2NtYWtlIikKIAotU0VUKENNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJ UkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L2xpYikKLVNFVChDTUFLRV9MSUJSQVJZX09VVFBV VF9ESVJFQ1RPUlkgJHtDTUFLRV9CSU5BUllfRElSfS9saWIpCi1TRVQoQ01BS0VfUlVOVElNRV9P VVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vYmluKQotCiBJTkNMVURFKFdlYktp dE1hY3JvcykKIElOQ0xVREUoV2ViS2l0RlMpCiBJTkNMVURFKFdlYktpdEhlbHBlcnMpCkBAIC0x MzEsOSArMTI3LDE2IEBAIFNFVChXZWJLaXQyX0xJQlJBUllfVFlQRSBTSEFSRUQpCiBTRVQoV2Vi Q29yZVRlc3RTdXBwb3J0X0xJQlJBUllfVFlQRSBTVEFUSUMpCiAKICMgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KKyMgQ29tbW9uIG9wdGlvbnMKKyMtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK0lOQ0xVREUo T3B0aW9uc0NvbW1vbikKK1NFVChDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUlkgJHtDTUFL RV9CSU5BUllfRElSfS8ke0xJQl9JTlNUQUxMX0RJUn0pCitTRVQoQ01BS0VfTElCUkFSWV9PVVRQ VVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vJHtMSUJfSU5TVEFMTF9ESVJ9KQorU0VU KENNQUtFX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9LyR7RVhF Q19JTlNUQUxMX0RJUn0pCisKKyMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgUG9ydC1zcGVjaWZp YyBvcHRpb25zCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi1JTkNMVURFKE9wdGlvbnNDb21tb24p CiBJTkNMVURFKE9wdGlvbnMke1BPUlR9KQogCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCmRpZmYg LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWMzY2FkZDBhZTM0ODMzMDE1MGVh NzM4NzUwNmM5N2Q3ZWQ3YTI5Yy4uNzFkODVmNWU3MDRiZGMxMjgwNGNjMDU3ZTYwYTFjNTIxOTMw ZWIxMyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA5LTIzICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQ01ha2VdIENoYW5nZSBoYXJkY29kZWQgJ2xpYicgYW5kICdiaW4nIGluIENNYWtl TGlzdHMudHh0IHRvICdMSUJfSU5TVEFMTF9ESVInIGFuZCAnRVhFQ19JTlNUQUxMX0RJUicuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgdmFs dWUgb2YgTElCX0lOU1RBTExfRElSIGFuZCBFWEVDX0lOU1RBTExfRElSIGluc3RlYWQgb2YKKyAg ICAgICAgaGFyZGNvZGluZyAnbGliJyBhbmQgJ2JpbicgZm9yIENNQUtFX3tBUkNISVZFLExJQlJB UlksUlVOVElNRX1fT1VUUFVUX0RJUkVDVE9SWS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0 OgorICAgICAgICBVc2UgJHtMSUJfSU5TVEFMTF9ESVJ9IGluc3RlYWQgb2YgaGFyZGNvZGluZyAi bGliIi4KKyAgICAgICAgVXNlICR7RVhFQ19JTlNUQUxMX0RJUn0gaW5zdGVhZCBvZiBoYXJkY29k aW5nICJiaW4iLgorCiAyMDEyLTA5LTE4ICBTYWlsZXNoIEFncmF3YWwgIDxzYWlsQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBDaHJvbWl1bTogU2Nyb2xsYmFyIHdpdGggdGlja21hcmtzIGRvZXNu J3QgcmVzcG9uZCB0byBjbGlja3MK