97416 2012-09-23 17:08:00 -0700 PutScopedVar should not be marked as clobbering the world 2012-09-23 20:47:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren fpizlo oldest_to_newest 726318 0 ggaren 2012-09-23 17:08:00 -0700 PutScopedVar should not be marked as clobbering the world 726319 1 165297 ggaren 2012-09-23 17:08:36 -0700 Created attachment 165297 Patch 726320 2 165297 fpizlo 2012-09-23 17:14:07 -0700 Comment on attachment 165297 Patch I think you've already covered your bases, but before landing I would go through the cases in CSE one more time and make sure that nothing has slipped by. In your case, you're probably fine since we don't inline PutScopedVar, and we never have PutScopedVar on *this frame's* locals, and I don't think we do any CSE on resolve's. 726359 3 ggaren 2012-09-23 20:45:54 -0700 > we don't inline PutScopedVar Yeah. > and we never have PutScopedVar on *this frame's* locals Yup. (Or, when we do, we use get/put_scoped_var exclusively, and not local variable references.) > and I don't think we do any CSE on resolve's. Also true. 726360 4 165297 ggaren 2012-09-23 20:47:20 -0700 Comment on attachment 165297 Patch Clearing flags on attachment: 165297 Committed r129325: <http://trac.webkit.org/changeset/129325> 726361 5 ggaren 2012-09-23 20:47:22 -0700 All reviewed patches have been landed. Closing bug. 165297 2012-09-23 17:08:36 -0700 2012-09-23 20:47:20 -0700 Patch bug-97416-20120923170805.patch text/plain 1417 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5MzE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA5LTIzICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUHV0U2NvcGVkVmFyIHNob3VsZCBub3QgYmUgbWFya2VkIGFzIGNsb2JiZXJpbmcgdGhlIHdv cmxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzQx NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIHBl cmZvcm1hbmNlIGNoYW5nZS4KKworICAgICAgICBQdXRTY29wZWRWYXIgZG9lc24ndCBoYXZlIGFy Yml0cmFyeSBzaWRlLWVmZmVjdHMsIHNvIGl0IHNob3VsZG4ndCBiZSBtYXJrZWQKKyAgICAgICAg YXMgc3VjaC4KKworICAgICAgICAqIGRmZy9ERkdOb2RlVHlwZS5oOgorICAgICAgICAoREZHKToK KwogMjAxMi0wOS0yMyAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+ CiAKICAgICAgICAgU29ydGluZyBhIG5vbi1hcnJheSBjcmVhdGVzIHByb3ByZXRpZXMgKHNwZWMt dmlvbGF0aW9uKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlVHlwZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZVR5cGUuaAko cmV2aXNpb24gMTI5MzE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlVHlw ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsNyArMTQ3LDcgQEAgbmFtZXNwYWNlIEpTQyB7IG5h bWVzcGFjZSBERkcgewogICAgIG1hY3JvKEdldFNjb3BlLCBOb2RlUmVzdWx0SlMpIFwKICAgICBt YWNybyhHZXRTY29wZVJlZ2lzdGVycywgTm9kZVJlc3VsdFN0b3JhZ2UpIFwKICAgICBtYWNybyhH ZXRTY29wZWRWYXIsIE5vZGVSZXN1bHRKUykgXAotICAgIG1hY3JvKFB1dFNjb3BlZFZhciwgTm9k ZU11c3RHZW5lcmF0ZSB8IE5vZGVDbG9iYmVyc1dvcmxkKSBcCisgICAgbWFjcm8oUHV0U2NvcGVk VmFyLCBOb2RlTXVzdEdlbmVyYXRlKSBcCiAgICAgbWFjcm8oR2V0R2xvYmFsVmFyLCBOb2RlUmVz dWx0SlMpIFwKICAgICBtYWNybyhQdXRHbG9iYWxWYXIsIE5vZGVNdXN0R2VuZXJhdGUpIFwKICAg ICBtYWNybyhHbG9iYWxWYXJXYXRjaHBvaW50LCBOb2RlTXVzdEdlbmVyYXRlKSBcCg==