97399 2012-09-22 15:11:07 -0700 Allow setting a custom path to where the plug-in sandbox profiles are being kept 2012-09-22 15:18:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 726179 0 sam 2012-09-22 15:11:07 -0700 Allow setting a custom path to where the plug-in sandbox profiles are being kept 726180 1 165270 sam 2012-09-22 15:13:17 -0700 Created attachment 165270 Patch 726181 2 165270 andersca 2012-09-22 15:15:20 -0700 Comment on attachment 165270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165270&action=review > Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:56 > +NSString * const PlugInSandboxProfileDirectoryPathKey = @"PlugInSandboxProfileDirectoryPath"; I think the preference key should have a WebKit prefix. > Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:140 > + NSString* sandboxProfileDirectoryPath = [[NSUserDefaults standardUserDefaults] stringForKey:PlugInSandboxProfileDirectoryPathKey]; > + if (sandboxProfileDirectoryPath) > + parameters.sandboxProfileDirectoryPath = String(sandboxProfileDirectoryPath); Add a FIXME about disallowing this for app sandbox apps. 726182 3 sam 2012-09-22 15:18:12 -0700 Committed r129309: <http://trac.webkit.org/changeset/129309> 165270 2012-09-22 15:13:17 -0700 2012-09-22 15:15:19 -0700 Patch bug-97399-20120922151242.patch text/plain 6241 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTMwOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTIyICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWxsb3cgc2V0dGluZyBhIGN1c3RvbSBw YXRoIHRvIHdoZXJlIHRoZSBwbHVnLWluIHNhbmRib3ggcHJvZmlsZXMgYXJlIGJlaW5nIGtlcHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3Mzk5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3 IGRlZmF1bHQgdG8gYWxsb3cgY29udHJvbGxpbmcgd2hlcmUgdG8gbG9vayBmb3IgcGx1Zy1pbiBz YW5kYm94IHByb2ZpbGVzCisgICAgICAgIGNhbGxlZCAiUGx1Z0luU2FuZGJveFByb2ZpbGVEaXJl Y3RvcnlQYXRoIi4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NN YWMubW06CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemVTYW5kYm94KToKKyAgICAgICAgVXNl IHRoZSBwYXNzZWQgaW4gc2FuZGJveFByb2ZpbGVEaXJlY3RvcnlQYXRoIGluc3RlYWQgb2YgaGFy ZCBjb2RpbmcgL3Vzci9zaGFyZS9zYW5kYm94Ly4KKworICAgICAgICAoV2ViS2l0OjpQbHVnaW5Q cm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL1Bs dWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVn aW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNvZGUpOgorICAgICAgICAoV2ViS2l0OjpQ bHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUpOgorICAgICAgICAqIFNoYXJl ZC9QbHVnaW5zL1BsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaDoKKyAgICAgICAgKFBs dWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMpOgorICAgICAgICAqIFVJUHJvY2Vzcy9QbHVn aW5zL21hYy9QbHVnaW5Qcm9jZXNzUHJveHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6OlBsdWdp blByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2Vzcyk6CisgICAgICAg IEdyYWIgdGhlIHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aCBmcm9tIHN0YW5kYXJkVXNlckRl ZmF1bHRzIGFuZCBwYXNzIGl0IHRvCisgICAgICAgIHRoZSBwbHVnLWluLgorCiAyMDEyLTA5LTIx ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHRoZSBMaW9uIGFu ZCBTbm93IExlb3BhcmQgYnVpbGRzLgpJbmRleDogU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vz cy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9Q bHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCShyZXZpc2lvbiAxMjkyOTMpCisr KyBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yNjcsOCArMjY3LDExIEBAIHZvaWQgUGx1Z2luUHJvY2Vzczo6c2V0 RnVsbHNjcmVlbldpbmRvd0kKIH0KIAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTA3MAotc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVNhbmRib3goY29uc3QgU3RyaW5nJiBw bHVnaW5QYXRoKQorc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVNhbmRib3goY29uc3QgU3RyaW5nJiBw bHVnaW5QYXRoLCBjb25zdCBTdHJpbmcmIHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aCkKIHsK KyAgICBpZiAoc2FuZGJveFByb2ZpbGVEaXJlY3RvcnlQYXRoLmlzRW1wdHkoKSkKKyAgICAgICAg cmV0dXJuOworCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBjZlBsdWdpblBhdGggPSBhZG9w dENGKHBsdWdpblBhdGguY3JlYXRlQ0ZTdHJpbmcoKSk7CiAgICAgUmV0YWluUHRyPENGVVJMUmVm PiBwbHVnaW5VUkwgPSBhZG9wdENGKENGVVJMQ3JlYXRlV2l0aEZpbGVTeXN0ZW1QYXRoKDAsIGNm UGx1Z2luUGF0aC5nZXQoKSwga0NGVVJMUE9TSVhQYXRoU3R5bGUsIGZhbHNlKSk7CiAgICAgaWYg KCFwbHVnaW5VUkwpCkBAIC0yODIsOSArMjg1LDEyIEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVT YW5kYm94KGNvbnN0IFN0cmkKICAgICBpZiAoIWJ1bmRsZUlkZW50aWZpZXIpCiAgICAgICAgIHJl dHVybjsKIAorICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gY2ZTYW5kYm94UHJvZmlsZURpcmVj dG9yeVBhdGggPSBhZG9wdENGKHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aC5jcmVhdGVDRlN0 cmluZygpKTsKKyAgICBSZXRhaW5QdHI8Q0ZVUkxSZWY+IHNhbmRib3hQcm9maWxlRGlyZWN0b3J5 ID0gYWRvcHRDRihDRlVSTENyZWF0ZVdpdGhGaWxlU3lzdGVtUGF0aCgwLCBjZlNhbmRib3hQcm9m aWxlRGlyZWN0b3J5UGF0aC5nZXQoKSwga0NGVVJMUE9TSVhQYXRoU3R5bGUsIFRSVUUpKTsKKwog ICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gc2FuZGJveEZpbGVOYW1lID0gQ0ZTdHJpbmdDcmVh dGVXaXRoRm9ybWF0KDAsIDAsIENGU1RSKCIlQC5zYiIpLCBidW5kbGVJZGVudGlmaWVyKTsKLSAg ICBSZXRhaW5QdHI8Q0ZVUkxSZWY+IHBsdWdpblNhbmRib3hEaXJlY3RvcnkgPSBhZG9wdENGKENG VVJMQ3JlYXRlV2l0aEZpbGVTeXN0ZW1QYXRoKDAsIENGU1RSKCIvdXNyL3NoYXJlL3NhbmRib3gv IiksIGtDRlVSTFBPU0lYUGF0aFN0eWxlLCBZRVMpKTsKLSAgICBSZXRhaW5QdHI8Q0ZVUkxSZWY+ IHNhbmRib3hVUkwgPSBhZG9wdENGKENGVVJMQ3JlYXRlV2l0aEZpbGVTeXN0ZW1QYXRoUmVsYXRp dmVUb0Jhc2UoMCwgc2FuZGJveEZpbGVOYW1lLmdldCgpLCBrQ0ZVUkxQT1NJWFBhdGhTdHlsZSwg RkFMU0UsIHBsdWdpblNhbmRib3hEaXJlY3RvcnkuZ2V0KCkpKTsKKyAgICBSZXRhaW5QdHI8Q0ZV UkxSZWY+IHNhbmRib3hVUkwgPSBhZG9wdENGKENGVVJMQ3JlYXRlV2l0aEZpbGVTeXN0ZW1QYXRo UmVsYXRpdmVUb0Jhc2UoMCwgc2FuZGJveEZpbGVOYW1lLmdldCgpLCBrQ0ZVUkxQT1NJWFBhdGhT dHlsZSwgRkFMU0UsIHNhbmRib3hQcm9maWxlRGlyZWN0b3J5LmdldCgpKSk7CisKICAgICBSZXRh aW5QdHI8TlNTdHJpbmc+IHByb2ZpbGVTdHJpbmcgPSBbW05TU3RyaW5nIGFsbG9jXSBpbml0V2l0 aENvbnRlbnRzT2ZVUkw6KE5TVVJMICopc2FuZGJveFVSTC5nZXQoKSBlbmNvZGluZzpOU1VURjhT dHJpbmdFbmNvZGluZyBlcnJvcjpOVUxMXTsKICAgICBpZiAoIXByb2ZpbGVTdHJpbmcpCiAgICAg ICAgIHJldHVybjsKQEAgLTMwNiw3ICszMTIsNyBAQCB2b2lkIFBsdWdpblByb2Nlc3M6OnBsYXRm b3JtSW5pdGlhbGl6ZShjCiAgICAgV0tTZXRWaXNpYmxlQXBwbGljYXRpb25OYW1lKChDRlN0cmlu Z1JlZilhcHBsaWNhdGlvbk5hbWUpOwogCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDcwCi0gICAgaW5pdGlhbGl6ZVNhbmRib3gobV9wbHVnaW5QYXRoKTsKKyAgICBp bml0aWFsaXplU2FuZGJveChtX3BsdWdpblBhdGgsIHBhcmFtZXRlcnMuc2FuZGJveFByb2ZpbGVE aXJlY3RvcnlQYXRoKTsKICNlbmRpZgogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv UGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJh bWV0ZXJzLmNwcAkocmV2aXNpb24gMTI5MjkzKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1Bs dWdpbnMvUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ3LDYgKzQ3LDcgQEAgdm9pZCBQbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpl bgogI2lmIFBMQVRGT1JNKE1BQykKICAgICBlbmNvZGVyLT5lbmNvZGUocGFyZW50UHJvY2Vzc05h bWUpOwogICAgIGVuY29kZXItPmVuY29kZShhY2NlbGVyYXRlZENvbXBvc2l0aW5nUG9ydCk7Cisg ICAgZW5jb2Rlci0+ZW5jb2RlKHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aCk7CiAjZW5kaWYK IH0KIApAQCAtNjUsNiArNjYsOCBAQCBib29sIFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRl cnM6OmRlCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIWRlY29kZXItPmRlY29kZShy ZXN1bHQuYWNjZWxlcmF0ZWRDb21wb3NpdGluZ1BvcnQpKQogICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUocmVzdWx0LnNhbmRib3hQcm9maWxlRGlyZWN0b3J5 UGF0aCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogCiAgICAgcmV0dXJuIHRydWU7 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdp bnMvUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oCShyZXZpc2lvbiAxMjkyOTMpCisr KyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJh bWV0ZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDYgKzU2LDcgQEAgc3RydWN0IFBsdWdpblBy b2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMgewogI2lmIFBMQVRGT1JNKE1BQykKICAgICBTdHJpbmcg cGFyZW50UHJvY2Vzc05hbWU7CiAgICAgQ29yZUlQQzo6TWFjaFBvcnQgYWNjZWxlcmF0ZWRDb21w b3NpdGluZ1BvcnQ7CisgICAgU3RyaW5nIHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aDsKICNl bmRpZgogfTsKIApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvbWFjL1Bs dWdpblByb2Nlc3NQcm94eU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy9tYWMvUGx1Z2luUHJvY2Vzc1Byb3h5TWFjLm1tCShyZXZpc2lvbiAxMjky OTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9tYWMvUGx1Z2luUHJvY2Vz c1Byb3h5TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01Myw2ICs1Myw4IEBAIC0gKEJPT0wpX3dh bnRzVXNlckF0dGVudGlvbgogCiBAZW5kCiAKK05TU3RyaW5nICogY29uc3QgUGx1Z0luU2FuZGJv eFByb2ZpbGVEaXJlY3RvcnlQYXRoS2V5ID0gQCJQbHVnSW5TYW5kYm94UHJvZmlsZURpcmVjdG9y eVBhdGgiOworCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7 CkBAIC0xMzIsNiArMTM0LDEwIEBAIHZvaWQgUGx1Z2luUHJvY2Vzc1Byb3h5OjpwbGF0Zm9ybUlu aXRpYWwKICAgICBpZiAocmVuZGVyU2VydmVyUG9ydCAhPSBNQUNIX1BPUlRfTlVMTCkKICAgICAg ICAgcGFyYW1ldGVycy5hY2NlbGVyYXRlZENvbXBvc2l0aW5nUG9ydCA9IENvcmVJUEM6Ok1hY2hQ b3J0KHJlbmRlclNlcnZlclBvcnQsIE1BQ0hfTVNHX1RZUEVfQ09QWV9TRU5EKTsKICNlbmRpZgor CisgICAgTlNTdHJpbmcqIHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aCA9IFtbTlNVc2VyRGVm YXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIHN0cmluZ0ZvcktleTpQbHVnSW5TYW5kYm94UHJv ZmlsZURpcmVjdG9yeVBhdGhLZXldOworICAgIGlmIChzYW5kYm94UHJvZmlsZURpcmVjdG9yeVBh dGgpCisgICAgICAgIHBhcmFtZXRlcnMuc2FuZGJveFByb2ZpbGVEaXJlY3RvcnlQYXRoID0gU3Ry aW5nKHNhbmRib3hQcm9maWxlRGlyZWN0b3J5UGF0aCk7CiB9CiAKIGJvb2wgUGx1Z2luUHJvY2Vz c1Byb3h5OjpnZXRQbHVnaW5Qcm9jZXNzU2VyaWFsTnVtYmVyKFByb2Nlc3NTZXJpYWxOdW1iZXIm IHBsdWdpblByb2Nlc3NTZXJpYWxOdW1iZXIpCg==