97379 2012-09-21 16:29:58 -0700 Update SVGFontData for 8 bit TextRun changes 2022-02-27 23:32:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff dbates fmalita pdr schenney webkit.review.bot zimmermann oldest_to_newest 725954 0 msaboff 2012-09-21 16:29:58 -0700 Make SVGFontData aware of 8 bit changes to TextRun. 726385 1 165310 msaboff 2012-09-23 22:08:14 -0700 Created attachment 165310 Patch 727372 2 165310 sam 2012-09-25 00:54:18 -0700 Comment on attachment 165310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review > Source/WebCore/svg/SVGFontData.cpp:148 > remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length()); Is this line also 8 / 16 bit aware? 727736 3 msaboff 2012-09-25 09:43:28 -0700 (In reply to comment #2) > (From update of attachment 165310 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review > > > Source/WebCore/svg/SVGFontData.cpp:148 > > remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length()); > > Is this line also 8 / 16 bit aware? Yes, characters() up converts 8 bit data if necessary. 728236 4 165310 ggaren 2012-09-25 23:32:53 -0700 Comment on attachment 165310 Patch r=me 728723 5 msaboff 2012-09-26 10:43:42 -0700 Committed r129668: <http://trac.webkit.org/changeset/129668> 165310 2012-09-23 22:08:14 -0700 2022-02-27 23:32:42 -0800 Patch 97379.patch text/plain 2100 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTI3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIxICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBTVkdGb250RGF0 YSBmb3IgOCBiaXQgVGV4dFJ1biBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NzM3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEVkdWNhdGVkIGFwcGx5U1ZHR2x5cGhTZWxlY3Rpb24gdG8gYmUg OCAvIDE2IGJpdCBUZXh0UnVuIGF3YXJlLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jaXRv bmFsaXR5LCB0aGVyZWZvcmUgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogc3ZnL1NWR0ZvbnRE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0ZvbnREYXRhOjphcHBseVNWR0dseXBoU2Vs ZWN0aW9uKToKKwogMjAxMi0wOS0yMSAgQnJhbmRvbiBKb25lcyAgPGJham9uZXNAZ29vZ2xlLmNv bT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgT0VTX3ZlcnRleF9hcnJheV9vYmplY3QgaW4g Y2hyb21pdW0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGb250RGF0YS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnREYXRhLmNwcAkocmV2aXNpb24gMTI4 NzE0KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnREYXRhLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTM0LDggKzEzNCwxNiBAQCBib29sIFNWR0ZvbnREYXRhOjphcHBseVNWR0dseXBoU2Vs ZWN0aW9uCiAgICAgQVNTRVJUKGludChydW4uY2hhcmFjdGVyc0xlbmd0aCgpKSA+PSBjdXJyZW50 Q2hhcmFjdGVyKTsKIAogICAgIC8vIEFzc29jaWF0ZSB0ZXh0IHdpdGggYXJhYmljIGZvcm1zLCBp ZiBuZWVkZWQuCi0gICAgU3RyaW5nIHJlbWFpbmluZ1RleHRJblJ1bihydW4uZGF0YTE2KGN1cnJl bnRDaGFyYWN0ZXIpLCBydW4uY2hhcmFjdGVyc0xlbmd0aCgpIC0gY3VycmVudENoYXJhY3Rlcik7 Ci0gICAgcmVtYWluaW5nVGV4dEluUnVuID0gRm9udDo6bm9ybWFsaXplU3BhY2VzKHJlbWFpbmlu Z1RleHRJblJ1bi5jaGFyYWN0ZXJzKCksIHJlbWFpbmluZ1RleHRJblJ1bi5sZW5ndGgoKSk7Cisg ICAgU3RyaW5nIHJlbWFpbmluZ1RleHRJblJ1bjsKKworICAgIGlmIChydW4uaXM4Qml0KCkpIHsK KyAgICAgICAgcmVtYWluaW5nVGV4dEluUnVuID0gU3RyaW5nKHJ1bi5kYXRhOChjdXJyZW50Q2hh cmFjdGVyKSwgcnVuLmNoYXJhY3RlcnNMZW5ndGgoKSAtIGN1cnJlbnRDaGFyYWN0ZXIpOworICAg ICAgICByZW1haW5pbmdUZXh0SW5SdW4gPSBGb250Ojpub3JtYWxpemVTcGFjZXMocmVtYWluaW5n VGV4dEluUnVuLmNoYXJhY3RlcnM4KCksIHJlbWFpbmluZ1RleHRJblJ1bi5sZW5ndGgoKSk7Cisg ICAgfSBlbHNlIHsKKyAgICAgICAgcmVtYWluaW5nVGV4dEluUnVuID0gU3RyaW5nKHJ1bi5kYXRh MTYoY3VycmVudENoYXJhY3RlciksIHJ1bi5jaGFyYWN0ZXJzTGVuZ3RoKCkgLSBjdXJyZW50Q2hh cmFjdGVyKTsKKyAgICAgICAgcmVtYWluaW5nVGV4dEluUnVuID0gRm9udDo6bm9ybWFsaXplU3Bh Y2VzKHJlbWFpbmluZ1RleHRJblJ1bi5jaGFyYWN0ZXJzMTYoKSwgcmVtYWluaW5nVGV4dEluUnVu Lmxlbmd0aCgpKTsKKyAgICB9CisKICAgICBpZiAobWlycm9yKQogICAgICAgICByZW1haW5pbmdU ZXh0SW5SdW4gPSBjcmVhdGVTdHJpbmdXaXRoTWlycm9yZWRDaGFyYWN0ZXJzKHJlbWFpbmluZ1Rl eHRJblJ1bi5jaGFyYWN0ZXJzKCksIHJlbWFpbmluZ1RleHRJblJ1bi5sZW5ndGgoKSk7CiAgICAg aWYgKCFjdXJyZW50Q2hhcmFjdGVyICYmIGFyYWJpY0Zvcm1zLmlzRW1wdHkoKSkK