97377 2012-09-21 16:18:40 -0700 REGRESSION (r129176): Incorrect line breaking when kerning occurs between a space and the following character 2012-09-21 23:56:57 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Normal --- 97388 1 mitz webkit-unassigned eric webkit.review.bot oldest_to_newest 725943 0 mitz 2012-09-21 16:18:40 -0700 After <http://trac.webkit.org/r129176>, string measurements can be off when kerning is enabled and TextLayout is used. 725952 1 165223 mitz 2012-09-21 16:29:44 -0700 Created attachment 165223 Don’t use the trailingSpaceWidth mechanism when TextLayout is used 725980 2 165223 enrica 2012-09-21 16:55:00 -0700 Comment on attachment 165223 Don’t use the trailingSpaceWidth mechanism when TextLayout is used Looks good to me. 726014 3 mitz 2012-09-21 17:59:57 -0700 Fixed in <http://trac.webkit.org/r129284>. 165223 2012-09-21 16:29:44 -0700 2012-09-21 16:54:58 -0700 Don’t use the trailingSpaceWidth mechanism when TextLayout is used 97377_r1.diff text/plain 4756 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTI3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA5LTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyOTE3Nik6 IEluY29ycmVjdCBsaW5lIGJyZWFraW5nIHdoZW4ga2VybmluZyBvY2N1cnMgYmV0d2VlbiBhIHNw YWNlIGFuZCB0aGUgZm9sbG93aW5nIGNoYXJhY3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTczNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQva2VybmluZy13aXRoLVRleHRM YXlvdXQuaHRtbAorCisgICAgICAgIFdoZW4ga2VybmluZyBpcyBlbmFibGVkLCB0aGUgbGFzdCBj aGFyYWN0ZXIgaW4gYSB3b3JkIG1heSBoYXZlIGl0cyBhZHZhbmNlIHNob3J0ZW5lZCBiZWNhdXNl CisgICAgICAgIG9mIGl0cyB0cmFpbGluZyBzcGFjZS4gVG8gYWNjb3VudCBmb3IgdGhhdCwgd29y ZHMgYXJlIG1lYXN1cmVkIGFsb25nIHdpdGggdGhlIHRyYWlsaW5nIHNwYWNlLAorICAgICAgICB0 aGVuIHRoZSB3aWR0aCBvZiBhIHNwYWNlIGlzIHN1YnRyYWN0ZWQgZnJvbSB0aGUgcmVzdWx0LiBU aGlzIGRvZXNu4oCZdCB3b3JrIHdoZW4gdGhlIHRyYWlsaW5nCisgICAgICAgIHNwYWNlIGl0c2Vs ZiBoYXMgaXRzIGFkdmFuY2Ugc2hvcnRlbmVkIGR1ZSB0byB0aGUgY2hhcmFjdGVyIGZvbGxvd2lu ZyBpdCwgd2hpY2ggY2FuIGhhcHBlbgorICAgICAgICB3aGVuIHVzaW5nIHRoZSBUZXh0TGF5b3V0 IG9wdGltaXphdGlvbi4gSG93ZXZlciwgd2hlbiB0aGUgb3B0aW1pemF0aW9uIGlzIHVzZWQsIHRo ZSBhZHZhbmNlCisgICAgICAgIG9mIHRoZSBsYXN0IGNoYXJhY3RlciBvZiB0aGUgd29yZCBpcyBh bHJlYWR5IGFkanVzdGVkIGZvciB0aGUgdHJhaWxpbmcgc3BhY2UsIHNvIHRoZXJlIGlzIG5vCisg ICAgICAgIG5lZWQgdG8gbWVhc3VyZSB3aXRoIHRoYXQgc3BhY2UgYW5kIHN1YnRyYWN0IGl0cyBh ZHZhbmNlLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6TGluZUJyZWFrZXI6Om5leHRMaW5lQnJl YWspOiBDaGFuZ2VkIHRvIG5vdCB1c2UgdGhlIHRyYWlsaW5nU3BhY2VXaWR0aAorICAgICAgICBt ZWNoYW5pc20gd2hlbiBUZXh0TGF5b3V0IGlzIGJlaW5nIHVzZWQuCisKIDIwMTItMDktMjEgIEpl cmVteSBBcHRob3JwICA8amVyZW15YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2ggaW4g V2ViQ29yZTo6RG9jdW1lbnQ6OmZ1bGxTY3JlZW5DaGFuZ2VEZWxheVRpbWVyRmlyZWQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQu Y3BwCShyZXZpc2lvbiAxMjkyMzApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tMaW5lTGF5b3V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQxNCwxMCArMjQxNCw2IEBA IElubGluZUl0ZXJhdG9yIFJlbmRlckJsb2NrOjpMaW5lQnJlYWtlcjoKICAgICAgICAgICAgIGZs b2F0IHdvcmRTcGFjaW5nID0gY3VycmVudFN0eWxlLT53b3JkU3BhY2luZygpOwogICAgICAgICAg ICAgZmxvYXQgbGFzdFNwYWNlV29yZFNwYWNpbmcgPSAwOwogCi0gICAgICAgICAgICAvLyBOb24t emVybyBvbmx5IHdoZW4ga2VybmluZyBpcyBlbmFibGVkLCBpbiB3aGljaCBjYXNlIHdlIG1lYXN1 cmUgd29yZHMgd2l0aCB0aGVpciB0cmFpbGluZwotICAgICAgICAgICAgLy8gc3BhY2UsIHRoZW4g c3VidHJhY3QgaXRzIHdpZHRoLgotICAgICAgICAgICAgZmxvYXQgd29yZFRyYWlsaW5nU3BhY2VX aWR0aCA9IGYudHlwZXNldHRpbmdGZWF0dXJlcygpICYgS2VybmluZyA/IGYud2lkdGgoY29uc3Ry dWN0VGV4dFJ1bih0LCBmLCAmc3BhY2UsIDEsIHN0eWxlKSkgKyB3b3JkU3BhY2luZyA6IDA7Ci0K ICAgICAgICAgICAgIGZsb2F0IHdyYXBXID0gd2lkdGgudW5jb21taXR0ZWRXaWR0aCgpICsgaW5s aW5lTG9naWNhbFdpZHRoKGN1cnJlbnQubV9vYmosICFhcHBsaWVkU3RhcnRXaWR0aCwgdHJ1ZSk7 CiAgICAgICAgICAgICBmbG9hdCBjaGFyV2lkdGggPSAwOwogICAgICAgICAgICAgYm9vbCBicmVh a05CU1AgPSBhdXRvV3JhcCAmJiBjdXJyZW50U3R5bGUtPm5ic3BNb2RlKCkgPT0gU1BBQ0U7CkBA IC0yNDQ3LDYgKzI0NDMsMTAgQEAgSW5saW5lSXRlcmF0b3IgUmVuZGVyQmxvY2s6OkxpbmVCcmVh a2VyOgogCiAgICAgICAgICAgICBUZXh0TGF5b3V0KiB0ZXh0TGF5b3V0ID0gcmVuZGVyVGV4dElu Zm8ubV9sYXlvdXQuZ2V0KCk7CiAKKyAgICAgICAgICAgIC8vIE5vbi16ZXJvIG9ubHkgd2hlbiBr ZXJuaW5nIGlzIGVuYWJsZWQgYW5kIFRleHRMYXlvdXQgaXNuJ3QgdXNlZCwgaW4gd2hpY2ggY2Fz ZSB3ZSBtZWFzdXJlCisgICAgICAgICAgICAvLyB3b3JkcyB3aXRoIHRoZWlyIHRyYWlsaW5nIHNw YWNlLCB0aGVuIHN1YnRyYWN0IGl0cyB3aWR0aC4KKyAgICAgICAgICAgIGZsb2F0IHdvcmRUcmFp bGluZ1NwYWNlV2lkdGggPSAoZi50eXBlc2V0dGluZ0ZlYXR1cmVzKCkgJiBLZXJuaW5nKSAmJiAh dGV4dExheW91dCA/IGYud2lkdGgoY29uc3RydWN0VGV4dFJ1bih0LCBmLCAmc3BhY2UsIDEsIHN0 eWxlKSkgKyB3b3JkU3BhY2luZyA6IDA7CisKICAgICAgICAgICAgIGZvciAoOyBjdXJyZW50Lm1f cG9zIDwgdC0+dGV4dExlbmd0aCgpOyBjdXJyZW50LmZhc3RJbmNyZW1lbnRJblRleHROb2RlKCkp IHsKICAgICAgICAgICAgICAgICBib29sIHByZXZpb3VzQ2hhcmFjdGVySXNTcGFjZSA9IGN1cnJl bnRDaGFyYWN0ZXJJc1NwYWNlOwogICAgICAgICAgICAgICAgIGJvb2wgcHJldmlvdXNDaGFyYWN0 ZXJJc1dTID0gY3VycmVudENoYXJhY3RlcklzV1M7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjkyNzAp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAxMi0wOS0yMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIxMjkxNzYpOiBJbmNvcnJlY3QgbGluZSBicmVha2luZyB3aGVuIGtlcm5p bmcgb2NjdXJzIGJldHdlZW4gYSBzcGFjZSBhbmQgdGhlIGZvbGxvd2luZyBjaGFyYWN0ZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3Mzc3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQv a2VybmluZy13aXRoLVRleHRMYXlvdXQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICog ZmFzdC90ZXh0L2tlcm5pbmctd2l0aC1UZXh0TGF5b3V0Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTA5 LTIxICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFNr aXAgZmFzdC9kb20vR2VvbG9jYXRpb24vZGlzY29ubmVjdGVkLWZyYW1lLmh0bWwgdW50aWwgdGhl IGFzc2VydGlvbiBpcyBmaXhlZApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2tlcm5pbmct d2l0aC1UZXh0TGF5b3V0LWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L2tlcm5pbmctd2l0aC1UZXh0TGF5b3V0LWV4cGVjdGVkLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQva2VybmluZy13aXRoLVRleHRMYXlvdXQtZXhw ZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACis8ZGl2IHN0eWxlPSJ3aWR0 aDogODBweDsgYm9yZGVyOiBzb2xpZCBibHVlOyBmb250LXNpemU6IDU2cHg7IC13ZWJraXQtZm9u dC1rZXJuaW5nOiBub3JtYWw7Ij4KKy48YnI+VworPC9kaXY+CkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L3RleHQva2VybmluZy13aXRoLVRleHRMYXlvdXQuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L3RleHQva2VybmluZy13aXRoLVRleHRMYXlvdXQuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGV4dC9rZXJuaW5nLXdpdGgtVGV4dExheW91dC5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKKzxkaXYgc3R5bGU9IndpZHRoOiA4MHB4OyBi b3JkZXI6IHNvbGlkIGJsdWU7IGZvbnQtc2l6ZTogNTZweDsgLXdlYmtpdC1mb250LWtlcm5pbmc6 IG5vcm1hbDsiPgorLiAgVworPC9kaXY+Cg==