97369 2012-09-21 15:20:38 -0700 BiquadFilterNode must take audio-rate parameter changes into account 2012-11-16 13:06:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr ray webkit.review.bot oldest_to_newest 725876 0 crogers 2012-09-21 15:20:38 -0700 BiquadFilterNode must take audio-rate parameter changes into account 725879 1 165208 crogers 2012-09-21 15:24:59 -0700 Created attachment 165208 Patch 725905 2 165208 kbr 2012-09-21 15:50:40 -0700 Comment on attachment 165208 Patch Looks good to me assuming all of the logic underneath is working well. 725982 3 165208 webkit.review.bot 2012-09-21 16:58:00 -0700 Comment on attachment 165208 Patch Clearing flags on attachment: 165208 Committed r129277: <http://trac.webkit.org/changeset/129277> 725983 4 webkit.review.bot 2012-09-21 16:58:03 -0700 All reviewed patches have been landed. Closing bug. 769607 5 crogers 2012-11-16 13:06:42 -0800 *** Bug 102439 has been marked as a duplicate of this bug. *** 165208 2012-09-21 15:24:59 -0700 2012-09-21 16:58:00 -0700 Patch bug-97369-20120921152423.patch text/plain 5677 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRjZWZkMjg2NzkzNTAy YWU3MDczYmUyOThjZWNkZWU5YWNiZjBhOC4uMzczZDNlOWRlZmQ4YWNhOWZmYzU1MjIyODYyMjJh YTQ3YzQ3YTAxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIxICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgQmlxdWFkRmlsdGVyTm9k ZSBtdXN0IHRha2UgYXVkaW8tcmF0ZSBwYXJhbWV0ZXIgY2hhbmdlcyBpbnRvIGFjY291bnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MzY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmlxdWFkRmlsdGVy Tm9kZSBpcyBjdXJyZW50bHkgaWdub3JpbmcgYW55IHRpbWVsaW5lIG9yIGF1ZGlvLXJhdGUgY2hh bmdlcyB0byBpdHMgcGFyYW1ldGVycy4KKyAgICAgICAgV2Ugbm93IGNoZWNrIGlmIGFueSBvZiBp dHMgcGFyYW1ldGVycyBoYXZlIHRpbWVsaW5lIG9yIGF1ZGlvLXJhdGUgY2hhbmdlcyBhbmQsIGlm IHNvLCB0YWtlCisgICAgICAgIHRoZW0gaW50byBhY2NvdW50LiAgT3RoZXJ3aXNlLCB3ZSB1c2Ug b3JkaW5hcnkgcGFyYW1ldGVyIHNtb290aGluZy9kZS16aXBwZXJpbmcgd2hpY2ggaXMKKyAgICAg ICAgdGhlIGNhc2Ugd2hlbiB0aGUgcGFyYW1ldGVycyBhcmUgYWRqdXN0ZWQsIGZvciBleGFtcGxl LCBmcm9tIGEga25vYiBvciBzbGlkZXIgaW4gdGhlIFVJLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9CaXF1YWREU1BLZXJuZWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QmlxdWFkRFNQ S2VybmVsOjp1cGRhdGVDb2VmZmljaWVudHNJZk5lY2Vzc2FyeSk6CisgICAgICAgICogTW9kdWxl cy93ZWJhdWRpby9CaXF1YWRQcm9jZXNzb3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QmlxdWFk UHJvY2Vzc29yOjpjaGVja0ZvckRpcnR5Q29lZmZpY2llbnRzKToKKyAgICAgICAgKiBNb2R1bGVz L3dlYmF1ZGlvL0JpcXVhZFByb2Nlc3Nvci5oOgorICAgICAgICAoV2ViQ29yZTo6QmlxdWFkUHJv Y2Vzc29yOjpoYXNTYW1wbGVBY2N1cmF0ZVZhbHVlcyk6CisgICAgICAgIChCaXF1YWRQcm9jZXNz b3IpOgorCiAyMDEyLTA5LTIxICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIHJlbW92ZSBnZXRGb250RmFtaWx5Rm9yQ2hhcmFjdGVycyBm cm9tIFBsYXRmb3JtU3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9CaXF1YWREU1BLZXJuZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9CaXF1YWREU1BLZXJuZWwuY3BwCmluZGV4IGNmZWQxZGE0ZDBjZDU0YzIwZTI0ZTBhN2U1 YTU3ZjkwODAxODhiMGEuLmEwNjExZGNkNDVkY2Y1NjMxODRhMjgzOWNkNmM2ODc2OTIzODU4MWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQmlxdWFkRFNQS2Vy bmVsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0JpcXVhZERTUEtl cm5lbC5jcHAKQEAgLTQ3LDggKzQ3LDEyIEBAIHZvaWQgQmlxdWFkRFNQS2VybmVsOjp1cGRhdGVD b2VmZmljaWVudHNJZk5lY2Vzc2FyeShib29sIHVzZVNtb290aGluZywgYm9vbCBmb3JjCiAgICAg ICAgIGRvdWJsZSB2YWx1ZTE7CiAgICAgICAgIGRvdWJsZSB2YWx1ZTI7CiAgICAgICAgIGRvdWJs ZSBnYWluOwotICAgICAgICAKLSAgICAgICAgaWYgKHVzZVNtb290aGluZykgeworCisgICAgICAg IGlmIChiaXF1YWRQcm9jZXNzb3IoKS0+aGFzU2FtcGxlQWNjdXJhdGVWYWx1ZXMoKSkgeworICAg ICAgICAgICAgdmFsdWUxID0gYmlxdWFkUHJvY2Vzc29yKCktPnBhcmFtZXRlcjEoKS0+ZmluYWxW YWx1ZSgpOworICAgICAgICAgICAgdmFsdWUyID0gYmlxdWFkUHJvY2Vzc29yKCktPnBhcmFtZXRl cjIoKS0+ZmluYWxWYWx1ZSgpOworICAgICAgICAgICAgZ2FpbiA9IGJpcXVhZFByb2Nlc3Nvcigp LT5wYXJhbWV0ZXIzKCktPmZpbmFsVmFsdWUoKTsKKyAgICAgICAgfSBlbHNlIGlmICh1c2VTbW9v dGhpbmcpIHsKICAgICAgICAgICAgIHZhbHVlMSA9IGJpcXVhZFByb2Nlc3NvcigpLT5wYXJhbWV0 ZXIxKCktPnNtb290aGVkVmFsdWUoKTsKICAgICAgICAgICAgIHZhbHVlMiA9IGJpcXVhZFByb2Nl c3NvcigpLT5wYXJhbWV0ZXIyKCktPnNtb290aGVkVmFsdWUoKTsKICAgICAgICAgICAgIGdhaW4g PSBiaXF1YWRQcm9jZXNzb3IoKS0+cGFyYW1ldGVyMygpLT5zbW9vdGhlZFZhbHVlKCk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0JpcXVhZFByb2Nlc3Nvci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0JpcXVhZFByb2Nlc3Nvci5jcHAK aW5kZXggZTg2NzdkMjllMDIyZGIxZjExMjBhMTRkNzY5NzU0ZmRmNTdhMWYxMy4uM2FlMDI2MzZh YmZiZWUwYWYxZGNiMDdhZGMzZGM0MWZhZGFkMzU2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9CaXF1YWRQcm9jZXNzb3IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQmlxdWFkUHJvY2Vzc29yLmNwcApAQCAtNjgsMjEgKzY4LDI3 IEBAIHZvaWQgQmlxdWFkUHJvY2Vzc29yOjpjaGVja0ZvckRpcnR5Q29lZmZpY2llbnRzKCkKIAog ICAgIC8vIFRoZSBCaXF1YWREU1BLZXJuZWwgb2JqZWN0cyByZWx5IG9uIHRoaXMgdmFsdWUgdG8g c2VlIGlmIHRoZXkgbmVlZCB0byByZS1jb21wdXRlIHRoZWlyIGludGVybmFsIGZpbHRlciBjb2Vm ZmljaWVudHMuCiAgICAgbV9maWx0ZXJDb2VmZmljaWVudHNEaXJ0eSA9IGZhbHNlOworICAgIG1f aGFzU2FtcGxlQWNjdXJhdGVWYWx1ZXMgPSBmYWxzZTsKICAgICAKLSAgICBpZiAobV9oYXNKdXN0 UmVzZXQpIHsKLSAgICAgICAgLy8gU25hcCB0byBleGFjdCB2YWx1ZXMgZmlyc3QgdGltZSBhZnRl ciByZXNldCwgdGhlbiBzbW9vdGggZm9yIHN1YnNlcXVlbnQgY2hhbmdlcy4KLSAgICAgICAgbV9w YXJhbWV0ZXIxLT5yZXNldFNtb290aGVkVmFsdWUoKTsKLSAgICAgICAgbV9wYXJhbWV0ZXIyLT5y ZXNldFNtb290aGVkVmFsdWUoKTsKLSAgICAgICAgbV9wYXJhbWV0ZXIzLT5yZXNldFNtb290aGVk VmFsdWUoKTsKKyAgICBpZiAobV9wYXJhbWV0ZXIxLT5oYXNTYW1wbGVBY2N1cmF0ZVZhbHVlcygp IHx8IG1fcGFyYW1ldGVyMi0+aGFzU2FtcGxlQWNjdXJhdGVWYWx1ZXMoKSB8fCBtX3BhcmFtZXRl cjMtPmhhc1NhbXBsZUFjY3VyYXRlVmFsdWVzKCkpIHsKICAgICAgICAgbV9maWx0ZXJDb2VmZmlj aWVudHNEaXJ0eSA9IHRydWU7Ci0gICAgICAgIG1faGFzSnVzdFJlc2V0ID0gZmFsc2U7CisgICAg ICAgIG1faGFzU2FtcGxlQWNjdXJhdGVWYWx1ZXMgPSB0cnVlOwogICAgIH0gZWxzZSB7Ci0gICAg ICAgIC8vIFNtb290aCBhbGwgb2YgdGhlIGZpbHRlciBwYXJhbWV0ZXJzLiBJZiB0aGV5IGhhdmVu J3QgeWV0IGNvbnZlcmdlZCB0byB0aGVpciB0YXJnZXQgdmFsdWUgdGhlbiBtYXJrIGNvZWZmaWNp ZW50cyBhcyBkaXJ0eS4KLSAgICAgICAgYm9vbCBpc1N0YWJsZTEgPSBtX3BhcmFtZXRlcjEtPnNt b290aCgpOwotICAgICAgICBib29sIGlzU3RhYmxlMiA9IG1fcGFyYW1ldGVyMi0+c21vb3RoKCk7 Ci0gICAgICAgIGJvb2wgaXNTdGFibGUzID0gbV9wYXJhbWV0ZXIzLT5zbW9vdGgoKTsKLSAgICAg ICAgaWYgKCEoaXNTdGFibGUxICYmIGlzU3RhYmxlMiAmJiBpc1N0YWJsZTMpKQorICAgICAgICBp ZiAobV9oYXNKdXN0UmVzZXQpIHsKKyAgICAgICAgICAgIC8vIFNuYXAgdG8gZXhhY3QgdmFsdWVz IGZpcnN0IHRpbWUgYWZ0ZXIgcmVzZXQsIHRoZW4gc21vb3RoIGZvciBzdWJzZXF1ZW50IGNoYW5n ZXMuCisgICAgICAgICAgICBtX3BhcmFtZXRlcjEtPnJlc2V0U21vb3RoZWRWYWx1ZSgpOworICAg ICAgICAgICAgbV9wYXJhbWV0ZXIyLT5yZXNldFNtb290aGVkVmFsdWUoKTsKKyAgICAgICAgICAg IG1fcGFyYW1ldGVyMy0+cmVzZXRTbW9vdGhlZFZhbHVlKCk7CiAgICAgICAgICAgICBtX2ZpbHRl ckNvZWZmaWNpZW50c0RpcnR5ID0gdHJ1ZTsKKyAgICAgICAgICAgIG1faGFzSnVzdFJlc2V0ID0g ZmFsc2U7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvLyBTbW9vdGggYWxsIG9mIHRo ZSBmaWx0ZXIgcGFyYW1ldGVycy4gSWYgdGhleSBoYXZlbid0IHlldCBjb252ZXJnZWQgdG8gdGhl aXIgdGFyZ2V0IHZhbHVlIHRoZW4gbWFyayBjb2VmZmljaWVudHMgYXMgZGlydHkuCisgICAgICAg ICAgICBib29sIGlzU3RhYmxlMSA9IG1fcGFyYW1ldGVyMS0+c21vb3RoKCk7CisgICAgICAgICAg ICBib29sIGlzU3RhYmxlMiA9IG1fcGFyYW1ldGVyMi0+c21vb3RoKCk7CisgICAgICAgICAgICBi b29sIGlzU3RhYmxlMyA9IG1fcGFyYW1ldGVyMy0+c21vb3RoKCk7CisgICAgICAgICAgICBpZiAo IShpc1N0YWJsZTEgJiYgaXNTdGFibGUyICYmIGlzU3RhYmxlMykpCisgICAgICAgICAgICAgICAg bV9maWx0ZXJDb2VmZmljaWVudHNEaXJ0eSA9IHRydWU7CisgICAgICAgIH0KICAgICB9CiB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQmlxdWFkUHJvY2Vz c29yLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0JpcXVhZFByb2Nlc3Nvci5o CmluZGV4IDQwODI5NDQwMjkxZDkyZjRmZWE1ZWJmOGIzNzlkOGFlNGEyYzBiYTguLjljM2I5Njgy ZGRlMzE0Y2M2NzlhMGI0NjA2NjNmZDVkZGYyMTg0OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQmlxdWFkUHJvY2Vzc29yLmgKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9CaXF1YWRQcm9jZXNzb3IuaApAQCAtNjcsNiArNjcsNyBAQCBw dWJsaWM6CiAgICAgdm9pZCBjaGVja0ZvckRpcnR5Q29lZmZpY2llbnRzKCk7CiAgICAgCiAgICAg Ym9vbCBmaWx0ZXJDb2VmZmljaWVudHNEaXJ0eSgpIGNvbnN0IHsgcmV0dXJuIG1fZmlsdGVyQ29l ZmZpY2llbnRzRGlydHk7IH0KKyAgICBib29sIGhhc1NhbXBsZUFjY3VyYXRlVmFsdWVzKCkgY29u c3QgeyByZXR1cm4gbV9oYXNTYW1wbGVBY2N1cmF0ZVZhbHVlczsgfQogCiAgICAgQXVkaW9QYXJh bSogcGFyYW1ldGVyMSgpIHsgcmV0dXJuIG1fcGFyYW1ldGVyMS5nZXQoKTsgfQogICAgIEF1ZGlv UGFyYW0qIHBhcmFtZXRlcjIoKSB7IHJldHVybiBtX3BhcmFtZXRlcjIuZ2V0KCk7IH0KQEAgLTg0 LDYgKzg1LDkgQEAgcHJpdmF0ZToKIAogICAgIC8vIHNvIERTUCBrZXJuZWxzIGtub3cgd2hlbiB0 byByZS1jb21wdXRlIGNvZWZmaWNpZW50cwogICAgIGJvb2wgbV9maWx0ZXJDb2VmZmljaWVudHNE aXJ0eTsKKworICAgIC8vIFNldCB0byB0cnVlIGlmIGFueSBvZiB0aGUgZmlsdGVyIHBhcmFtZXRl cnMgYXJlIHNhbXBsZS1hY2N1cmF0ZS4KKyAgICBib29sIG1faGFzU2FtcGxlQWNjdXJhdGVWYWx1 ZXM7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==