97342 2012-09-21 08:48:46 -0700 [BlackBerry] Media player won't resize for the following source when first source fail to load 2012-09-21 09:31:45 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jonathan.dong.webkit jonathan.dong.webkit charles.wei eric.carlson feature-media-reviews mfeil mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 725542 0 jonathan.dong.webkit 2012-09-21 08:48:46 -0700 RIM PR: 211662 simplified test case: <html> <body> <video control> <source src="video-do-not-exist.mp4" /> <source src="video-valid.mp4" /> </video> </body> </html> the first source is an invalid url and the second is valid. This issue can also reproduce by test case media/video-size.html The root cause is if we failed to load the first source, we will accidentally set the video renderer's width and height attributes, which will prevent the second source's intrinsic size if it gets loaded successfully. 725545 1 165139 jonathan.dong.webkit 2012-09-21 08:52:32 -0700 Created attachment 165139 Patch 725547 2 165141 jonathan.dong.webkit 2012-09-21 08:55:23 -0700 Created attachment 165141 Patch 725570 3 165141 webkit.review.bot 2012-09-21 09:31:42 -0700 Comment on attachment 165141 Patch Clearing flags on attachment: 165141 Committed r129235: <http://trac.webkit.org/changeset/129235> 725571 4 webkit.review.bot 2012-09-21 09:31:45 -0700 All reviewed patches have been landed. Closing bug. 165139 2012-09-21 08:52:32 -0700 2012-09-21 08:55:11 -0700 Patch bug-97342-20120921235155.patch text/plain 2160 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTViNmJhYTc1NTAxYzgx MTJkN2RhNDEwNmZjNjdkNTk4NTg5ZTFiMy4uZWE2YmE2Mzk5NmU1YTAzZjE4ODhjYTY0Zjk1YWI2 OTgzNTVhNjZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTIxICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIE1lZGlhIHBsYXllciB3b24ndCByZXNpemUgZm9yIHRoZSBmb2xsb3dpbmcg c291cmNlIHdoZW4gZmlyc3Qgc291cmNlIGZhaWwgdG8gbG9hZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTczNDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBwbGF0Zm9ybVBsYXllciB3aWxsIG5vdGlm eSBNZWRpYVBsYXllclByaXZhdGUgZm9yIHNpemUgY2hhbmdlCisgICAgICAgIHdoZW4gbG9hZGlu ZyBtZXRhZGF0YSBmYWlsZWQgKGluIHRoaXMgY2FzZSBoYXNWaWRlbygpIGlzIGZhbHNlKSwKKyAg ICAgICAgd2Ugc2hvdWxkIHByZXZlbnQgTWVkaWFQbGF5ZXJQcml2YXRlIHRvIHNldCB3aWR0aCBh bmQgaGVpZ2h0CisgICAgICAgIGF0dHJpYnV0ZSBvZiBtZWRpYSBlbGVtZW50LCBvdGhlcndpc2Ug d2Ugd29uJ3QgZ2V0IHRoZSBjb3JyZWN0CisgICAgICAgIGRpbWVuc2lvbiBmb3IgdGhlIGZvbGxv d2luZyBtZWRpYSBzb3VyY2UuIChpZiB0aGUgdmlkZW8gdGFnIGhhcworICAgICAgICBtb3JlIHRo YW4gb25lIHNvdXJjZSB0YWdzKQorCisgICAgICAgIFRlc3QgY2FzZTogbWVkaWEvdmlkZW8tc2l6 ZS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxh eWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlOjpyZXNpemVTb3VyY2VEaW1lbnNpb25zKToKKwogMjAxMi0wOS0xOSAgVGVycnkgQW5k ZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFN0 b3JlIHRoZSBjb250ZW50cyBzY2FsZSBmYWN0b3IgaW4gUGxhdGZvcm1Db250ZXh0U2tpYSBvbiBp bml0aWFsaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxh Y2tCZXJyeS5jcHAKaW5kZXggYjRlNWNlMzNjZGM1ZDJhNDAyYjFiMGZmZDEyY2VmMmFmNDJmMzNi Yi4uYzgyN2VkN2Y4MThhNmY1NjQzYTcxMzFjNDY1ZTdmN2VkYWY1OWQxOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclBy aXZhdGVCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCkBAIC00MDAsNyAr NDAwLDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnJlc2l6ZVNvdXJjZURpbWVuc2lvbnMo KQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBJZiB3ZSBoYXZlIGFuIEhUTUxWaWRlb0VsZW1l bnQgYnV0IHRoZSBzb3VyY2UgaGFzIG5vIHZpZGVvLCB0aGVuIHdlIG5lZWQgdG8gcmVzaXplIHRo ZSBtZWRpYSBlbGVtZW50LgotICAgIGlmICghaGFzVmlkZW8oKSkgeworICAgIGlmICghaGFzVmlk ZW8oKSAmJiBQbGF0Zm9ybVBsYXllcjo6TWVkaWFPSyA9PSBtX3BsYXRmb3JtUGxheWVyLT5lcnJv cigpKSB7CiAgICAgICAgIExheW91dFJlY3QgcmVjdCA9IG1fd2ViQ29yZVBsYXllci0+bWVkaWFQ bGF5ZXJDbGllbnQoKS0+bWVkaWFQbGF5ZXJDb250ZW50Qm94UmVjdCgpOwogCiAgICAgICAgIHN0 YXRpYyBjb25zdCBpbnQgcGxheWJvb2tNaW5BdWRpb0VsZW1lbnRXaWR0aCA9IDMwMDsK 165141 2012-09-21 08:55:23 -0700 2012-09-21 09:31:42 -0700 Patch bug-97342-20120921235446.patch text/plain 2147 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTViNmJhYTc1NTAxYzgx MTJkN2RhNDEwNmZjNjdkNTk4NTg5ZTFiMy4uMWRkYjZmMDE2NWNmY2IwZGQ4OGIzMmJiMjI5YWVj M2FkNjg4Y2U5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIxICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIE1lZGlhIHBsYXllciB3b24ndCByZXNpemUgZm9yIHRoZSBmb2xsb3dpbmcg c291cmNlIHdoZW4gZmlyc3Qgc291cmNlIGZhaWwgdG8gbG9hZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTczNDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBwbGF0Zm9ybVBsYXllciB3aWxsIG5vdGlm eSBNZWRpYVBsYXllclByaXZhdGUgZm9yIHNpemUgY2hhbmdlCisgICAgICAgIHdoZW4gbG9hZGlu ZyBtZXRhZGF0YSBmYWlsZWQgKGluIHRoaXMgY2FzZSBoYXNWaWRlbygpIGlzIGZhbHNlKSwKKyAg ICAgICAgd2Ugc2hvdWxkIHByZXZlbnQgTWVkaWFQbGF5ZXJQcml2YXRlIHRvIHNldCB3aWR0aCBh bmQgaGVpZ2h0CisgICAgICAgIGF0dHJpYnV0ZSBvZiBtZWRpYSBlbGVtZW50LCBvdGhlcndpc2Ug d2Ugd29uJ3QgZ2V0IHRoZSBjb3JyZWN0CisgICAgICAgIGRpbWVuc2lvbiBmb3IgdGhlIGZvbGxv d2luZyBtZWRpYSBzb3VyY2VzLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWF4 IEZlaWwuCisKKyAgICAgICAgVGVzdCBjYXNlOiBtZWRpYS92aWRlby1zaXplLmh0bWwKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxh Y2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OnJlc2l6 ZVNvdXJjZURpbWVuc2lvbnMpOgorCiAyMDEyLTA5LTE5ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5k ZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gU3RvcmUgdGhlIGNvbnRl bnRzIHNjYWxlIGZhY3RvciBpbiBQbGF0Zm9ybUNvbnRleHRTa2lhIG9uIGluaXRpYWxpemF0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcApp bmRleCBiNGU1Y2UzM2NkYzVkMmE0MDJiMWIwZmZkMTJjZWYyYWY0MmYzM2JiLi5jODI3ZWQ3Zjgx OGE2ZjU2NDNhNzEzMWM0NjVlN2Y3ZWRhZjU5ZDE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVy cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv TWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKQEAgLTQwMCw3ICs0MDAsNyBAQCB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZTo6cmVzaXplU291cmNlRGltZW5zaW9ucygpCiAgICAgICAgIHJl dHVybjsKIAogICAgIC8vIElmIHdlIGhhdmUgYW4gSFRNTFZpZGVvRWxlbWVudCBidXQgdGhlIHNv dXJjZSBoYXMgbm8gdmlkZW8sIHRoZW4gd2UgbmVlZCB0byByZXNpemUgdGhlIG1lZGlhIGVsZW1l bnQuCi0gICAgaWYgKCFoYXNWaWRlbygpKSB7CisgICAgaWYgKCFoYXNWaWRlbygpICYmIFBsYXRm b3JtUGxheWVyOjpNZWRpYU9LID09IG1fcGxhdGZvcm1QbGF5ZXItPmVycm9yKCkpIHsKICAgICAg ICAgTGF5b3V0UmVjdCByZWN0ID0gbV93ZWJDb3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgp LT5tZWRpYVBsYXllckNvbnRlbnRCb3hSZWN0KCk7CiAKICAgICAgICAgc3RhdGljIGNvbnN0IGlu dCBwbGF5Ym9va01pbkF1ZGlvRWxlbWVudFdpZHRoID0gMzAwOwo=