97329 2012-09-21 05:05:53 -0700 [WTR] Memory leaks in InjectedBundleController::initialize() 2012-09-21 09:13:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis andersca webkit.review.bot oldest_to_newest 725427 0 naginenis 2012-09-21 05:05:53 -0700 Noticed the following leaks while running the webkit2 api tests. ==26661== 72 (24 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 4,528 of 6,028 ==26661== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26661== by 0x902468A: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==26661== by 0x52EAFEA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==26661== by 0x533673D: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==26661== by 0x533633D: WKStringCreateWithUTF8CString (WKString.cpp:41) ==26661== by 0x188405D1: TestWebKitAPI::InjectedBundleController::initialize(OpaqueWKBundle const*, void const*) (InjectedBundleController.cpp:73) ==26661== by 0x18841C4B: WKBundleInitialize (InjectedBundleMain.cpp:37) ==26661== by 0x54C63E2: WebKit::InjectedBundle::load(WebKit::APIObject*) (InjectedBundleEfl.cpp:57) ==26661== 72 (24 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 4,529 of 6,028 ==26661== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26661== by 0x902468A: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==26661== by 0x52EAFEA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==26661== by 0x533673D: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==26661== by 0x533633D: WKStringCreateWithUTF8CString (WKString.cpp:41) ==26661== by 0x188405F3: TestWebKitAPI::InjectedBundleController::initialize(OpaqueWKBundle const*, void const*) (InjectedBundleController.cpp:75) ==26661== by 0x18841C4B: WKBundleInitialize (InjectedBundleMain.cpp:37) ==26661== by 0x54C63E2: WebKit::InjectedBundle::load(WebKit::APIObject*) (InjectedBundleEfl.cpp:57) 725432 1 165119 naginenis 2012-09-21 05:17:09 -0700 Created attachment 165119 Patch 725562 2 165119 webkit.review.bot 2012-09-21 09:13:38 -0700 Comment on attachment 165119 Patch Clearing flags on attachment: 165119 Committed r129232: <http://trac.webkit.org/changeset/129232> 725563 3 webkit.review.bot 2012-09-21 09:13:41 -0700 All reviewed patches have been landed. Closing bug. 165119 2012-09-21 05:17:09 -0700 2012-09-21 09:13:38 -0700 Patch 97329.patch text/plain 2051 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlZjY5 YzE1Li5mMmFjZjhkYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTIxICBTdWRhcnNhbmEgTmFnaW5lbmkg IDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29tPgorCisgICAgICAgIFtXVFJdIE1lbW9yeSBs ZWFrcyBpbiBJbmplY3RlZEJ1bmRsZUNvbnRyb2xsZXI6OmluaXRpYWxpemUoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTczMjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbGVha3MgaW4gSW5qZWN0 ZWRCdW5kbGVDb250cm9sbGVyOjppbml0aWFsaXplKCkgYnkgYWRvcHRpbmcKKyAgICAgICAgc3Ry aW5ncyBjcmVhdGVkIHdpdGggV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvSW5qZWN0ZWRCdW5kbGVDb250cm9sbGVyLmNwcDoKKyAgICAg ICAgKFRlc3RXZWJLaXRBUEk6OkluamVjdGVkQnVuZGxlQ29udHJvbGxlcjo6aW5pdGlhbGl6ZSk6 CisKIDIwMTItMDktMjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgQ29tbWVudCBvdXQgYSBmYWlsaW5nIHdlYmtpdHB5IHVuaXQgdGVzdCB1bnRpbCBE aXJrIGNhbiBmaXggaXQuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL0luamVjdGVk QnVuZGxlQ29udHJvbGxlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0luamVjdGVkQnVuZGxl Q29udHJvbGxlci5jcHAKaW5kZXggNTM3MTA0Zi4uZmI3ODAxMyAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9JbmplY3RlZEJ1bmRsZUNvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvSW5qZWN0ZWRCdW5kbGVDb250cm9sbGVyLmNwcApAQCAtNzAsOSArNzAsMTEg QEAgdm9pZCBJbmplY3RlZEJ1bmRsZUNvbnRyb2xsZXI6OmluaXRpYWxpemUoV0tCdW5kbGVSZWYg YnVuZGxlLCBXS1R5cGVSZWYgaW5pdGlhbGkKICAgICBhc3NlcnQoV0tHZXRUeXBlSUQoaW5pdGlh bGl6YXRpb25Vc2VyRGF0YSkgPT0gV0tEaWN0aW9uYXJ5R2V0VHlwZUlEKCkpOwogICAgIFdLRGlj dGlvbmFyeVJlZiBpbml0aWFsaXphdGlvbkRpY3Rpb25hcnkgPSBzdGF0aWNfY2FzdDxXS0RpY3Rp b25hcnlSZWY+KGluaXRpYWxpemF0aW9uVXNlckRhdGEpOwogCi0gICAgV0tTdHJpbmdSZWYgdGVz dE5hbWUgPSBzdGF0aWNfY2FzdDxXS1N0cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktl eShpbml0aWFsaXphdGlvbkRpY3Rpb25hcnksIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KCJUZXN0TmFtZSIpKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHRlc3ROYW1lS2V5 KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJUZXN0TmFtZSIpKTsKKyAg ICBXS1N0cmluZ1JlZiB0ZXN0TmFtZSA9IHN0YXRpY19jYXN0PFdLU3RyaW5nUmVmPihXS0RpY3Rp b25hcnlHZXRJdGVtRm9yS2V5KGluaXRpYWxpemF0aW9uRGljdGlvbmFyeSwgdGVzdE5hbWVLZXku Z2V0KCkpKTsKIAotICAgIFdLVHlwZVJlZiB1c2VyRGF0YSA9IFdLRGljdGlvbmFyeUdldEl0ZW1G b3JLZXkoaW5pdGlhbGl6YXRpb25EaWN0aW9uYXJ5LCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0 cmluZygiVXNlckRhdGEiKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHVzZXJEYXRh S2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJVc2VyRGF0YSIpKTsK KyAgICBXS1R5cGVSZWYgdXNlckRhdGEgPSBXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGluaXRp YWxpemF0aW9uRGljdGlvbmFyeSwgdXNlckRhdGFLZXkuZ2V0KCkpOwogICAgIGluaXRpYWxpemVU ZXN0TmFtZWQoYnVuZGxlLCBVdGlsOjp0b1NURCh0ZXN0TmFtZSksIHVzZXJEYXRhKTsKIH0KIAo=