97313 2012-09-21 02:37:18 -0700 [BlackBerry] Wrong seperator for viewport meta in Popup scripts 2012-09-21 07:59:31 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei charles.wei mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 725315 0 charles.wei 2012-09-21 02:37:18 -0700 The valid seperator for viewport meta is ',' instead of ';'. We are using the wrong seperator in PopupDialogBlackBerry.cpp 725342 1 165101 charles.wei 2012-09-21 03:01:37 -0700 Created attachment 165101 Patch 725492 2 165101 yong.li.webkit 2012-09-21 07:09:06 -0700 Comment on attachment 165101 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165101&action=review > Source/WebKit/blackberry/ChangeLog:3 > + Wrong seperator for viewport meta in Popup scripts [BlackBerry] should be put there as other changes. it seems minor as the changelog is in webkit/blackberry anyway. 725509 3 165101 charles.wei 2012-09-21 07:50:54 -0700 Comment on attachment 165101 Patch Commit 725515 4 165101 webkit.review.bot 2012-09-21 07:59:28 -0700 Comment on attachment 165101 Patch Clearing flags on attachment: 165101 Committed r129228: <http://trac.webkit.org/changeset/129228> 725516 5 webkit.review.bot 2012-09-21 07:59:31 -0700 All reviewed patches have been landed. Closing bug. 165101 2012-09-21 03:01:37 -0700 2012-09-21 07:59:28 -0700 Patch bug-97313-20120921180100.patch text/plain 1820 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA2M2JjMTgyNzYxOTM0MTM2NDk1OTA0ODhiNjcwN2Q0NTYzZTA3MjgyLi42YmY0ZDE5MGYz ZDcxMTYyZTdiNzc2OGM2NjA1NGI2YjFmODkxMjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0yMSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgV3Jvbmcgc2VwZXJhdG9yIGZvciB2 aWV3cG9ydCBtZXRhIGluIFBvcHVwIHNjcmlwdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIHZhbGlkIHNlcGVyYXRvciBmb3Igdmlld3BvcnQgbWV0 YSBpcyAnLCcgaW5zdGVhZCBvZiAnOycuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QYWdl UG9wdXBCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VQb3B1cEJsYWNrQmVy cnk6OmdlbmVyYXRlSFRNTCk6CisKIDIwMTItMDktMjAgIFBldGVyIFdhbmcgIDxwZXRlci53YW5n QHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVG8gc3VwcG9ydCAi RnJhbWVzIFZpZXciIG9mICJUaW1lTGluZSIgcGFuZWwgIGluIEluc3BlY3RvcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNr QmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQ b3B1cEJsYWNrQmVycnkuY3BwCmluZGV4IDk4NGEyMWI5ODIxM2MyODliZmQ5YjViYzlmYTMzZTk2 OTM5OTdjZTcuLjc5OTEyOTFjZWVhNjkzYWRmMzQ5ZjU0NjI4MWQyZGRjOWNmZjg4YjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBC bGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBv cnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgdm9pZCBQYWdlUG9w dXBCbGFja0JlcnJ5OjpnZW5lcmF0ZUhUTUwoV2ViUGFnZSogd2VicGFnZSkKICAgICBpbnQgc2Ny ZWVuV2lkdGggPSB3ZWJwYWdlLT5kLT5zY3JlZW5TaXplKCkud2lkdGgoKSAtIFBBRERJTkc7CiAg ICAgc291cmNlLmFwcGVuZExpdGVyYWwoIjxodG1sPjxoZWFkPjxtZXRhIGh0dHAtZXF1aXY9XCJD b250ZW50LVR5cGVcIiBjb250ZW50PVwidGV4dC9odG1sOyBjaGFyc2V0PVVURi04XCIvPlxuIik7 CiAgICAgc291cmNlLmFwcGVuZCgiPG1ldGEgbmFtZT1cInZpZXdwb3J0XCIgY29udGVudD1cIndp ZHRoPSIgKyBTdHJpbmc6Om51bWJlcihzY3JlZW5XaWR0aCkpOwotICAgIHNvdXJjZS5hcHBlbmRM aXRlcmFsKCI7IHVzZXItc2NhbGFibGU9bm9cIiAvPlxuIik7CisgICAgc291cmNlLmFwcGVuZExp dGVyYWwoIiwgdXNlci1zY2FsYWJsZT1ub1wiIC8+XG4iKTsKICAgICB3cml0ZXItPmFkZERhdGEo c291cmNlLnRvU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgc291cmNlLnRvU3RyaW5nKCkudXRmOCgp Lmxlbmd0aCgpKTsKIAogICAgIG1fY2xpZW50LT53cml0ZURvY3VtZW50KCp3cml0ZXIpOwo=