97308 2012-09-21 01:25:19 -0700 Build is broken with GLib Unicode backend 2012-09-22 04:32:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 thierry.reding webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 725261 0 thierry.reding 2012-09-21 01:25:19 -0700 The TextBreakIteratorGtk implementation uses ubrk_close() to delete the iterator. However that function is ICU specific and not declared when using the GLib backend. A patch for this has been proposed here: http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210 I'll follow up with a patch with the proper ChangeLog updates. 725268 1 165078 thierry.reding 2012-09-21 01:35:32 -0700 Created attachment 165078 Patch 725598 2 165078 cgarcia 2012-09-21 10:03:24 -0700 Comment on attachment 165078 Patch Thanks! 726116 3 thierry.reding 2012-09-22 04:13:43 -0700 (In reply to comment #2) > (From update of attachment 165078 [details]) > Thanks! Great. I'm unfamiliar with the procedure and what to do next. Do I repost the patch marking it reviewed by you? Or will somebody with commit access take care of it? 726123 4 165078 webkit.review.bot 2012-09-22 04:32:09 -0700 Comment on attachment 165078 Patch Clearing flags on attachment: 165078 Committed r129305: <http://trac.webkit.org/changeset/129305> 726124 5 webkit.review.bot 2012-09-22 04:32:12 -0700 All reviewed patches have been landed. Closing bug. 165078 2012-09-21 01:35:32 -0700 2012-09-22 04:32:09 -0700 Patch bug-97308-20120921103456.patch text/plain 2073 thierry.reding U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjhiYjNjOGVkMzIyYTg1 MjQwZTJkMWUzYjY2NTkwYzM4N2YzMTM0Mi4uNTQ4YTg1MWE3ODZiMTcxZGNhYmJmM2YzMDIxNTY2 ZDc3N2ExMWRhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA5LTIxICBUaGll cnJ5IFJlZGluZyAgPHRoaWVycnkucmVkaW5nQGF2aW9uaWMtZGVzaWduLmRlPgorCisgICAgICAg IFtHVEtdIEJ1aWxkIGlzIGJyb2tlbiB3aXRoIEdMaWIgVW5pY29kZSBiYWNrZW5kCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzMwOC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgVGV4dEJyZWFrSXRl cmF0b3JHdGsgaW1wbGVtZW50YXRpb24gdXNlcyB1YnJrX2Nsb3NlKCkgdG8gZGVsZXRlCisgICAg ICAgIHRoZSBpdGVyYXRvci4gSG93ZXZlciB0aGF0IGZ1bmN0aW9uIGlzIElDVSBzcGVjaWZpYyBh bmQgbm90IGRlY2xhcmVkCisgICAgICAgIHdoZW4gdXNpbmcgdGhlIEdMaWIgYmFja2VuZC4gSW5z dGVhZCB0aGUgaXRlcmF0b3IgY2FuIHNpbXBseSBiZSBmcmVlZAorICAgICAgICB1c2luZyB0aGUg ZGVsZXRlIG9wZXJhdG9yLgorCisgICAgICAgIFRoaXMgY29tbWl0IGlzIGJhc2VkIG9uIHdvcmsg YnkgTWFydGluIFNjaGxlbW1lciB3aG8gcG9zdGVkIGEgZml4IGZvcgorICAgICAgICB0aGlzIGhl cmU6CisKKyAgICAgICAgICAgIGh0dHA6Ly9wZXJtYWxpbmsuZ21hbmUub3JnL2dtYW5lLm9zLm9w ZW5kYXJ3aW4ud2Via2l0Lmd0ay8xMjEwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJyZWFrSXRlcmF0b3JHdGsuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Tm9uU2hhcmVkQ2hhcmFjdGVyQnJlYWtJdGVyYXRvcjo6fk5vblNoYXJlZENo YXJhY3RlckJyZWFrSXRlcmF0b3IpOgorICAgICAgICBGcmVlIGl0ZXJhdG9yIHVzaW5nIGRlbGV0 ZSBpbnN0ZWFkIG9mIHVicmtfY2xvc2UoKS4KKwogMjAxMi0wOS0yMSAgS2Vpc2hpIEhhdHRvcmkg IDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBQcmVwYXJlIENhbGVuZGFyUGlja2VyIHNv IHdlIGNhbiBhZGQgYW5vdGhlciBwaWNrZXIsIFN1Z2dldGlvblBpY2tlcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJyZWFrSXRlcmF0b3JHdGsuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJyZWFrSXRlcmF0b3JHdGsu Y3BwCmluZGV4IDczM2Q3NTk4MmIwYzliYzAxYTc2MTliMmFiODdiMWE4NGRlYWVlZmYuLmIzMzI1 NWRhNWVmNmYxMWNhOTgzOGJmMjcyMWQ1NDdhMjhlODgxODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRCcmVha0l0ZXJhdG9yR3RrLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2d0ay9UZXh0QnJlYWtJdGVyYXRvckd0ay5jcHAK QEAgLTIzMyw3ICsyMzMsNyBAQCBOb25TaGFyZWRDaGFyYWN0ZXJCcmVha0l0ZXJhdG9yOjpOb25T aGFyZWRDaGFyYWN0ZXJCcmVha0l0ZXJhdG9yKGNvbnN0IFVDaGFyKiBidQogTm9uU2hhcmVkQ2hh cmFjdGVyQnJlYWtJdGVyYXRvcjo6fk5vblNoYXJlZENoYXJhY3RlckJyZWFrSXRlcmF0b3IoKQog ewogICAgIGlmICghd2Vha0NvbXBhcmVBbmRTd2FwKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigm bm9uU2hhcmVkQ2hhcmFjdGVyQnJlYWtJdGVyYXRvciksIDAsIG1faXRlcmF0b3IpKQotICAgICAg ICB1YnJrX2Nsb3NlKG1faXRlcmF0b3IpOworICAgICAgICBkZWxldGUgbV9pdGVyYXRvcjsKIH0K IAogVGV4dEJyZWFrSXRlcmF0b3IqIGN1cnNvck1vdmVtZW50SXRlcmF0b3IoY29uc3QgVUNoYXIq IHN0cmluZywgaW50IGxlbmd0aCkK