97287 2012-09-20 20:47:26 -0700 [mac] WKTR should use tiled drawing/threaded scrolling on Mountain Lion 2013-05-03 04:47:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 98065 98077 98064 98074 1 thorton webkit-unassigned andersca bdakin mitz simon.fraser oldest_to_newest 725114 0 thorton 2012-09-20 20:47:26 -0700 It'd be nice if we could run the tests with a TiledCoreAnimationDrawingArea and scrolling thread, etc. It'd be really nice if we could swap into and out of tiled drawing via internals, but running all the tests that way would be a start. This patch will just add support to WKTR, but no way to use it yet. 725119 1 thorton 2012-09-20 20:59:07 -0700 On second thought, there are no other features enabled by WKTR command line flags, so maybe we should just do the right thing and support it via internals? I don't know how much work it is to get swapping-out-the-drawing-area working again. Anders? 725175 2 165055 thorton 2012-09-20 23:04:26 -0700 Created attachment 165055 wktr switch Attaching a patch to add a --use-tiled-drawing switch to WKTR. I don't think this is the approach we want to take, but it's probably easier than the alternative. 725686 3 thorton 2012-09-21 12:05:29 -0700 Related to <rdar://problem/11778900> 727903 4 165658 thorton 2012-09-25 13:20:30 -0700 Created attachment 165658 patch to enable tiled drawing on ML Attaching a patch to turn on tiled drawing in WKTR on ML. Will wait to land until I see what effect it has on layout test results. 165055 2012-09-20 23:04:26 -0700 2012-09-25 13:20:30 -0700 wktr switch tiled-wktr.diff text/plain 4320 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NDU3 NzczLi40ZWMwZjliIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTItMDktMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gV0tUUiBzaG91bGQgc3VwcG9ydCBh IHRpbGVkIGRyYXdpbmcvdGhyZWFkZWQgc2Nyb2xsaW5nIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3Mjg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgdG8gV0tUUiBmb3IgdGls ZWQgZHJhd2luZyAodXNlIG9mIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhKSBvbiBNYWMu CisgICAgICAgIFRoaXMgZmVhdHVyZSBjYW4gYmUgZW5hYmxlZCBieSBwYXNzaW5nIC0tdXNlLXRp bGVkLWRyYXdpbmcgdG8gV0tUUi4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6VGVzdENvbnRyb2xs ZXIpOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZSk6CisgICAgICAg ICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oOgorICAgICAgICAoVGVzdENvbnRy b2xsZXIpOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6dXNlVGlsZWREcmF3aW5nKToK KyAgICAgICAgQWRkIGEgY29tbWFuZCBsaW5lIGFyZ3VtZW50ICgtLXVzZS10aWxlZC1kcmF3aW5n KSBvbiBNYWMsIHdoaWNoIHdpbGwgZW5hYmxlIHRpbGVkIGRyYXdpbmcuCisgICAgICAgIFRoaXMg YXJndW1lbnQgaXMgbm90IGVuYWJsZWQgYnkgZGVmYXVsdC4KKworICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbToKKyAgICAgICAgKC1bVGVzdFJ1bm5l cldLVmlldyBfc2hvdWxkVXNlVGlsZWREcmF3aW5nQXJlYV0pOgorICAgICAgICBBZGQgVGVzdFJ1 bm5lcldLVmlldywgYSBzdWJjbGFzcyBvZiBXS1ZpZXcsIHdoaWNoIG92ZXJyaWRlcyBfc2hvdWxk VXNlVGlsZWREcmF3aW5nQXJlYSwKKyAgICAgICAgcmV0dXJuaW5nIHRoZSBzdGF0ZSBvZiB0aGUg LS11c2UtdGlsZWQtZHJhd2luZyBmbGFnLgorCisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmll dzo6UGxhdGZvcm1XZWJWaWV3KToKKyAgICAgICAgVXNlIFRlc3RSdW5uZXJXS1ZpZXcgaW5zdGVh ZCBvZiBXS1ZpZXcuCisKIDIwMTItMDktMTkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjkwMDcu CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDNkYTM4ODAu LjlmM2NhN2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBA IC03MCw2ICs3MCwxMCBAQCBzdGF0aWMgV0tVUkxSZWYgYmxhbmtVUkwoKQogCiBzdGF0aWMgVGVz dENvbnRyb2xsZXIqIGNvbnRyb2xsZXI7CiAKKyNpZiBQTEFURk9STShNQUMpCitib29sIFRlc3RD b250cm9sbGVyOjpzX3VzZVRpbGVkRHJhd2luZyA9IGZhbHNlOworI2VuZGlmCisKIFRlc3RDb250 cm9sbGVyJiBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkKIHsKICAgICBBU1NFUlQoY29udHJvbGxl cik7CkBAIC0yOTAsNiArMjk0LDEyIEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUo aW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgICAgIHByaW50U3VwcG9ydGVk RmVhdHVyZXMgPSB0cnVlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KKyNpZiBQTEFU Rk9STShNQUMpCisgICAgICAgIGlmIChhcmd1bWVudCA9PSAiLS11c2UtdGlsZWQtZHJhd2luZyIp IHsKKyAgICAgICAgICAgIHNfdXNlVGlsZWREcmF3aW5nID0gdHJ1ZTsKKyAgICAgICAgICAgIGJy ZWFrOworICAgICAgICB9CisjZW5kaWYKIAogICAgICAgICAvLyBTa2lwIGFueSBvdGhlciBhcmd1 bWVudHMgdGhhdCBiZWdpbiB3aXRoICctLScuCiAgICAgICAgIGlmIChhcmd1bWVudC5sZW5ndGgo KSA+PSAyICYmIGFyZ3VtZW50WzBdID09ICctJyAmJiBhcmd1bWVudFsxXSA9PSAnLScpCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmggYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgKaW5kZXggMGQzMzcxNy4uZTQ0NTQ3ZSAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaApAQCAtNjcsNiArNjcsMTAg QEAgcHVibGljOgogCiAgICAgYm9vbCByZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCk7CiAK KyNpZiBQTEFURk9STShNQUMpCisgICAgc3RhdGljIGJvb2wgdXNlVGlsZWREcmF3aW5nKCkgeyBy ZXR1cm4gc191c2VUaWxlZERyYXdpbmc7IH0KKyNlbmRpZgorCiBwcml2YXRlOgogICAgIHZvaWQg aW5pdGlhbGl6ZShpbnQgYXJnYywgY29uc3QgY2hhciogYXJndltdKTsKICAgICB2b2lkIHJ1bigp OwpAQCAtMTQzLDYgKzE0NywxMCBAQCBwcml2YXRlOgogICAgIAogICAgIGJvb2wgbV9iZWZvcmVV bmxvYWRSZXR1cm5WYWx1ZTsKIAorI2lmIFBMQVRGT1JNKE1BQykKKyAgICBzdGF0aWMgYm9vbCBz X3VzZVRpbGVkRHJhd2luZzsKKyNlbmRpZgorCiAgICAgRXZlbnRTZW5kZXJQcm94eSogbV9ldmVu dFNlbmRlclByb3h5OwogfTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9t YWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxh dGZvcm1XZWJWaWV3TWFjLm1tCmluZGV4IGM5YmNjM2QuLmI0NjNiMmQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQorKysgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KQEAgLTI1LDYgKzI1 LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBsYXRmb3JtV2ViVmlldy5o IgorI2luY2x1ZGUgIlRlc3RDb250cm9sbGVyLmgiCiAKICNpbXBvcnQgPFdlYktpdDIvV0tJbWFn ZUNHLmg+CiAjaW1wb3J0IDxXZWJLaXQyL1dLVmlld1ByaXZhdGUuaD4KQEAgLTg0LDEzICs4NSwy NSBAQAogCiBAZW5kCiAKK0BpbnRlcmZhY2UgVGVzdFJ1bm5lcldLVmlldyA6IFdLVmlldworQGVu ZAorCitAaW1wbGVtZW50YXRpb24gVGVzdFJ1bm5lcldLVmlldworCistIChCT09MKV9zaG91bGRV c2VUaWxlZERyYXdpbmdBcmVhCit7CisgICAgcmV0dXJuIFdUUjo6VGVzdENvbnRyb2xsZXI6OnVz ZVRpbGVkRHJhd2luZygpOworfQorCitAZW5kCisKIG5hbWVzcGFjZSBXVFIgewogCiBQbGF0Zm9y bVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tQYWdl R3JvdXBSZWYgcGFnZUdyb3VwUmVmKQogICAgIDogbV93aW5kb3dJc0tleSh0cnVlKQogewogICAg IE5TUmVjdCByZWN0ID0gTlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCk7Ci0gICAgbV92aWV3ID0g W1tXS1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6cmVjdCBjb250ZXh0UmVmOmNvbnRleHRSZWYg cGFnZUdyb3VwUmVmOnBhZ2VHcm91cFJlZl07CisgICAgbV92aWV3ID0gW1tUZXN0UnVubmVyV0tW aWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOnJlY3QgY29udGV4dFJlZjpjb250ZXh0UmVmIHBhZ2VH cm91cFJlZjpwYWdlR3JvdXBSZWZdOwogCiAgICAgTlNSZWN0IHdpbmRvd1JlY3QgPSBOU09mZnNl dFJlY3QocmVjdCwgLTEwMDAwLCBbKE5TU2NyZWVuICopW1tOU1NjcmVlbiBzY3JlZW5zXSBvYmpl Y3RBdEluZGV4OjBdIGZyYW1lXS5zaXplLmhlaWdodCAtIHJlY3Quc2l6ZS5oZWlnaHQgKyAxMDAw MCk7CiAgICAgbV93aW5kb3cgPSBbW1dlYktpdFRlc3RSdW5uZXJXaW5kb3cgYWxsb2NdIGluaXRX aXRoQ29udGVudFJlY3Q6d2luZG93UmVjdCBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFz ayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6WUVTXTsK 165658 2012-09-25 13:20:30 -0700 2013-05-03 04:47:55 -0700 patch to enable tiled drawing on ML wktr-td.diff text/plain 2222 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjOWY2 NmJhLi43ODA0NmRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDktMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gV0tUUiBzaG91bGQgdXNlIHRpbGVk IGRyYXdpbmcvdGhyZWFkZWQgc2Nyb2xsaW5nIG9uIE1vdW50YWluIExpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3Mjg3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xMTc3ODkwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbmFibGUgdGlsZWQgZHJhd2luZyAoYW5kIHdpdGggaXQsIHRocmVhZGVk IHNjcm9sbGluZykgb24gTW91bnRhaW4gTGlvbi4KKyAgICAgICAgVGhpcyBpcyB0aGUgY29uZmln dXJhdGlvbiB3ZSBzaGlwIHRoZXJlLCBzbyBpdCBpcyB0aGUgY29uZmlndXJhdGlvbiB3ZQorICAg ICAgICBzaG91bGQgYmUgdGVzdGluZyEKKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFj L1BsYXRmb3JtV2ViVmlld01hYy5tbToKKyAgICAgICAgKC1bVGVzdFJ1bm5lcldLVmlldyBfc2hv dWxkVXNlVGlsZWREcmF3aW5nQXJlYV0pOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6 OlBsYXRmb3JtV2ViVmlldyk6CisKIDIwMTItMDktMjUgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6 b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAgQVg6IENocm9taXVtIGRvZXNuJ3QgcGFzcyBhY2Nl c3NpYmlsaXR5IHRleHQgcmFuZ2UgYW5kIGxpbmUgbnVtYmVyIHRlc3RzCmRpZmYgLS1naXQgYS9U b29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0gYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KaW5kZXggYzliY2MzZC4u Y2NlMDE4NSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1X ZWJWaWV3TWFjLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2Vi Vmlld01hYy5tbQpAQCAtMzgsNiArMzgsMTkgQEAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBhc3Np Z24pIFdUUjo6UGxhdGZvcm1XZWJWaWV3KiBwbGF0Zm9ybVdlYlZpZXc7CiBAZW5kCiAKK0BpbnRl cmZhY2UgVGVzdFJ1bm5lcldLVmlldyA6IFdLVmlldworQGVuZAorCitAaW1wbGVtZW50YXRpb24g VGVzdFJ1bm5lcldLVmlldworCistIChCT09MKV9zaG91bGRVc2VUaWxlZERyYXdpbmdBcmVhCit7 CisgICAgcmV0dXJuIChfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwODApOwor fQorCitAZW5kCisKKwogQGltcGxlbWVudGF0aW9uIFdlYktpdFRlc3RSdW5uZXJXaW5kb3cKIEBz eW50aGVzaXplIHBsYXRmb3JtV2ViVmlldyA9IF9wbGF0Zm9ybVdlYlZpZXc7CiAKQEAgLTkwLDcg KzEwMyw3IEBAIFBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLQ29udGV4dFJlZiBj b250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvCiAgICAgOiBtX3dpbmRvd0lzS2V5KHRy dWUpCiB7CiAgICAgTlNSZWN0IHJlY3QgPSBOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKTsKLSAg ICBtX3ZpZXcgPSBbW1dLVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpyZWN0IGNvbnRleHRSZWY6 Y29udGV4dFJlZiBwYWdlR3JvdXBSZWY6cGFnZUdyb3VwUmVmXTsKKyAgICBtX3ZpZXcgPSBbW1Rl c3RSdW5uZXJXS1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6cmVjdCBjb250ZXh0UmVmOmNvbnRl eHRSZWYgcGFnZUdyb3VwUmVmOnBhZ2VHcm91cFJlZl07CiAKICAgICBOU1JlY3Qgd2luZG93UmVj dCA9IE5TT2Zmc2V0UmVjdChyZWN0LCAtMTAwMDAsIFsoTlNTY3JlZW4gKilbW05TU2NyZWVuIHNj cmVlbnNdIG9iamVjdEF0SW5kZXg6MF0gZnJhbWVdLnNpemUuaGVpZ2h0IC0gcmVjdC5zaXplLmhl aWdodCArIDEwMDAwKTsKICAgICBtX3dpbmRvdyA9IFtbV2ViS2l0VGVzdFJ1bm5lcldpbmRvdyBh bGxvY10gaW5pdFdpdGhDb250ZW50UmVjdDp3aW5kb3dSZWN0IHN0eWxlTWFzazpOU0JvcmRlcmxl c3NXaW5kb3dNYXNrIGJhY2tpbmc6TlNCYWNraW5nU3RvcmVCdWZmZXJlZCBkZWZlcjpZRVNdOwo=