97286 2012-09-20 20:10:27 -0700 Chromium mac cannot display AppleColorEmoji 2012-09-20 21:42:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tkent webkit.review.bot oldest_to_newest 725104 0 bashi 2012-09-20 20:10:27 -0700 See http://crbug.com/62435 We need to ask Skia to use CTFontDrawGlyphs(). It will take time, so I'd like to disable AppleColorEmoji for now so that fallback fonts can be selected. 725109 1 165038 bashi 2012-09-20 20:16:06 -0700 Created attachment 165038 Patch 725110 2 bashi 2012-09-20 20:16:39 -0700 Kent-san, What do you think about disabling AppleColorEmoji now? 725113 3 165038 tkent 2012-09-20 20:36:54 -0700 Comment on attachment 165038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165038&action=review > Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122 > +#if PLATFORM(CHROMIUM) && OS(DARWIN) > + // Chromium can't render AppleColorEmoji. > + if ([[substituteFont familyName] isEqual:@"Apple Color Emoji"]) > + return 0; > +#endif nit: I think OS(DARWIN) is not needed. FYI: Using PLATFORM() macro is not preferable in general. Ideally, we had better have WTF_USE_NO_APPLE_COLOR_EMOJI flag, and enable it for Chromium in WebCore/config.h. Using PLATFORM() is acceptable in this case because it's temporarily. 725120 4 165041 bashi 2012-09-20 20:59:20 -0700 Created attachment 165041 Patch for landing 725124 5 165038 bashi 2012-09-20 21:00:55 -0700 Comment on attachment 165038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165038&action=review >> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122 >> +#endif > > nit: I think OS(DARWIN) is not needed. > > FYI: > Using PLATFORM() macro is not preferable in general. > Ideally, we had better have WTF_USE_NO_APPLE_COLOR_EMOJI flag, and enable it for Chromium in WebCore/config.h. > > Using PLATFORM() is acceptable in this case because it's temporarily. Removed OS(DARWIN). Thank you for the heads-up. I'll keep in mind it! 725142 6 165041 webkit.review.bot 2012-09-20 21:42:23 -0700 Comment on attachment 165041 Patch for landing Clearing flags on attachment: 165041 Committed r129190: <http://trac.webkit.org/changeset/129190> 725143 7 webkit.review.bot 2012-09-20 21:42:26 -0700 All reviewed patches have been landed. Closing bug. 165038 2012-09-20 20:16:06 -0700 2012-09-20 21:00:55 -0700 Patch bug-97286-20120921121531.patch text/plain 1821 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJhNGU2YjgxYmJlZjgx OGI1MDZkMzBkYzBiMTY2Yzg4YmE1ODNjMy4uMzlhNWYwOGUzOWJkYmYwMWQzY2M3NDlhMWUyYzc5 YzdkMTE1YzY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWl1bSBt YWMgY2Fubm90IGRpc3BsYXkgQXBwbGVDb2xvckVtb2ppCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgQXBwbGVDb2xvckVtb2ppIGZvciBub3cu IFdlIHdpbGwgcmUtZW5hYmxlIGl0IGFmdGVyIFNraWEgc3VwcG9ydCBDVEZvbnREcmF3R2x5cGhz KCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBGYWxsYmFjayBmb250cyBzaG91bGQgYmUgdXNl ZCBmb3IgZW1vamkgY29kZXBvaW50cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21h Yy9Gb250Q2FjaGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OmdldEZvbnRE YXRhRm9yQ2hhcmFjdGVycyk6CisKIDIwMTItMDktMTkgIEpvbmF0aGFuIERvbmcgIDxqb25hdGhh bi5kb25nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIGZ1 bmN0aW9uIHBsYXllcklkKCkgaW4gY2xhc3MgUGFnZUNsaWVudEJsYWNrQmVycnkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q2FjaGVNYWMubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udENhY2hlTWFjLm1tCmlu ZGV4IDZiMmUwNTQ3NGRiZDg1OWJlZDgwNDgxODRhMjI1YzgxZjZjYzBiYjMuLjg0ZmU3ODRiN2Y4 MDk4YjkyYjFhYmY0MDNiZDBkZGMzNThlMDhlODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q2FjaGVNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRDYWNoZU1hYy5tbQpAQCAtMTE1LDYgKzExNSwx MiBAQCBjb25zdCBTaW1wbGVGb250RGF0YSogRm9udENhY2hlOjpnZXRGb250RGF0YUZvckNoYXJh Y3RlcnMoY29uc3QgRm9udCYgZm9udCwgY29ucwogICAgIGlmICghc3Vic3RpdHV0ZUZvbnQpCiAg ICAgICAgIHJldHVybiAwOwogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKERBUldJTikK KyAgICAvLyBDaHJvbWl1bSBjYW4ndCByZW5kZXIgQXBwbGVDb2xvckVtb2ppLgorICAgIGlmIChb W3N1YnN0aXR1dGVGb250IGZhbWlseU5hbWVdIGlzRXF1YWw6QCJBcHBsZSBDb2xvciBFbW9qaSJd KQorICAgICAgICByZXR1cm4gMDsKKyNlbmRpZgorCiAgICAgLy8gVXNlIHRoZSBmYW1pbHkgbmFt ZSBmcm9tIHRoZSBBcHBLaXQtc3VwcGxpZWQgc3Vic3RpdHV0ZSBmb250LCByZXF1ZXN0aW5nIHRo ZQogICAgIC8vIHRyYWl0cywgd2VpZ2h0LCBhbmQgc2l6ZSB3ZSB3YW50LiBPbmUgd2F5IHRoaXMg ZG9lcyBiZXR0ZXIgdGhhbiB0aGUgb3JpZ2luYWwKICAgICAvLyBBcHBLaXQgcmVxdWVzdCBpcyB0 aGF0IGl0IHRha2VzIHN5bnRoZXRpYyBib2xkIGFuZCBvYmxpcXVlIGludG8gYWNjb3VudC4K 165041 2012-09-20 20:59:20 -0700 2012-09-20 21:42:23 -0700 Patch for landing bug-97286-20120921125844.patch text/plain 1805 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJhNGU2YjgxYmJlZjgx OGI1MDZkMzBkYzBiMTY2Yzg4YmE1ODNjMy4uMzI2NGRmYTk3MjhhMzUxYmE4ZjczNDdiY2M4NDk3 ZGJiZGNhZjI5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWl1bSBt YWMgY2Fubm90IGRpc3BsYXkgQXBwbGVDb2xvckVtb2ppCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IEtl bnQgVGFtdXJhLgorCisgICAgICAgIERpc2FibGUgQXBwbGVDb2xvckVtb2ppIGZvciBub3cuIFdl IHdpbGwgcmUtZW5hYmxlIGl0IGFmdGVyIFNraWEgc3VwcG9ydHMgQ1RGb250RHJhd0dseXBocygp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRmFsbGJhY2sgZm9udHMgc2hvdWxkIGJlIHVzZWQg Zm9yIGVtb2ppIGNvZGVwb2ludHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMv Rm9udENhY2hlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRGb250RGF0 YUZvckNoYXJhY3RlcnMpOgorCiAyMDEyLTA5LTE5ICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4u ZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZCBmdW5j dGlvbiBwbGF5ZXJJZCgpIGluIGNsYXNzIFBhZ2VDbGllbnRCbGFja0JlcnJ5CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udENhY2hlTWFjLm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRDYWNoZU1hYy5tbQppbmRl eCA2YjJlMDU0NzRkYmQ4NTliZWQ4MDQ4MTg0YTIyNWM4MWY2Y2MwYmIzLi45YjI1NTU4MjMxMGU0 ODg5ZWMxZDFlOWIwODM4ZTE4YjBmYTA3YTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udENhY2hlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q2FjaGVNYWMubW0KQEAgLTExNSw2ICsxMTUsMTIg QEAgY29uc3QgU2ltcGxlRm9udERhdGEqIEZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0 ZXJzKGNvbnN0IEZvbnQmIGZvbnQsIGNvbnMKICAgICBpZiAoIXN1YnN0aXR1dGVGb250KQogICAg ICAgICByZXR1cm4gMDsKIAorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIC8vIENocm9taXVt IGNhbid0IHJlbmRlciBBcHBsZUNvbG9yRW1vamkuCisgICAgaWYgKFtbc3Vic3RpdHV0ZUZvbnQg ZmFtaWx5TmFtZV0gaXNFcXVhbDpAIkFwcGxlIENvbG9yIEVtb2ppIl0pCisgICAgICAgIHJldHVy biAwOworI2VuZGlmCisKICAgICAvLyBVc2UgdGhlIGZhbWlseSBuYW1lIGZyb20gdGhlIEFwcEtp dC1zdXBwbGllZCBzdWJzdGl0dXRlIGZvbnQsIHJlcXVlc3RpbmcgdGhlCiAgICAgLy8gdHJhaXRz LCB3ZWlnaHQsIGFuZCBzaXplIHdlIHdhbnQuIE9uZSB3YXkgdGhpcyBkb2VzIGJldHRlciB0aGFu IHRoZSBvcmlnaW5hbAogICAgIC8vIEFwcEtpdCByZXF1ZXN0IGlzIHRoYXQgaXQgdGFrZXMgc3lu dGhldGljIGJvbGQgYW5kIG9ibGlxdWUgaW50byBhY2NvdW50Lgo=