97280 2012-09-20 18:48:38 -0700 REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled 2012-09-21 09:21:48 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,%3Cdiv%20style=%22border:%20solid;%20width:%2050px;%20word-spacing:%2050px;%20-webkit-font-kerning:%20normal;%22%3Ea%20b%3C/div%3E Regression P1 Normal --- 1 mitz webkit-unassigned ned oldest_to_newest 725069 0 mitz 2012-09-20 18:48:38 -0700 To reproduce: run-webkit-tests --complex fast/text/basic/004.html Line breaking isn’t accounting for word spacing correctly. This was caused by <http://trac.webkit.org/r126763>, the fix for bug 83045. 725126 1 mitz 2012-09-20 21:01:39 -0700 Please ignore the original description. The failure happens when the test is modified to enable kerning. 725130 2 mitz 2012-09-20 21:08:46 -0700 The URL contains a reduction. <div style="border: solid; width: 50px; word-spacing: 50px; -webkit-font-kerning: normal;">a b</div> 725197 3 mitz 2012-09-20 23:41:31 -0700 TextLayout uses fontWithNoWordSpacing… 725222 4 165064 mitz 2012-09-21 00:21:21 -0700 Created attachment 165064 Make TextLayout::width() apply word spacing except at the first character of a run 725564 5 mitz 2012-09-21 09:21:48 -0700 Fixed in <http://trac.webkit.org/r129233>. 165064 2012-09-21 00:21:21 -0700 2012-09-21 09:17:31 -0700 Make TextLayout::width() apply word spacing except at the first character of a run 97280_r1.diff text/plain 4412 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyNjc2Myk6 IEluY29ycmVjdCBsaW5lIGJyZWFraW5nIHdoZW4gYm90aCBrZXJuaW5nIGFuZCB3b3JkIHNwYWNp bmcgYXJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk3MjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRm9udDo6d2lkdGgoKSBuZXZlciBhcHBsaWVzIHdvcmQgc3BhY2luZyB0byB0aGUgZmly c3QgY2hhcmFjdGVyIGluIHRoZSBUZXh0UnVuLiBUaGUKKyAgICAgICAgVGV4dExheW91dCBvcHRp bWl6YXRpb24gdHJpZWQgdG8gYWNoaWV2ZSB0aGlzIGJlaGF2aW9yIGJ5IG5vdCBhcHBseWluZyB3 b3JkIHNwYWNpbmcgdG8KKyAgICAgICAgYW55IGNoYXJhY3Rlciwgd2hpY2ggbGVkIHRvIHRoaXMg YnVnLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC93b3JkLXNwYWNlLXdpdGgta2VybmluZy0y Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dExheW91dDo6VGV4dExheW91dCk6IENo YW5nZWQgdG8gdXNlIHRoZSBnaXZlbiBmb250IHJhdGhlciB0aGFuIGEgdmVyc2lvbgorICAgICAg ICB3aXRob3V0IHdvcmQgc3BhY2luZy4KKyAgICAgICAgKFdlYkNvcmU6OlRleHRMYXlvdXQ6Ondp ZHRoKTogQWRkZWQgYSBjaGVjayBpZiB0aGUgcnVuIHN0YXJ0cyB3aXRoIGEgc3BhY2UgYXQgYSBu b24temVybworICAgICAgICBvZmZzZXQuIElmIHRoYXQgaXMgdGhlIGNhc2UsIHRoZW4gdGhlIENv bXBsZXhUZXh0Q29udHJvbGxlciBoYXMgYWRkZWQgd29yZCBzcGFjaW5nIHRvIHRoYXQKKyAgICAg ICAgc3BhY2UsIHNvIHN1YnRyYWN0IGl0IGhlcmUgaW4gb3JkZXIgdG8gbWFpbnRhaW4gdGhlIGJl aGF2aW9yIGRlc2NyaWJlZCBhYm92ZS4KKwogMjAxMi0wOS0yMSAgS2Vpc2hpIEhhdHRvcmkgIDxr ZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBQcmVwYXJlIENhbGVuZGFyUGlja2VyIHNvIHdl IGNhbiBhZGQgYW5vdGhlciBwaWNrZXIsIFN1Z2dldGlvblBpY2tlcgpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhU ZXh0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDEyOTE4NykKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OCw3ICs0OCw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBUZXh0TGF5b3V0KFJl bmRlclRleHQqIHRleHQsIGNvbnN0IEZvbnQmIGZvbnQsIGZsb2F0IHhQb3MpCi0gICAgICAgIDog bV9mb250KGZvbnRXaXRoTm9Xb3JkU3BhY2luZyhmb250KSkKKyAgICAgICAgOiBtX2ZvbnQoZm9u dCkKICAgICAgICAgLCBtX3J1bihjb25zdHJ1Y3RUZXh0UnVuKHRleHQsIGZvbnQsIHhQb3MpKQog ICAgICAgICAsIG1fY29udHJvbGxlcihhZG9wdFB0cihuZXcgQ29tcGxleFRleHRDb250cm9sbGVy KCZtX2ZvbnQsIG1fcnVuLCB0cnVlKSkpCiAgICAgewpAQCAtNTgsMTkgKzU4LDE0IEBAIHB1Ymxp YzoKICAgICB7CiAgICAgICAgIG1fY29udHJvbGxlci0+YWR2YW5jZShmcm9tLCAwLCBCeVdob2xl R2x5cGhzKTsKICAgICAgICAgZmxvYXQgYmVmb3JlV2lkdGggPSBtX2NvbnRyb2xsZXItPnJ1bldp ZHRoU29GYXIoKTsKKyAgICAgICAgaWYgKG1fZm9udC53b3JkU3BhY2luZygpICYmIGZyb20gJiYg Rm9udDo6dHJlYXRBc1NwYWNlKG1fcnVuW2Zyb21dKSkKKyAgICAgICAgICAgIGJlZm9yZVdpZHRo ICs9IG1fZm9udC53b3JkU3BhY2luZygpOwogICAgICAgICBtX2NvbnRyb2xsZXItPmFkdmFuY2Uo ZnJvbSArIGxlbiwgMCwgQnlXaG9sZUdseXBocyk7CiAgICAgICAgIGZsb2F0IGFmdGVyV2lkdGgg PSBtX2NvbnRyb2xsZXItPnJ1bldpZHRoU29GYXIoKTsKICAgICAgICAgcmV0dXJuIGFmdGVyV2lk dGggLSBiZWZvcmVXaWR0aDsKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgc3RhdGljIEZvbnQgZm9u dFdpdGhOb1dvcmRTcGFjaW5nKGNvbnN0IEZvbnQmIG9yaWdpbmFsRm9udCkKLSAgICB7Ci0gICAg ICAgIEZvbnQgZm9udChvcmlnaW5hbEZvbnQpOwotICAgICAgICBmb250LnNldFdvcmRTcGFjaW5n KDApOwotICAgICAgICByZXR1cm4gZm9udDsKLSAgICB9Ci0KICAgICBzdGF0aWMgVGV4dFJ1biBj b25zdHJ1Y3RUZXh0UnVuKFJlbmRlclRleHQqIHRleHQsIGNvbnN0IEZvbnQmIGZvbnQsIGZsb2F0 IHhQb3MpCiAgICAgewogICAgICAgICBUZXh0UnVuIHJ1biA9IFJlbmRlckJsb2NrOjpjb25zdHJ1 Y3RUZXh0UnVuKHRleHQsIGZvbnQsIHRleHQtPmNoYXJhY3RlcnMoKSwgdGV4dC0+dGV4dExlbmd0 aCgpLCB0ZXh0LT5zdHlsZSgpKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTE5OCkKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA5 LTIxICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjEyNjc2Myk6IEluY29ycmVjdCBsaW5lIGJyZWFraW5nIHdoZW4gYm90aCBrZXJuaW5nIGFu ZCB3b3JkIHNwYWNpbmcgYXJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk3MjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvd29yZC1zcGFjZS13aXRoLWtlcm5pbmctMi1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvd29yZC1zcGFjZS13aXRo LWtlcm5pbmctMi5odG1sOiBBZGRlZC4KKwogMjAxMi0wOS0yMCAgS2VuaWNoaSBJc2hpYmFzaGkg IDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIHRl c3QgZXhwZWN0YXRpb24gdXBkYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3dvcmQt c3BhY2Utd2l0aC1rZXJuaW5nLTItZXhwZWN0ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L3RleHQvd29yZC1zcGFjZS13aXRoLWtlcm5pbmctMi1leHBlY3RlZC5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3dvcmQtc3BhY2Utd2l0aC1rZXJu aW5nLTItZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACis8ZGl2IHN0 eWxlPSJmb250LXNpemU6IDIwcHg7Ij4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWZvbnQta2Vy bmluZzogbm9ybWFsOyB3aWR0aDogNjBweDsgYm9yZGVyOiBzb2xpZCBibHVlOyI+CisgICAgICAg IGE8YnI+YgorICAgIDwvZGl2PgorPC9kaXY+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQv d29yZC1zcGFjZS13aXRoLWtlcm5pbmctMi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvdGV4dC93b3JkLXNwYWNlLXdpdGgta2VybmluZy0yLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvd29yZC1zcGFjZS13aXRoLWtlcm5pbmctMi5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKKzxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMjBweDsi PgorICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtZm9udC1rZXJuaW5nOiBub3JtYWw7IHdpZHRoOiA2 MHB4OyB3b3JkLXNwYWNpbmc6IDYwcHg7IGJvcmRlcjogc29saWQgYmx1ZTsiPgorICAgICAgICBh IGIKKyAgICA8L2Rpdj4KKzwvZGl2Pgo=