97257 2012-09-20 13:21:04 -0700 [chromium] Enable more clang warnings 2012-09-21 11:16:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony jamesr thakis webkit.review.bot oldest_to_newest 724790 0 tony 2012-09-20 13:21:04 -0700 [chromium] Enable more clang warnings 724798 1 164970 tony 2012-09-20 13:25:12 -0700 Created attachment 164970 Patch 724800 2 tony 2012-09-20 13:25:55 -0700 Not sure if there's a better way for me to consolidate these. Let me know if you have any ideas. 724968 3 164970 webkit.review.bot 2012-09-20 16:38:01 -0700 Comment on attachment 164970 Patch Clearing flags on attachment: 164970 Committed r129178: <http://trac.webkit.org/changeset/129178> 724969 4 webkit.review.bot 2012-09-20 16:38:04 -0700 All reviewed patches have been landed. Closing bug. 725086 5 164970 thakis 2012-09-20 19:15:13 -0700 Comment on attachment 164970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164970&action=review > Source/WebKit/chromium/WebKit.gyp:1337 > + ['clang==1', { There's already a block like this around line 739. Remove this again? (Also, you're not setting -Wunused-parameter here -- I suppose that's intentional? --- ah, the changelog says it is. So just revert the changes to this file, or at least delete the duplicate block eralier in this file.) > Source/WebKit/chromium/WebKitUnitTests.gyp:230 > + 'cflags': ['-Wglobal-constructors', '-Wunused-parameter'], No need to warn about global constructors in tests. We don't care about those. > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:533 > + # FIXME: Add -Wglobal-constructors after fixing existing bugs. Not sure if we care about them in DRT either. 725648 6 tony 2012-09-21 11:16:27 -0700 Thanks for looking, Nico! (In reply to comment #5) > (From update of attachment 164970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164970&action=review > > > Source/WebKit/chromium/WebKit.gyp:1337 > > + ['clang==1', { > > There's already a block like this around line 739. Remove this again? Good catch, I removed the earlier block here: http://trac.webkit.org/changeset/129242 > > Source/WebKit/chromium/WebKitUnitTests.gyp:230 > > + 'cflags': ['-Wglobal-constructors', '-Wunused-parameter'], > > No need to warn about global constructors in tests. We don't care about those. Yeah, I had to revert this part of the change last night. The TEST/TEST_F macros create static initializers (I didn't see it because I was using the shared build). > > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:533 > > + # FIXME: Add -Wglobal-constructors after fixing existing bugs. > > Not sure if we care about them in DRT either. I'm not sure it makes a big difference either, but we do launch DRT many times when running the layout tests, so it might have a tiny impact on bot cycle speed (although today the long pole is http tests, so maybe it doesn't matter). 164970 2012-09-20 13:25:12 -0700 2012-09-20 19:15:13 -0700 Patch bug-97257-20120920132437.patch text/plain 5145 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAyMjJiMTNlNmQ0NmEy YTMwODg2NDAzMTUwYTY1MzdkZWRmNmFhZS4uM2QwZjViZmNmZWI1Mjc4MDM1MDk2OTNiMGIxYjNi ZWQ0YTk3ZGRhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBFbmFibGUg bW9yZSBjbGFuZyB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTcyNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgLVd1bnVzZWQtcGFyYW1ldGVyIHRvIFdlYkNvcmUgdGFyZ2V0cy4gQXBw bGUncyBNYWMgY29tcGlsZSBhbHJlYWR5CisgICAgICAgIHdhcm5zIG9uIHRoaXMgYW5kIGl0J3Mg YSBjb21tb24gc291cmNlIG9mIGVycm9yIGZvciBDaHJvbWl1bSBwYXRjaGVzLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgc2hvdWxkIGNvbXBpbGUgY2xlYW5seS4KKworICAgICAgICAqIFdlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDEyLTA5LTIwICBNaWtlIFdlc3QgIDxta3dzdEBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQ1NQIHJlcG9ydHMgc2hvdWxkIHNlbmQgYW4gZW1wdHkgJ3Jl ZmVycmVyJyByYXRoZXIgdGhhbiBub3RoaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRl eCAwNzRiNTUxYTc0OGQ0YWJkOWE3YjllMzhhMTUzOWE2NGMxYWI4ZjIwLi4yNzVlNGNhOTEzZWVk ZWY3YjUyMzYyNDJhMGJiYmM5YzczNWRjZWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEyLTA5LTIwICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgbW9yZSBjbGFuZyB3YXJuaW5ncworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcyNTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6 IEFkZCAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMuIERvbid0IGFkZCAtV3VudXNlZC1wYXJhbWV0ZXIg YmVjYXVzZSBtYW55IG9mIG91ciBBUEkgaW50ZXJmYWNlcyBoYXZlIG5hbWVkIHBhcmFtZXRlcnMg d2l0aCBlbXB0eSBpbXBsZW1lbnRhdGlvbnMuCisgICAgICAgICogV2ViS2l0VW5pdFRlc3RzLmd5 cDogQWRkIC1XZ2xvYmFsLWNvbnN0cnVjdG9ycyBhbmQgLVd1bnVzZWQtcGFyYW1ldGVyLgorCiAy MDEyLTA5LTIwICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAg ICAgIE1lZGlhU3RyZWFtIEFQSTogRXh0ZW5kIFVzZXJNZWRpYVJlcXVlc3Qgd2l0aCBhIG93bmVy RG9jdW1lbnQgbWV0aG9kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9X ZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4 IDE3MTIyMzMxNDEwYzZiNTdmZjM0YTUxMjI4ZTIxMDkyOTgyYjQxNGEuLjM5OGZiYWUzZWU0ZThi MTYyZTcyNGYxZmZlMDRmMWY1MzYwMGVlMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwCkBAIC0zNjEsOSArMzYxLDkgQEAKICAgICB9XSwgICMgY29uZGl0aW9uIE9TID09 ICJtYWMiCiAgICAgWydjbGFuZz09MScsIHsKICAgICAgICd0YXJnZXRfZGVmYXVsdHMnOiB7Ci0g ICAgICAgICdjZmxhZ3MnOiBbJy1XZ2xvYmFsLWNvbnN0cnVjdG9ycyddLAorICAgICAgICAnY2Zs YWdzJzogWyctV2dsb2JhbC1jb25zdHJ1Y3RvcnMnLCAnLVd1bnVzZWQtcGFyYW1ldGVyJ10sCiAg ICAgICAgICd4Y29kZV9zZXR0aW5ncyc6IHsKLSAgICAgICAgICAnV0FSTklOR19DRkxBR1MnOiBb Jy1XZ2xvYmFsLWNvbnN0cnVjdG9ycyddLAorICAgICAgICAgICdXQVJOSU5HX0NGTEFHUyc6IFsn LVdnbG9iYWwtY29uc3RydWN0b3JzJywgJy1XdW51c2VkLXBhcmFtZXRlciddLAogICAgICAgICB9 LAogICAgICAgfSwKICAgICB9XSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v V2ViS2l0Lmd5cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCA1OWFi MjQ5MmQ2OTFjZDA5ZDFmOTg5NzFhNDI2MTNjMzY0ZTEyMzg3Li5mZGQ3OTBlNWExZjVmMTg0YTEx MGFhMGYwOTg1MDc4Yjk3ZWNmYTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L1dlYktpdC5neXAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC0x MzM0LDUgKzEzMzQsMTMgQEAKICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgXSwKICAg ICAgICAgfV0sCisgICAgICAgIFsnY2xhbmc9PTEnLCB7CisgICAgICAgICAgICAndGFyZ2V0X2Rl ZmF1bHRzJzogeworICAgICAgICAgICAgICAgICdjZmxhZ3MnOiBbJy1XZ2xvYmFsLWNvbnN0cnVj dG9ycyddLAorICAgICAgICAgICAgICAgICd4Y29kZV9zZXR0aW5ncyc6IHsKKyAgICAgICAgICAg ICAgICAgICAgJ1dBUk5JTkdfQ0ZMQUdTJzogWyctV2dsb2JhbC1jb25zdHJ1Y3RvcnMnXSwKKyAg ICAgICAgICAgICAgICB9LAorICAgICAgICAgICAgfSwKKyAgICAgICAgfV0sCiAgICAgXSwgIyBj b25kaXRpb25zCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVu aXRUZXN0cy5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAK aW5kZXggODNiMzJjZjZlOTE4MTc1MGY2NDgxYjEyZGMwNmQ0ODVkZGE1MTdhZS4uNTExYzI0NDRl MDNhNzBkODBmNTVhNzRhNmFkMjkwOTJhNmM3NGI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vV2ViS2l0VW5pdFRlc3RzLmd5cApAQCAtMjI1LDUgKzIyNSwxMyBAQAogICAgICAgICAgICAg ICAgIF0sCiAgICAgICAgICAgICB9XSwKICAgICAgICAgfV0sCisgICAgICAgIFsnY2xhbmc9PTEn LCB7CisgICAgICAgICAgICAndGFyZ2V0X2RlZmF1bHRzJzogeworICAgICAgICAgICAgICAgICdj ZmxhZ3MnOiBbJy1XZ2xvYmFsLWNvbnN0cnVjdG9ycycsICctV3VudXNlZC1wYXJhbWV0ZXInXSwK KyAgICAgICAgICAgICAgICAneGNvZGVfc2V0dGluZ3MnOiB7CisgICAgICAgICAgICAgICAgICAg ICdXQVJOSU5HX0NGTEFHUyc6IFsnLVdnbG9iYWwtY29uc3RydWN0b3JzJywgJy1XdW51c2VkLXBh cmFtZXRlciddLAorICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICB9LAorICAgICAgICB9 XSwKICAgICBdLAogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDQwZjg2OWEzNGJjZDhlNTYyN2IyNmNlNGVkYzQzOWM2ZGY1MDkzM2YuLjBhYzY0 YzNjMjE3NTRiZjUzNTllYTk3NDc0NzdiZWU3OTlkNzAzNmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wOS0y MCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g RW5hYmxlIG1vcmUgY2xhbmcgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk3MjU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVt cFJlbmRlclRyZWUuZ3lwOiBBZGQgLVd1bnVzZWQtcGFyYW1ldGVyLiBEb24ndCBhZGQgLVdnbG9i YWwtY29uc3RydWN0b3JzIGJlY2F1c2UKKyAgICAgICAgdGhlcmUgYXJlIGxvdHMgb2YgdmlvbGF0 aW9ucyBpbiB0aGVzZSBmaWxlcy4KKwogMjAxMi0wOS0yMCAgRGlyayBQcmFua2UgIDxkcHJhbmtl QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OOiBsYXlvdXQgdGVzdCByZXN1bHRz IGRvZXNuJ3Qgc2hvdyBkaWZmcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVt cFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKaW5kZXggMTMxZDQwZjAyNDM5 YTY0MTMxOWIzM2VjOWRlMmIxYzMzMmIxNTZlMC4uMjM5ZWI4ZjBhMjE5NWMwMjY1N2UxZTc5NjM3 OTE2NzEwNzI3N2FjMCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRl clRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9E dW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCkBAIC01MjgsNSArNTI4LDE0IEBA CiAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICB9XSwKICAgICAgICAgfV0sCisgICAg ICAgIFsnY2xhbmc9PTEnLCB7CisgICAgICAgICAgICAndGFyZ2V0X2RlZmF1bHRzJzogeworICAg ICAgICAgICAgICAgICMgRklYTUU6IEFkZCAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMgYWZ0ZXIgZml4 aW5nIGV4aXN0aW5nIGJ1Z3MuCisgICAgICAgICAgICAgICAgJ2NmbGFncyc6IFsnLVd1bnVzZWQt cGFyYW1ldGVyJ10sCisgICAgICAgICAgICAgICAgJ3hjb2RlX3NldHRpbmdzJzogeworICAgICAg ICAgICAgICAgICAgICAnV0FSTklOR19DRkxBR1MnOiBbJy1XdW51c2VkLXBhcmFtZXRlciddLAor ICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICB9LAorICAgICAgICB9XSwKICAgICBdLCAj IGNvbmRpdGlvbnMKIH0K